Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/79743/?format=api
https://patches.dpdk.org/api/patches/79743/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201006105913.3801726-1-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201006105913.3801726-1-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201006105913.3801726-1-pablo.de.lara.guarch@intel.com", "date": "2020-10-06T10:59:11", "name": "[1/3] crypto/aesni_mb: fix CCM digest size check", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "984879af99f3637eb7eb576afbbcac00a813fe86", "submitter": { "id": 9, "url": "https://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201006105913.3801726-1-pablo.de.lara.guarch@intel.com/mbox/", "series": [ { "id": 12715, "url": "https://patches.dpdk.org/api/series/12715/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12715", "date": "2020-10-06T10:59:11", "name": "[1/3] crypto/aesni_mb: fix CCM digest size check", "version": 1, "mbox": "https://patches.dpdk.org/series/12715/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/79743/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/79743/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D5DA8A04BB;\n\tTue, 6 Oct 2020 12:59:25 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B699D29AC;\n\tTue, 6 Oct 2020 12:59:24 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id C660D1023;\n Tue, 6 Oct 2020 12:59:21 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 06 Oct 2020 03:59:18 -0700", "from silpixa00399593.ir.intel.com (HELO\n silpixa00399593.ger.corp.intel.com) ([10.237.223.27])\n by orsmga005.jf.intel.com with ESMTP; 06 Oct 2020 03:59:16 -0700" ], "IronPort-SDR": [ "\n SojJUa/QqAS80npkYry4SaM62mSiQyzX8d2N2waZG1UqgSdTjiikbEjuQJRSg7fFLYPgHJGibu\n A/wDrfdhCJjQ==", "\n LC3Gb7UuxUJTp7YyDjphBdqrd77qD6hwL76/lvZrn2Q3e6kJm+EjVT/mHE5hRc2adSE0eNJ95O\n B2dNhuXzivvA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9765\"; a=\"152210418\"", "E=Sophos;i=\"5.77,343,1596524400\"; d=\"scan'208\";a=\"152210418\"", "E=Sophos;i=\"5.77,343,1596524400\"; d=\"scan'208\";a=\"527299379\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "declan.doherty@intel.com", "Cc": "dev@dpdk.org, Pablo de Lara <pablo.de.lara.guarch@intel.com>,\n stable@dpdk.org", "Date": "Tue, 6 Oct 2020 10:59:11 +0000", "Message-Id": "<20201006105913.3801726-1-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/3] crypto/aesni_mb: fix CCM digest size check", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Digest size for CCM was being checked for other algorithms\napart from CCM.\n\nFixes: c4c0c312a823 (\"crypto/aesni_mb: check for invalid digest size\")\nCc: stable@dpdk.org\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 29 +++++++++++-----------\n 1 file changed, 15 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c\nindex 1bddbcf74..784278719 100644\n--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c\n+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c\n@@ -564,6 +564,14 @@ aesni_mb_set_session_aead_parameters(const MB_MGR *mb_mgr,\n \t\treturn -EINVAL;\n \t}\n \n+\t/* Set IV parameters */\n+\tsess->iv.offset = xform->aead.iv.offset;\n+\tsess->iv.length = xform->aead.iv.length;\n+\n+\t/* Set digest sizes */\n+\tsess->auth.req_digest_len = xform->aead.digest_length;\n+\tsess->auth.gen_digest_len = sess->auth.req_digest_len;\n+\n \tswitch (xform->aead.algo) {\n \tcase RTE_CRYPTO_AEAD_AES_CCM:\n \t\tsess->cipher.mode = CCM;\n@@ -582,6 +590,13 @@ aesni_mb_set_session_aead_parameters(const MB_MGR *mb_mgr,\n \t\t\treturn -EINVAL;\n \t\t}\n \n+\t\t/* CCM digests must be between 4 and 16 and an even number */\n+\t\tif (sess->auth.req_digest_len < AES_CCM_DIGEST_MIN_LEN ||\n+\t\t\t\tsess->auth.req_digest_len > AES_CCM_DIGEST_MAX_LEN ||\n+\t\t\t\t(sess->auth.req_digest_len & 1) == 1) {\n+\t\t\tAESNI_MB_LOG(ERR, \"Invalid digest size\\n\");\n+\t\t\treturn -EINVAL;\n+\t\t}\n \t\tbreak;\n \n \tcase RTE_CRYPTO_AEAD_AES_GCM:\n@@ -616,20 +631,6 @@ aesni_mb_set_session_aead_parameters(const MB_MGR *mb_mgr,\n \t\treturn -ENOTSUP;\n \t}\n \n-\t/* Set IV parameters */\n-\tsess->iv.offset = xform->aead.iv.offset;\n-\tsess->iv.length = xform->aead.iv.length;\n-\n-\tsess->auth.req_digest_len = xform->aead.digest_length;\n-\t/* CCM digests must be between 4 and 16 and an even number */\n-\tif (sess->auth.req_digest_len < AES_CCM_DIGEST_MIN_LEN ||\n-\t\t\tsess->auth.req_digest_len > AES_CCM_DIGEST_MAX_LEN ||\n-\t\t\t(sess->auth.req_digest_len & 1) == 1) {\n-\t\tAESNI_MB_LOG(ERR, \"Invalid digest size\\n\");\n-\t\treturn -EINVAL;\n-\t}\n-\tsess->auth.gen_digest_len = sess->auth.req_digest_len;\n-\n \treturn 0;\n }\n \n", "prefixes": [ "1/3" ] }{ "id": 79743, "url": "