Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/79508/?format=api
{ "id": 79508, "url": "https://patches.dpdk.org/api/patches/79508/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/5a25973431babe75cf681df7827ee69942297446.1601586564.git.dekelp@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<5a25973431babe75cf681df7827ee69942297446.1601586564.git.dekelp@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/5a25973431babe75cf681df7827ee69942297446.1601586564.git.dekelp@nvidia.com", "date": "2020-10-01T21:15:08", "name": "[v2,11/11] net/mlx5: enforce limitation on IPv6 next proto", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f9dc930123604143508ab3955f653358e1aecc6c", "submitter": { "id": 1897, "url": "https://patches.dpdk.org/api/people/1897/?format=api", "name": "Dekel Peled", "email": "dekelp@nvidia.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/5a25973431babe75cf681df7827ee69942297446.1601586564.git.dekelp@nvidia.com/mbox/", "series": [ { "id": 12655, "url": "https://patches.dpdk.org/api/series/12655/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12655", "date": "2020-10-01T21:14:57", "name": "support match on L3 fragmented packets", "version": 2, "mbox": "https://patches.dpdk.org/series/12655/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/79508/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/79508/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2DAC7A04BA;\n\tThu, 1 Oct 2020 23:19:07 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 18BB01DAD7;\n\tThu, 1 Oct 2020 23:15:52 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id AC1D01D6F6\n for <dev@dpdk.org>; Thu, 1 Oct 2020 23:15:42 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n dekelp@nvidia.com) with SMTP; 2 Oct 2020 00:15:39 +0300", "from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx\n [10.228.134.250])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 091LFOe7021286;\n Fri, 2 Oct 2020 00:15:39 +0300" ], "From": "Dekel Peled <dekelp@nvidia.com>", "To": "orika@nvidia.com, thomas@monjalon.net, ferruh.yigit@intel.com,\n arybchenko@solarflare.com, konstantin.ananyev@intel.com,\n olivier.matz@6wind.com, wenzhuo.lu@intel.com, beilei.xing@intel.com,\n bernard.iremonger@intel.com, matan@nvidia.com, shahafs@nvidia.com,\n viacheslavo@nvidia.com", "Cc": "dev@dpdk.org", "Date": "Fri, 2 Oct 2020 00:15:08 +0300", "Message-Id": "\n <5a25973431babe75cf681df7827ee69942297446.1601586564.git.dekelp@nvidia.com>", "X-Mailer": "git-send-email 1.7.1", "In-Reply-To": "<cover.1601586563.git.dekelp@nvidia.com>", "References": "<cover.1601474841.git.dekelp@nvidia.com>\n <cover.1601586563.git.dekelp@nvidia.com>", "Subject": "[dpdk-dev] [PATCH v2 11/11] net/mlx5: enforce limitation on IPv6\n\tnext proto", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Due to PRM requirement, the IPv6 header item 'proto' field, indicating\nthe next header protocol, should not be set as extension header.\nThis patch adds the relevant validation, and documents the limitation.\n\nSigned-off-by: Dekel Peled <dekelp@nvidia.com>\n---\n doc/guides/nics/mlx5.rst | 7 +++++++\n drivers/net/mlx5/mlx5_flow.c | 14 ++++++++++++--\n 2 files changed, 19 insertions(+), 2 deletions(-)", "diff": "diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst\nindex 211c0c5..e6ca5e1 100644\n--- a/doc/guides/nics/mlx5.rst\n+++ b/doc/guides/nics/mlx5.rst\n@@ -311,6 +311,13 @@ Limitations\n for some NICs (such as ConnectX-6 Dx and BlueField 2).\n The capability bit ``scatter_fcs_w_decap_disable`` shows NIC support.\n \n+- IPv6 header item 'proto' field, indicating the next header protocol, should\n+ not be set as extension header.\n+ In case the next header is an extension header, it should not be specified in\n+ IPv6 header item 'proto' field.\n+ The last extension header item 'next header' field can specify the following\n+ header protocol type.\n+\n Statistics\n ----------\n \ndiff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex 906741f..7a438cf 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -1645,9 +1645,9 @@ struct mlx5_flow_tunnel_info {\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM, item,\n \t\t\t\t\t \"IPv6 cannot follow L2/VLAN layer \"\n \t\t\t\t\t \"which ether type is not IPv6\");\n+\tif (mask && spec)\n+\t\tnext_proto = mask->hdr.proto & spec->hdr.proto;\n \tif (item_flags & MLX5_FLOW_LAYER_IPV6_ENCAP) {\n-\t\tif (mask && spec)\n-\t\t\tnext_proto = mask->hdr.proto & spec->hdr.proto;\n \t\tif (next_proto == IPPROTO_IPIP || next_proto == IPPROTO_IPV6)\n \t\t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n@@ -1655,6 +1655,16 @@ struct mlx5_flow_tunnel_info {\n \t\t\t\t\t\t \"multiple tunnel \"\n \t\t\t\t\t\t \"not supported\");\n \t}\n+\tif (next_proto == IPPROTO_HOPOPTS ||\n+\t next_proto == IPPROTO_ROUTING ||\n+\t next_proto == IPPROTO_FRAGMENT ||\n+\t next_proto == IPPROTO_ESP\t ||\n+\t next_proto == IPPROTO_AH\t ||\n+\t next_proto == IPPROTO_DSTOPTS)\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM, item,\n+\t\t\t\t\t \"IPv6 proto (next header) should \"\n+\t\t\t\t\t \"not be set as extension header\");\n \tif (item_flags & MLX5_FLOW_LAYER_IPIP)\n \t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM, item,\n", "prefixes": [ "v2", "11/11" ] }