Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/79413/?format=api
{ "id": 79413, "url": "https://patches.dpdk.org/api/patches/79413/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201001101155.206237-3-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201001101155.206237-3-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201001101155.206237-3-maxime.coquelin@redhat.com", "date": "2020-10-01T10:11:55", "name": "[2/2] vhost: use fixed Virtio-net header len packed ring", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ae53133064f8928d9b37de95161ab2dea86f0da5", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201001101155.206237-3-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 12637, "url": "https://patches.dpdk.org/api/series/12637/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12637", "date": "2020-10-01T10:11:53", "name": "Fix packed ring header len", "version": 1, "mbox": "https://patches.dpdk.org/series/12637/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/79413/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/79413/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 045F8A04B5;\n\tThu, 1 Oct 2020 12:12:47 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 097B11DAE6;\n\tThu, 1 Oct 2020 12:12:13 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [216.205.24.124])\n by dpdk.org (Postfix) with ESMTP id 9314E1DADD\n for <dev@dpdk.org>; Thu, 1 Oct 2020 12:12:10 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-379-61s3xOYpMCO6cDRO0nqYiQ-1; Thu, 01 Oct 2020 06:12:07 -0400", "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com\n [10.5.11.13])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4CB1885C707;\n Thu, 1 Oct 2020 10:12:06 +0000 (UTC)", "from localhost.localdomain (unknown [10.36.110.36])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 183F860DA0;\n Thu, 1 Oct 2020 10:12:04 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1601547129;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=XRekJUAncc/jaGPaAsHfVHLu99I2xrzrjFjeu+7d5hw=;\n b=Mqxt7KMIii/Wwgqr7ejNkF2wfx6EOMs8ddQEWyXl7xL29qwiJoDXT/jHru6weOiyfEMZIS\n pVq0349RZqPlHL/wlC/bYyJ+g/x4JaRoeYTVHCGQZ/4iJewdQhRiHU6htWnxjBGbHT7Xpc\n 8VKO6DUvz6WexbfjbKSzTjJkNvtT54E=", "X-MC-Unique": "61s3xOYpMCO6cDRO0nqYiQ-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org,\n\tchenbo.xia@intel.com,\n\tyong.liu@intel.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Thu, 1 Oct 2020 12:11:55 +0200", "Message-Id": "<20201001101155.206237-3-maxime.coquelin@redhat.com>", "In-Reply-To": "<20201001101155.206237-1-maxime.coquelin@redhat.com>", "References": "<20201001101155.206237-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH 2/2] vhost: use fixed Virtio-net header len\n\tpacked ring", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This small optimization uses static the Virtio-net header len\nin packed datapath, since Virtio-net header cannot be the\nlegacy one in case of packed ring.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/virtio_net.c | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c\nindex 0a0bea1a5a..5865fa5f65 100644\n--- a/lib/librte_vhost/virtio_net.c\n+++ b/lib/librte_vhost/virtio_net.c\n@@ -1147,7 +1147,7 @@ vhost_enqueue_single_packed(struct virtio_net *dev,\n \tuint16_t buf_id = 0;\n \tuint32_t len = 0;\n \tuint16_t desc_count;\n-\tuint32_t size = pkt->pkt_len + dev->vhost_hlen;\n+\tuint32_t size = pkt->pkt_len + sizeof(struct virtio_net_hdr_mrg_rxbuf);\n \tuint16_t num_buffers = 0;\n \tuint32_t buffer_len[vq->size];\n \tuint16_t buffer_buf_id[vq->size];\n@@ -1262,7 +1262,7 @@ virtio_dev_rx_batch_packed(struct virtio_net *dev,\n \tuint16_t avail_idx = vq->last_avail_idx;\n \tuint64_t desc_addrs[PACKED_BATCH_SIZE];\n \tstruct virtio_net_hdr_mrg_rxbuf *hdrs[PACKED_BATCH_SIZE];\n-\tuint32_t buf_offset = dev->vhost_hlen;\n+\tuint32_t buf_offset = sizeof(struct virtio_net_hdr_mrg_rxbuf);\n \tuint64_t lens[PACKED_BATCH_SIZE];\n \tuint16_t ids[PACKED_BATCH_SIZE];\n \tuint16_t i;\n@@ -1308,7 +1308,8 @@ virtio_dev_rx_batch_packed(struct virtio_net *dev,\n \t\trte_prefetch0((void *)(uintptr_t)desc_addrs[i]);\n \t\thdrs[i] = (struct virtio_net_hdr_mrg_rxbuf *)\n \t\t\t\t\t(uintptr_t)desc_addrs[i];\n-\t\tlens[i] = pkts[i]->pkt_len + dev->vhost_hlen;\n+\t\tlens[i] = pkts[i]->pkt_len +\n+\t\t\tsizeof(struct virtio_net_hdr_mrg_rxbuf);\n \t}\n \n \tvhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE)\n@@ -2277,7 +2278,7 @@ vhost_reserve_avail_batch_packed(struct virtio_net *dev,\n \tstruct virtio_net_hdr *hdr;\n \tuint64_t lens[PACKED_BATCH_SIZE];\n \tuint64_t buf_lens[PACKED_BATCH_SIZE];\n-\tuint32_t buf_offset = dev->vhost_hlen;\n+\tuint32_t buf_offset = sizeof(struct virtio_net_hdr_mrg_rxbuf);\n \tuint16_t flags, i;\n \n \tif (unlikely(avail_idx & PACKED_BATCH_MASK))\n@@ -2354,7 +2355,7 @@ virtio_dev_tx_batch_packed(struct virtio_net *dev,\n \t\t\t struct rte_mbuf **pkts)\n {\n \tuint16_t avail_idx = vq->last_avail_idx;\n-\tuint32_t buf_offset = dev->vhost_hlen;\n+\tuint32_t buf_offset = sizeof(struct virtio_net_hdr_mrg_rxbuf);\n \tuintptr_t desc_addrs[PACKED_BATCH_SIZE];\n \tuint16_t ids[PACKED_BATCH_SIZE];\n \tuint16_t i;\n", "prefixes": [ "2/2" ] }