Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/79412/?format=api
{ "id": 79412, "url": "https://patches.dpdk.org/api/patches/79412/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20201001101155.206237-2-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20201001101155.206237-2-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20201001101155.206237-2-maxime.coquelin@redhat.com", "date": "2020-10-01T10:11:54", "name": "[1/2] vhost: fix Virtio-net header len with packed ring", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f4a2ceb29158408b09ac2b6267f8327f68f2c63e", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20201001101155.206237-2-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 12637, "url": "https://patches.dpdk.org/api/series/12637/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12637", "date": "2020-10-01T10:11:53", "name": "Fix packed ring header len", "version": 1, "mbox": "https://patches.dpdk.org/series/12637/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/79412/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/79412/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F261DA04B5;\n\tThu, 1 Oct 2020 12:12:27 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 53FE01DAD7;\n\tThu, 1 Oct 2020 12:12:11 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [216.205.24.124])\n by dpdk.org (Postfix) with ESMTP id 16F7C1DAD2\n for <dev@dpdk.org>; Thu, 1 Oct 2020 12:12:08 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-441-9Q8UZ4KgO1ecgLC6cJ7XdA-1; Thu, 01 Oct 2020 06:12:05 -0400", "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com\n [10.5.11.13])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8B0A6109106D;\n Thu, 1 Oct 2020 10:12:04 +0000 (UTC)", "from localhost.localdomain (unknown [10.36.110.36])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 0759E60DA0;\n Thu, 1 Oct 2020 10:12:02 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1601547127;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=tkCMYcJxPPdDdhRhddMOzRN3LznzZqdglScsrtstOD4=;\n b=i7y40KUOK2nHp+IDZ4JwyX4ln1lbVvy5Vnzbm5Xq3ND4euTRyZ0b9oYXVbLVtKyGQjG1Yg\n iE0zez8Oug3aX2OxPDyoQuy+Fou+pilI5pjCGyAf4wv1EpCXXBv/qqctYWWwmvwwHufh/a\n a7qSmXCTcGsjHBEHNSmBscVRjgCUwig=", "X-MC-Unique": "9Q8UZ4KgO1ecgLC6cJ7XdA-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org,\n\tchenbo.xia@intel.com,\n\tyong.liu@intel.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>,\n\tstable@dpdk.org", "Date": "Thu, 1 Oct 2020 12:11:54 +0200", "Message-Id": "<20201001101155.206237-2-maxime.coquelin@redhat.com>", "In-Reply-To": "<20201001101155.206237-1-maxime.coquelin@redhat.com>", "References": "<20201001101155.206237-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"", "Subject": "[dpdk-dev] [PATCH 1/2] vhost: fix Virtio-net header len with packed\n\tring", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In case packed ring layout has been negotiated, but neither\nVersion 1 nor mergeable buffers, the Virtio-net header len\nis assigned to the legacy devices value, which is wrong.\n\nThis patch fixes this with using the proper len as devices\nusing packed ring are not legacy devices.\n\nFixes: a922401f35cc (\"vhost: add Rx support for packed ring\")\nFixes: ae999ce49dcb (\"vhost: add Tx support for packed ring\")\nCc: stable@dpdk.org\n\nReported-by: Marvin Liu <yong.liu@intel.com>\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/vhost_user.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 4deceb3e00..5d1fb9e863 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -341,7 +341,9 @@ vhost_user_set_features(struct virtio_net **pdev, struct VhostUserMsg *msg,\n \n \tdev->features = features;\n \tif (dev->features &\n-\t\t((1 << VIRTIO_NET_F_MRG_RXBUF) | (1ULL << VIRTIO_F_VERSION_1))) {\n+\t\t((1ULL << VIRTIO_NET_F_MRG_RXBUF) |\n+\t\t (1ULL << VIRTIO_F_VERSION_1) |\n+\t\t (1ULL << VIRTIO_F_RING_PACKED))) {\n \t\tdev->vhost_hlen = sizeof(struct virtio_net_hdr_mrg_rxbuf);\n \t} else {\n \t\tdev->vhost_hlen = sizeof(struct virtio_net_hdr);\n", "prefixes": [ "1/2" ] }