Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/79362/?format=api
{ "id": 79362, "url": "https://patches.dpdk.org/api/patches/79362/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/790a02b1c629f8d9c1dbde14b8736367eedca34a.1601474841.git.dekelp@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<790a02b1c629f8d9c1dbde14b8736367eedca34a.1601474841.git.dekelp@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/790a02b1c629f8d9c1dbde14b8736367eedca34a.1601474841.git.dekelp@nvidia.com", "date": "2020-09-30T14:10:14", "name": "[06/10] net/mlx5: remove handling of ICMP fragmented packets", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "91ae08e5c7eb38dfa7f16fe9f9623ada5cc0cd30", "submitter": { "id": 1897, "url": "https://patches.dpdk.org/api/people/1897/?format=api", "name": "Dekel Peled", "email": "dekelp@nvidia.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/790a02b1c629f8d9c1dbde14b8736367eedca34a.1601474841.git.dekelp@nvidia.com/mbox/", "series": [ { "id": 12622, "url": "https://patches.dpdk.org/api/series/12622/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12622", "date": "2020-09-30T14:10:08", "name": "support match on L3 fragmented packets", "version": 1, "mbox": "https://patches.dpdk.org/series/12622/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/79362/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/79362/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7AC6EA04B5;\n\tWed, 30 Sep 2020 16:12:44 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CCD871DB78;\n\tWed, 30 Sep 2020 16:11:00 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id B9DE71DB5F\n for <dev@dpdk.org>; Wed, 30 Sep 2020 16:10:55 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n dekelp@nvidia.com) with SMTP; 30 Sep 2020 17:10:51 +0300", "from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx\n [10.228.134.250])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 08UEAWtj023904;\n Wed, 30 Sep 2020 17:10:51 +0300" ], "From": "Dekel Peled <dekelp@nvidia.com>", "To": "orika@nvidia.com, thomas@monjalon.net, ferruh.yigit@intel.com,\n arybchenko@solarflare.com, konstantin.ananyev@intel.com,\n olivier.matz@6wind.com, wenzhuo.lu@intel.com, beilei.xing@intel.com,\n bernard.iremonger@intel.com, matan@nvidia.com, shahafs@nvidia.com,\n viacheslavo@nvidia.com", "Cc": "dev@dpdk.org", "Date": "Wed, 30 Sep 2020 17:10:14 +0300", "Message-Id": "\n <790a02b1c629f8d9c1dbde14b8736367eedca34a.1601474841.git.dekelp@nvidia.com>", "X-Mailer": "git-send-email 1.7.1", "In-Reply-To": "<cover.1601474841.git.dekelp@nvidia.com>", "References": "<cover.1601474841.git.dekelp@nvidia.com>", "Subject": "[dpdk-dev] [PATCH 06/10] net/mlx5: remove handling of ICMP\n\tfragmented packets", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Commit [1] forced setting of match on 'frag' bit mask 1 and value 0.\nPrevious patch in this series added support of match on fragmented and\nnon-fragmented packets on L3 items, so this setting is now redundant.\n\nThis patch removes the changes done in [1].\n\n[1] commit 85407db9f60d (\"net/mlx5: fix matching for ICMP fragments\")\n\nSigned-off-by: Dekel Peled <dekelp@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow_dv.c | 12 ------------\n 1 file changed, 12 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex 79fdf34..0a0a5a4 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -7345,12 +7345,6 @@ struct field_modify_info modify_tcp[] = {\n \t\treturn;\n \tif (!icmp6_m)\n \t\ticmp6_m = &rte_flow_item_icmp6_mask;\n-\t/*\n-\t * Force flow only to match the non-fragmented IPv6 ICMPv6 packets.\n-\t * If only the protocol is specified, no need to match the frag.\n-\t */\n-\tMLX5_SET(fte_match_set_lyr_2_4, headers_m, frag, 1);\n-\tMLX5_SET(fte_match_set_lyr_2_4, headers_v, frag, 0);\n \tMLX5_SET(fte_match_set_misc3, misc3_m, icmpv6_type, icmp6_m->type);\n \tMLX5_SET(fte_match_set_misc3, misc3_v, icmpv6_type,\n \t\t icmp6_v->type & icmp6_m->type);\n@@ -7398,12 +7392,6 @@ struct field_modify_info modify_tcp[] = {\n \t\treturn;\n \tif (!icmp_m)\n \t\ticmp_m = &rte_flow_item_icmp_mask;\n-\t/*\n-\t * Force flow only to match the non-fragmented IPv4 ICMP packets.\n-\t * If only the protocol is specified, no need to match the frag.\n-\t */\n-\tMLX5_SET(fte_match_set_lyr_2_4, headers_m, frag, 1);\n-\tMLX5_SET(fte_match_set_lyr_2_4, headers_v, frag, 0);\n \tMLX5_SET(fte_match_set_misc3, misc3_m, icmp_type,\n \t\t icmp_m->hdr.icmp_type);\n \tMLX5_SET(fte_match_set_misc3, misc3_v, icmp_type,\n", "prefixes": [ "06/10" ] }