Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7932/?format=api
{ "id": 7932, "url": "https://patches.dpdk.org/api/patches/7932/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1445582090-5927-7-git-send-email-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1445582090-5927-7-git-send-email-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/1445582090-5927-7-git-send-email-stephen@networkplumber.org", "date": "2015-10-23T06:34:50", "name": "[dpdk-dev,6/6] fm10k: use rte_eth_dma_zone_reserve", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "c7c8a90e503a6340d1dcb47d3ee77881bb4d9856", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1445582090-5927-7-git-send-email-stephen@networkplumber.org/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/7932/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/7932/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 00229C4CC;\n\tFri, 23 Oct 2015 08:34:57 +0200 (CEST)", "from mail-pa0-f54.google.com (mail-pa0-f54.google.com\n\t[209.85.220.54]) by dpdk.org (Postfix) with ESMTP id 62113C4A8\n\tfor <dev@dpdk.org>; Fri, 23 Oct 2015 08:34:49 +0200 (CEST)", "by pacfv9 with SMTP id fv9so114572174pac.3\n\tfor <dev@dpdk.org>; Thu, 22 Oct 2015 23:34:48 -0700 (PDT)", "from xeon-e3.home.lan (static-50-53-82-155.bvtn.or.frontiernet.net.\n\t[50.53.82.155]) by smtp.gmail.com with ESMTPSA id\n\tot8sm17078910pbb.26.2015.10.22.23.34.47\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 22 Oct 2015 23:34:48 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=M8cxXMwaRqBQoe8vEupEQhJ4cRBEqb37h5nTnIIpk5w=;\n\tb=c2nz0msxL0fkzVuQdm2AXhy4Dri0PNH/YcL97jZqsHGMqnCOhrkSQD0PmEqCTuN9DZ\n\t/dlj5febIV1wDxgfbl1wKRUjhkqlagG1A4ykrCV965J9vwIfMjyhHJXYfaGqU5gqLRQC\n\tN08O/u0mUxvD6YdKIE65z0MAq5UWw10RZbE/+lDcVc/7u9RdXUU9moJsm9OayF9LbMYW\n\txyR5wT/RcYZf1pxY02l1cPE434z69KLEE0tI+b6yAF141qb1Czf0k3loJlV2UTI9dGNB\n\t65VSMSO1D/By0iIfxQUgXqP9fK+TkFYtzZgUgehMzoK9GCLQfpuQeWQ/DbFHAldKdPZv\n\t6d+w==", "X-Gm-Message-State": "ALoCoQkfJE/DuIL80mu5ozZmJnoXemLImZO9rTBRop+SOvIdkpSx5X7pRTHXmmhL9S6W3gKvPJWx", "X-Received": "by 10.67.1.34 with SMTP id bd2mr2813806pad.45.1445582088769;\n\tThu, 22 Oct 2015 23:34:48 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Date": "Thu, 22 Oct 2015 23:34:50 -0700", "Message-Id": "<1445582090-5927-7-git-send-email-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<1445582090-5927-1-git-send-email-stephen@networkplumber.org>", "References": "<1445582090-5927-1-git-send-email-stephen@networkplumber.org>", "Subject": "[dpdk-dev] [PATCH 6/6] fm10k: use rte_eth_dma_zone_reserve", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Adapt to Xen at runtime.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\nv2 - fix typo where virt to phys is done\n\n drivers/net/fm10k/fm10k_ethdev.c | 47 +++++-----------------------------------\n 1 file changed, 6 insertions(+), 41 deletions(-)\n\n \t * enough to hold the maximum ring size is requested to allow for\n \t * resizing in later calls to the queue setup function.\n \t */\n-\tmz = allocate_hw_ring(dev->driver->pci_drv.name, \"tx_ring\",\n-\t\t\t\tdev->data->port_id, queue_id, socket_id,\n-\t\t\t\tFM10K_MAX_TX_RING_SZ, FM10K_ALIGN_TX_DESC);\n+\tmz = rte_eth_dma_zone_reserve(dev, \"tx_ring\", queue_id,\n+\t\t\t\t FM10K_MAX_TX_RING_SZ, FM10K_ALIGN_TX_DESC,\n+\t\t\t\t socket_id);\n \tif (mz == NULL) {\n \t\tPMD_INIT_LOG(ERR, \"Cannot allocate hardware ring\");\n \t\trte_free(q->sw_ring);\n@@ -1477,11 +1446,7 @@ fm10k_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_id,\n \t\treturn (-ENOMEM);\n \t}\n \tq->hw_ring = mz->addr;\n-#ifdef RTE_LIBRTE_XEN_DOM0\n \tq->hw_ring_phys_addr = rte_mem_phy2mch(mz->memseg_id, mz->phys_addr);\n-#else\n-\tq->hw_ring_phys_addr = mz->phys_addr;\n-#endif\n \n \t/*\n \t * allocate memory for the RS bit tracker. Enough slots to hold the", "diff": "diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c\nindex a69c990..571f5f0 100644\n--- a/drivers/net/fm10k/fm10k_ethdev.c\n+++ b/drivers/net/fm10k/fm10k_ethdev.c\n@@ -1144,34 +1144,6 @@ check_nb_desc(uint16_t min, uint16_t max, uint16_t mult, uint16_t request)\n \t\treturn 0;\n }\n \n-/*\n- * Create a memzone for hardware descriptor rings. Malloc cannot be used since\n- * the physical address is required. If the memzone is already created, then\n- * this function returns a pointer to the existing memzone.\n- */\n-static inline const struct rte_memzone *\n-allocate_hw_ring(const char *driver_name, const char *ring_name,\n-\tuint8_t port_id, uint16_t queue_id, int socket_id,\n-\tuint32_t size, uint32_t align)\n-{\n-\tchar name[RTE_MEMZONE_NAMESIZE];\n-\tconst struct rte_memzone *mz;\n-\n-\tsnprintf(name, sizeof(name), \"%s_%s_%d_%d_%d\",\n-\t\t driver_name, ring_name, port_id, queue_id, socket_id);\n-\n-\t/* return the memzone if it already exists */\n-\tmz = rte_memzone_lookup(name);\n-\tif (mz)\n-\t\treturn mz;\n-\n-#ifdef RTE_LIBRTE_XEN_DOM0\n-\treturn rte_memzone_reserve_bounded(name, size, socket_id, 0, align,\n-\t\t\t\t\t RTE_PGSIZE_2M);\n-#else\n-\treturn rte_memzone_reserve_aligned(name, size, socket_id, 0, align);\n-#endif\n-}\n \n static inline int\n check_thresh(uint16_t min, uint16_t max, uint16_t div, uint16_t request)\n@@ -1317,9 +1289,9 @@ fm10k_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_id,\n \t * enough to hold the maximum ring size is requested to allow for\n \t * resizing in later calls to the queue setup function.\n \t */\n-\tmz = allocate_hw_ring(dev->driver->pci_drv.name, \"rx_ring\",\n-\t\t\t\tdev->data->port_id, queue_id, socket_id,\n-\t\t\t\tFM10K_MAX_RX_RING_SZ, FM10K_ALIGN_RX_DESC);\n+\tmz = rte_eth_dma_zone_reserve(dev, \"rx_ring\", queue_id,\n+\t\t\t\t FM10K_MAX_RX_RING_SZ, FM10K_ALIGN_RX_DESC,\n+\t\t\t\t socket_id);\n \tif (mz == NULL) {\n \t\tPMD_INIT_LOG(ERR, \"Cannot allocate hardware ring\");\n \t\trte_free(q->sw_ring);\n@@ -1327,11 +1299,8 @@ fm10k_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_id,\n \t\treturn (-ENOMEM);\n \t}\n \tq->hw_ring = mz->addr;\n-#ifdef RTE_LIBRTE_XEN_DOM0\n \tq->hw_ring_phys_addr = rte_mem_phy2mch(mz->memseg_id, mz->phys_addr);\n-#else\n-\tq->hw_ring_phys_addr = mz->phys_addr;\n-#endif\n \n \tdev->data->rx_queues[queue_id] = q;\n \treturn 0;\n@@ -1467,9 +1436,9 @@ fm10k_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_id,\n", "prefixes": [ "dpdk-dev", "6/6" ] }