Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7930/?format=api
{ "id": 7930, "url": "https://patches.dpdk.org/api/patches/7930/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1445582090-5927-5-git-send-email-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1445582090-5927-5-git-send-email-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/1445582090-5927-5-git-send-email-stephen@networkplumber.org", "date": "2015-10-23T06:34:48", "name": "[dpdk-dev,4/6] ixgbe: use rte_eth_dma_zone_reserve", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "fd4b27962244df9707b5dee03c1131989adf67c5", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1445582090-5927-5-git-send-email-stephen@networkplumber.org/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/7930/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/7930/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0F4B3C482;\n\tFri, 23 Oct 2015 08:34:54 +0200 (CEST)", "from mail-pa0-f41.google.com (mail-pa0-f41.google.com\n\t[209.85.220.41]) by dpdk.org (Postfix) with ESMTP id AB07FC482\n\tfor <dev@dpdk.org>; Fri, 23 Oct 2015 08:34:47 +0200 (CEST)", "by pacfv9 with SMTP id fv9so114571405pac.3\n\tfor <dev@dpdk.org>; Thu, 22 Oct 2015 23:34:47 -0700 (PDT)", "from xeon-e3.home.lan (static-50-53-82-155.bvtn.or.frontiernet.net.\n\t[50.53.82.155]) by smtp.gmail.com with ESMTPSA id\n\tot8sm17078910pbb.26.2015.10.22.23.34.46\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tThu, 22 Oct 2015 23:34:46 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=EkEDkLWvBRHo54xh4DlQH5UGlnSTQvU9ZaIqneW//+k=;\n\tb=G7fIxn89oZj+0n4u6tuvWaFINKntIiQtOmb/YABu0aRVkj+IykTTV+imxTy/Q3YOOJ\n\thV36s9JxiZE39kiTlEMSlHZb5n4zcGhVAsd8bvBXY1NIlR2EFSa57hqh5VUj2oHNNvNh\n\tUUDwYgvBVRVARD+0+wYbalvVKJcH336jlG0Gy9PsK2LytgnhbCskZ3fLxB11boyRpvah\n\tSrWWlFRqp472PrU84YwJReq0gDXl6ogtCUpWpZNLnbj3nYlJjy08DE66rYCUU3gbDJnU\n\t91pduUDM3RCkIW304Nq3a7pqt7bcxTXhwAzz8YnK8zEkejVL8QUZCMDn38OdyVjyxVPM\n\tZo3Q==", "X-Gm-Message-State": "ALoCoQn47/zzMkmGf8l/+OJSwwNvZZWnjNgtt8U4eEHAWoEeBs5Sy79Q001WLQ/kwnhsBWXGP91v", "X-Received": "by 10.66.164.10 with SMTP id ym10mr2914795pab.26.1445582087083; \n\tThu, 22 Oct 2015 23:34:47 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Date": "Thu, 22 Oct 2015 23:34:48 -0700", "Message-Id": "<1445582090-5927-5-git-send-email-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<1445582090-5927-1-git-send-email-stephen@networkplumber.org>", "References": "<1445582090-5927-1-git-send-email-stephen@networkplumber.org>", "Subject": "[dpdk-dev] [PATCH 4/6] ixgbe: use rte_eth_dma_zone_reserve", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Adapt DMA memory for Xen at runtime.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/ixgbe/ixgbe_rxtx.c | 47 ++++++------------------------------------\n 1 file changed, 6 insertions(+), 41 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c\nindex a598a72..b6cbb64 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx.c\n@@ -1839,35 +1839,6 @@ ixgbe_recv_pkts_lro_bulk_alloc(void *rx_queue, struct rte_mbuf **rx_pkts,\n #define IXGBE_MIN_RING_DESC 32\n #define IXGBE_MAX_RING_DESC 4096\n \n-/*\n- * Create memzone for HW rings. malloc can't be used as the physical address is\n- * needed. If the memzone is already created, then this function returns a ptr\n- * to the old one.\n- */\n-static const struct rte_memzone * __attribute__((cold))\n-ring_dma_zone_reserve(struct rte_eth_dev *dev, const char *ring_name,\n-\t\t uint16_t queue_id, uint32_t ring_size, int socket_id)\n-{\n-\tchar z_name[RTE_MEMZONE_NAMESIZE];\n-\tconst struct rte_memzone *mz;\n-\n-\tsnprintf(z_name, sizeof(z_name), \"%s_%s_%d_%d\",\n-\t\t\tdev->driver->pci_drv.name, ring_name,\n-\t\t\tdev->data->port_id, queue_id);\n-\n-\tmz = rte_memzone_lookup(z_name);\n-\tif (mz)\n-\t\treturn mz;\n-\n-#ifdef RTE_LIBRTE_XEN_DOM0\n-\treturn rte_memzone_reserve_bounded(z_name, ring_size,\n-\t\tsocket_id, 0, IXGBE_ALIGN, RTE_PGSIZE_2M);\n-#else\n-\treturn rte_memzone_reserve_aligned(z_name, ring_size,\n-\t\tsocket_id, 0, IXGBE_ALIGN);\n-#endif\n-}\n-\n static void __attribute__((cold))\n ixgbe_tx_queue_release_mbufs(struct ixgbe_tx_queue *txq)\n {\n@@ -2102,9 +2073,9 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_dev *dev,\n \t * handle the maximum ring size is allocated in order to allow for\n \t * resizing in later calls to the queue setup function.\n \t */\n-\ttz = ring_dma_zone_reserve(dev, \"tx_ring\", queue_idx,\n+\ttz = rte_eth_dma_zone_reserve(dev, \"tx_ring\", queue_idx,\n \t\t\tsizeof(union ixgbe_adv_tx_desc) * IXGBE_MAX_RING_DESC,\n-\t\t\tsocket_id);\n+\t\t\tIXGBE_ALIGN, socket_id);\n \tif (tz == NULL) {\n \t\tixgbe_tx_queue_release(txq);\n \t\treturn (-ENOMEM);\n@@ -2134,11 +2105,8 @@ ixgbe_dev_tx_queue_setup(struct rte_eth_dev *dev,\n \t\ttxq->tdt_reg_addr = IXGBE_PCI_REG_ADDR(hw, IXGBE_VFTDT(queue_idx));\n \telse\n \t\ttxq->tdt_reg_addr = IXGBE_PCI_REG_ADDR(hw, IXGBE_TDT(txq->reg_idx));\n-#ifndef\tRTE_LIBRTE_XEN_DOM0\n-\ttxq->tx_ring_phys_addr = (uint64_t) tz->phys_addr;\n-#else\n+\n \ttxq->tx_ring_phys_addr = rte_mem_phy2mch(tz->memseg_id, tz->phys_addr);\n-#endif\n \ttxq->tx_ring = (union ixgbe_adv_tx_desc *) tz->addr;\n \n \t/* Allocate software ring */\n@@ -2408,8 +2376,8 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_dev *dev,\n \t * handle the maximum ring size is allocated in order to allow for\n \t * resizing in later calls to the queue setup function.\n \t */\n-\trz = ring_dma_zone_reserve(dev, \"rx_ring\", queue_idx,\n-\t\t\t\t RX_RING_SZ, socket_id);\n+\trz = rte_eth_dma_zone_reserve(dev, \"rx_ring\", queue_idx,\n+\t\t\t\t RX_RING_SZ, IXGBE_ALIGN, socket_id);\n \tif (rz == NULL) {\n \t\tixgbe_rx_queue_release(rxq);\n \t\treturn (-ENOMEM);\n@@ -2438,11 +2406,8 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_dev *dev,\n \t\trxq->rdh_reg_addr =\n \t\t\tIXGBE_PCI_REG_ADDR(hw, IXGBE_RDH(rxq->reg_idx));\n \t}\n-#ifndef RTE_LIBRTE_XEN_DOM0\n-\trxq->rx_ring_phys_addr = (uint64_t) rz->phys_addr;\n-#else\n+\n \trxq->rx_ring_phys_addr = rte_mem_phy2mch(rz->memseg_id, rz->phys_addr);\n-#endif\n \trxq->rx_ring = (union ixgbe_adv_rx_desc *) rz->addr;\n \n \t/*\n", "prefixes": [ "dpdk-dev", "4/6" ] }