Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78907/?format=api
{ "id": 78907, "url": "https://patches.dpdk.org/api/patches/78907/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200927072626.28374-5-robinx.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200927072626.28374-5-robinx.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200927072626.28374-5-robinx.zhang@intel.com", "date": "2020-09-27T07:26:22", "name": "[4/8] net/iavf: optimize promiscuous ops", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "da74321546dcc2bdbc37bc3e3bb261a4957c6d32", "submitter": { "id": 2004, "url": "https://patches.dpdk.org/api/people/2004/?format=api", "name": "Robin Zhang", "email": "robinx.zhang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200927072626.28374-5-robinx.zhang@intel.com/mbox/", "series": [ { "id": 12526, "url": "https://patches.dpdk.org/api/series/12526/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12526", "date": "2020-09-27T07:26:18", "name": "feature porting from i40evf to iavf", "version": 1, "mbox": "https://patches.dpdk.org/series/12526/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/78907/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/78907/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C2583A04BC;\n\tSun, 27 Sep 2020 09:48:22 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C11CA1D940;\n\tSun, 27 Sep 2020 09:47:29 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by dpdk.org (Postfix) with ESMTP id 122601D8F1\n for <dev@dpdk.org>; Sun, 27 Sep 2020 09:47:25 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Sep 2020 00:47:25 -0700", "from intel-npg-odc-srv03.cd.intel.com ([10.240.178.138])\n by orsmga002.jf.intel.com with ESMTP; 27 Sep 2020 00:47:23 -0700" ], "IronPort-SDR": [ "\n FUo0MZKs9n8CevdXTDQCfpM7lDPbvwvq4CdJRQgXaM64EKQY7ibT7BUwjHQooihpACxZGn9UWG\n fIULOT9gGafA==", "\n TofppEKV+dHGqFjXAquQ66ShrO90WP6IFS/B2RIdoj2f6sSP3O1atyHFM/IFMBBVsWW5ber/AW\n 0N19ELnGqkug==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9756\"; a=\"223438301\"", "E=Sophos;i=\"5.77,309,1596524400\"; d=\"scan'208\";a=\"223438301\"", "E=Sophos;i=\"5.77,309,1596524400\"; d=\"scan'208\";a=\"323939417\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Robin Zhang <robinx.zhang@intel.com>", "To": "dev@dpdk.org", "Cc": "beilei.xing@intel.com, jingjing.wu@intel.com, qiming.yang@intel.com,\n stevex.yang@intel.com, Robin Zhang <robinx.zhang@intel.com>", "Date": "Sun, 27 Sep 2020 07:26:22 +0000", "Message-Id": "<20200927072626.28374-5-robinx.zhang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200927072626.28374-1-robinx.zhang@intel.com>", "References": "<20200927072626.28374-1-robinx.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH 4/8] net/iavf: optimize promiscuous ops", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch is to improve efficiency and eliminate code\nredundancy of promiscuous ops.\n\nSigned-off-by: Robin Zhang <robinx.zhang@intel.com>\n---\n drivers/net/iavf/iavf_ethdev.c | 49 ++++++----------------------------\n drivers/net/iavf/iavf_vchnl.c | 13 +++++++--\n 2 files changed, 19 insertions(+), 43 deletions(-)", "diff": "diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex 57640c52a..3b3829f75 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -676,17 +676,9 @@ iavf_dev_promiscuous_enable(struct rte_eth_dev *dev)\n \tstruct iavf_adapter *adapter =\n \t\tIAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);\n \tstruct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter);\n-\tint ret;\n-\n-\tret = iavf_config_promisc(adapter, true, vf->promisc_multicast_enabled);\n-\tif (!ret)\n-\t\tvf->promisc_unicast_enabled = true;\n-\telse if (ret == IAVF_NOT_SUPPORTED)\n-\t\tret = -ENOTSUP;\n-\telse\n-\t\tret = -EAGAIN;\n \n-\treturn ret;\n+\treturn iavf_config_promisc(adapter,\n+\t\t\t\t true, vf->promisc_multicast_enabled);\n }\n \n static int\n@@ -695,18 +687,9 @@ iavf_dev_promiscuous_disable(struct rte_eth_dev *dev)\n \tstruct iavf_adapter *adapter =\n \t\tIAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);\n \tstruct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter);\n-\tint ret;\n-\n-\tret = iavf_config_promisc(adapter, false,\n-\t\t\t\t vf->promisc_multicast_enabled);\n-\tif (!ret)\n-\t\tvf->promisc_unicast_enabled = false;\n-\telse if (ret == IAVF_NOT_SUPPORTED)\n-\t\tret = -ENOTSUP;\n-\telse\n-\t\tret = -EAGAIN;\n \n-\treturn ret;\n+\treturn iavf_config_promisc(adapter,\n+\t\t\t\t false, vf->promisc_multicast_enabled);\n }\n \n static int\n@@ -715,17 +698,9 @@ iavf_dev_allmulticast_enable(struct rte_eth_dev *dev)\n \tstruct iavf_adapter *adapter =\n \t\tIAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);\n \tstruct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter);\n-\tint ret;\n-\n-\tret = iavf_config_promisc(adapter, vf->promisc_unicast_enabled, true);\n-\tif (!ret)\n-\t\tvf->promisc_multicast_enabled = true;\n-\telse if (ret == IAVF_NOT_SUPPORTED)\n-\t\tret = -ENOTSUP;\n-\telse\n-\t\tret = -EAGAIN;\n \n-\treturn ret;\n+\treturn iavf_config_promisc(adapter,\n+\t\t\t\t vf->promisc_unicast_enabled, true);\n }\n \n static int\n@@ -734,17 +709,9 @@ iavf_dev_allmulticast_disable(struct rte_eth_dev *dev)\n \tstruct iavf_adapter *adapter =\n \t\tIAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);\n \tstruct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter);\n-\tint ret;\n-\n-\tret = iavf_config_promisc(adapter, vf->promisc_unicast_enabled, false);\n-\tif (!ret)\n-\t\tvf->promisc_multicast_enabled = false;\n-\telse if (ret == IAVF_NOT_SUPPORTED)\n-\t\tret = -ENOTSUP;\n-\telse\n-\t\tret = -EAGAIN;\n \n-\treturn ret;\n+\treturn iavf_config_promisc(adapter,\n+\t\t\t\t vf->promisc_unicast_enabled, false);\n }\n \n static int\ndiff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c\nindex 76f8e38d1..7a9f6b920 100644\n--- a/drivers/net/iavf/iavf_vchnl.c\n+++ b/drivers/net/iavf/iavf_vchnl.c\n@@ -841,10 +841,19 @@ iavf_config_promisc(struct iavf_adapter *adapter,\n \n \terr = iavf_execute_vf_cmd(adapter, &args);\n \n-\tif (err)\n+\tif (err) {\n \t\tPMD_DRV_LOG(ERR,\n \t\t\t \"fail to execute command CONFIG_PROMISCUOUS_MODE\");\n-\treturn err;\n+\n+\t\tif (err == IAVF_NOT_SUPPORTED)\n+\t\t\treturn -ENOTSUP;\n+\n+\t\treturn -EAGAIN;\n+\t}\n+\n+\tvf->promisc_unicast_enabled = enable_unicast;\n+\tvf->promisc_multicast_enabled = enable_multicast;\n+\treturn 0;\n }\n \n int\n", "prefixes": [ "4/8" ] }