Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78877/?format=api
{ "id": 78877, "url": "https://patches.dpdk.org/api/patches/78877/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200925233243.7302-2-dmitry.kozliuk@gmail.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200925233243.7302-2-dmitry.kozliuk@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200925233243.7302-2-dmitry.kozliuk@gmail.com", "date": "2020-09-25T23:32:42", "name": "[v2,1/2] eal/windows: add interrupt thread skeleton", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "88b755ca5a7f80255a0af0572bc80369b42e7e5d", "submitter": { "id": 1581, "url": "https://patches.dpdk.org/api/people/1581/?format=api", "name": "Dmitry Kozlyuk", "email": "dmitry.kozliuk@gmail.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200925233243.7302-2-dmitry.kozliuk@gmail.com/mbox/", "series": [ { "id": 12519, "url": "https://patches.dpdk.org/api/series/12519/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12519", "date": "2020-09-25T23:32:41", "name": "eal/windows: implement alarms", "version": 2, "mbox": "https://patches.dpdk.org/series/12519/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/78877/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/78877/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4FFF2A04BB;\n\tSat, 26 Sep 2020 01:33:18 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 855201EA0D;\n\tSat, 26 Sep 2020 01:33:00 +0200 (CEST)", "from mail-lj1-f195.google.com (mail-lj1-f195.google.com\n [209.85.208.195]) by dpdk.org (Postfix) with ESMTP id BA9BE1DE7D\n for <dev@dpdk.org>; Sat, 26 Sep 2020 01:32:54 +0200 (CEST)", "by mail-lj1-f195.google.com with SMTP id n25so3784397ljj.4\n for <dev@dpdk.org>; Fri, 25 Sep 2020 16:32:54 -0700 (PDT)", "from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23])\n by smtp.gmail.com with ESMTPSA id v14sm394511lfe.79.2020.09.25.16.32.52\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 25 Sep 2020 16:32:52 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=bfVOx5c6G7gqEgB2stcpP23riJ35U+wP8ZUZ0qyR0ic=;\n b=u2FP+Y21LKpIzBR3p3SVAKFIjcPKWakVK+J2yjWgrId8mdgK4JUwoZ+84lCnQ5SqBD\n alkWJcG/a9h8vUSeJG/C+J8bRmhA3KrIBo2g+SSxwwLIpkTpuGjbn41htw6iJwf7qSGc\n AFVNtT9iDWR4LiIS51VCU0vV3lMrAr8s8ZMCAuoU1beS5y6GHyYnfq+8ih33k++OWMWl\n WqqdrgTr5Tt2hmiv63g4Cy+m7PfHpiEcQ7dfqx0tvqb0FuY/DrZmJySF+bslVZo6oBfv\n noEK2Fc1AxTQmgqogfZ7mqwDI4IkTQIbpbrNJQ1gocgvVNB7wu1QpZ1/bHd3VQOdoMnd\n 8JpA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=bfVOx5c6G7gqEgB2stcpP23riJ35U+wP8ZUZ0qyR0ic=;\n b=YONBLOfsQPMhTxx6NLqKWBbb2eco1kvg7JvVTeSobLFMpISkHU6avLnDxJ0fF8WMo1\n rjhHOn99agWNa2l+F2RiH7rUuDtSoozdbdwH/LXqfPJNXeuQpj32VpwSMvm+g1sOBrP/\n cxTeyQYmounhUeEJcvxg6g3HZAXtatvgvKrZEPGodmhVpptW+mkhdcmyWWppmm5mR85D\n Yer/SHnjL05Wp2zR/QEKK6lScZSPe9Oa0Ji1NA9ylcO3JiH6QEZfV9GWuueNg7mfZ10c\n Arcz9hCjOIsZzidts3DE+WifHeX/H03f22GxkuCJ9sRLbdPbyBHgh1aig2MfhadMYTdm\n lXxQ==", "X-Gm-Message-State": "AOAM533Mhe3hnCdtw2ZCn93eKU8TmPqxuZN6pocoptyn/1U1P/YXUo87\n OhGOJk/6Ao4Qb0AxAHjdsSIZvUmmusUxvefz", "X-Google-Smtp-Source": "\n ABdhPJzH1aYal1wqhzvtnAmyFMA7bLOlU0pqaFffeGjvLnfciUlL97ix5qGKDlD5jTFOr9R2km5ebw==", "X-Received": "by 2002:a2e:2ac3:: with SMTP id\n q186mr2104235ljq.419.1601076772994;\n Fri, 25 Sep 2020 16:32:52 -0700 (PDT)", "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "To": "dev@dpdk.org", "Cc": "Khoa To <khot@microsoft.com>, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Harman Kalra <hkalra@marvell.com>,\n Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,\n Dmitry Malloy <dmitrym@microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>", "Date": "Sat, 26 Sep 2020 02:32:42 +0300", "Message-Id": "<20200925233243.7302-2-dmitry.kozliuk@gmail.com>", "X-Mailer": "git-send-email 2.25.4", "In-Reply-To": "<20200925233243.7302-1-dmitry.kozliuk@gmail.com>", "References": "<20200911002207.31813-1-dmitry.kozliuk@gmail.com>\n <20200925233243.7302-1-dmitry.kozliuk@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 1/2] eal/windows: add interrupt thread skeleton", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Windows interrupt support is based on IO completion ports (IOCP).\nInterrupt thread would send the devices requests to notify about\ninterrupts and then wait for any request completion. Add skeleton code\nof this model without any hardware support.\n\nAnother way to wake up the interrupt thread is APC (asynchronous procedure\ncall), scheduled by any other thread via eal_intr_thread_schedule().\nThis internal API is intended for alarm implementation.\n\nSigned-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\n---\n lib/librte_eal/include/rte_eal_interrupts.h | 14 ++-\n lib/librte_eal/rte_eal_exports.def | 1 +\n lib/librte_eal/windows/eal.c | 5 ++\n lib/librte_eal/windows/eal_interrupts.c | 94 +++++++++++++++++++++\n lib/librte_eal/windows/eal_windows.h | 12 +++\n lib/librte_eal/windows/include/pthread.h | 7 ++\n 6 files changed, 130 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/librte_eal/include/rte_eal_interrupts.h b/lib/librte_eal/include/rte_eal_interrupts.h\nindex b1e8a2934..b80edfc65 100644\n--- a/lib/librte_eal/include/rte_eal_interrupts.h\n+++ b/lib/librte_eal/include/rte_eal_interrupts.h\n@@ -69,10 +69,18 @@ struct rte_epoll_event {\n struct rte_intr_handle {\n \tRTE_STD_C11\n \tunion {\n-\t\tint vfio_dev_fd; /**< VFIO device file descriptor */\n-\t\tint uio_cfg_fd; /**< UIO cfg file desc for uio_pci_generic */\n+\t\tstruct {\n+\t\t\tRTE_STD_C11\n+\t\t\tunion {\n+\t\t\t\t/** VFIO device file descriptor */\n+\t\t\t\tint vfio_dev_fd;\n+\t\t\t\t/** UIO cfg file desc for uio_pci_generic */\n+\t\t\t\tint uio_cfg_fd;\n+\t\t\t};\n+\t\t\tint fd;\t/**< interrupt event file descriptor */\n+\t\t};\n+\t\tvoid *handle; /**< device driver handle (Windows) */\n \t};\n-\tint fd;\t /**< interrupt event file descriptor */\n \tenum rte_intr_handle_type type; /**< handle type */\n \tuint32_t max_intr; /**< max interrupt requested */\n \tuint32_t nb_efd; /**< number of available efd(event fd) */\ndiff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def\nindex cda3e0c79..dd8adfa23 100644\n--- a/lib/librte_eal/rte_eal_exports.def\n+++ b/lib/librte_eal/rte_eal_exports.def\n@@ -70,6 +70,7 @@ EXPORTS\n \trte_vlog\n \trte_realloc\n \trte_strscpy\n+\trte_thread_is_intr\n \trte_zmalloc\n \trte_zmalloc_socket\n \ndiff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c\nindex bc48f27ab..141f22adb 100644\n--- a/lib/librte_eal/windows/eal.c\n+++ b/lib/librte_eal/windows/eal.c\n@@ -344,6 +344,11 @@ rte_eal_init(int argc, char **argv)\n \t\treturn -1;\n \t}\n \n+\tif (rte_eal_intr_init() < 0) {\n+\t\trte_eal_init_alert(\"Cannot init interrupt-handling thread\");\n+\t\treturn -1;\n+\t}\n+\n \tif (rte_eal_timer_init() < 0) {\n \t\trte_eal_init_alert(\"Cannot init TSC timer\");\n \t\trte_errno = EFAULT;\ndiff --git a/lib/librte_eal/windows/eal_interrupts.c b/lib/librte_eal/windows/eal_interrupts.c\nindex d3ecdaccb..6c64a48f3 100644\n--- a/lib/librte_eal/windows/eal_interrupts.c\n+++ b/lib/librte_eal/windows/eal_interrupts.c\n@@ -4,6 +4,81 @@\n \n #include <rte_interrupts.h>\n \n+#include \"eal_private.h\"\n+#include \"eal_windows.h\"\n+\n+static pthread_t intr_thread;\n+\n+static HANDLE intr_iocp;\n+\n+static void\n+eal_intr_process(const OVERLAPPED_ENTRY *event)\n+{\n+\tRTE_SET_USED(event);\n+}\n+\n+static void *\n+eal_intr_thread_main(LPVOID arg __rte_unused)\n+{\n+\twhile (1) {\n+\t\tOVERLAPPED_ENTRY events[16];\n+\t\tULONG event_count, i;\n+\t\tBOOL result;\n+\n+\t\tresult = GetQueuedCompletionStatusEx(\n+\t\t\tintr_iocp, events, RTE_DIM(events), &event_count,\n+\t\t\tINFINITE, /* no timeout */\n+\t\t\tTRUE); /* alertable wait for alarm APCs */\n+\n+\t\tif (!result) {\n+\t\t\tDWORD error = GetLastError();\n+\t\t\tif (error != WAIT_IO_COMPLETION) {\n+\t\t\t\tRTE_LOG_WIN32_ERR(\"GetQueuedCompletionStatusEx()\");\n+\t\t\t\tRTE_LOG(ERR, EAL, \"Failed waiting for interrupts\\n\");\n+\t\t\t\tbreak;\n+\t\t\t}\n+\n+\t\t\t/* No I/O events, all work is done in completed APCs. */\n+\t\t\tcontinue;\n+\t\t}\n+\n+\t\tfor (i = 0; i < event_count; i++)\n+\t\t\teal_intr_process(&events[i]);\n+\t}\n+\n+\tCloseHandle(intr_iocp);\n+\tintr_iocp = NULL;\n+\treturn NULL;\n+}\n+\n+int\n+rte_eal_intr_init(void)\n+{\n+\tint ret = 0;\n+\n+\tintr_iocp = CreateIoCompletionPort(INVALID_HANDLE_VALUE, NULL, 0, 1);\n+\tif (intr_iocp == NULL) {\n+\t\tRTE_LOG_WIN32_ERR(\"CreateIoCompletionPort()\");\n+\t\tRTE_LOG(ERR, EAL, \"Cannot create interrupt IOCP\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\tret = rte_ctrl_thread_create(&intr_thread, \"eal-intr-thread\", NULL,\n+\t\t\teal_intr_thread_main, NULL);\n+\tif (ret != 0) {\n+\t\trte_errno = -ret;\n+\t\tRTE_LOG(ERR, EAL, \"Cannot create interrupt thread\\n\");\n+\t}\n+\n+\treturn ret;\n+}\n+\n+int\n+rte_thread_is_intr(void)\n+{\n+\treturn pthread_equal(intr_thread, pthread_self());\n+}\n+\n int\n rte_intr_rx_ctl(__rte_unused struct rte_intr_handle *intr_handle,\n \t\t__rte_unused int epfd, __rte_unused int op,\n@@ -11,3 +86,22 @@ rte_intr_rx_ctl(__rte_unused struct rte_intr_handle *intr_handle,\n {\n \treturn -ENOTSUP;\n }\n+\n+int\n+eal_intr_thread_schedule(void (*func)(void *arg), void *arg)\n+{\n+\tHANDLE handle;\n+\n+\thandle = OpenThread(THREAD_ALL_ACCESS, FALSE, intr_thread);\n+\tif (handle == NULL) {\n+\t\tRTE_LOG_WIN32_ERR(\"OpenThread(%llu)\", intr_thread);\n+\t\treturn -ENOENT;\n+\t}\n+\n+\tif (!QueueUserAPC((PAPCFUNC)(ULONG_PTR)func, handle, (ULONG_PTR)arg)) {\n+\t\tRTE_LOG_WIN32_ERR(\"QueueUserAPC()\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\treturn 0;\n+}\ndiff --git a/lib/librte_eal/windows/eal_windows.h b/lib/librte_eal/windows/eal_windows.h\nindex d48ee0a12..478accc1b 100644\n--- a/lib/librte_eal/windows/eal_windows.h\n+++ b/lib/librte_eal/windows/eal_windows.h\n@@ -55,6 +55,18 @@ int eal_thread_create(pthread_t *thread);\n */\n unsigned int eal_socket_numa_node(unsigned int socket_id);\n \n+/**\n+ * Schedule code for execution in the interrupt thread.\n+ *\n+ * @param func\n+ * Function to call.\n+ * @param arg\n+ * Argument to the called function.\n+ * @return\n+ * 0 on success, netagive error code on failure.\n+ */\n+int eal_intr_thread_schedule(void (*func)(void *arg), void *arg);\n+\n /**\n * Open virt2phys driver interface device.\n *\ndiff --git a/lib/librte_eal/windows/include/pthread.h b/lib/librte_eal/windows/include/pthread.h\nindex 99013dc94..a4ab4d094 100644\n--- a/lib/librte_eal/windows/include/pthread.h\n+++ b/lib/librte_eal/windows/include/pthread.h\n@@ -42,6 +42,13 @@ typedef SYNCHRONIZATION_BARRIER pthread_barrier_t;\n #define pthread_self() \\\n \t((pthread_t)GetCurrentThreadId())\n \n+\n+static inline int\n+pthread_equal(pthread_t t1, pthread_t t2)\n+{\n+\treturn t1 == t2;\n+}\n+\n static inline int\n pthread_setaffinity_np(pthread_t threadid, size_t cpuset_size,\n \t\t\trte_cpuset_t *cpuset)\n", "prefixes": [ "v2", "1/2" ] }