Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78810/?format=api
{ "id": 78810, "url": "https://patches.dpdk.org/api/patches/78810/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200925110910.284098-5-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200925110910.284098-5-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200925110910.284098-5-bruce.richardson@intel.com", "date": "2020-09-25T11:08:49", "name": "[v3,04/25] raw/ioat: include extra info in error messages", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dfa38bf5d3365a307aedee407530d17ebf6dd50c", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200925110910.284098-5-bruce.richardson@intel.com/mbox/", "series": [ { "id": 12509, "url": "https://patches.dpdk.org/api/series/12509/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12509", "date": "2020-09-25T11:08:45", "name": "raw/ioat: enhancements and new hardware support", "version": 3, "mbox": "https://patches.dpdk.org/series/12509/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/78810/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/78810/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 81810A04C0;\n\tFri, 25 Sep 2020 13:10:09 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A64EB1E8F5;\n\tFri, 25 Sep 2020 13:09:43 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id B63E41E8BE\n for <dev@dpdk.org>; Fri, 25 Sep 2020 13:09:39 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Sep 2020 04:09:37 -0700", "from unknown (HELO silpixa00399126.ir.intel.com) ([10.237.222.4])\n by orsmga004.jf.intel.com with ESMTP; 25 Sep 2020 04:09:36 -0700" ], "IronPort-SDR": [ "\n w0mFrNS9LoHkWo3InDnFbc5LTcbFvqIC44BGsaOUjg15p2k5s/lP6sAyVbOT+JLyGc91aYwI/H\n ruGwx54+ct0w==", "\n JDZ2xHfHinYSwVwy3JN23WchypiyXsCFad5PCJd7ggf/vxH97kTzEreDN0R7FYxBXL0KWBQbZ7\n 3AS6kvanNxBg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9754\"; a=\"149263052\"", "E=Sophos;i=\"5.77,301,1596524400\"; d=\"scan'208\";a=\"149263052\"", "E=Sophos;i=\"5.77,301,1596524400\"; d=\"scan'208\";a=\"455787821\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "patrick.fu@intel.com, Bruce Richardson <bruce.richardson@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>", "Date": "Fri, 25 Sep 2020 12:08:49 +0100", "Message-Id": "<20200925110910.284098-5-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20200925110910.284098-1-bruce.richardson@intel.com>", "References": "<20200721095140.719297-1-bruce.richardson@intel.com>\n <20200925110910.284098-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 04/25] raw/ioat: include extra info in error\n\tmessages", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In case of any failures, include the function name and the line number of\nthe error message in the message, to make tracking down the failure easier.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nReviewed-by: Kevin Laatz <kevin.laatz@intel.com>\n---\n drivers/raw/ioat/ioat_rawdev_test.c | 53 +++++++++++++++++++----------\n 1 file changed, 35 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/raw/ioat/ioat_rawdev_test.c b/drivers/raw/ioat/ioat_rawdev_test.c\nindex c463a82ad..8e7fd96af 100644\n--- a/drivers/raw/ioat/ioat_rawdev_test.c\n+++ b/drivers/raw/ioat/ioat_rawdev_test.c\n@@ -13,6 +13,23 @@ int ioat_rawdev_test(uint16_t dev_id); /* pre-define to keep compiler happy */\n static struct rte_mempool *pool;\n static unsigned short expected_ring_size;\n \n+#define PRINT_ERR(...) print_err(__func__, __LINE__, __VA_ARGS__)\n+\n+static inline int\n+__rte_format_printf(3, 4)\n+print_err(const char *func, int lineno, const char *format, ...)\n+{\n+\tva_list ap;\n+\tint ret;\n+\n+\tret = fprintf(stderr, \"In %s:%d - \", func, lineno);\n+\tva_start(ap, format);\n+\tret += vfprintf(stderr, format, ap);\n+\tva_end(ap);\n+\n+\treturn ret;\n+}\n+\n static int\n test_enqueue_copies(int dev_id)\n {\n@@ -42,7 +59,7 @@ test_enqueue_copies(int dev_id)\n \t\t\t\t(uintptr_t)src,\n \t\t\t\t(uintptr_t)dst,\n \t\t\t\t0 /* no fence */) != 1) {\n-\t\t\tprintf(\"Error with rte_ioat_enqueue_copy\\n\");\n+\t\t\tPRINT_ERR(\"Error with rte_ioat_enqueue_copy\\n\");\n \t\t\treturn -1;\n \t\t}\n \t\trte_ioat_do_copies(dev_id);\n@@ -50,18 +67,18 @@ test_enqueue_copies(int dev_id)\n \n \t\tif (rte_ioat_completed_copies(dev_id, 1, (void *)&completed[0],\n \t\t\t\t(void *)&completed[1]) != 1) {\n-\t\t\tprintf(\"Error with rte_ioat_completed_copies\\n\");\n+\t\t\tPRINT_ERR(\"Error with rte_ioat_completed_copies\\n\");\n \t\t\treturn -1;\n \t\t}\n \t\tif (completed[0] != src || completed[1] != dst) {\n-\t\t\tprintf(\"Error with completions: got (%p, %p), not (%p,%p)\\n\",\n+\t\t\tPRINT_ERR(\"Error with completions: got (%p, %p), not (%p,%p)\\n\",\n \t\t\t\t\tcompleted[0], completed[1], src, dst);\n \t\t\treturn -1;\n \t\t}\n \n \t\tfor (i = 0; i < length; i++)\n \t\t\tif (dst_data[i] != src_data[i]) {\n-\t\t\t\tprintf(\"Data mismatch at char %u\\n\", i);\n+\t\t\t\tPRINT_ERR(\"Data mismatch at char %u\\n\", i);\n \t\t\t\treturn -1;\n \t\t\t}\n \t\trte_pktmbuf_free(src);\n@@ -94,7 +111,7 @@ test_enqueue_copies(int dev_id)\n \t\t\t\t\t(uintptr_t)srcs[i],\n \t\t\t\t\t(uintptr_t)dsts[i],\n \t\t\t\t\t0 /* nofence */) != 1) {\n-\t\t\t\tprintf(\"Error with rte_ioat_enqueue_copy for buffer %u\\n\",\n+\t\t\t\tPRINT_ERR(\"Error with rte_ioat_enqueue_copy for buffer %u\\n\",\n \t\t\t\t\t\ti);\n \t\t\t\treturn -1;\n \t\t\t}\n@@ -104,18 +121,18 @@ test_enqueue_copies(int dev_id)\n \n \t\tif (rte_ioat_completed_copies(dev_id, 64, (void *)completed_src,\n \t\t\t\t(void *)completed_dst) != RTE_DIM(srcs)) {\n-\t\t\tprintf(\"Error with rte_ioat_completed_copies\\n\");\n+\t\t\tPRINT_ERR(\"Error with rte_ioat_completed_copies\\n\");\n \t\t\treturn -1;\n \t\t}\n \t\tfor (i = 0; i < RTE_DIM(srcs); i++) {\n \t\t\tchar *src_data, *dst_data;\n \n \t\t\tif (completed_src[i] != srcs[i]) {\n-\t\t\t\tprintf(\"Error with source pointer %u\\n\", i);\n+\t\t\t\tPRINT_ERR(\"Error with source pointer %u\\n\", i);\n \t\t\t\treturn -1;\n \t\t\t}\n \t\t\tif (completed_dst[i] != dsts[i]) {\n-\t\t\t\tprintf(\"Error with dest pointer %u\\n\", i);\n+\t\t\t\tPRINT_ERR(\"Error with dest pointer %u\\n\", i);\n \t\t\t\treturn -1;\n \t\t\t}\n \n@@ -123,7 +140,7 @@ test_enqueue_copies(int dev_id)\n \t\t\tdst_data = rte_pktmbuf_mtod(dsts[i], char *);\n \t\t\tfor (j = 0; j < length; j++)\n \t\t\t\tif (src_data[j] != dst_data[j]) {\n-\t\t\t\t\tprintf(\"Error with copy of packet %u, byte %u\\n\",\n+\t\t\t\t\tPRINT_ERR(\"Error with copy of packet %u, byte %u\\n\",\n \t\t\t\t\t\t\ti, j);\n \t\t\t\t\treturn -1;\n \t\t\t\t}\n@@ -150,26 +167,26 @@ ioat_rawdev_test(uint16_t dev_id)\n \n \trte_rawdev_info_get(dev_id, &info, sizeof(p));\n \tif (p.ring_size != expected_ring_size) {\n-\t\tprintf(\"Error, initial ring size is not as expected (Actual: %d, Expected: %d)\\n\",\n+\t\tPRINT_ERR(\"Error, initial ring size is not as expected (Actual: %d, Expected: %d)\\n\",\n \t\t\t\t(int)p.ring_size, expected_ring_size);\n \t\treturn -1;\n \t}\n \n \tp.ring_size = IOAT_TEST_RINGSIZE;\n \tif (rte_rawdev_configure(dev_id, &info, sizeof(p)) != 0) {\n-\t\tprintf(\"Error with rte_rawdev_configure()\\n\");\n+\t\tPRINT_ERR(\"Error with rte_rawdev_configure()\\n\");\n \t\treturn -1;\n \t}\n \trte_rawdev_info_get(dev_id, &info, sizeof(p));\n \tif (p.ring_size != IOAT_TEST_RINGSIZE) {\n-\t\tprintf(\"Error, ring size is not %d (%d)\\n\",\n+\t\tPRINT_ERR(\"Error, ring size is not %d (%d)\\n\",\n \t\t\t\tIOAT_TEST_RINGSIZE, (int)p.ring_size);\n \t\treturn -1;\n \t}\n \texpected_ring_size = p.ring_size;\n \n \tif (rte_rawdev_start(dev_id) != 0) {\n-\t\tprintf(\"Error with rte_rawdev_start()\\n\");\n+\t\tPRINT_ERR(\"Error with rte_rawdev_start()\\n\");\n \t\treturn -1;\n \t}\n \n@@ -180,7 +197,7 @@ ioat_rawdev_test(uint16_t dev_id)\n \t\t\t2048, /* data room size */\n \t\t\tinfo.socket_id);\n \tif (pool == NULL) {\n-\t\tprintf(\"Error with mempool creation\\n\");\n+\t\tPRINT_ERR(\"Error with mempool creation\\n\");\n \t\treturn -1;\n \t}\n \n@@ -189,14 +206,14 @@ ioat_rawdev_test(uint16_t dev_id)\n \n \tsnames = malloc(sizeof(*snames) * nb_xstats);\n \tif (snames == NULL) {\n-\t\tprintf(\"Error allocating xstat names memory\\n\");\n+\t\tPRINT_ERR(\"Error allocating xstat names memory\\n\");\n \t\tgoto err;\n \t}\n \trte_rawdev_xstats_names_get(dev_id, snames, nb_xstats);\n \n \tids = malloc(sizeof(*ids) * nb_xstats);\n \tif (ids == NULL) {\n-\t\tprintf(\"Error allocating xstat ids memory\\n\");\n+\t\tPRINT_ERR(\"Error allocating xstat ids memory\\n\");\n \t\tgoto err;\n \t}\n \tfor (i = 0; i < nb_xstats; i++)\n@@ -204,7 +221,7 @@ ioat_rawdev_test(uint16_t dev_id)\n \n \tstats = malloc(sizeof(*stats) * nb_xstats);\n \tif (stats == NULL) {\n-\t\tprintf(\"Error allocating xstat memory\\n\");\n+\t\tPRINT_ERR(\"Error allocating xstat memory\\n\");\n \t\tgoto err;\n \t}\n \n@@ -224,7 +241,7 @@ ioat_rawdev_test(uint16_t dev_id)\n \n \trte_rawdev_stop(dev_id);\n \tif (rte_rawdev_xstats_reset(dev_id, NULL, 0) != 0) {\n-\t\tprintf(\"Error resetting xstat values\\n\");\n+\t\tPRINT_ERR(\"Error resetting xstat values\\n\");\n \t\tgoto err;\n \t}\n \n", "prefixes": [ "v3", "04/25" ] }