Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78738/?format=api
{ "id": 78738, "url": "https://patches.dpdk.org/api/patches/78738/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1600949555-28043-30-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1600949555-28043-30-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1600949555-28043-30-git-send-email-arybchenko@solarflare.com", "date": "2020-09-24T12:12:04", "name": "[v3,29/60] common/sfc_efx/base: maintain RxQ counter in generic code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "cde589c609737a3897d1f44e84a7c42eaad10bbc", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1600949555-28043-30-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 12473, "url": "https://patches.dpdk.org/api/series/12473/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12473", "date": "2020-09-24T12:11:40", "name": "common/sfc_efx: support Riverhead NIC family", "version": 3, "mbox": "https://patches.dpdk.org/series/12473/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/78738/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/78738/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B1A00A04B1;\n\tThu, 24 Sep 2020 14:24:43 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AF1C01E559;\n\tThu, 24 Sep 2020 14:14:26 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id A919C1DE35\n for <dev@dpdk.org>; Thu, 24 Sep 2020 14:13:28 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.64])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n 3580760084 for <dev@dpdk.org>; Thu, 24 Sep 2020 12:13:28 +0000 (UTC)", "from us4-mdac16-50.ut7.mdlocal (unknown [10.7.66.17])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 347552009B\n for <dev@dpdk.org>; Thu, 24 Sep 2020 12:13:28 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.175])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 80697220056\n for <dev@dpdk.org>; Thu, 24 Sep 2020 12:12:57 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 377F2700053\n for <dev@dpdk.org>; Thu, 24 Sep 2020 12:12:57 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Thu, 24 Sep 2020 13:12:47 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Thu, 24 Sep 2020 13:12:47 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 08OCClUj025987\n for <dev@dpdk.org>; Thu, 24 Sep 2020 13:12:47 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 359AB1613A9\n for <dev@dpdk.org>; Thu, 24 Sep 2020 13:12:47 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Thu, 24 Sep 2020 13:12:04 +0100", "Message-ID": "<1600949555-28043-30-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1600949555-28043-1-git-send-email-arybchenko@solarflare.com>", "References": "<1600764594-14752-1-git-send-email-arybchenko@solarflare.com>\n <1600949555-28043-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25674.003", "X-TM-AS-Result": "No-1.781200-8.000000-10", "X-TMASE-MatchedRID": "m5OprH8CLZCaVIIaatNFMCZm6wdY+F8KSoCG4sefl8RKddiF2Wo8eaJF\n mbmfOdw3Jhc7ZyunPkUWsp6eJb7A2xt/FEV6QNBCnFVnNmvv47tLXPA26IG0hN9RlPzeVuQQrIV\n tWePlRJHBpZJtALK4pJiZtB0b70pFGURp8zeLWy/HmyDJSEsI2+6jyigxCo6yrlV24CuN0IZnY0\n nSyjeN3eLzNWBegCW2wgn7iDBesS1YF3qW3Je6+0KHP2ZsKkf0QFGuVXX4dA0/+ZnAPtkrDfB8w\n x2Mtm3fIRXE0K4Gn7ZrUrARoes+cqIckCVieNFqrn1V5j9JVNNYWbPs2y9u4aoWu33FSCn66r5P\n Qhx29DUG0+3lZBNmQtq4RBohbjorhiKda4whv6J+3BndfXUhXQ==", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10-1.781200-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25674.003", "X-MDID": "1600949578-k84urEe1PiD4", "Subject": "[dpdk-dev] [PATCH v3 29/60] common/sfc_efx/base: maintain RxQ\n\tcounter in generic code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The counter is incremented in generic efx_rx_qcreate(), but was\nasserted and decremented in NIC family specific queue create and\ndestroy callbacks. Move assert and decrement to generic functions\nas well to make NIC family specific callbacks shorter.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/common/sfc_efx/base/ef10_rx.c | 4 ----\n drivers/common/sfc_efx/base/efx_rx.c | 9 +++++----\n 2 files changed, 5 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/common/sfc_efx/base/ef10_rx.c b/drivers/common/sfc_efx/base/ef10_rx.c\nindex f27058963f..7004ab2aca 100644\n--- a/drivers/common/sfc_efx/base/ef10_rx.c\n+++ b/drivers/common/sfc_efx/base/ef10_rx.c\n@@ -844,7 +844,6 @@ ef10_rx_qcreate(\n \n \tEFX_STATIC_ASSERT(EFX_EV_RX_NLABELS == (1 << ESF_DZ_RX_QLABEL_WIDTH));\n \tEFSYS_ASSERT3U(label, <, EFX_EV_RX_NLABELS);\n-\tEFSYS_ASSERT3U(enp->en_rx_qcount + 1, <, encp->enc_rxq_limit);\n \n \tif (index >= encp->enc_rxq_limit) {\n \t\trc = EINVAL;\n@@ -1022,9 +1021,6 @@ ef10_rx_qdestroy(\n \n \tef10_ev_rxlabel_fini(eep, label);\n \n-\tEFSYS_ASSERT(enp->en_rx_qcount != 0);\n-\t--enp->en_rx_qcount;\n-\n \tEFSYS_KMEM_FREE(enp->en_esip, sizeof (efx_rxq_t), erp);\n }\n \ndiff --git a/drivers/common/sfc_efx/base/efx_rx.c b/drivers/common/sfc_efx/base/efx_rx.c\nindex cce34cfce9..a361112849 100644\n--- a/drivers/common/sfc_efx/base/efx_rx.c\n+++ b/drivers/common/sfc_efx/base/efx_rx.c\n@@ -819,6 +819,8 @@ efx_rx_qcreate_internal(\n \tEFSYS_ASSERT3U(enp->en_magic, ==, EFX_NIC_MAGIC);\n \tEFSYS_ASSERT3U(enp->en_mod_flags, &, EFX_MOD_RX);\n \n+\tEFSYS_ASSERT3U(enp->en_rx_qcount + 1, <, encp->enc_rxq_limit);\n+\n \tEFSYS_ASSERT(ISP2(encp->enc_rxq_max_ndescs));\n \tEFSYS_ASSERT(ISP2(encp->enc_rxq_min_ndescs));\n \n@@ -975,6 +977,9 @@ efx_rx_qdestroy(\n \n \tEFSYS_ASSERT3U(erp->er_magic, ==, EFX_RXQ_MAGIC);\n \n+\tEFSYS_ASSERT(enp->en_rx_qcount != 0);\n+\t--enp->en_rx_qcount;\n+\n \terxop->erxo_qdestroy(erp);\n }\n \n@@ -1626,7 +1631,6 @@ siena_rx_qcreate(\n \tEFX_STATIC_ASSERT(EFX_EV_RX_NLABELS ==\n \t (1 << FRF_AZ_RX_DESCQ_LABEL_WIDTH));\n \tEFSYS_ASSERT3U(label, <, EFX_EV_RX_NLABELS);\n-\tEFSYS_ASSERT3U(enp->en_rx_qcount + 1, <, encp->enc_rxq_limit);\n \n \tif (index >= encp->enc_rxq_limit) {\n \t\trc = EINVAL;\n@@ -1697,9 +1701,6 @@ siena_rx_qdestroy(\n \tefx_nic_t *enp = erp->er_enp;\n \tefx_oword_t oword;\n \n-\tEFSYS_ASSERT(enp->en_rx_qcount != 0);\n-\t--enp->en_rx_qcount;\n-\n \t/* Purge descriptor queue */\n \tEFX_ZERO_OWORD(oword);\n \n", "prefixes": [ "v3", "29/60" ] }