Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78729/?format=api
{ "id": 78729, "url": "https://patches.dpdk.org/api/patches/78729/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1600949555-28043-61-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1600949555-28043-61-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1600949555-28043-61-git-send-email-arybchenko@solarflare.com", "date": "2020-09-24T12:12:35", "name": "[v3,60/60] common/sfc_efx/base: handle descriptor proxy queue events", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e4f415cd9d54c940c49f650c8654b07edd1bd1ad", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1600949555-28043-61-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 12473, "url": "https://patches.dpdk.org/api/series/12473/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12473", "date": "2020-09-24T12:11:40", "name": "common/sfc_efx: support Riverhead NIC family", "version": 3, "mbox": "https://patches.dpdk.org/series/12473/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/78729/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/78729/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2FB53A04B1;\n\tThu, 24 Sep 2020 14:22:23 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C56581E4BC;\n\tThu, 24 Sep 2020 14:14:15 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 255531DE34\n for <dev@dpdk.org>; Thu, 24 Sep 2020 14:13:06 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.62])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n A5EE6600A5 for <dev@dpdk.org>; Thu, 24 Sep 2020 12:13:05 +0000 (UTC)", "from us4-mdac16-41.ut7.mdlocal (unknown [10.7.64.23])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id A4F668009B\n for <dev@dpdk.org>; Thu, 24 Sep 2020 12:13:05 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.200])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 2152A28005C\n for <dev@dpdk.org>; Thu, 24 Sep 2020 12:13:05 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n CC86B80005A\n for <dev@dpdk.org>; Thu, 24 Sep 2020 12:13:04 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Thu, 24 Sep 2020 13:12:48 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Thu, 24 Sep 2020 13:12:48 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 08OCCmpc026139;\n Thu, 24 Sep 2020 13:12:48 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id D225B1613AB;\n Thu, 24 Sep 2020 13:12:48 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Andy Moreton <amoreton@xilinx.com>", "Date": "Thu, 24 Sep 2020 13:12:35 +0100", "Message-ID": "<1600949555-28043-61-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1600949555-28043-1-git-send-email-arybchenko@solarflare.com>", "References": "<1600764594-14752-1-git-send-email-arybchenko@solarflare.com>\n <1600949555-28043-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25674.003", "X-TM-AS-Result": "No-9.619100-8.000000-10", "X-TMASE-MatchedRID": "mI+vgRxq91g7mxcq3Lrcs3T7rnt3EYkYOTjDMsgp/8FQmhcK24nKvi35\n 5p3utdHTcKLpeT1KvPYs/31GzKkTsQihmwiXCMoGPwKTD1v8YV5MkOX0UoduufdG7cmuMnEoDT9\n yMWZunWd8iXFJnQ8v8xVut6p9K14pWNQe1bLu8dlusn2BWc6xnbOLGEexUnny0SxMhOhuA0R7qL\n CJ87oUjCiOUNh0Cg8F/X61PWt0t3y8lW3ZCgNPR511xPnSv0xQ3V4UShoTXad7FPRDQ9E1dE1zo\n 9VwQLtwSJfeYWo7uiUL0RECp9c/60s3SiaAjbkfsJribvbshQ+g8867bIwmUy2QO02vY1BNo8WM\n kQWv6iXBcIE78YqRWo6HM5rqDwqtTwRSHNQlYTxAiuaQYQV9tC3/zGDej6j2TSIMAOYVOYl/Rlb\n 1TxS7NkMMprcbiest", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--9.619100-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25674.003", "X-MDID": "1600949585-narG49p2-dLD", "Subject": "[dpdk-dev] [PATCH v3 60/60] common/sfc_efx/base: handle descriptor\n\tproxy queue events", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Andy Moreton <amoreton@xilinx.com>\n\nThe TXQ_DESC and VIRTQ_DESC events are used to pass host descriptors\nover an extended width event queue to an application processor for\nhandling. See SF-122927-TC and SF-122966-SW for details.\n\nSigned-off-by: Andy Moreton <amoreton@xilinx.com>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/common/sfc_efx/base/efx.h | 32 +++++++++\n drivers/common/sfc_efx/base/efx_impl.h | 10 +++\n drivers/common/sfc_efx/base/rhead_ev.c | 95 ++++++++++++++++++++++++++\n 3 files changed, 137 insertions(+)", "diff": "diff --git a/drivers/common/sfc_efx/base/efx.h b/drivers/common/sfc_efx/base/efx.h\nindex ecd16712ba..07a7e3c952 100644\n--- a/drivers/common/sfc_efx/base/efx.h\n+++ b/drivers/common/sfc_efx/base/efx.h\n@@ -2487,6 +2487,33 @@ typedef __checkReturn\tboolean_t\n \n #endif\t/* EFSYS_OPT_MAC_STATS */\n \n+#if EFSYS_OPT_DESC_PROXY\n+\n+/*\n+ * NOTE: This callback returns the raw descriptor data, which has not been\n+ * converted to host endian. The callback must use the EFX_OWORD macros\n+ * to extract the descriptor fields as host endian values.\n+ */\n+typedef __checkReturn\tboolean_t\n+(*efx_desc_proxy_txq_desc_ev_t)(\n+\t__in_opt\tvoid *arg,\n+\t__in\t\tuint16_t vi_id,\n+\t__in\t\tefx_oword_t txq_desc);\n+\n+/*\n+ * NOTE: This callback returns the raw descriptor data, which has not been\n+ * converted to host endian. The callback must use the EFX_OWORD macros\n+ * to extract the descriptor fields as host endian values.\n+ */\n+typedef __checkReturn\tboolean_t\n+(*efx_desc_proxy_virtq_desc_ev_t)(\n+\t__in_opt\tvoid *arg,\n+\t__in\t\tuint16_t vi_id,\n+\t__in\t\tuint16_t avail,\n+\t__in\t\tefx_oword_t virtq_desc);\n+\n+#endif /* EFSYS_OPT_DESC_PROXY */\n+\n typedef struct efx_ev_callbacks_s {\n \tefx_initialized_ev_t\t\teec_initialized;\n \tefx_rx_ev_t\t\t\teec_rx;\n@@ -2511,6 +2538,11 @@ typedef struct efx_ev_callbacks_s {\n #if EFSYS_OPT_MAC_STATS\n \tefx_mac_stats_ev_t\t\teec_mac_stats;\n #endif\t/* EFSYS_OPT_MAC_STATS */\n+#if EFSYS_OPT_DESC_PROXY\n+\tefx_desc_proxy_txq_desc_ev_t\teec_desc_proxy_txq_desc;\n+\tefx_desc_proxy_virtq_desc_ev_t\teec_desc_proxy_virtq_desc;\n+#endif /* EFSYS_OPT_DESC_PROXY */\n+\n } efx_ev_callbacks_t;\n \n LIBEFX_API\ndiff --git a/drivers/common/sfc_efx/base/efx_impl.h b/drivers/common/sfc_efx/base/efx_impl.h\nindex f58586bee0..196fd4a79c 100644\n--- a/drivers/common/sfc_efx/base/efx_impl.h\n+++ b/drivers/common/sfc_efx/base/efx_impl.h\n@@ -902,6 +902,11 @@ struct efx_nic_s {\n typedef\tboolean_t (*efx_ev_handler_t)(efx_evq_t *, efx_qword_t *,\n const efx_ev_callbacks_t *, void *);\n \n+#if EFSYS_OPT_EV_EXTENDED_WIDTH\n+typedef\tboolean_t (*efx_ev_ew_handler_t)(efx_evq_t *, efx_xword_t *,\n+ const efx_ev_callbacks_t *, void *);\n+#endif /* EFSYS_OPT_EV_EXTENDED_WIDTH */\n+\n typedef struct efx_evq_rxq_state_s {\n \tunsigned int\t\t\teers_rx_read_ptr;\n \tunsigned int\t\t\teers_rx_mask;\n@@ -934,6 +939,11 @@ struct efx_evq_s {\n \tefx_ev_handler_t\t\tee_mcdi;\n #endif\t/* EFSYS_OPT_MCDI */\n \n+#if EFSYS_OPT_DESC_PROXY\n+\tefx_ev_ew_handler_t\t\tee_ew_txq_desc;\n+\tefx_ev_ew_handler_t\t\tee_ew_virtq_desc;\n+#endif /* EFSYS_OPT_DESC_PROXY */\n+\n \tefx_evq_rxq_state_t\t\tee_rxq_state[EFX_EV_RX_NLABELS];\n };\n \ndiff --git a/drivers/common/sfc_efx/base/rhead_ev.c b/drivers/common/sfc_efx/base/rhead_ev.c\nindex 5bda315171..2b5635f1cd 100644\n--- a/drivers/common/sfc_efx/base/rhead_ev.c\n+++ b/drivers/common/sfc_efx/base/rhead_ev.c\n@@ -58,6 +58,22 @@ rhead_ev_ew_qpoll(\n \t__inout\t\tunsigned int *countp,\n \t__in\t\tconst efx_ev_callbacks_t *eecp,\n \t__in_opt\tvoid *arg);\n+\n+#if EFSYS_OPT_DESC_PROXY\n+static\t\t\tboolean_t\n+rhead_ev_ew_txq_desc(\n+\t__in\t\tefx_evq_t *eep,\n+\t__in\t\tefx_xword_t *eventp,\n+\t__in\t\tconst efx_ev_callbacks_t *eecp,\n+\t__in_opt\tvoid *arg);\n+\n+static\t\t\tboolean_t\n+rhead_ev_ew_virtq_desc(\n+\t__in\t\tefx_evq_t *eep,\n+\t__in\t\tefx_xword_t *eventp,\n+\t__in\t\tconst efx_ev_callbacks_t *eecp,\n+\t__in_opt\tvoid *arg);\n+#endif /* EFSYS_OPT_DESC_PROXY */\n #endif /* EFSYS_OPT_EV_EXTENDED_WIDTH */\n \n \n@@ -115,6 +131,11 @@ rhead_ev_qcreate(\n \teep->ee_drv_gen\t= NULL; /* FIXME */\n \teep->ee_mcdi\t= rhead_ev_mcdi;\n \n+#if EFSYS_OPT_DESC_PROXY\n+\teep->ee_ew_txq_desc\t= rhead_ev_ew_txq_desc;\n+\teep->ee_ew_virtq_desc\t= rhead_ev_ew_virtq_desc;\n+#endif /* EFSYS_OPT_DESC_PROXY */\n+\n \t/* Set up the event queue */\n \t/* INIT_EVQ expects function-relative vector number */\n \tif ((flags & EFX_EVQ_FLAGS_NOTIFY_MASK) ==\n@@ -345,6 +366,16 @@ rhead_ev_ew_dispatch(\n \t\t rhead_ev_dispatch(eep, &eventp->ex_qword[0], eecp, arg);\n \t\tbreak;\n \n+#if EFSYS_OPT_DESC_PROXY\n+\tcase ESE_GZ_EF100_EVEW_TXQ_DESC:\n+\t\tshould_abort = eep->ee_ew_txq_desc(eep, eventp, eecp, arg);\n+\t\tbreak;\n+\n+\tcase ESE_GZ_EF100_EVEW_VIRTQ_DESC:\n+\t\tshould_abort = eep->ee_ew_virtq_desc(eep, eventp, eecp, arg);\n+\t\tbreak;\n+#endif /* EFSYS_OPT_DESC_PROXY */\n+\n \tdefault:\n \t\t/* Omit currently unused reserved bits from the probe. */\n \t\tEFSYS_PROBE7(ew_bad_event, unsigned int, eep->ee_index,\n@@ -589,4 +620,68 @@ rhead_ev_mcdi(\n \treturn (ret);\n }\n \n+#if EFSYS_OPT_DESC_PROXY\n+static\t\t\tboolean_t\n+rhead_ev_ew_txq_desc(\n+\t__in\t\tefx_evq_t *eep,\n+\t__in\t\tefx_xword_t *eventp,\n+\t__in\t\tconst efx_ev_callbacks_t *eecp,\n+\t__in_opt\tvoid *arg)\n+{\n+\tefx_oword_t txq_desc;\n+\tuint16_t vi_id;\n+\tboolean_t should_abort;\n+\n+\t_NOTE(ARGUNUSED(eep))\n+\n+\tvi_id = EFX_XWORD_FIELD(*eventp, ESF_GZ_EV_TXQ_DP_VI_ID);\n+\n+\t/*\n+\t * NOTE: This is the raw descriptor data, and has not been converted\n+\t * to host endian. The handler callback must use the EFX_OWORD macros\n+\t * to extract the descriptor fields as host endian values.\n+\t */\n+\ttxq_desc = eventp->ex_oword[0];\n+\n+\tEFSYS_ASSERT(eecp->eec_desc_proxy_txq_desc != NULL);\n+\tshould_abort = eecp->eec_desc_proxy_txq_desc(arg, vi_id, txq_desc);\n+\n+\treturn (should_abort);\n+}\n+#endif /* EFSYS_OPT_DESC_PROXY */\n+\n+\n+#if EFSYS_OPT_DESC_PROXY\n+static\t\t\tboolean_t\n+rhead_ev_ew_virtq_desc(\n+\t__in\t\tefx_evq_t *eep,\n+\t__in\t\tefx_xword_t *eventp,\n+\t__in\t\tconst efx_ev_callbacks_t *eecp,\n+\t__in_opt\tvoid *arg)\n+{\n+\tefx_oword_t virtq_desc;\n+\tuint16_t vi_id;\n+\tuint16_t avail;\n+\tboolean_t should_abort;\n+\n+\t_NOTE(ARGUNUSED(eep))\n+\n+\tvi_id = EFX_XWORD_FIELD(*eventp, ESF_GZ_EV_VQ_DP_VI_ID);\n+\tavail = EFX_XWORD_FIELD(*eventp, ESF_GZ_EV_VQ_DP_AVAIL_ENTRY);\n+\n+\t/*\n+\t * NOTE: This is the raw descriptor data, and has not been converted\n+\t * to host endian. The handler callback must use the EFX_OWORD macros\n+\t * to extract the descriptor fields as host endian values.\n+\t */\n+\tvirtq_desc = eventp->ex_oword[0];\n+\n+\tEFSYS_ASSERT(eecp->eec_desc_proxy_virtq_desc != NULL);\n+\tshould_abort =\n+\t eecp->eec_desc_proxy_virtq_desc(arg, vi_id, avail, virtq_desc);\n+\n+\treturn (should_abort);\n+}\n+#endif /* EFSYS_OPT_DESC_PROXY */\n+\n #endif\t/* EFSYS_OPT_RIVERHEAD */\n", "prefixes": [ "v3", "60/60" ] }