Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78720/?format=api
{ "id": 78720, "url": "https://patches.dpdk.org/api/patches/78720/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1600949555-28043-49-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1600949555-28043-49-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1600949555-28043-49-git-send-email-arybchenko@solarflare.com", "date": "2020-09-24T12:12:23", "name": "[v3,48/60] common/sfc_efx/base: introduce UDP tunnel destruct operation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0af1491dccfd49add78f02984999e2e7f3ce0184", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1600949555-28043-49-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 12473, "url": "https://patches.dpdk.org/api/series/12473/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12473", "date": "2020-09-24T12:11:40", "name": "common/sfc_efx: support Riverhead NIC family", "version": 3, "mbox": "https://patches.dpdk.org/series/12473/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/78720/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/78720/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F1810A04B1;\n\tThu, 24 Sep 2020 14:20:39 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 04E781DFEC;\n\tThu, 24 Sep 2020 14:14:04 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id BA57F1DE24\n for <dev@dpdk.org>; Thu, 24 Sep 2020 14:13:03 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.61])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n 4537D600CF for <dev@dpdk.org>; Thu, 24 Sep 2020 12:13:03 +0000 (UTC)", "from us4-mdac16-9.ut7.mdlocal (unknown [10.7.65.177])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 442A38009E\n for <dev@dpdk.org>; Thu, 24 Sep 2020 12:13:03 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.174])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id AA6A38005B\n for <dev@dpdk.org>; Thu, 24 Sep 2020 12:13:02 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 5E1651C0064\n for <dev@dpdk.org>; Thu, 24 Sep 2020 12:13:02 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Thu, 24 Sep 2020 13:12:48 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Thu, 24 Sep 2020 13:12:48 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 08OCCmHk026079;\n Thu, 24 Sep 2020 13:12:48 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 365F41613AB;\n Thu, 24 Sep 2020 13:12:48 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Igor Romanov <igor.romanov@oktetlabs.ru>", "Date": "Thu, 24 Sep 2020 13:12:23 +0100", "Message-ID": "<1600949555-28043-49-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1600949555-28043-1-git-send-email-arybchenko@solarflare.com>", "References": "<1600764594-14752-1-git-send-email-arybchenko@solarflare.com>\n <1600949555-28043-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25674.003", "X-TM-AS-Result": "No-3.537200-8.000000-10", "X-TMASE-MatchedRID": "4vsFl2z3FkpGpTGDN8pp+TXgRPG8Apuyjs/yyyVHGh5JfyfUaPjAASHV\n xv5WrG66lrzk0LlP1ZnQhrnrADRtjdIoDgSfXQ2wLbjXqdzdtCV6i696PjRPiI5JUK9UdYkniE3\n dRTeE2jN8bO6hWfRWzo9CL1e45ag4LgycURHhkaL/V0SDC1Do0O6jyigxCo6yVWQnHKxp38gVAs\n f1+cZFJzAD8UvGR6e8/xrkZhZF1M978ZKYQ4N2cjCMW7zNwFaIMI2NtA9qrmL5LkL/TyFZzVmwP\n Iu07EES4vM1YF6AJbbCCfuIMF6xLSdET58jp62SOeZ+57R+u9N0kgBr/ykW+ycICVBm2M0Ot/IO\n lWttHI8yxGY1FZcCJrU09TZYJSPaJrk7eB63FHRxojUlmYtAdn+hn1G/MV0hvU24pLfQFmdAgUh\n ku2yAbQNQf6dUs3KIKyog/1PG+0kxvqnnvSKWdw==", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--3.537200-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25674.003", "X-MDID": "1600949583-dCxJlMioQ16X", "Subject": "[dpdk-dev] [PATCH v3 48/60] common/sfc_efx/base: introduce UDP\n\ttunnel destruct operation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Igor Romanov <igor.romanov@oktetlabs.ru>\n\nThe procedures for destroying UDP tunnels are NIC family specific,\nso they should be implemented separately for each of them.\n\nCheck for supported UDP encapsulation is removed from generic\noperations since it is no longer used by the generic libefx API.\n\nSigned-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/common/sfc_efx/base/efx_impl.h | 2 +-\n drivers/common/sfc_efx/base/efx_tunnel.c | 39 +++++++++++++++---------\n 2 files changed, 26 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/common/sfc_efx/base/efx_impl.h b/drivers/common/sfc_efx/base/efx_impl.h\nindex dfe5f1fecf..64156de884 100644\n--- a/drivers/common/sfc_efx/base/efx_impl.h\n+++ b/drivers/common/sfc_efx/base/efx_impl.h\n@@ -303,8 +303,8 @@ efx_filter_reconfigure(\n \n #if EFSYS_OPT_TUNNEL\n typedef struct efx_tunnel_ops_s {\n-\tboolean_t\t(*eto_udp_encap_supported)(efx_nic_t *);\n \tefx_rc_t\t(*eto_reconfigure)(efx_nic_t *);\n+\tvoid\t\t(*eto_fini)(efx_nic_t *);\n } efx_tunnel_ops_t;\n #endif /* EFSYS_OPT_TUNNEL */\n \ndiff --git a/drivers/common/sfc_efx/base/efx_tunnel.c b/drivers/common/sfc_efx/base/efx_tunnel.c\nindex b1d1407bd2..5f2186c4c8 100644\n--- a/drivers/common/sfc_efx/base/efx_tunnel.c\n+++ b/drivers/common/sfc_efx/base/efx_tunnel.c\n@@ -12,8 +12,8 @@\n \n #if EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || EFSYS_OPT_RIVERHEAD\n static const efx_tunnel_ops_t\t__efx_tunnel_dummy_ops = {\n-\tNULL,\t/* eto_udp_encap_supported */\n \tNULL,\t/* eto_reconfigure */\n+\tNULL,\t/* eto_fini */\n };\n #endif /* EFSYS_OPT_SIENA || EFSYS_OPT_HUNTINGTON || EFSYS_OPT_RIVERHEAD */\n \n@@ -26,9 +26,13 @@ static\t__checkReturn\tefx_rc_t\n ef10_tunnel_reconfigure(\n \t__in\t\tefx_nic_t *enp);\n \n+static\t\t\tvoid\n+ef10_tunnel_fini(\n+\t__in\t\tefx_nic_t *enp);\n+\n static const efx_tunnel_ops_t\t__efx_tunnel_ef10_ops = {\n-\tef10_udp_encap_supported,\t/* eto_udp_encap_supported */\n \tef10_tunnel_reconfigure,\t/* eto_reconfigure */\n+\tef10_tunnel_fini,\t\t/* eto_fini */\n };\n #endif /* EFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2 */\n \n@@ -204,22 +208,12 @@ efx_tunnel_init(\n efx_tunnel_fini(\n \t__in\t\tefx_nic_t *enp)\n {\n-\tboolean_t resetting;\n-\n \tEFSYS_ASSERT3U(enp->en_magic, ==, EFX_NIC_MAGIC);\n \tEFSYS_ASSERT3U(enp->en_mod_flags, &, EFX_MOD_PROBE);\n \tEFSYS_ASSERT3U(enp->en_mod_flags, &, EFX_MOD_TUNNEL);\n \n-\tif ((enp->en_etop->eto_udp_encap_supported != NULL) &&\n-\t enp->en_etop->eto_udp_encap_supported(enp)) {\n-\t\t/*\n-\t\t * The UNLOADING flag allows the MC to suppress the datapath\n-\t\t * reset if it was set on the last call to\n-\t\t * MC_CMD_SET_TUNNEL_ENCAP_UDP_PORTS by all functions\n-\t\t */\n-\t\t(void) efx_mcdi_set_tunnel_encap_udp_ports(enp, NULL, B_TRUE,\n-\t\t &resetting);\n-\t}\n+\tif (enp->en_etop->eto_fini != NULL)\n+\t\tenp->en_etop->eto_fini(enp);\n \n \tenp->en_etop = NULL;\n \tenp->en_mod_flags &= ~EFX_MOD_TUNNEL;\n@@ -476,6 +470,23 @@ ef10_tunnel_reconfigure(\n \n \treturn (rc);\n }\n+\n+static\t\t\tvoid\n+ef10_tunnel_fini(\n+\t__in\t\tefx_nic_t *enp)\n+{\n+\tboolean_t resetting;\n+\n+\tif (ef10_udp_encap_supported(enp) != B_FALSE) {\n+\t\t/*\n+\t\t * The UNLOADING flag allows the MC to suppress the datapath\n+\t\t * reset if it was set on the last call to\n+\t\t * MC_CMD_SET_TUNNEL_ENCAP_UDP_PORTS by all functions\n+\t\t */\n+\t\t(void) efx_mcdi_set_tunnel_encap_udp_ports(enp, NULL, B_TRUE,\n+\t\t &resetting);\n+\t}\n+}\n #endif /* EFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2 */\n \n #endif /* EFSYS_OPT_TUNNEL */\n", "prefixes": [ "v3", "48/60" ] }