Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78703/?format=api
{ "id": 78703, "url": "https://patches.dpdk.org/api/patches/78703/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1600949555-28043-37-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1600949555-28043-37-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1600949555-28043-37-git-send-email-arybchenko@solarflare.com", "date": "2020-09-24T12:12:11", "name": "[v3,36/60] common/sfc_efx/base: handle Tx complete on Riverhead", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "06841aa16626a1388b53372c5f11340de23708a3", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1600949555-28043-37-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 12473, "url": "https://patches.dpdk.org/api/series/12473/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12473", "date": "2020-09-24T12:11:40", "name": "common/sfc_efx: support Riverhead NIC family", "version": 3, "mbox": "https://patches.dpdk.org/series/12473/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/78703/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/78703/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C1BD4A04B5;\n\tThu, 24 Sep 2020 14:17:33 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 09DC11DEA9;\n\tThu, 24 Sep 2020 14:13:44 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 1E0BB1DE0D\n for <dev@dpdk.org>; Thu, 24 Sep 2020 14:12:59 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.60])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n E10F36008C for <dev@dpdk.org>; Thu, 24 Sep 2020 12:12:58 +0000 (UTC)", "from us4-mdac16-27.ut7.mdlocal (unknown [10.7.66.59])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id DF5A52009A\n for <dev@dpdk.org>; Thu, 24 Sep 2020 12:12:58 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.174])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 3BFEB1C0055\n for <dev@dpdk.org>; Thu, 24 Sep 2020 12:12:58 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n E62241C0064\n for <dev@dpdk.org>; Thu, 24 Sep 2020 12:12:57 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Thu, 24 Sep 2020 13:12:47 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Thu, 24 Sep 2020 13:12:47 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 08OCCl6s026019\n for <dev@dpdk.org>; Thu, 24 Sep 2020 13:12:47 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 9024E1613AB\n for <dev@dpdk.org>; Thu, 24 Sep 2020 13:12:47 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Thu, 24 Sep 2020 13:12:11 +0100", "Message-ID": "<1600949555-28043-37-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1600949555-28043-1-git-send-email-arybchenko@solarflare.com>", "References": "<1600764594-14752-1-git-send-email-arybchenko@solarflare.com>\n <1600949555-28043-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25674.003", "X-TM-AS-Result": "No-4.178900-8.000000-10", "X-TMASE-MatchedRID": "UKVvtpGOi8W3CKSZlTKFT2I5Hlv2xZ2jH6pHzc00RUrwJYZa/L83HX7L\n cZObGgN9rW702S6GBavZJDu+P9KrgkWSfdP0PEqZIf0TE1VduNsxXH/dlhvLv3CR0itW3xfVsoG\n mWO8qx8739CfzL6vbjTtuVglUWXzvLgycURHhkaJH+PTjR9EWkrp0somlfE2zSg8ufp5n3T6Gon\n GL0jN7MlfdYI1jtiJOBukl+sGSmY0aeqxnyxGvYiDSF4zvwLoK3YSaHlnZL83g9GtYPBPdS34Ed\n iDLAdil2TtEMkKrch6udxrwMMiYnjhWRwsgQQIYDDlsUbcsIPqX3dHCCeCwWqT6hbegvOYeF5ZR\n TdcETVTi8zVgXoAltsIJ+4gwXrEtWBd6ltyXuvu/UKGDnvcK/oPr2VzhM7VzWTkGlwyTI1D1SJp\n i6psc589AaePk3y0oY4vYWPZaUQiiTdT63+4p54062rT0ejAJiReo5MZwWP+qFrt9xUgp+uq+T0\n IcdvQ1BtPt5WQTZkLauEQaIW46Kz1vpbjBE8IeftwZ3X11IV0=", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--4.178900-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25674.003", "X-MDID": "1600949578-PKZyF_kD6gre", "Subject": "[dpdk-dev] [PATCH v3 36/60] common/sfc_efx/base: handle Tx complete\n\ton Riverhead", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Introduce a new event callback which has the same prototype, but\nprovides number of completed descriptors instead of the last\ncompleted descriptor index.\n\nWhen all libefx-based drivers implement the new callback, libefx\nmay be updated to use it for Siena and EF10 family NICs and\nthe old one may be removed.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/common/sfc_efx/base/efx.h | 7 ++++\n drivers/common/sfc_efx/base/rhead_ev.c | 51 +++++++++++++++++++++++++-\n 2 files changed, 57 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/common/sfc_efx/base/efx.h b/drivers/common/sfc_efx/base/efx.h\nindex 983b723145..2437980c9e 100644\n--- a/drivers/common/sfc_efx/base/efx.h\n+++ b/drivers/common/sfc_efx/base/efx.h\n@@ -2319,6 +2319,12 @@ typedef\t__checkReturn\tboolean_t\n \t__in\t\tuint32_t label,\n \t__in\t\tuint32_t id);\n \n+typedef\t__checkReturn\tboolean_t\n+(*efx_tx_ndescs_ev_t)(\n+\t__in_opt\tvoid *arg,\n+\t__in\t\tuint32_t label,\n+\t__in\t\tunsigned int ndescs);\n+\n #define\tEFX_EXCEPTION_RX_RECOVERY\t0x00000001\n #define\tEFX_EXCEPTION_RX_DSC_ERROR\t0x00000002\n #define\tEFX_EXCEPTION_TX_DSC_ERROR\t0x00000003\n@@ -2406,6 +2412,7 @@ typedef struct efx_ev_callbacks_s {\n \tefx_rx_ps_ev_t\t\t\teec_rx_ps;\n #endif\n \tefx_tx_ev_t\t\t\teec_tx;\n+\tefx_tx_ndescs_ev_t\t\teec_tx_ndescs;\n \tefx_exception_ev_t\t\teec_exception;\n \tefx_rxq_flush_done_ev_t\t\teec_rxq_flush_done;\n \tefx_rxq_flush_failed_ev_t\teec_rxq_flush_failed;\ndiff --git a/drivers/common/sfc_efx/base/rhead_ev.c b/drivers/common/sfc_efx/base/rhead_ev.c\nindex 44a79e2e5d..380729d174 100644\n--- a/drivers/common/sfc_efx/base/rhead_ev.c\n+++ b/drivers/common/sfc_efx/base/rhead_ev.c\n@@ -23,6 +23,13 @@ rhead_ev_rx_packets(\n \t__in\t\tconst efx_ev_callbacks_t *eecp,\n \t__in_opt\tvoid *arg);\n \n+static\t__checkReturn\tboolean_t\n+rhead_ev_tx_completion(\n+\t__in\t\tefx_evq_t *eep,\n+\t__in\t\tefx_qword_t *eqp,\n+\t__in\t\tconst efx_ev_callbacks_t *eecp,\n+\t__in_opt\tvoid *arg);\n+\n \n static\t__checkReturn\tboolean_t\n rhead_ev_mcdi(\n@@ -66,7 +73,7 @@ rhead_ev_qcreate(\n \n \t/* Set up the handler table */\n \teep->ee_rx\t= rhead_ev_rx_packets;\n-\teep->ee_tx\t= NULL; /* FIXME */\n+\teep->ee_tx\t= rhead_ev_tx_completion;\n \teep->ee_driver\t= NULL; /* FIXME */\n \teep->ee_drv_gen\t= NULL; /* FIXME */\n \teep->ee_mcdi\t= rhead_ev_mcdi;\n@@ -212,6 +219,10 @@ rhead_ev_qpoll(\n \t\t\t\tshould_abort = eep->ee_rx(eep,\n \t\t\t\t &(ev[index]), eecp, arg);\n \t\t\t\tbreak;\n+\t\t\tcase ESE_GZ_EF100_EV_TX_COMPLETION:\n+\t\t\t\tshould_abort = eep->ee_tx(eep,\n+\t\t\t\t &(ev[index]), eecp, arg);\n+\t\t\t\tbreak;\n \t\t\tcase ESE_GZ_EF100_EV_MCDI:\n \t\t\t\tshould_abort = eep->ee_mcdi(eep,\n \t\t\t\t &(ev[index]), eecp, arg);\n@@ -328,6 +339,44 @@ rhead_ev_rx_packets(\n \treturn (should_abort);\n }\n \n+static\t__checkReturn\tboolean_t\n+rhead_ev_tx_completion(\n+\t__in\t\tefx_evq_t *eep,\n+\t__in\t\tefx_qword_t *eqp,\n+\t__in\t\tconst efx_ev_callbacks_t *eecp,\n+\t__in_opt\tvoid *arg)\n+{\n+\tefx_nic_t *enp = eep->ee_enp;\n+\tuint32_t num_descs;\n+\tuint32_t label;\n+\tboolean_t should_abort;\n+\n+\tEFX_EV_QSTAT_INCR(eep, EV_TX);\n+\n+\t/* Discard events after RXQ/TXQ errors, or hardware not available */\n+\tif (enp->en_reset_flags &\n+\t (EFX_RESET_RXQ_ERR | EFX_RESET_TXQ_ERR | EFX_RESET_HW_UNAVAIL))\n+\t\treturn (B_FALSE);\n+\n+\tlabel = EFX_QWORD_FIELD(*eqp, ESF_GZ_EV_TXCMPL_Q_LABEL);\n+\n+\t/*\n+\t * On EF100 the EV_TX event reports the number of completed Tx\n+\t * descriptors (on EF10, the event reports the low bits of the\n+\t * index of the last completed descriptor).\n+\t * The client driver completion callback will compute the\n+\t * descriptor index, so that is not needed here.\n+\t */\n+\tnum_descs = EFX_QWORD_FIELD(*eqp, ESF_GZ_EV_TXCMPL_NUM_DESC);\n+\n+\tEFSYS_PROBE2(tx_ndescs, uint32_t, label, unsigned int, num_descs);\n+\n+\tEFSYS_ASSERT(eecp->eec_tx_ndescs != NULL);\n+\tshould_abort = eecp->eec_tx_ndescs(arg, label, num_descs);\n+\n+\treturn (should_abort);\n+}\n+\n static\t__checkReturn\tboolean_t\n rhead_ev_mcdi(\n \t__in\t\tefx_evq_t *eep,\n", "prefixes": [ "v3", "36/60" ] }