Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78702/?format=api
{ "id": 78702, "url": "https://patches.dpdk.org/api/patches/78702/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1600949555-28043-26-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1600949555-28043-26-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1600949555-28043-26-git-send-email-arybchenko@solarflare.com", "date": "2020-09-24T12:12:00", "name": "[v3,25/60] common/sfc_efx/base: handle MCDI events on Riverhead", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4cabbde70fdcf819c0a5d348df9d0616c41ec69d", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1600949555-28043-26-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 12473, "url": "https://patches.dpdk.org/api/series/12473/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12473", "date": "2020-09-24T12:11:40", "name": "common/sfc_efx: support Riverhead NIC family", "version": 3, "mbox": "https://patches.dpdk.org/series/12473/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/78702/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/78702/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BD32AA04B1;\n\tThu, 24 Sep 2020 14:17:23 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D4B471DE25;\n\tThu, 24 Sep 2020 14:13:42 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 9E1471DE19\n for <dev@dpdk.org>; Thu, 24 Sep 2020 14:12:58 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.60])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n 6B41B600AC for <dev@dpdk.org>; Thu, 24 Sep 2020 12:12:58 +0000 (UTC)", "from us4-mdac16-71.ut7.mdlocal (unknown [10.7.64.190])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 69BC32009A\n for <dev@dpdk.org>; Thu, 24 Sep 2020 12:12:58 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.174])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n D07051C0052\n for <dev@dpdk.org>; Thu, 24 Sep 2020 12:12:57 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 868251C0064\n for <dev@dpdk.org>; Thu, 24 Sep 2020 12:12:57 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Thu, 24 Sep 2020 13:12:47 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Thu, 24 Sep 2020 13:12:47 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 08OCCl6H025967\n for <dev@dpdk.org>; Thu, 24 Sep 2020 13:12:47 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 032261613A9\n for <dev@dpdk.org>; Thu, 24 Sep 2020 13:12:47 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Thu, 24 Sep 2020 13:12:00 +0100", "Message-ID": "<1600949555-28043-26-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1600949555-28043-1-git-send-email-arybchenko@solarflare.com>", "References": "<1600764594-14752-1-git-send-email-arybchenko@solarflare.com>\n <1600949555-28043-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25674.003", "X-TM-AS-Result": "No-8.800500-8.000000-10", "X-TMASE-MatchedRID": "AVQ9v9IjTRVf4BpTN+neE7BZAi3nrnzbaeMaKzvXUpljLp8Cm8vwF7KB\n pljvKsfOfGzuoVn0Vs6PQi9XuOWoOC4MnFER4ZGiGjzBgnFZvQ5Wva+n/kCpr5GPHiE2kiT4sFm\n zNLPWp6JK9ns3X9uF5v1RnTJXuwcgiA9C6oekWISEsxw9kf3dvEpFpc3bJiMe27KSseGDg91JzE\n eCSYAQ+va+1VWhPfX7S/i41cQ7DTPvshHUAhiu675k9lVEXoZafS0Ip2eEHnz3IzXlXlpamPoLR\n 4+zsDTtw38dXReMtXe5orEYxUJD/ZLqTqUSl0NHYWfcTB2t7wI3wwcosd/AClZca9RSYo/b", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--8.800500-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25674.003", "X-MDID": "1600949578-a0DmGn5ARFOU", "Subject": "[dpdk-dev] [PATCH v3 25/60] common/sfc_efx/base: handle MCDI events\n\ton Riverhead", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "EF100 MCDI event layout is same as on EF10 except added QDMA phase\nbit which is unused on EF10.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/common/sfc_efx/base/ef10_ev.c | 17 +++++++------\n drivers/common/sfc_efx/base/ef10_impl.h | 8 ++++++\n drivers/common/sfc_efx/base/rhead_ev.c | 33 ++++++++++++++++++++++++-\n 3 files changed, 49 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/common/sfc_efx/base/ef10_ev.c b/drivers/common/sfc_efx/base/ef10_ev.c\nindex e2b5c62d5d..aec1c468a4 100644\n--- a/drivers/common/sfc_efx/base/ef10_ev.c\n+++ b/drivers/common/sfc_efx/base/ef10_ev.c\n@@ -47,13 +47,6 @@ ef10_ev_drv_gen(\n \t__in\t\tconst efx_ev_callbacks_t *eecp,\n \t__in_opt\tvoid *arg);\n \n-static\t__checkReturn\tboolean_t\n-ef10_ev_mcdi(\n-\t__in\t\tefx_evq_t *eep,\n-\t__in\t\tefx_qword_t *eqp,\n-\t__in\t\tconst efx_ev_callbacks_t *eecp,\n-\t__in_opt\tvoid *arg);\n-\n \n static\t__checkReturn\tefx_rc_t\n efx_mcdi_set_evq_tmr(\n@@ -857,7 +850,11 @@ ef10_ev_drv_gen(\n \treturn (should_abort);\n }\n \n-static\t__checkReturn\tboolean_t\n+#endif\t/* EFX_OPTS_EF10() */\n+\n+#if EFSYS_OPT_RIVERHEAD || EFX_OPTS_EF10()\n+\n+\t__checkReturn\tboolean_t\n ef10_ev_mcdi(\n \t__in\t\tefx_evq_t *eep,\n \t__in\t\tefx_qword_t *eqp,\n@@ -1064,6 +1061,10 @@ ef10_ev_mcdi(\n \treturn (should_abort);\n }\n \n+#endif\t/* EFSYS_OPT_RIVERHEAD || EFX_OPTS_EF10() */\n+\n+#if EFX_OPTS_EF10()\n+\n \t\tvoid\n ef10_ev_rxlabel_init(\n \t__in\t\tefx_evq_t *eep,\ndiff --git a/drivers/common/sfc_efx/base/ef10_impl.h b/drivers/common/sfc_efx/base/ef10_impl.h\nindex e933d88135..e77fb4ddea 100644\n--- a/drivers/common/sfc_efx/base/ef10_impl.h\n+++ b/drivers/common/sfc_efx/base/ef10_impl.h\n@@ -158,6 +158,14 @@ ef10_ev_rxlabel_fini(\n \t__in\t\tefx_evq_t *eep,\n \t__in\t\tunsigned int label);\n \n+LIBEFX_INTERNAL\n+extern\t__checkReturn\tboolean_t\n+ef10_ev_mcdi(\n+\t__in\t\tefx_evq_t *eep,\n+\t__in\t\tefx_qword_t *eqp,\n+\t__in\t\tconst efx_ev_callbacks_t *eecp,\n+\t__in_opt\tvoid *arg);\n+\n /* INTR */\n \n LIBEFX_INTERNAL\ndiff --git a/drivers/common/sfc_efx/base/rhead_ev.c b/drivers/common/sfc_efx/base/rhead_ev.c\nindex 36e355f209..6113cc9cf3 100644\n--- a/drivers/common/sfc_efx/base/rhead_ev.c\n+++ b/drivers/common/sfc_efx/base/rhead_ev.c\n@@ -17,6 +17,14 @@\n #define\tEFX_RHEAD_ALWAYS_INTERRUPTING_EVQ_INDEX\t(0)\n \n \n+static\t__checkReturn\tboolean_t\n+rhead_ev_mcdi(\n+\t__in\t\tefx_evq_t *eep,\n+\t__in\t\tefx_qword_t *eqp,\n+\t__in\t\tconst efx_ev_callbacks_t *eecp,\n+\t__in_opt\tvoid *arg);\n+\n+\n \t__checkReturn\tefx_rc_t\n rhead_ev_init(\n \t__in\t\tefx_nic_t *enp)\n@@ -54,7 +62,7 @@ rhead_ev_qcreate(\n \teep->ee_tx\t= NULL; /* FIXME */\n \teep->ee_driver\t= NULL; /* FIXME */\n \teep->ee_drv_gen\t= NULL; /* FIXME */\n-\teep->ee_mcdi\t= NULL; /* FIXME */\n+\teep->ee_mcdi\t= rhead_ev_mcdi;\n \n \t/* Set up the event queue */\n \t/* INIT_EVQ expects function-relative vector number */\n@@ -193,6 +201,10 @@ rhead_ev_qpoll(\n \n \t\t\tcode = EFX_QWORD_FIELD(ev[index], ESF_GZ_E_TYPE);\n \t\t\tswitch (code) {\n+\t\t\tcase ESE_GZ_EF100_EV_MCDI:\n+\t\t\t\tshould_abort = eep->ee_mcdi(eep,\n+\t\t\t\t &(ev[index]), eecp, arg);\n+\t\t\t\tbreak;\n \t\t\tdefault:\n \t\t\t\tEFSYS_PROBE3(bad_event,\n \t\t\t\t unsigned int, eep->ee_index,\n@@ -262,4 +274,23 @@ rhead_ev_qstats_update(\n }\n #endif /* EFSYS_OPT_QSTATS */\n \n+static\t__checkReturn\tboolean_t\n+rhead_ev_mcdi(\n+\t__in\t\tefx_evq_t *eep,\n+\t__in\t\tefx_qword_t *eqp,\n+\t__in\t\tconst efx_ev_callbacks_t *eecp,\n+\t__in_opt\tvoid *arg)\n+{\n+\tboolean_t ret;\n+\n+\t/*\n+\t * Event format was changed post Riverhead R1 and now\n+\t * MCDI event layout on EF100 is exactly the same as on EF10\n+\t * except added QDMA phase bit which is unused on EF10.\n+\t */\n+\tret = ef10_ev_mcdi(eep, eqp, eecp, arg);\n+\n+\treturn (ret);\n+}\n+\n #endif\t/* EFSYS_OPT_RIVERHEAD */\n", "prefixes": [ "v3", "25/60" ] }