Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78696/?format=api
https://patches.dpdk.org/api/patches/78696/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1600949555-28043-17-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1600949555-28043-17-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1600949555-28043-17-git-send-email-arybchenko@solarflare.com", "date": "2020-09-24T12:11:51", "name": "[v3,16/60] common/sfc_efx/base: use EF10 filter methods for Riverhead", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "452ce43425827b4b981c45b44762c0009d388a16", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1600949555-28043-17-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 12473, "url": "https://patches.dpdk.org/api/series/12473/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12473", "date": "2020-09-24T12:11:40", "name": "common/sfc_efx: support Riverhead NIC family", "version": 3, "mbox": "https://patches.dpdk.org/series/12473/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/78696/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/78696/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EA3A8A04B1;\n\tThu, 24 Sep 2020 14:16:13 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DFCC71DE89;\n\tThu, 24 Sep 2020 14:13:34 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 3D8571DE16\n for <dev@dpdk.org>; Thu, 24 Sep 2020 14:12:57 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.62])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n BE08E600AB for <dev@dpdk.org>; Thu, 24 Sep 2020 12:12:56 +0000 (UTC)", "from us4-mdac16-5.ut7.mdlocal (unknown [10.7.65.73])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id BB1D38009B\n for <dev@dpdk.org>; Thu, 24 Sep 2020 12:12:56 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.174])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 4574B280050\n for <dev@dpdk.org>; Thu, 24 Sep 2020 12:12:56 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n F018B1C007F\n for <dev@dpdk.org>; Thu, 24 Sep 2020 12:12:55 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Thu, 24 Sep 2020 13:12:46 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Thu, 24 Sep 2020 13:12:46 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 08OCCk5k025921\n for <dev@dpdk.org>; Thu, 24 Sep 2020 13:12:46 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 848C91613AB\n for <dev@dpdk.org>; Thu, 24 Sep 2020 13:12:46 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Thu, 24 Sep 2020 13:11:51 +0100", "Message-ID": "<1600949555-28043-17-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1600949555-28043-1-git-send-email-arybchenko@solarflare.com>", "References": "<1600764594-14752-1-git-send-email-arybchenko@solarflare.com>\n <1600949555-28043-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25674.003", "X-TM-AS-Result": "No-4.173700-8.000000-10", "X-TMASE-MatchedRID": "Ou944MYOkXrabBVcqlDcF2wTEruL9ObTP6Tki+9nU38HZBaLwEXlKIpb\n wG9fIuIT1p2ymPHEye/1bPzaj6HcXeel5KJlNpuVD3uYMxd01be6hgVvSdGKo/dx761qtyVer9Y\n /9i+8T9ZT/JXxfFyJkZ+0zpV1PUWjXXhMBXemG5QqsMfMfrOZRedppbZRNp/IdBaEtWosUzVFEs\n yDmZUQjM5IuBJ6+KfEuewO5rBHdH4fE8yM4pjsDwtuKBGekqUpm+MB6kaZ2g5JbWVADY7tVIA2n\n N7VSxAMatTNT3F/RFIgMOkfe7hRSgUzdQSSYby8E+xo/YJuXWdN2up9o9CxplwMgif9irfDswOP\n o08YeE0vOSq+nxEQtagePGmIEwXO/4UC4n7D3uWJl6tigvYfLwvFyo7FWyY1", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--4.173700-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25674.003", "X-MDID": "1600949576-I60Ko9BCyfOn", "Subject": "[dpdk-dev] [PATCH v3 16/60] common/sfc_efx/base: use EF10 filter\n\tmethods for Riverhead", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Filtering MCDI on Riverhead are the same as on EF10.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\nReviewed-by: Vijay Kumar Srivastava <vsrivast@xilinx.com>\n---\n drivers/common/sfc_efx/base/ef10_filter.c | 14 +++++++-------\n drivers/common/sfc_efx/base/efx_filter.c | 18 ++++++++++++++++++\n drivers/common/sfc_efx/base/efx_impl.h | 4 ++--\n 3 files changed, 27 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/common/sfc_efx/base/ef10_filter.c b/drivers/common/sfc_efx/base/ef10_filter.c\nindex 12c84a5640..51e6f1a210 100644\n--- a/drivers/common/sfc_efx/base/ef10_filter.c\n+++ b/drivers/common/sfc_efx/base/ef10_filter.c\n@@ -7,7 +7,7 @@\n #include \"efx.h\"\n #include \"efx_impl.h\"\n \n-#if EFX_OPTS_EF10()\n+#if EFSYS_OPT_RIVERHEAD || EFX_OPTS_EF10()\n \n #if EFSYS_OPT_FILTER\n \n@@ -94,7 +94,7 @@ ef10_filter_init(\n \tefx_rc_t rc;\n \tef10_filter_table_t *eftp;\n \n-\tEFSYS_ASSERT(EFX_FAMILY_IS_EF10(enp));\n+\tEFSYS_ASSERT(EFX_FAMILY_IS_EF100(enp) || EFX_FAMILY_IS_EF10(enp));\n \n #define\tMATCH_MASK(match) (EFX_MASK32(match) << EFX_LOW_BIT(match))\n \tEFX_STATIC_ASSERT(EFX_FILTER_MATCH_REM_HOST ==\n@@ -152,7 +152,7 @@ ef10_filter_init(\n ef10_filter_fini(\n \t__in\t\tefx_nic_t *enp)\n {\n-\tEFSYS_ASSERT(EFX_FAMILY_IS_EF10(enp));\n+\tEFSYS_ASSERT(EFX_FAMILY_IS_EF100(enp) || EFX_FAMILY_IS_EF10(enp));\n \n \tif (enp->en_filter.ef_ef10_filter_table != NULL) {\n \t\tEFSYS_KMEM_FREE(enp->en_esip, sizeof (ef10_filter_table_t),\n@@ -540,7 +540,7 @@ ef10_filter_restore(\n \tefsys_lock_state_t state;\n \tefx_rc_t rc;\n \n-\tEFSYS_ASSERT(EFX_FAMILY_IS_EF10(enp));\n+\tEFSYS_ASSERT(EFX_FAMILY_IS_EF100(enp) || EFX_FAMILY_IS_EF10(enp));\n \n \tfor (tbl_id = 0; tbl_id < EFX_EF10_FILTER_TBL_ROWS; tbl_id++) {\n \n@@ -839,7 +839,7 @@ ef10_filter_add_internal(\n \tefsys_lock_state_t state;\n \tboolean_t locked = B_FALSE;\n \n-\tEFSYS_ASSERT(EFX_FAMILY_IS_EF10(enp));\n+\tEFSYS_ASSERT(EFX_FAMILY_IS_EF100(enp) || EFX_FAMILY_IS_EF10(enp));\n \n \tEFSYS_ASSERT(spec->efs_overridden_spec == NULL);\n \n@@ -1149,7 +1149,7 @@ ef10_filter_delete(\n \tefsys_lock_state_t state;\n \tboolean_t locked = B_FALSE;\n \n-\tEFSYS_ASSERT(EFX_FAMILY_IS_EF10(enp));\n+\tEFSYS_ASSERT(EFX_FAMILY_IS_EF100(enp) || EFX_FAMILY_IS_EF10(enp));\n \n \thash = ef10_filter_hash(spec);\n \n@@ -2138,4 +2138,4 @@ ef10_filter_default_rxq_clear(\n \n #endif /* EFSYS_OPT_FILTER */\n \n-#endif /* EFX_OPTS_EF10() */\n+#endif /* EFSYS_OPT_RIVERHEAD || EFX_OPTS_EF10() */\ndiff --git a/drivers/common/sfc_efx/base/efx_filter.c b/drivers/common/sfc_efx/base/efx_filter.c\nindex 3310b738e2..9b4cd08bb8 100644\n--- a/drivers/common/sfc_efx/base/efx_filter.c\n+++ b/drivers/common/sfc_efx/base/efx_filter.c\n@@ -68,6 +68,18 @@ static const efx_filter_ops_t\t__efx_filter_ef10_ops = {\n };\n #endif /* EFX_OPTS_EF10() */\n \n+#if EFSYS_OPT_RIVERHEAD\n+static const efx_filter_ops_t\t__efx_filter_rhead_ops = {\n+\tef10_filter_init,\t\t/* efo_init */\n+\tef10_filter_fini,\t\t/* efo_fini */\n+\tef10_filter_restore,\t\t/* efo_restore */\n+\tef10_filter_add,\t\t/* efo_add */\n+\tef10_filter_delete,\t\t/* efo_delete */\n+\tef10_filter_supported_filters,\t/* efo_supported_filters */\n+\tef10_filter_reconfigure,\t/* efo_reconfigure */\n+};\n+#endif /* EFSYS_OPT_RIVERHEAD */\n+\n \t__checkReturn\tefx_rc_t\n efx_filter_insert(\n \t__in\t\tefx_nic_t *enp,\n@@ -180,6 +192,12 @@ efx_filter_init(\n \t\tbreak;\n #endif /* EFSYS_OPT_MEDFORD2 */\n \n+#if EFSYS_OPT_RIVERHEAD\n+\tcase EFX_FAMILY_RIVERHEAD:\n+\t\tefop = &__efx_filter_rhead_ops;\n+\t\tbreak;\n+#endif /* EFSYS_OPT_RIVERHEAD */\n+\n \tdefault:\n \t\tEFSYS_ASSERT(0);\n \t\trc = ENOTSUP;\ndiff --git a/drivers/common/sfc_efx/base/efx_impl.h b/drivers/common/sfc_efx/base/efx_impl.h\nindex b41b0e5dea..cc34a05f95 100644\n--- a/drivers/common/sfc_efx/base/efx_impl.h\n+++ b/drivers/common/sfc_efx/base/efx_impl.h\n@@ -465,9 +465,9 @@ typedef struct efx_filter_s {\n #if EFSYS_OPT_SIENA\n \tsiena_filter_t\t\t*ef_siena_filter;\n #endif /* EFSYS_OPT_SIENA */\n-#if EFX_OPTS_EF10()\n+#if EFSYS_OPT_RIVERHEAD || EFX_OPTS_EF10()\n \tef10_filter_table_t\t*ef_ef10_filter_table;\n-#endif /* EFX_OPTS_EF10() */\n+#endif /* EFSYS_OPT_RIVERHEAD || EFX_OPTS_EF10() */\n } efx_filter_t;\n \n #if EFSYS_OPT_SIENA\n", "prefixes": [ "v3", "16/60" ] }{ "id": 78696, "url": "