Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78693/?format=api
{ "id": 78693, "url": "https://patches.dpdk.org/api/patches/78693/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1600949555-28043-14-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1600949555-28043-14-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1600949555-28043-14-git-send-email-arybchenko@solarflare.com", "date": "2020-09-24T12:11:48", "name": "[v3,13/60] common/sfc_efx/base: factor out MCDI entity reset helper", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a4ad3920fa37779ab428d78c052bba2730774384", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1600949555-28043-14-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 12473, "url": "https://patches.dpdk.org/api/series/12473/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12473", "date": "2020-09-24T12:11:40", "name": "common/sfc_efx: support Riverhead NIC family", "version": 3, "mbox": "https://patches.dpdk.org/series/12473/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/78693/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/78693/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0112AA04B5;\n\tThu, 24 Sep 2020 14:15:37 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DDF881DE74;\n\tThu, 24 Sep 2020 14:13:30 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id DEEF51DE0D\n for <dev@dpdk.org>; Thu, 24 Sep 2020 14:12:56 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.64])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n 697F360056 for <dev@dpdk.org>; Thu, 24 Sep 2020 12:12:56 +0000 (UTC)", "from us4-mdac16-14.ut7.mdlocal (unknown [10.7.65.238])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 685552009B\n for <dev@dpdk.org>; Thu, 24 Sep 2020 12:12:56 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.175])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n E8C6122004D\n for <dev@dpdk.org>; Thu, 24 Sep 2020 12:12:55 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n A06E6700079\n for <dev@dpdk.org>; Thu, 24 Sep 2020 12:12:55 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Thu, 24 Sep 2020 13:12:46 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Thu, 24 Sep 2020 13:12:46 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 08OCCkSX025906\n for <dev@dpdk.org>; Thu, 24 Sep 2020 13:12:46 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 5E3D01613A9\n for <dev@dpdk.org>; Thu, 24 Sep 2020 13:12:46 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Thu, 24 Sep 2020 13:11:48 +0100", "Message-ID": "<1600949555-28043-14-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1600949555-28043-1-git-send-email-arybchenko@solarflare.com>", "References": "<1600764594-14752-1-git-send-email-arybchenko@solarflare.com>\n <1600949555-28043-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25674.003", "X-TM-AS-Result": "No-3.030100-8.000000-10", "X-TMASE-MatchedRID": "vYGa0+7iE6DabBVcqlDcF2wTEruL9ObTS1zwNuiBtITfUZT83lbkEKq9\n 0Gjn1y69rjxIGTs1wDBelHLO9H8oHK2IX6n70FjpMIxbvM3AVojdXhRKGhNdp//rgj9ncWz98jt\n NzZMEHRNbdScq6YVMbtpjYdI8mvH+HxPMjOKY7A8LbigRnpKlKZvjAepGmdoOsdQxcazehh/TUu\n e+deTgrY2BL4iuOHdl6WvlrBe68vfMYJRW801xUrajsXieXSINEpx4NrD0J/kCKhzOMf/KvmmPr\n C9+i3ndLzkqvp8RELWoHjxpiBMFzv+FAuJ+w97liZerYoL2Hy8LxcqOxVsmNQ==", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--3.030100-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25674.003", "X-MDID": "1600949576-Q_rOpyZurJYK", "Subject": "[dpdk-dev] [PATCH v3 13/60] common/sfc_efx/base: factor out MCDI\n\tentity reset helper", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The helper will be reused on Riverhead.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/common/sfc_efx/base/ef10_nic.c | 51 +++++++++++++++++---------\n 1 file changed, 34 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/common/sfc_efx/base/ef10_nic.c b/drivers/common/sfc_efx/base/ef10_nic.c\nindex 4796dd6b59..c5990f16cc 100644\n--- a/drivers/common/sfc_efx/base/ef10_nic.c\n+++ b/drivers/common/sfc_efx/base/ef10_nic.c\n@@ -1921,6 +1921,39 @@ efx_mcdi_nic_board_cfg(\n \treturn (rc);\n }\n \n+static\t__checkReturn\tefx_rc_t\n+efx_mcdi_entity_reset(\n+\t__in\t\tefx_nic_t *enp)\n+{\n+\tefx_mcdi_req_t req;\n+\tEFX_MCDI_DECLARE_BUF(payload, MC_CMD_ENTITY_RESET_IN_LEN,\n+\t\tMC_CMD_ENTITY_RESET_OUT_LEN);\n+\tefx_rc_t rc;\n+\n+\treq.emr_cmd = MC_CMD_ENTITY_RESET;\n+\treq.emr_in_buf = payload;\n+\treq.emr_in_length = MC_CMD_ENTITY_RESET_IN_LEN;\n+\treq.emr_out_buf = payload;\n+\treq.emr_out_length = MC_CMD_ENTITY_RESET_OUT_LEN;\n+\n+\tMCDI_IN_POPULATE_DWORD_1(req, ENTITY_RESET_IN_FLAG,\n+\t ENTITY_RESET_IN_FUNCTION_RESOURCE_RESET, 1);\n+\n+\tefx_mcdi_execute(enp, &req);\n+\n+\tif (req.emr_rc != 0) {\n+\t\trc = req.emr_rc;\n+\t\tgoto fail1;\n+\t}\n+\n+\treturn (0);\n+\n+fail1:\n+\tEFSYS_PROBE1(fail1, efx_rc_t, rc);\n+\n+\treturn (rc);\n+}\n+\n static\t__checkReturn\tefx_rc_t\n ef10_set_workaround_bug26807(\n \t__in\t\tefx_nic_t *enp)\n@@ -2203,9 +2236,6 @@ ef10_nic_set_drv_limits(\n ef10_nic_reset(\n \t__in\t\tefx_nic_t *enp)\n {\n-\tefx_mcdi_req_t req;\n-\tEFX_MCDI_DECLARE_BUF(payload, MC_CMD_ENTITY_RESET_IN_LEN,\n-\t\tMC_CMD_ENTITY_RESET_OUT_LEN);\n \tefx_rc_t rc;\n \n \t/* ef10_nic_reset() is called to recover from BADASSERT failures. */\n@@ -2214,21 +2244,8 @@ ef10_nic_reset(\n \tif ((rc = efx_mcdi_exit_assertion_handler(enp)) != 0)\n \t\tgoto fail2;\n \n-\treq.emr_cmd = MC_CMD_ENTITY_RESET;\n-\treq.emr_in_buf = payload;\n-\treq.emr_in_length = MC_CMD_ENTITY_RESET_IN_LEN;\n-\treq.emr_out_buf = payload;\n-\treq.emr_out_length = MC_CMD_ENTITY_RESET_OUT_LEN;\n-\n-\tMCDI_IN_POPULATE_DWORD_1(req, ENTITY_RESET_IN_FLAG,\n-\t ENTITY_RESET_IN_FUNCTION_RESOURCE_RESET, 1);\n-\n-\tefx_mcdi_execute(enp, &req);\n-\n-\tif (req.emr_rc != 0) {\n-\t\trc = req.emr_rc;\n+\tif ((rc = efx_mcdi_entity_reset(enp)) != 0)\n \t\tgoto fail3;\n-\t}\n \n \t/* Clear RX/TX DMA queue errors */\n \tenp->en_reset_flags &= ~(EFX_RESET_RXQ_ERR | EFX_RESET_TXQ_ERR);\n", "prefixes": [ "v3", "13/60" ] }