Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78682/?format=api
{ "id": 78682, "url": "https://patches.dpdk.org/api/patches/78682/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1600949555-28043-5-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1600949555-28043-5-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1600949555-28043-5-git-send-email-arybchenko@solarflare.com", "date": "2020-09-24T12:11:39", "name": "[v3,04/60] common/sfc_efx/base: add efsys option for Riverhead", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2f8893e9b572f232745d1d3e7999fd9b619cec7f", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1600949555-28043-5-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 12473, "url": "https://patches.dpdk.org/api/series/12473/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12473", "date": "2020-09-24T12:11:40", "name": "common/sfc_efx: support Riverhead NIC family", "version": 3, "mbox": "https://patches.dpdk.org/series/12473/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/78682/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/78682/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6B68DA04B1;\n\tThu, 24 Sep 2020 14:13:35 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 197FE1DE21;\n\tThu, 24 Sep 2020 14:13:01 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 9F8B41DE02\n for <dev@dpdk.org>; Thu, 24 Sep 2020 14:12:52 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.62])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n 5C933600BA for <dev@dpdk.org>; Thu, 24 Sep 2020 12:12:52 +0000 (UTC)", "from us4-mdac16-54.ut7.mdlocal (unknown [10.7.66.25])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 5B1928009B\n for <dev@dpdk.org>; Thu, 24 Sep 2020 12:12:52 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.7.65.175])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n ADF5E280079\n for <dev@dpdk.org>; Thu, 24 Sep 2020 12:12:50 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 647B3700053\n for <dev@dpdk.org>; Thu, 24 Sep 2020 12:12:50 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Thu, 24 Sep 2020 13:12:46 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Thu, 24 Sep 2020 13:12:45 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 08OCCj7G025862\n for <dev@dpdk.org>; Thu, 24 Sep 2020 13:12:45 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id DFDD81613A9\n for <dev@dpdk.org>; Thu, 24 Sep 2020 13:12:45 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Thu, 24 Sep 2020 13:11:39 +0100", "Message-ID": "<1600949555-28043-5-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1600949555-28043-1-git-send-email-arybchenko@solarflare.com>", "References": "<1600764594-14752-1-git-send-email-arybchenko@solarflare.com>\n <1600949555-28043-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25674.003", "X-TM-AS-Result": "No-4.144600-8.000000-10", "X-TMASE-MatchedRID": "B6OF5MsVQnvabBVcqlDcF2wTEruL9ObTBGvINcfHqhcGmHr1eMxt2UAc\n 6DyoS2rIqQ4DH3i/D94595trGMYhhrlcL8GzHfqtB8Lglj0iCADESSxPxTa9g0krZ4mFjTbD1mI\n qSQOMZGzVPGtJpQStsFtRr92EMHJLFUPnz5fE4uPjsEyk2Mc+L0ewdu9S21aiGy2EO7JCB/FLIA\n jDsEYHR4TcmhipZoOaGx4QOjd5HXXBQaAoBFeC8gKDWtq/hHcNfS0Ip2eEHnz3IzXlXlpamPoLR\n 4+zsDTtwwUcWQpWasFx2W5Aq4G8V5+P9ta3Q4mDOkFMwHFWNmTHjKN5yOwgpxtoD4jTgeV5UH5w\n ntxidcnuq9pVZlPsArz0+RNybP9kxdfpLuQmFPsAA9BapWXaJtG+KyfdrZrRf3e2vVbH8zBmH8z\n Zfront1XK9tOD+u6c", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10-4.144600-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25674.003", "X-MDID": "1600949571-YAu-rFH8EYxW", "Subject": "[dpdk-dev] [PATCH v3 04/60] common/sfc_efx/base: add efsys option\n\tfor Riverhead", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\nReviewed-by: Vijay Kumar Srivastava <vsrivast@xilinx.com>\n---\n drivers/common/sfc_efx/base/efx_check.h | 44 ++++++++++++-------------\n drivers/common/sfc_efx/efsys.h | 3 ++\n 2 files changed, 25 insertions(+), 22 deletions(-)", "diff": "diff --git a/drivers/common/sfc_efx/base/efx_check.h b/drivers/common/sfc_efx/base/efx_check.h\nindex 5a04a69e5f..978321cf67 100644\n--- a/drivers/common/sfc_efx/base/efx_check.h\n+++ b/drivers/common/sfc_efx/base/efx_check.h\n@@ -47,8 +47,8 @@\n \n #if EFSYS_OPT_CHECK_REG\n /* Verify chip implements accessed registers */\n-# if !(EFX_OPTS_EF10() || EFSYS_OPT_SIENA)\n-# error \"CHECK_REG requires EF10 arch or SIENA\"\n+# if !(EFSYS_OPT_RIVERHEAD || EFX_OPTS_EF10() || EFSYS_OPT_SIENA)\n+# error \"CHECK_REG requires RIVERHEAD or EF10 arch or SIENA\"\n # endif\n #endif /* EFSYS_OPT_CHECK_REG */\n \n@@ -79,21 +79,21 @@\n \n #if EFSYS_OPT_FILTER\n /* Support hardware packet filters */\n-# if !(EFX_OPTS_EF10() || EFSYS_OPT_SIENA)\n-# error \"FILTER requires EF10 arch or SIENA\"\n+# if !(EFSYS_OPT_RIVERHEAD || EFX_OPTS_EF10() || EFSYS_OPT_SIENA)\n+# error \"FILTER requires RIVERHEAD or EF10 arch or SIENA\"\n # endif\n #endif /* EFSYS_OPT_FILTER */\n \n-#if EFX_OPTS_EF10()\n+#if EFSYS_OPT_RIVERHEAD || EFX_OPTS_EF10()\n # if !EFSYS_OPT_FILTER\n-# error \"EF10 arch requires FILTER\"\n+# error \"RIVERHEAD or EF10 arch requires FILTER\"\n # endif\n #endif /* EFX_OPTS_EF10() */\n \n #if EFSYS_OPT_LOOPBACK\n /* Support hardware loopback modes */\n-# if !(EFX_OPTS_EF10() || EFSYS_OPT_SIENA)\n-# error \"LOOPBACK requires EF10 arch or SIENA\"\n+# if !(EFSYS_OPT_RIVERHEAD || EFX_OPTS_EF10() || EFSYS_OPT_SIENA)\n+# error \"LOOPBACK requires RIVERHEAD or EF10 arch or SIENA\"\n # endif\n #endif /* EFSYS_OPT_LOOPBACK */\n \n@@ -107,21 +107,21 @@\n \n #if EFSYS_OPT_MAC_STATS\n /* Support MAC statistics */\n-# if !(EFX_OPTS_EF10() || EFSYS_OPT_SIENA)\n-# error \"MAC_STATS requires EF10 arch or SIENA\"\n+# if !(EFSYS_OPT_RIVERHEAD || EFX_OPTS_EF10() || EFSYS_OPT_SIENA)\n+# error \"MAC_STATS requires RIVERHEAD or EF10 arch or SIENA\"\n # endif\n #endif /* EFSYS_OPT_MAC_STATS */\n \n #if EFSYS_OPT_MCDI\n /* Support management controller messages */\n-# if !(EFX_OPTS_EF10() || EFSYS_OPT_SIENA)\n-# error \"MCDI requires EF10 arch or SIENA\"\n+# if !(EFSYS_OPT_RIVERHEAD || EFX_OPTS_EF10() || EFSYS_OPT_SIENA)\n+# error \"MCDI requires RIVERHEAD or EF10 arch or SIENA\"\n # endif\n #endif /* EFSYS_OPT_MCDI */\n \n-#if (EFX_OPTS_EF10() || EFSYS_OPT_SIENA)\n+#if (EFSYS_OPT_RIVERHEAD || EFX_OPTS_EF10() || EFSYS_OPT_SIENA)\n # if !EFSYS_OPT_MCDI\n-# error \"EF10 arch or SIENA requires MCDI\"\n+# error \"RIVERHEAD or EF10 arch or SIENA requires MCDI\"\n # endif\n #endif\n \n@@ -288,15 +288,15 @@\n \n #if EFSYS_OPT_RX_SCALE\n /* Support receive scaling (RSS) */\n-# if !(EFX_OPTS_EF10() || EFSYS_OPT_SIENA)\n-# error \"RX_SCALE requires EF10 arch or SIENA\"\n+# if !(EFSYS_OPT_RIVERHEAD || EFX_OPTS_EF10() || EFSYS_OPT_SIENA)\n+# error \"RX_SCALE requires RIVERHEAD or EF10 arch or SIENA\"\n # endif\n #endif /* EFSYS_OPT_RX_SCALE */\n \n #if EFSYS_OPT_RX_SCATTER\n /* Support receive scatter DMA */\n-# if !(EFX_OPTS_EF10() || EFSYS_OPT_SIENA)\n-# error \"RX_SCATTER requires EF10 arch or SIENA\"\n+# if !(EFSYS_OPT_RIVERHEAD || EFX_OPTS_EF10() || EFSYS_OPT_SIENA)\n+# error \"RX_SCATTER requires RIVERHEAD or EF10 arch or SIENA\"\n # endif\n #endif /* EFSYS_OPT_RX_SCATTER */\n \n@@ -338,8 +338,8 @@\n \n #if EFSYS_OPT_ALLOW_UNCONFIGURED_NIC\n /* Support adapters with missing static config (for factory use only) */\n-# if !(EFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2)\n-# error \"ALLOW_UNCONFIGURED_NIC requires MEDFORD or MEDFORD2\"\n+# if !(EFSYS_OPT_RIVERHEAD || EFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2)\n+# error \"ALLOW_UNCONFIGURED_NIC requires RIVERHEAD or MEDFORD or MEDFORD2\"\n # endif\n #endif /* EFSYS_OPT_ALLOW_UNCONFIGURED_NIC */\n \n@@ -359,8 +359,8 @@\n \n /* Support hardware assistance for tunnels */\n #if EFSYS_OPT_TUNNEL\n-# if !(EFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2)\n-# error \"TUNNEL requires MEDFORD or MEDFORD2\"\n+# if !(EFSYS_OPT_RIVERHEAD || EFSYS_OPT_MEDFORD || EFSYS_OPT_MEDFORD2)\n+# error \"TUNNEL requires RIVERHEAD or MEDFORD or MEDFORD2\"\n # endif\n #endif /* EFSYS_OPT_TUNNEL */\n \ndiff --git a/drivers/common/sfc_efx/efsys.h b/drivers/common/sfc_efx/efsys.h\nindex 46b08f9789..1567d91588 100644\n--- a/drivers/common/sfc_efx/efsys.h\n+++ b/drivers/common/sfc_efx/efsys.h\n@@ -105,6 +105,9 @@ prefetch_read_once(const volatile void *addr)\n #define EFSYS_OPT_MEDFORD 1\n /* Enable SFN2xxx support */\n #define EFSYS_OPT_MEDFORD2 1\n+/* Disable Riverhead support */\n+#define EFSYS_OPT_RIVERHEAD 0\n+\n #ifdef RTE_LIBRTE_SFC_EFX_DEBUG\n #define EFSYS_OPT_CHECK_REG 1\n #else\n", "prefixes": [ "v3", "04/60" ] }