Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78516/?format=api
https://patches.dpdk.org/api/patches/78516/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200923094902.216856-1-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200923094902.216856-1-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200923094902.216856-1-maxime.coquelin@redhat.com", "date": "2020-09-23T09:49:02", "name": "vhost: fix external backends readiness", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "94f2a71b424150b58082bccb1749a90b6160307b", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200923094902.216856-1-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 12436, "url": "https://patches.dpdk.org/api/series/12436/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12436", "date": "2020-09-23T09:49:02", "name": "vhost: fix external backends readiness", "version": 1, "mbox": "https://patches.dpdk.org/series/12436/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/78516/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/78516/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id ADB3DA04B1;\n\tWed, 23 Sep 2020 11:49:17 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 564DE1D5BC;\n\tWed, 23 Sep 2020 11:49:16 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [63.128.21.124])\n by dpdk.org (Postfix) with ESMTP id 204971D549\n for <dev@dpdk.org>; Wed, 23 Sep 2020 11:49:15 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-298-ir4UkzUxMGGl7GTnErjzfw-1; Wed, 23 Sep 2020 05:49:12 -0400", "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com\n [10.5.11.13])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6BAE380EF84;\n Wed, 23 Sep 2020 09:49:11 +0000 (UTC)", "from localhost.localdomain (unknown [10.36.110.9])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 7362073682;\n Wed, 23 Sep 2020 09:49:05 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1600854554;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=RF8mxhHMQb0fqnN/cE3GLoAKqZFsUKwWR94KZMwDPy8=;\n b=T8b1Hm/kqpqGxc4G3fbpCHUUmU1X2DCo17I0jEHkutVZ2zhHBzAx8x/h1pMd59T0vPmHcq\n GOmp/JFo1spW+aIOiWHfiAycP5EI5N5sK/1pn59lC1YxQg+thyTAvbr9Om1Pkg1sV91W9v\n 0Unn0ApwoqRRtC5ryTduWgR6B4fFT6Q=", "X-MC-Unique": "ir4UkzUxMGGl7GTnErjzfw-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, chenbo.xia@intel.com, matan@mellanox.com,\n tomasz.zawadzki@intel.com, changpeng.liu@intel.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Wed, 23 Sep 2020 11:49:02 +0200", "Message-Id": "<20200923094902.216856-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] vhost: fix external backends readiness", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Commit d0fcc38f5fa4 (\"vhost: improve device readiness notifications\")\nmakes the assumption that every Virtio devices are considered\nready for preocessing as soon as first queue pair is configured\nand enabled.\n\nWhile this is true for Virtio-net, it isn't for Virtio-scsi\nand Virtio-blk.\n\nThis patch fixes this by only making this assumption for\nthe builtin Virtio-net backend, and restores back to previous\nbehaviour for other backends.\n\nFixes: d0fcc38f5fa4 (\"vhost: improve device readiness notifications\")\n\nReported-by: Changpeng Liu <changpeng.liu@intel.com>\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\nSigned-off-by: Changpeng Liu <changpeng.liu@intel.com>\n---\n lib/librte_vhost/vhost_user.c | 15 +++++++++++----\n 1 file changed, 11 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 501218e192..b00e1f91dc 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -1343,21 +1343,28 @@ vq_is_ready(struct virtio_net *dev, struct vhost_virtqueue *vq)\n \t vq->enabled;\n }\n \n-#define VIRTIO_DEV_NUM_VQS_TO_BE_READY 2u\n+#define VIRTIO_BUILTIN_NUM_VQS_TO_BE_READY 2u\n \n static int\n virtio_is_ready(struct virtio_net *dev)\n {\n \tstruct vhost_virtqueue *vq;\n-\tuint32_t i;\n+\tuint32_t i, nr_vring = dev->nr_vring;\n \n \tif (dev->flags & VIRTIO_DEV_READY)\n \t\treturn 1;\n \n-\tif (dev->nr_vring < VIRTIO_DEV_NUM_VQS_TO_BE_READY)\n+\tif (!dev->nr_vring)\n \t\treturn 0;\n \n-\tfor (i = 0; i < VIRTIO_DEV_NUM_VQS_TO_BE_READY; i++) {\n+\tif (dev->flags & VIRTIO_DEV_BUILTIN_VIRTIO_NET) {\n+\t\tnr_vring = VIRTIO_BUILTIN_NUM_VQS_TO_BE_READY;\n+\n+\t\tif (dev->nr_vring < nr_vring)\n+\t\t\treturn 0;\n+\t}\n+\n+\tfor (i = 0; i < nr_vring; i++) {\n \t\tvq = dev->virtqueue[i];\n \n \t\tif (!vq_is_ready(dev, vq))\n", "prefixes": [] }{ "id": 78516, "url": "