Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78338/?format=api
{ "id": 78338, "url": "https://patches.dpdk.org/api/patches/78338/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1600767288-12109-11-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1600767288-12109-11-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1600767288-12109-11-git-send-email-arybchenko@solarflare.com", "date": "2020-09-22T09:33:58", "name": "[v2,10/60] common/sfc_efx/base: remove PF count get from caps get", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5065d249db57fcbdaaf446d0333142139dc42971", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1600767288-12109-11-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 12402, "url": "https://patches.dpdk.org/api/series/12402/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12402", "date": "2020-09-22T09:33:53", "name": "common/sfc_efx: support Riverhead NIC family", "version": 2, "mbox": "https://patches.dpdk.org/series/12402/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/78338/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/78338/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 20482A04E1;\n\tTue, 22 Sep 2020 11:36:41 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 984971DCE7;\n\tTue, 22 Sep 2020 11:35:28 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 36CA41DB0F\n for <dev@dpdk.org>; Tue, 22 Sep 2020 11:35:04 +0200 (CEST)", "from mx1-us1.ppe-hosted.com (unknown [10.110.50.144])\n by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id\n D848120073 for <dev@dpdk.org>; Tue, 22 Sep 2020 09:35:03 +0000 (UTC)", "from us4-mdac16-46.at1.mdlocal (unknown [10.110.50.129])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id D80DA800A4\n for <dev@dpdk.org>; Tue, 22 Sep 2020 09:35:03 +0000 (UTC)", "from mx1-us1.ppe-hosted.com (unknown [10.110.49.30])\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 8036840070\n for <dev@dpdk.org>; Tue, 22 Sep 2020 09:35:03 +0000 (UTC)", "from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n (No client certificate requested)\n by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id\n 342C8140069\n for <dev@dpdk.org>; Tue, 22 Sep 2020 09:35:03 +0000 (UTC)", "from ukex01.SolarFlarecom.com (10.17.10.4) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id\n 15.0.1497.2; Tue, 22 Sep 2020 10:34:56 +0100", "from opal.uk.solarflarecom.com (10.17.10.1) by\n ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id\n 15.0.1497.2 via Frontend Transport; Tue, 22 Sep 2020 10:34:56 +0100", "from ukv-loginhost.uk.solarflarecom.com\n (ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 08M9Ytus026890\n for <dev@dpdk.org>; Tue, 22 Sep 2020 10:34:55 +0100", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id DBA091613A9\n for <dev@dpdk.org>; Tue, 22 Sep 2020 10:34:55 +0100 (BST)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Tue, 22 Sep 2020 10:33:58 +0100", "Message-ID": "<1600767288-12109-11-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1600767288-12109-1-git-send-email-arybchenko@solarflare.com>", "References": "<1600764594-14752-1-git-send-email-arybchenko@solarflare.com>\n <1600767288-12109-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.6.1012-25674.003", "X-TM-AS-Result": "No-7.293400-8.000000-10", "X-TMASE-MatchedRID": "fASjJbTnm+HhqMon2KWg9MYv//yaWh0DzDHtVtmAaYrwJYZa/L83HeXf\n obWTj2nCpu8oJ7W6Qzc73+B0i2dxjdpsFVyqUNwXbBMSu4v05tNLXPA26IG0hA9BGny4aW9IJ7o\n vlkPXpS0CJK826czEZBDon3fee1LyE2Fn9cnI7pdH+PTjR9EWkjKx0awWOyc1GlfXMQvierc1pG\n BDbSwzIuW8u2FgK0WKt6dCQtb8q1FkJsQ3rBV4iIdlc1JaOB1TBGvINcfHqhc7OtcKFS0EBKEGK\n hm9baaNtLYTKXvwdBD6eNYcDxJcEID5PWrQnVeEmXzg0bB6zmD1mLEwgfqpIJsoi2XrUn/J6M+9\n pHJMV8guGQkQ2SYJmSdET58jp62SVk57R0JkCPFooMBe7CNSdAdmgucK+tYct1JTiwc7lUZQ5p5\n qfwp+zwbNd2jN64Xqaq1yCICbxa/jEqiYEqhz6S6NNT2NZLVnqha7fcVIKfrqvk9CHHb0NQbT7e\n VkE2ZC2rhEGiFuOiuny9fy0ieryw==", "X-TM-AS-User-Approved-Sender": "Yes", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--7.293400-8.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.6.1012-25674.003", "X-MDID": "1600767304-RQil0HcZHKRp", "Subject": "[dpdk-dev] [PATCH v2 10/60] common/sfc_efx/base: remove PF count\n\tget from caps get", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "ef10_get_datapath_caps() should simply fill in NIC configuration\nbased MC_CMD_GET_CAPABILITIES output.\n\nNumber of PFs is a part of board configuration should be obtained\nin corresponding function.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/common/sfc_efx/base/ef10_nic.c | 37 +++++++++++++-------------\n 1 file changed, 18 insertions(+), 19 deletions(-)", "diff": "diff --git a/drivers/common/sfc_efx/base/ef10_nic.c b/drivers/common/sfc_efx/base/ef10_nic.c\nindex bb5fd50eab..f7c4601819 100644\n--- a/drivers/common/sfc_efx/base/ef10_nic.c\n+++ b/drivers/common/sfc_efx/base/ef10_nic.c\n@@ -1031,10 +1031,6 @@ ef10_get_datapath_caps(\n \t\tMC_CMD_GET_CAPABILITIES_V5_OUT_LEN);\n \tefx_rc_t rc;\n \n-\tif ((rc = ef10_mcdi_get_pf_count(enp, &encp->enc_hw_pf_count)) != 0)\n-\t\tgoto fail1;\n-\n-\n \treq.emr_cmd = MC_CMD_GET_CAPABILITIES;\n \treq.emr_in_buf = payload;\n \treq.emr_in_length = MC_CMD_GET_CAPABILITIES_IN_LEN;\n@@ -1045,12 +1041,12 @@ ef10_get_datapath_caps(\n \n \tif (req.emr_rc != 0) {\n \t\trc = req.emr_rc;\n-\t\tgoto fail2;\n+\t\tgoto fail1;\n \t}\n \n \tif (req.emr_out_length_used < MC_CMD_GET_CAPABILITIES_OUT_LEN) {\n \t\trc = EMSGSIZE;\n-\t\tgoto fail3;\n+\t\tgoto fail2;\n \t}\n \n #define\tCAP_FLAGS1(_req, _flag)\t\t\t\t\t\t\\\n@@ -1344,7 +1340,7 @@ ef10_get_datapath_caps(\n \n \t\tdefault:\n \t\t\trc = EINVAL;\n-\t\t\tgoto fail4;\n+\t\t\tgoto fail3;\n \t\t}\n \n \t\t/* Port numbers cannot contribute to the hash value */\n@@ -1393,11 +1389,9 @@ ef10_get_datapath_caps(\n \treturn (0);\n \n #if EFSYS_OPT_RX_SCALE\n-fail4:\n-\tEFSYS_PROBE(fail4);\n-#endif /* EFSYS_OPT_RX_SCALE */\n fail3:\n \tEFSYS_PROBE(fail3);\n+#endif /* EFSYS_OPT_RX_SCALE */\n fail2:\n \tEFSYS_PROBE(fail2);\n fail1:\n@@ -1856,6 +1850,9 @@ ef10_nic_board_cfg(\n \tencp->enc_pf = pf;\n \tencp->enc_vf = vf;\n \n+\tif ((rc = ef10_mcdi_get_pf_count(enp, &encp->enc_hw_pf_count)) != 0)\n+\t\tgoto fail4;\n+\n \t/* MAC address for this function */\n \tif (EFX_PCI_FUNCTION_IS_PF(encp)) {\n \t\trc = efx_mcdi_get_mac_address_pf(enp, mac_addr);\n@@ -1880,7 +1877,7 @@ ef10_nic_board_cfg(\n \t\trc = efx_mcdi_get_mac_address_vf(enp, mac_addr);\n \t}\n \tif (rc != 0)\n-\t\tgoto fail4;\n+\t\tgoto fail5;\n \n \tEFX_MAC_ADDR_COPY(encp->enc_mac_addr, mac_addr);\n \n@@ -1891,7 +1888,7 @@ ef10_nic_board_cfg(\n \t\tif (rc == EACCES)\n \t\t\tboard_type = 0;\n \t\telse\n-\t\t\tgoto fail5;\n+\t\t\tgoto fail6;\n \t}\n \n \tencp->enc_board_type = board_type;\n@@ -1899,7 +1896,7 @@ ef10_nic_board_cfg(\n \n \t/* Fill out fields in enp->en_port and enp->en_nic_cfg from MCDI */\n \tif ((rc = efx_mcdi_get_phy_cfg(enp)) != 0)\n-\t\tgoto fail6;\n+\t\tgoto fail7;\n \n \t/*\n \t * Firmware with support for *_FEC capability bits does not\n@@ -1918,13 +1915,13 @@ ef10_nic_board_cfg(\n \n \t/* Obtain the default PHY advertised capabilities */\n \tif ((rc = ef10_phy_get_link(enp, &els)) != 0)\n-\t\tgoto fail7;\n+\t\tgoto fail8;\n \tepp->ep_default_adv_cap_mask = els.epls.epls_adv_cap_mask;\n \tepp->ep_adv_cap_mask = els.epls.epls_adv_cap_mask;\n \n \t/* Check capabilities of running datapath firmware */\n \tif ((rc = ef10_get_datapath_caps(enp)) != 0)\n-\t\tgoto fail8;\n+\t\tgoto fail9;\n \n \t/*\n \t * Huntington RXDP firmware inserts a 0 or 14 byte prefix.\n@@ -1932,7 +1929,7 @@ ef10_nic_board_cfg(\n \t */\n \tif (encp->enc_rx_prefix_size != 14) {\n \t\trc = ENOTSUP;\n-\t\tgoto fail9;\n+\t\tgoto fail10;\n \t}\n \n \t/* Alignment for WPTR updates */\n@@ -1963,7 +1960,7 @@ ef10_nic_board_cfg(\n \t/* Get interrupt vector limits */\n \tif ((rc = efx_mcdi_get_vector_cfg(enp, &base, &nvec, NULL)) != 0) {\n \t\tif (EFX_PCI_FUNCTION_IS_PF(encp))\n-\t\t\tgoto fail10;\n+\t\t\tgoto fail11;\n \n \t\t/* Ignore error (cannot query vector limits from a VF). */\n \t\tbase = 0;\n@@ -1979,7 +1976,7 @@ ef10_nic_board_cfg(\n \t * can result in time-of-check/time-of-use bugs.\n \t */\n \tif ((rc = ef10_get_privilege_mask(enp, &mask)) != 0)\n-\t\tgoto fail11;\n+\t\tgoto fail12;\n \tencp->enc_privilege_mask = mask;\n \n \tif ((rc = ef10_set_workaround_bug26807(enp)) != 0)\n@@ -1988,10 +1985,12 @@ ef10_nic_board_cfg(\n \t/* Get remaining controller-specific board config */\n \tif ((rc = enop->eno_board_cfg(enp)) != 0)\n \t\tif (rc != EACCES)\n-\t\t\tgoto fail12;\n+\t\t\tgoto fail13;\n \n \treturn (0);\n \n+fail13:\n+\tEFSYS_PROBE(fail13);\n fail12:\n \tEFSYS_PROBE(fail12);\n fail11:\n", "prefixes": [ "v2", "10/60" ] }