Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78224/?format=api
{ "id": 78224, "url": "https://patches.dpdk.org/api/patches/78224/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200922012338.11277-5-stevex.yang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200922012338.11277-5-stevex.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200922012338.11277-5-stevex.yang@intel.com", "date": "2020-09-22T01:23:37", "name": "[v2,4/5] net/i40e: fix max mtu size packets with vlan tag cannot be received by default", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "62aeca4b3308bd1fdffc5c0c5a49332bdf487087", "submitter": { "id": 1883, "url": "https://patches.dpdk.org/api/people/1883/?format=api", "name": "Steve Yang", "email": "stevex.yang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200922012338.11277-5-stevex.yang@intel.com/mbox/", "series": [ { "id": 12387, "url": "https://patches.dpdk.org/api/series/12387/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12387", "date": "2020-09-22T01:23:33", "name": "fix default max mtu size when device configured", "version": 2, "mbox": "https://patches.dpdk.org/series/12387/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/78224/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/78224/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CA490A04DE;\n\tTue, 22 Sep 2020 03:43:25 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 40BC71DA9C;\n\tTue, 22 Sep 2020 03:43:04 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by dpdk.org (Postfix) with ESMTP id 133B71DA8C\n for <dev@dpdk.org>; Tue, 22 Sep 2020 03:43:00 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Sep 2020 18:43:00 -0700", "from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136])\n by orsmga002.jf.intel.com with ESMTP; 21 Sep 2020 18:42:58 -0700" ], "IronPort-SDR": [ "\n 8E5S31jiArmYaEnbx662qP9+pxgQECnmErkDBPy51BaW00dGr4WLMPSg0F2agFflDLub3fKx1k\n L1CyT86qdzsA==", "\n O2daw5eGgNjmpFBVkdybmY2aHLau22t4ZlKQd5pFlB989WA+DT35JZEj+TD6RYw99s6UasFZus\n kNp8RcunCMoQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9751\"; a=\"148265200\"", "E=Sophos;i=\"5.77,288,1596524400\"; d=\"scan'208\";a=\"148265200\"", "E=Sophos;i=\"5.77,288,1596524400\"; d=\"scan'208\";a=\"322045754\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "SteveX Yang <stevex.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "wei.zhao1@intel.com, jia.guo@intel.com, qiming.yang@intel.com,\n qi.z.zhang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com,\n konstantin.ananyev@intel.com, SteveX Yang <stevex.yang@intel.com>", "Date": "Tue, 22 Sep 2020 01:23:37 +0000", "Message-Id": "<20200922012338.11277-5-stevex.yang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200922012338.11277-1-stevex.yang@intel.com>", "References": "<20200916055212.25019-1-stevex.yang@intel.com>\n <20200922012338.11277-1-stevex.yang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 4/5] net/i40e: fix max mtu size packets with\n\tvlan tag cannot be received by default", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "testpmd will initialize default max packet length to 1518 which doesn't\ninclude vlan tag size in ether overheader. Once, send the max mtu length\npacket with vlan tag, the max packet length will exceed 1518 that will\ncause packets dropped directly from NIC hw side. But for i40e/i40evf,\nthey should support dual vlan tags that need more 8 bytes for max packet\nsize, so, configure the correct max packet size in dev_config ops.\n\nFixes: ff8282f4bbcd (\"net/i40e: consider QinQ when setting MTU\")\n\nSigned-off-by: SteveX Yang <stevex.yang@intel.com>\n---\n drivers/net/i40e/i40e_ethdev.c | 5 +++++\n drivers/net/i40e/i40e_ethdev_vf.c | 11 +++++++++++\n 2 files changed, 16 insertions(+)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 563f21d9d..023c86d66 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -1930,6 +1930,11 @@ i40e_dev_configure(struct rte_eth_dev *dev)\n \tad->tx_simple_allowed = true;\n \tad->tx_vec_allowed = true;\n \n+\t/* Considering QinQ packet, max frame size should be MTU and\n+\t * corresponding ether overhead.\n+\t */\n+\ti40e_dev_mtu_set(dev, dev->data->mtu);\n+\n \tif (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG)\n \t\tdev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH;\n \ndiff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c\nindex 8531cf6b1..b268b3d00 100644\n--- a/drivers/net/i40e/i40e_ethdev_vf.c\n+++ b/drivers/net/i40e/i40e_ethdev_vf.c\n@@ -1669,6 +1669,7 @@ i40evf_dev_configure(struct rte_eth_dev *dev)\n \t\tI40E_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);\n \tuint16_t num_queue_pairs = RTE_MAX(dev->data->nb_rx_queues,\n \t\t\t\tdev->data->nb_tx_queues);\n+\tstruct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;\n \n \t/* Initialize to TRUE. If any of Rx queues doesn't meet the bulk\n \t * allocation or vector Rx preconditions we will reset it.\n@@ -1681,6 +1682,16 @@ i40evf_dev_configure(struct rte_eth_dev *dev)\n \tdev->data->dev_conf.intr_conf.lsc =\n \t\t!!(dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC);\n \n+\n+\t/* Considering QinQ packet, max frame size should be MTU and\n+\t * corresponding ether overhead.\n+\t */\n+\tif (dev->data->mtu == RTE_ETHER_MTU &&\n+\t\trxmode->max_rx_pkt_len == RTE_ETHER_MAX_LEN) {\n+\t\trxmode->max_rx_pkt_len = RTE_ETHER_MTU + I40E_ETH_OVERHEAD;\n+\t\trxmode->offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME;\n+\t}\n+\n \tif (num_queue_pairs > vf->vsi_res->num_queue_pairs) {\n \t\tstruct i40e_hw *hw;\n \t\tint ret;\n", "prefixes": [ "v2", "4/5" ] }