Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/78084/?format=api
{ "id": 78084, "url": "https://patches.dpdk.org/api/patches/78084/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200918095505.1619-1-vipul.ashri@oracle.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200918095505.1619-1-vipul.ashri@oracle.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200918095505.1619-1-vipul.ashri@oracle.com", "date": "2020-09-18T09:55:04", "name": "[v5] net/virtio: fix wrong variable assignment in helper macro", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "13da0a7632a5371cb3c6ebb1d20dd36635cecccd", "submitter": { "id": 1867, "url": "https://patches.dpdk.org/api/people/1867/?format=api", "name": "Vipul Ashri", "email": "vipul.ashri@oracle.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200918095505.1619-1-vipul.ashri@oracle.com/mbox/", "series": [ { "id": 12342, "url": "https://patches.dpdk.org/api/series/12342/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12342", "date": "2020-09-18T09:55:04", "name": "[v5] net/virtio: fix wrong variable assignment in helper macro", "version": 5, "mbox": "https://patches.dpdk.org/series/12342/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/78084/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/78084/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 45910A04C8;\n\tFri, 18 Sep 2020 11:55:25 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 036BB1D981;\n\tFri, 18 Sep 2020 11:55:25 +0200 (CEST)", "from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85])\n by dpdk.org (Postfix) with ESMTP id 10DCC1D97E;\n Fri, 18 Sep 2020 11:55:23 +0200 (CEST)", "from pps.filterd (userp2120.oracle.com [127.0.0.1])\n by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08I9ik9o022013;\n Fri, 18 Sep 2020 09:55:23 GMT", "from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80])\n by userp2120.oracle.com with ESMTP id 33j91dyxgd-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);\n Fri, 18 Sep 2020 09:55:23 +0000", "from pps.filterd (userp3030.oracle.com [127.0.0.1])\n by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08I9iuo9068203;\n Fri, 18 Sep 2020 09:55:22 GMT", "from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236])\n by userp3030.oracle.com with ESMTP id 33megb3mh5-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Fri, 18 Sep 2020 09:55:22 +0000", "from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14])\n by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 08I9tHlC029644;\n Fri, 18 Sep 2020 09:55:18 GMT", "from VASHRI-IN.in.oracle.com (/10.166.169.57)\n by default (Oracle Beehive Gateway v4.0)\n with ESMTP ; Fri, 18 Sep 2020 09:55:17 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding; s=corp-2020-01-29;\n bh=WRFvYIMXqRcZWWyBOAv4c21XocIZDMCT/0UrLewgCl4=;\n b=MzAPqGvI4brtm/cXiJ1hEkP7dPnoSW+IQdd1UbsRXHNb/jdFic5jz9NuhzjEVlshLP+s\n UhbknL2ZYNVviXwTYyzmvriBG9AJkgyDuRzOxv81hRGryPVpBf93YyCQccVNauVfuVu/\n lkQDdpthrl/2H7KkWjS/Tlyf7xLTw2Fr2JpehJ5U1hn1DuvN+fbTFLFx3Fsg5JR3MNxr\n L/ngHq4OnnTVFyQncHlkQvHvX98ithlRrNYCZNrY87JLY9axoXz5Ap5gAEvqegTwjYhh\n MMT058sfL0jt1Bira0xWzA4OOkPeE1ocXj+MQgAYyyD4JUl7SIMCbjjmek5pQNymcPKD Gg==", "From": "Vipul Ashri <vipul.ashri@oracle.com>", "To": "dev@dpdk.org", "Cc": "chenbo.xia@intel.com, vipul.ashri@oracle.com, zhihong.wang@intel.com,\n maxime.coquelin@redhat.com, arybchenko@solarflare.com,\n makarov@kraftway.ru, stable@dpdk.org", "Date": "Fri, 18 Sep 2020 15:25:04 +0530", "Message-Id": "<20200918095505.1619-1-vipul.ashri@oracle.com>", "X-Mailer": "git-send-email 2.28.0.windows.1", "In-Reply-To": "<20200813072837.1468-1-vipul.ashri@oracle.com>", "References": "<20200813072837.1468-1-vipul.ashri@oracle.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-Virus-Version": [ "vendor=nai engine=6000 definitions=9747\n signatures=668679", "vendor=nai engine=6000 definitions=9747\n signatures=668679" ], "X-Proofpoint-Spam-Details": [ "rule=notspam policy=default score=0 suspectscore=1\n mlxscore=0 spamscore=0\n mlxlogscore=999 adultscore=0 bulkscore=0 phishscore=0 malwarescore=0\n classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000\n definitions=main-2009180080", "rule=notspam policy=default score=0 phishscore=0\n impostorscore=0\n priorityscore=1501 malwarescore=0 suspectscore=1 mlxlogscore=999\n clxscore=1015 adultscore=0 lowpriorityscore=0 spamscore=0 mlxscore=0\n bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n engine=8.12.0-2006250000 definitions=main-2009180080" ], "Subject": "[dpdk-dev] [PATCH v5] net/virtio: fix wrong variable assignment in\n\thelper macro", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Inside Macro ASSIGN_UNLESS_EQUAL(var, val), assignment to var is always\nfailing as assignment done using var_ having local scope only.\nThis leads to TX packets not going out and found broken due to cleanup\nmalfunctioning. This patch fixes the wrong variable assignment.\n\nFixes: 57f90f894588 (\"net/virtio: reuse packed ring functions\")\nCc: stable@dpdk.org\n\nSigned-off-by: Vipul Ashri <vipul.ashri@oracle.com>\n---\n drivers/net/virtio/virtqueue.h | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h\nindex 105a9c00c..6ed50648c 100644\n--- a/drivers/net/virtio/virtqueue.h\n+++ b/drivers/net/virtio/virtqueue.h\n@@ -607,10 +607,10 @@ virtqueue_notify(struct virtqueue *vq)\n \n /* avoid write operation when necessary, to lessen cache issues */\n #define ASSIGN_UNLESS_EQUAL(var, val) do {\t\\\n-\ttypeof(var) var_ = (var);\t\t\\\n-\ttypeof(val) val_ = (val);\t\t\\\n-\tif ((var_) != (val_))\t\t\t\\\n-\t\t(var_) = (val_);\t\t\\\n+\ttypeof(var) *const var_ = &(var);\t\\\n+\ttypeof(val) const val_ = (val);\t\\\n+\tif (*var_ != val_)\t\t\t\\\n+\t\t*var_ = val_;\t\t\t\\\n } while (0)\n \n #define virtqueue_clear_net_hdr(hdr) do {\t\t\\\n", "prefixes": [ "v5" ] }