Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77883/?format=api
{ "id": 77883, "url": "https://patches.dpdk.org/api/patches/77883/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200916090944.125128-3-mb@smartsharesystems.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200916090944.125128-3-mb@smartsharesystems.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200916090944.125128-3-mb@smartsharesystems.com", "date": "2020-09-16T09:09:44", "name": "[v2,2/2] mbuf: minor cleanup", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ad529640bffc1225ebfc7605f2d4070b9a404437", "submitter": { "id": 591, "url": "https://patches.dpdk.org/api/people/591/?format=api", "name": "Morten Brørup", "email": "mb@smartsharesystems.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200916090944.125128-3-mb@smartsharesystems.com/mbox/", "series": [ { "id": 12267, "url": "https://patches.dpdk.org/api/series/12267/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12267", "date": "2020-09-16T09:09:42", "name": "mbuf: minor cleanup", "version": 2, "mbox": "https://patches.dpdk.org/series/12267/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/77883/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/77883/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9D4D4A04C7;\n\tWed, 16 Sep 2020 11:10:07 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CFC7C1C216;\n\tWed, 16 Sep 2020 11:09:54 +0200 (CEST)", "from smartserver.smartsharesystems.com\n (smartserver.smartsharesystems.com [77.243.40.215])\n by dpdk.org (Postfix) with ESMTP id 751541C1F8\n for <dev@dpdk.org>; Wed, 16 Sep 2020 11:09:51 +0200 (CEST)", "from dkrd2.smartsharesys.local ([192.168.4.12]) by\n smartserver.smartsharesystems.com with Microsoft SMTPSVC(6.0.3790.4675);\n Wed, 16 Sep 2020 11:09:50 +0200" ], "From": "=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>", "To": "olivier.matz@6wind.com,\n\tthomas@monjalon.net", "Cc": "dev@dpdk.org, =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>", "Date": "Wed, 16 Sep 2020 11:09:44 +0200", "Message-Id": "<20200916090944.125128-3-mb@smartsharesystems.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200916090944.125128-1-mb@smartsharesystems.com>", "References": "<20200916090944.125128-1-mb@smartsharesystems.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-OriginalArrivalTime": "16 Sep 2020 09:09:50.0600 (UTC)\n FILETIME=[21F05080:01D68C09]", "Subject": "[dpdk-dev] [PATCH v2 2/2] mbuf: minor cleanup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The mbuf header files had some commenting style errors that affected the\nAPI documentation.\nAlso, the RTE_ prefix was missing on a macro and a definition.\n\nNote: This patch does not touch the offload and attachment flags that are\nalso missing the RTE_ prefix.\n\nChanges only affecting documentation:\n* Removed the MBUF_INVALID_PORT definition from rte_mbuf.h; it is\n already defined in rte_mbuf_core.h.\n This removal also reestablished the description of the\n rte_pktmbuf_reset() function.\n* Corrected the comment related to RTE_MBUF_MAX_NB_SEGS.\n* Corrected the comment related to PKT_TX_QINQ_PKT.\n\nChanges regarding missing RTE_ prefix:\n* Converted the MBUF_RAW_ALLOC_CHECK() macro to an\n __rte_mbuf_raw_sanity_check() inline function.\n Added backwards compatible macro with the original name.\n* Renamed the MBUF_INVALID_PORT definition to RTE_MBUF_PORT_INVALID.\n Added backwards compatible definition with the original name.\n\nv2:\n* Use RTE_MBUF_PORT_INVALID intead of MBUF_INVALID_PORT in rte_mbuf.c.\n\nSigned-off-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/librte_mbuf/rte_mbuf.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c\nindex 8a456e5e6..53a015311 100644\n--- a/lib/librte_mbuf/rte_mbuf.c\n+++ b/lib/librte_mbuf/rte_mbuf.c\n@@ -104,7 +104,7 @@ rte_pktmbuf_init(struct rte_mempool *mp,\n \t/* init some constant fields */\n \tm->pool = mp;\n \tm->nb_segs = 1;\n-\tm->port = MBUF_INVALID_PORT;\n+\tm->port = RTE_MBUF_PORT_INVALID;\n \trte_mbuf_refcnt_set(m, 1);\n \tm->next = NULL;\n }\n@@ -207,7 +207,7 @@ __rte_pktmbuf_init_extmem(struct rte_mempool *mp,\n \t/* init some constant fields */\n \tm->pool = mp;\n \tm->nb_segs = 1;\n-\tm->port = MBUF_INVALID_PORT;\n+\tm->port = RTE_MBUF_PORT_INVALID;\n \tm->ol_flags = EXT_ATTACHED_MBUF;\n \trte_mbuf_refcnt_set(m, 1);\n \tm->next = NULL;\n", "prefixes": [ "v2", "2/2" ] }