Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77854/?format=api
{ "id": 77854, "url": "https://patches.dpdk.org/api/patches/77854/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200916042851.32914-26-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200916042851.32914-26-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200916042851.32914-26-ajit.khaparde@broadcom.com", "date": "2020-09-16T04:28:51", "name": "[v2,25/25] net/bnxt: add separate mutex for FW health check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "528b77be92d6ab7dc07d8a464294198a0fc0965e", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200916042851.32914-26-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 12255, "url": "https://patches.dpdk.org/api/series/12255/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12255", "date": "2020-09-16T04:28:26", "name": "patchset for bnxt", "version": 2, "mbox": "https://patches.dpdk.org/series/12255/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/77854/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/77854/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C7272A04C7;\n\tWed, 16 Sep 2020 06:33:13 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5BFB81C22B;\n\tWed, 16 Sep 2020 06:29:50 +0200 (CEST)", "from mail-pl1-f227.google.com (mail-pl1-f227.google.com\n [209.85.214.227]) by dpdk.org (Postfix) with ESMTP id 0D6E41C19F\n for <dev@dpdk.org>; Wed, 16 Sep 2020 06:29:22 +0200 (CEST)", "by mail-pl1-f227.google.com with SMTP id j7so2493202plk.11\n for <dev@dpdk.org>; Tue, 15 Sep 2020 21:29:21 -0700 (PDT)", "from localhost.localdomain ([192.19.223.252])\n by smtp-relay.gmail.com with ESMTPS id hk6sm132636pjb.6.2020.09.15.21.29.20\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Tue, 15 Sep 2020 21:29:21 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com;\n s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=3WCofdLLFW0YnoEon3kcWiMVTgvymn70Cx2/nX02OUw=;\n b=AK1+SXpflkNH8PF5RidqrIBaPBBJ6/FZjh6pdvSzOKkWXzylpp/l+Ln1SbLuelDJYr\n xa6iqK1Dh7qMompofLM1pOXzh9dusYfhkyJGgKUU673X8GfnWj7akXZci9xc0uaJt87p\n oTtgJGQfu/Cb4G4BrDiaDcTWP/ruN+G+Gy3gE=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=3WCofdLLFW0YnoEon3kcWiMVTgvymn70Cx2/nX02OUw=;\n b=NGe7R75uFSUwPf8SGg2SwbfMP+Cg6G/tFu1O5uKKNPS0LNITBX+pXDpfX3a70h06Nk\n LTlo0keI1frCPOmBpzVYk8P/+UCiyANYGg8AcMAFSSQMpQwfPxGwW0mk6ebfRQD0+7Ld\n JQNJOSdNqCuRzEt1l9HScJ1Ph0WkvuKaP01nHqtlouzLZvehCoggRCOEdADGXe6BG8E/\n X7kpXLj71m7MgxixVZZwZXbI4tFPy/12xZy6XfU7Ej0hq/8Urxcen2soeW8X2U1Vzrsd\n 8RY1mZJbpGlP34cecCnL3fv0VCI3JVbLAtdCaZmNORwiqd8IoOt+vf4zu5SXzUYICqnI\n zOhA==", "X-Gm-Message-State": "AOAM531V1DYsAi7acdDkcO0BpA3rxz4eCtRKbxdkh3dTpErvFd9SeSe8\n wdNCPs4Q/oXxTHLQdK1TsvMsA4hQVirVyjXLRErjCxWwnbp2bqIUyu6MYakHZrYMoIlDMf0DbwB\n bK2gzRujspENJlkCNftisZ0HJXftIjehtpENnZKaraTHrYW5cGq9ZAAqbBNMYooNHkLQNn5igCR\n /w6A==", "X-Google-Smtp-Source": "\n ABdhPJwFokTsWVAV7tNyulXAQrovJLMm/8wwfuKMnz6AYwlZa0/oWUNcbe1Pw3hEb3IUasjCSgCUQZlHel8r", "X-Received": "by 2002:a17:902:b716:b029:d1:e598:400c with SMTP id\n d22-20020a170902b716b02900d1e598400cmr4680726pls.70.1600230561143;\n Tue, 15 Sep 2020 21:29:21 -0700 (PDT)", "X-Relaying-Domain": "broadcom.com", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Somnath Kotur <somnath.kotur@broadcom.com>, stable@dpdk.org,\n Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,\n Kalesh AP <kalesh-anakkur.purayil@broadcom.com>", "Date": "Tue, 15 Sep 2020 21:28:51 -0700", "Message-Id": "<20200916042851.32914-26-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.21.1 (Apple Git-122.3)", "In-Reply-To": "<20200916042851.32914-1-ajit.khaparde@broadcom.com>", "References": "<20200911015603.88359-1-ajit.khaparde@broadcom.com>\n <20200916042851.32914-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 25/25] net/bnxt: add separate mutex for FW\n\thealth check", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Somnath Kotur <somnath.kotur@broadcom.com>\n\ndef_cp_lock was added to sync race between dev_configure and\nint_handler. It should not be used to synchronize scheduling of FW\nhealth check between dev_start and async event handler as well,\nuse a separate mutex for the same.\n\nFixes: a73b8e939f10 (\"net/bnxt: fix race between start and interrupt handler\")\nCc: stable@dpdk.org\n\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>\nReviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 1 +\n drivers/net/bnxt/bnxt_ethdev.c | 16 ++++++++++++----\n 2 files changed, 13 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex f0b080015..bb265999d 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -712,6 +712,7 @@ struct bnxt {\n \trte_iova_t\t\t\thwrm_short_cmd_req_dma_addr;\n \trte_spinlock_t\t\t\thwrm_lock;\n \tpthread_mutex_t\t\t\tdef_cp_lock;\n+\tpthread_mutex_t\t\t\thealth_check_lock;\n \tuint16_t\t\t\tmax_req_len;\n \tuint16_t\t\t\tmax_resp_len;\n \tuint16_t hwrm_max_ext_req_len;\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 7c27e2435..05e9a6abb 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -1252,9 +1252,7 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev)\n \teth_dev->rx_pkt_burst = bnxt_receive_function(eth_dev);\n \teth_dev->tx_pkt_burst = bnxt_transmit_function(eth_dev);\n \n-\tpthread_mutex_lock(&bp->def_cp_lock);\n \tbnxt_schedule_fw_health_check(bp);\n-\tpthread_mutex_unlock(&bp->def_cp_lock);\n \n \treturn 0;\n \n@@ -4675,17 +4673,22 @@ void bnxt_schedule_fw_health_check(struct bnxt *bp)\n {\n \tuint32_t polling_freq;\n \n+\tpthread_mutex_lock(&bp->health_check_lock);\n+\n \tif (!bnxt_is_recovery_enabled(bp))\n-\t\treturn;\n+\t\tgoto done;\n \n \tif (bp->flags & BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED)\n-\t\treturn;\n+\t\tgoto done;\n \n \tpolling_freq = bp->recovery_info->driver_polling_freq;\n \n \trte_eal_alarm_set(US_PER_MS * polling_freq,\n \t\t\t bnxt_check_fw_health, (void *)bp);\n \tbp->flags |= BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED;\n+\n+done:\n+\tpthread_mutex_unlock(&bp->health_check_lock);\n }\n \n static void bnxt_cancel_fw_health_check(struct bnxt *bp)\n@@ -5473,6 +5476,10 @@ bnxt_init_locks(struct bnxt *bp)\n \terr = pthread_mutex_init(&bp->def_cp_lock, NULL);\n \tif (err)\n \t\tPMD_DRV_LOG(ERR, \"Unable to initialize def_cp_lock\\n\");\n+\n+\terr = pthread_mutex_init(&bp->health_check_lock, NULL);\n+\tif (err)\n+\t\tPMD_DRV_LOG(ERR, \"Unable to initialize health_check_lock\\n\");\n \treturn err;\n }\n \n@@ -5884,6 +5891,7 @@ bnxt_uninit_locks(struct bnxt *bp)\n {\n \tpthread_mutex_destroy(&bp->flow_lock);\n \tpthread_mutex_destroy(&bp->def_cp_lock);\n+\tpthread_mutex_destroy(&bp->health_check_lock);\n \tif (bp->rep_info) {\n \t\tpthread_mutex_destroy(&bp->rep_info->vfr_lock);\n \t\tpthread_mutex_destroy(&bp->rep_info->vfr_start_lock);\n", "prefixes": [ "v2", "25/25" ] }