Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7776/?format=api
{ "id": 7776, "url": "https://patches.dpdk.org/api/patches/7776/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1445351774-4459-3-git-send-email-piotrx.t.azarewicz@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1445351774-4459-3-git-send-email-piotrx.t.azarewicz@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1445351774-4459-3-git-send-email-piotrx.t.azarewicz@intel.com", "date": "2015-10-20T14:36:13", "name": "[dpdk-dev,v3,2/3] port: fix ras ring ports", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fb2de1683b235626a6dbb6542d345a7fc95d5312", "submitter": { "id": 273, "url": "https://patches.dpdk.org/api/people/273/?format=api", "name": "Piotr Azarewicz", "email": "piotrx.t.azarewicz@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1445351774-4459-3-git-send-email-piotrx.t.azarewicz@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/7776/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/7776/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id B36308E83;\n\tTue, 20 Oct 2015 16:40:46 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 04F0511F5\n\tfor <dev@dpdk.org>; Tue, 20 Oct 2015 16:40:45 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga102.jf.intel.com with ESMTP; 20 Oct 2015 07:39:54 -0700", "from unknown (HELO stargo) ([10.217.248.233])\n\tby orsmga002.jf.intel.com with SMTP; 20 Oct 2015 07:39:51 -0700", "by stargo (sSMTP sendmail emulation);\n\tTue, 20 Oct 2015 16:40:48 +0200" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,707,1437462000\"; d=\"scan'208\";a=\"830922382\"", "From": "Piotr Azarewicz <piotrx.t.azarewicz@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 20 Oct 2015 16:36:13 +0200", "Message-Id": "<1445351774-4459-3-git-send-email-piotrx.t.azarewicz@intel.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1445351774-4459-1-git-send-email-piotrx.t.azarewicz@intel.com>", "References": "<1443088539-28194-1-git-send-email-piotrx.t.azarewicz@intel.com>\n\t<1445351774-4459-1-git-send-email-piotrx.t.azarewicz@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 2/3] port: fix ras ring ports", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Bug fixes for ring ports with IPv4/IPv6 reassembly support.\nPrevious implementation can't work properly due to incorrect choosing\nprocess function.\nAlso, assuming that, when processing ip packet, ip header is know we can\nset l3_len parameter here.\n\nFixes: 50f54a84dfb7 (\"port: add IPv6 reassembly port\")\n\nSigned-off-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>\n---\n lib/librte_port/rte_port_ras.c | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_port/rte_port_ras.c b/lib/librte_port/rte_port_ras.c\nindex 6bd0f8c..e45d450 100644\n--- a/lib/librte_port/rte_port_ras.c\n+++ b/lib/librte_port/rte_port_ras.c\n@@ -144,7 +144,7 @@ rte_port_ring_writer_ras_create(void *params, int socket_id, int is_ipv4)\n \tport->tx_burst_sz = conf->tx_burst_sz;\n \tport->tx_buf_count = 0;\n \n-\tport->f_ras = (is_ipv4 == 0) ? process_ipv4 : process_ipv6;\n+\tport->f_ras = (is_ipv4 == 1) ? process_ipv4 : process_ipv6;\n \n \treturn port;\n }\n@@ -182,7 +182,7 @@ process_ipv4(struct rte_port_ring_writer_ras *p, struct rte_mbuf *pkt)\n \t/* Assume there is no ethernet header */\n \tstruct ipv4_hdr *pkt_hdr = rte_pktmbuf_mtod(pkt, struct ipv4_hdr *);\n \n-\t/* Get \"Do not fragment\" flag and fragment offset */\n+\t/* Get \"More fragments\" flag and fragment offset */\n \tuint16_t frag_field = rte_be_to_cpu_16(pkt_hdr->fragment_offset);\n \tuint16_t frag_offset = (uint16_t)(frag_field & IPV4_HDR_OFFSET_MASK);\n \tuint16_t frag_flag = (uint16_t)(frag_field & IPV4_HDR_MF_FLAG);\n@@ -195,6 +195,8 @@ process_ipv4(struct rte_port_ring_writer_ras *p, struct rte_mbuf *pkt)\n \t\tstruct rte_ip_frag_tbl *tbl = p->frag_tbl;\n \t\tstruct rte_ip_frag_death_row *dr = &p->death_row;\n \n+\t\tpkt->l3_len = sizeof(*pkt_hdr);\n+\n \t\t/* Process this fragment */\n \t\tmo = rte_ipv4_frag_reassemble_packet(tbl, dr, pkt, rte_rdtsc(),\n \t\t\t\tpkt_hdr);\n@@ -224,6 +226,8 @@ process_ipv6(struct rte_port_ring_writer_ras *p, struct rte_mbuf *pkt)\n \t\tstruct rte_ip_frag_tbl *tbl = p->frag_tbl;\n \t\tstruct rte_ip_frag_death_row *dr = &p->death_row;\n \n+\t\tpkt->l3_len = sizeof(*pkt_hdr) + sizeof(*frag_hdr);\n+\n \t\t/* Process this fragment */\n \t\tmo = rte_ipv6_frag_reassemble_packet(tbl, dr, pkt, rte_rdtsc(), pkt_hdr,\n \t\t\t\tfrag_hdr);\n", "prefixes": [ "dpdk-dev", "v3", "2/3" ] }