Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7774/?format=api
{ "id": 7774, "url": "https://patches.dpdk.org/api/patches/7774/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1445350066-31818-1-git-send-email-n.kalyazin@samsung.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1445350066-31818-1-git-send-email-n.kalyazin@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1445350066-31818-1-git-send-email-n.kalyazin@samsung.com", "date": "2015-10-20T14:07:46", "name": "[dpdk-dev] vhost: call write barrier before used index update", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "e4dfea126e5856b72a05f5bda8ae42bab961c728", "submitter": { "id": 234, "url": "https://patches.dpdk.org/api/people/234/?format=api", "name": "Nikita Kalyazin", "email": "n.kalyazin@samsung.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1445350066-31818-1-git-send-email-n.kalyazin@samsung.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/7774/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/7774/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 7B3768E82;\n\tTue, 20 Oct 2015 16:08:26 +0200 (CEST)", "from mailout2.w1.samsung.com (mailout2.w1.samsung.com\n\t[210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 5CE6C8E7C\n\tfor <dev@dpdk.org>; Tue, 20 Oct 2015 16:08:24 +0200 (CEST)", "from eucpsbgm2.samsung.com (unknown [203.254.199.245])\n\tby mailout2.w1.samsung.com\n\t(Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5\n\t2014)) with ESMTP id <0NWI000JZV9YUX00@mailout2.w1.samsung.com> for\n\tdev@dpdk.org; Tue, 20 Oct 2015 15:08:22 +0100 (BST)", "from eusync3.samsung.com ( [203.254.199.213])\n\tby eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 33.45.05269.6DA46265;\n\tTue, 20 Oct 2015 15:08:22 +0100 (BST)", "from localhost ([106.109.131.58])\n\tby eusync3.samsung.com (Oracle Communications Messaging Server\n\t7.0.5.31.0 64bit (built May 5 2014))\n\twith ESMTPA id <0NWI005JAV9Y1V50@eusync3.samsung.com>; Tue,\n\t20 Oct 2015 15:08:22 +0100 (BST)" ], "X-AuditID": "cbfec7f5-f794b6d000001495-f1-56264ad6117d", "From": "Nikita Kalyazin <n.kalyazin@samsung.com>", "To": "dev@dpdk.org", "Date": "Tue, 20 Oct 2015 17:07:46 +0300", "Message-id": "<1445350066-31818-1-git-send-email-n.kalyazin@samsung.com>", "X-Mailer": "git-send-email 2.5.3", "X-Brightmail-Tracker": "H4sIAAAAAAAAA+NgFrrKJMWRmVeSWpSXmKPExsVy+t/xq7rXvNTCDFZ3yFi8+7SdyeLK7GmM\n\tFpNnSzkwe/xasJTVo2/LKsYApigum5TUnMyy1CJ9uwSujDdb0gt2c1e8P7+GpYFxC2cXIyeH\n\thICJxP0VP5ggbDGJC/fWs3UxcnEICSxllGjomMQGkhAS+MoocXVVdhcjBwebgJ7E6dPBIGER\n\tAQGJz52LwUqYBUIk7s1dxAhiCws4S2y518kKYrMIqErcmToFzOYVcJNY++8BI8gYCQE5ie6d\n\tbhMYuRcwMqxiFE0tTS4oTkrPNdIrTswtLs1L10vOz93ECPHs1x2MS49ZHWIU4GBU4uHViFEN\n\tE2JNLCuuzD3EKMHBrCTC2yagFibEm5JYWZValB9fVJqTWnyIUZqDRUmcd+au9yFCAumJJanZ\n\tqakFqUUwWSYOTqkGxkOBKzfGMa4/y2WzQyT1wBsGM/fgO0dNzG5zn+o/4ZG6Up974VyeSzcn\n\tZusKPVSK2MsQZWDk/SdphofNFFVP9j+XJkvv9nfIq5K9EnSHc6rutr1CtnEZL/MS2pZ96zH9\n\tqyhSHZJ+28MsOuS1mcydy7l7OEtVEv2P3l5/I2DNS0VPre3RDHZrlFiKMxINtZiLihMB098U\n\tIOgBAAA=", "Cc": "Dyasly Sergey <s.dyasly@samsung.com>", "Subject": "[dpdk-dev] [PATCH] vhost: call write barrier before used index\n\tupdate", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Descriptors that have been put into the used vring must be observable by\nguest earlier than the new used index value.\nAlthough compiler barrier serves well for Intel architectue here, the\nproper cross-platform solution is to use write barrier before the used\nindex is updated.\n\nSigned-off-by: Nikita Kalyazin <n.kalyazin@samsung.com>\n---\n lib/librte_vhost/vhost_rxtx.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost_rxtx.c b/lib/librte_vhost/vhost_rxtx.c\nindex 7026bfa..d955287 100644\n--- a/lib/librte_vhost/vhost_rxtx.c\n+++ b/lib/librte_vhost/vhost_rxtx.c\n@@ -216,7 +216,7 @@ virtio_dev_rx(struct virtio_net *dev, uint16_t queue_id,\n \t\t}\n \t}\n \n-\trte_compiler_barrier();\n+\trte_wmb();\n \n \t/* Wait until it's our turn to add our buffer to the used ring. */\n \twhile (unlikely(vq->last_used_idx != res_base_idx))\n@@ -512,7 +512,7 @@ virtio_dev_merge_rx(struct virtio_net *dev, uint16_t queue_id,\n \t\tentry_success = copy_from_mbuf_to_vring(dev, res_base_idx,\n \t\t\tres_cur_idx, pkts[pkt_idx]);\n \n-\t\trte_compiler_barrier();\n+\t\trte_wmb();\n \n \t\t/*\n \t\t * Wait until it's our turn to add our buffer\n@@ -751,7 +751,7 @@ rte_vhost_dequeue_burst(struct virtio_net *dev, uint16_t queue_id,\n \t\tentry_success++;\n \t}\n \n-\trte_compiler_barrier();\n+\trte_wmb();\n \tvq->used->idx += entry_success;\n \t/* Kick guest if required. */\n \tif (!(vq->avail->flags & VRING_AVAIL_F_NO_INTERRUPT))\n", "prefixes": [ "dpdk-dev" ] }