Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7761/?format=api
{ "id": 7761, "url": "https://patches.dpdk.org/api/patches/7761/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1445337258-6101-1-git-send-email-maryam.tahhan@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1445337258-6101-1-git-send-email-maryam.tahhan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1445337258-6101-1-git-send-email-maryam.tahhan@intel.com", "date": "2015-10-20T10:34:18", "name": "[dpdk-dev,v2,1/1] ethdev: remove the imissed deprecation tag", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "af9e4685a5c68b184e898b0ed5800e32ced14307", "submitter": { "id": 259, "url": "https://patches.dpdk.org/api/people/259/?format=api", "name": "Tahhan, Maryam", "email": "maryam.tahhan@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1445337258-6101-1-git-send-email-maryam.tahhan@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/7761/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/7761/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 98E208E7C;\n\tTue, 20 Oct 2015 12:34:25 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id E81EB8E7A\n\tfor <dev@dpdk.org>; Tue, 20 Oct 2015 12:34:23 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga101.jf.intel.com with ESMTP; 20 Oct 2015 03:34:22 -0700", "from sie-lab-212-170.ir.intel.com (HELO\n\tsilpixa00378251.ir.intel.com) ([10.237.212.170])\n\tby orsmga003.jf.intel.com with ESMTP; 20 Oct 2015 03:34:21 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,707,1437462000\"; d=\"scan'208\";a=\"667923551\"", "From": "Maryam Tahhan <maryam.tahhan@intel.com>", "To": "dev@dpdk.org", "Date": "Tue, 20 Oct 2015 11:34:18 +0100", "Message-Id": "<1445337258-6101-1-git-send-email-maryam.tahhan@intel.com>", "X-Mailer": "git-send-email 2.4.3", "Subject": "[dpdk-dev] [PATCH v2 1/1] ethdev: remove the imissed deprecation tag", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Remove the deprecation tag and notice for imissed as it is a generic\nregister that accounts for packets that were dropped by the HW,\nbecause there are no available mbufs (RX queues are full). imissed is\ndifferent to ierrors and can help with general debug.\n\nFixes: 49f386542af4 (\"ethdev: remove driver specific stats\")\n\nSigned-off-by: Maryam Tahhan <maryam.tahhan@intel.com>\n---\nv2:\n - Clarify why imissed is no longer deprecated.\n - Improve definition of imissed in the documentation.\n---\n doc/guides/rel_notes/deprecation.rst | 2 +-\n lib/librte_ether/rte_ethdev.h | 4 +++-\n 2 files changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex fa55117..c4babbd 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -14,7 +14,7 @@ Deprecation Notices\n All binaries will need to be rebuilt from release 2.2.\n \n * The following fields have been deprecated in rte_eth_stats:\n- imissed, ibadcrc, ibadlen, imcasts, fdirmatch, fdirmiss,\n+ ibadcrc, ibadlen, imcasts, fdirmatch, fdirmiss,\n tx_pause_xon, rx_pause_xon, tx_pause_xoff, rx_pause_xoff\n \n * ABI changes are planned for struct rte_eth_fdir_flow_ext in order to support\ndiff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h\nindex 8a8c82b..d404f85 100644\n--- a/lib/librte_ether/rte_ethdev.h\n+++ b/lib/librte_ether/rte_ethdev.h\n@@ -195,7 +195,9 @@ struct rte_eth_stats {\n \tuint64_t ibytes; /**< Total number of successfully received bytes. */\n \tuint64_t obytes; /**< Total number of successfully transmitted bytes. */\n \tuint64_t imissed;\n-\t/**< Deprecated; Total of RX missed packets (e.g full FIFO). */\n+\t/**< Total of RX missed packets (packets that were dropped by the HW,\n+\t * because there are no available mbufs i.e. RX queues are full).\n+\t */\n \tuint64_t ibadcrc;\n \t/**< Deprecated; Total of RX packets with CRC error. */\n \tuint64_t ibadlen;\n", "prefixes": [ "dpdk-dev", "v2", "1/1" ] }