Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77565/?format=api
{ "id": 77565, "url": "https://patches.dpdk.org/api/patches/77565/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200913220711.3768597-15-thomas@monjalon.net/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200913220711.3768597-15-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20200913220711.3768597-15-thomas@monjalon.net", "date": "2020-09-13T22:07:05", "name": "[14/20] net/softnic: release port upon close", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "d2536759847c2aab5adf14f687ba42b11fef807e", "submitter": { "id": 685, "url": "https://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200913220711.3768597-15-thomas@monjalon.net/mbox/", "series": [ { "id": 12173, "url": "https://patches.dpdk.org/api/series/12173/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12173", "date": "2020-09-13T22:06:51", "name": "cleanup ethdev close operation", "version": 1, "mbox": "https://patches.dpdk.org/series/12173/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/77565/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/77565/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5DB25A04C9;\n\tMon, 14 Sep 2020 00:09:26 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2011F1C0B9;\n\tMon, 14 Sep 2020 00:08:30 +0200 (CEST)", "from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com\n [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 86AA51C12A\n for <dev@dpdk.org>; Mon, 14 Sep 2020 00:08:28 +0200 (CEST)", "from compute7.internal (compute7.nyi.internal [10.202.2.47])\n by mailout.west.internal (Postfix) with ESMTP id 7098E4A2;\n Sun, 13 Sep 2020 18:08:27 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n by compute7.internal (MEProxy); Sun, 13 Sep 2020 18:08:27 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n by mail.messagingengine.com (Postfix) with ESMTPA id 36A3C3064674;\n Sun, 13 Sep 2020 18:08:26 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding; s=fm2; bh=GKH9ZceWtvxkJ\n v7aVTxzAETGsGNLGvPSWHnufabDmZI=; b=jmVn0ra5ooH0wZxpC/OYuZxK2no3U\n 2Y7+RVyNE6v5t+QraMLDVvF8ZdI7tyOA5g5ByLvslALjEgvgxsd0+P3pna2aQFSE\n aP02U5THUrJpYRVwSGIq+Z2z95VR5R/YjRqUZWypnJoIaiaEBUYe2Y87Sm9blk8U\n 6p6eykJLZFN7g20a5ffodPlY3bvPIjBqK8Iva0626CjElJOuRzwRBgjiwaKfDLDA\n lzF6zps9DOvcEmL/ZFTLjVxVFPqflTxD+Y4n5UP/55aG+3qCLNOzQhqqUO6yN135\n ZmZVf6FZ1RSfsoni4RvgiFf5MSln5pXD6dajY5i5HuZgqnP5MYGg9ad4A==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n messagingengine.com; h=cc:content-transfer-encoding:date:from\n :in-reply-to:message-id:mime-version:references:subject:to\n :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n fm3; bh=GKH9ZceWtvxkJv7aVTxzAETGsGNLGvPSWHnufabDmZI=; b=PjAZRJNl\n kYCkHkfi2eB0vqlOb+/Lmovzar29wuTT/KLFaOqgNYVlQtkGQhCYl3PLuKDkOt2z\n o8MvjklYDt86WhAzKtewgospxZQwuiut6AVGFj7lFCvWPuUVUyTuTnaF7KFv/Mt4\n JxvX1UrJztBMXf8sSUi8WtVZiDZzbBNlgvOXBJSzl6tTtqxgRQHe7GblnJFf9hEV\n kVhP/Fd4iSVSlVtSlfPT/QRoA6e0PuWreQfqutOpcZsn8MTkCuYu8eeNsP4HK/P6\n lg9WJFBKIvu4lp2kPKinWS/iiVu6XG/Z0m6JRd9MQszv0OgffnxOc64xXn9eu5C6\n 3VfanOwbObPc1w==" ], "X-ME-Sender": "<xms:WpheX97JAZM-_cjtpL2ZkhmQie1a56utSA29WQcuiEUWYcOWLsDWiA>\n <xme:WpheX66DvhdgTXu5POQ4j7CRWqwHx8Xd668mmvlyXA5C6x_hU9hQBoxCEQfH0-Y_4\n YSJqNqn6Y0IOc28OA>", "X-ME-Proxy-Cause": "\n gggruggvucftvghtrhhoucdtuddrgeduiedrudeihedgtdehucetufdoteggodetrfdotf\n fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen\n uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne\n cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr\n shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg\n ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg\n uedthedtgeevnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf\n hiiigvpedufeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr\n lhhonhdrnhgvth", "X-ME-Proxy": "<xmx:WpheX0e9NIZifwV7KHKE5HuB84WKXLjvjzObrbGWhxWmTI1dJV1e3Q>\n <xmx:WpheX2LN2dr4JDgaCAFfRytUYzCO1UAkUaUk0cqfSWgIijV1BfxUPQ>\n <xmx:WpheXxJD3mu1c0JGRcEsY4UCuar_Gg27rQ8D_7M5r6GuKg9v2YOMcw>\n <xmx:W5heX4Xgs4_4cSz8NYXxFydQlpYVzEntzXNMVJtML9UlampJcwUvJA>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, arybchenko@solarflare.com,\n Jasvinder Singh <jasvinder.singh@intel.com>,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>", "Date": "Mon, 14 Sep 2020 00:07:05 +0200", "Message-Id": "<20200913220711.3768597-15-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20200913220711.3768597-1-thomas@monjalon.net>", "References": "<20200913220711.3768597-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 14/20] net/softnic: release port upon close", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources\ncan be freed by rte_eth_dev_close().\n\nFreeing of private port resources is moved\nfrom the \".remove(device)\" to the \".dev_close(port)\" operation.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n drivers/net/softnic/rte_eth_softnic.c | 63 ++++++++++++++-------------\n 1 file changed, 32 insertions(+), 31 deletions(-)", "diff": "diff --git a/drivers/net/softnic/rte_eth_softnic.c b/drivers/net/softnic/rte_eth_softnic.c\nindex 491a308c11..5b94e250d8 100644\n--- a/drivers/net/softnic/rte_eth_softnic.c\n+++ b/drivers/net/softnic/rte_eth_softnic.c\n@@ -201,9 +201,37 @@ pmd_dev_stop(struct rte_eth_dev *dev)\n \tsoftnic_mtr_free(p);\n }\n \n+static void\n+pmd_free(struct pmd_internals *p)\n+{\n+\tif (p == NULL)\n+\t\treturn;\n+\n+\tif (p->params.conn_port)\n+\t\tsoftnic_conn_free(p->conn);\n+\n+\tsoftnic_thread_free(p);\n+\tsoftnic_pipeline_free(p);\n+\tsoftnic_table_action_profile_free(p);\n+\tsoftnic_port_in_action_profile_free(p);\n+\tsoftnic_tap_free(p);\n+\tsoftnic_tmgr_free(p);\n+\tsoftnic_link_free(p);\n+\tsoftnic_swq_free(p);\n+\tsoftnic_mempool_free(p);\n+\n+\ttm_hierarchy_free(p);\n+\tsoftnic_mtr_free(p);\n+\n+\trte_free(p);\n+}\n+\n static int\n-pmd_dev_close(struct rte_eth_dev *dev __rte_unused)\n+pmd_dev_close(struct rte_eth_dev *dev)\n {\n+\tpmd_free(dev->data->dev_private);\n+\tdev->data->dev_private = NULL; /* already freed */\n+\tdev->data->mac_addrs = NULL; /* statically allocated */\n \treturn 0;\n }\n \n@@ -335,31 +363,6 @@ pmd_init(struct pmd_params *params)\n \treturn p;\n }\n \n-static void\n-pmd_free(struct pmd_internals *p)\n-{\n-\tif (p == NULL)\n-\t\treturn;\n-\n-\tif (p->params.conn_port)\n-\t\tsoftnic_conn_free(p->conn);\n-\n-\tsoftnic_thread_free(p);\n-\tsoftnic_pipeline_free(p);\n-\tsoftnic_table_action_profile_free(p);\n-\tsoftnic_port_in_action_profile_free(p);\n-\tsoftnic_tap_free(p);\n-\tsoftnic_tmgr_free(p);\n-\tsoftnic_link_free(p);\n-\tsoftnic_swq_free(p);\n-\tsoftnic_mempool_free(p);\n-\n-\ttm_hierarchy_free(p);\n-\tsoftnic_mtr_free(p);\n-\n-\trte_free(p);\n-}\n-\n static struct rte_ether_addr eth_addr = {\n \t.addr_bytes = {0},\n };\n@@ -384,6 +387,7 @@ pmd_ethdev_register(struct rte_vdev_device *vdev,\n \tdev->device = &vdev->device;\n \n \t/* dev->data */\n+\tdev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \tdev->data->dev_private = dev_private;\n \tdev->data->dev_link.link_speed = ETH_SPEED_NUM_100G;\n \tdev->data->dev_link.link_duplex = ETH_LINK_FULL_DUPLEX;\n@@ -653,12 +657,9 @@ pmd_remove(struct rte_vdev_device *vdev)\n \t/* Find the ethdev entry */\n \tdev = rte_eth_dev_allocated(rte_vdev_device_name(vdev));\n \tif (dev == NULL)\n-\t\treturn -ENODEV;\n+\t\treturn 0; /* port already released */\n \n-\t/* Free device data structures*/\n-\tpmd_free(dev->data->dev_private);\n-\tdev->data->dev_private = NULL; /* already freed */\n-\tdev->data->mac_addrs = NULL; /* statically allocated */\n+\tpmd_dev_close(dev);\n \trte_eth_dev_release_port(dev);\n \n \treturn 0;\n", "prefixes": [ "14/20" ] }