Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77461/?format=api
{ "id": 77461, "url": "https://patches.dpdk.org/api/patches/77461/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200911163334.86448-1-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200911163334.86448-1-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200911163334.86448-1-maxime.coquelin@redhat.com", "date": "2020-09-11T16:33:34", "name": "vhost: remove experimental tag on vDPA API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "64d927bfa2930535f8850e273b0384c19ac62a72", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200911163334.86448-1-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 12158, "url": "https://patches.dpdk.org/api/series/12158/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12158", "date": "2020-09-11T16:33:34", "name": "vhost: remove experimental tag on vDPA API", "version": 1, "mbox": "https://patches.dpdk.org/series/12158/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/77461/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/77461/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 97704A04BB;\n\tFri, 11 Sep 2020 18:33:47 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 06385E07;\n\tFri, 11 Sep 2020 18:33:47 +0200 (CEST)", "from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com\n [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 55C21255\n for <dev@dpdk.org>; Fri, 11 Sep 2020 18:33:46 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-466-1PHx1a5LOnKbeJ4Dg3PO0g-1; Fri, 11 Sep 2020 12:33:43 -0400", "from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com\n [10.5.11.22])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4325981F01E;\n Fri, 11 Sep 2020 16:33:42 +0000 (UTC)", "from localhost.localdomain (unknown [10.36.110.16])\n by smtp.corp.redhat.com (Postfix) with ESMTP id B1B951002D4E;\n Fri, 11 Sep 2020 16:33:37 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1599842025;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=2CO6Ak9z0b2PbY+sEENvz6JdXoY7AewsQMreGEhbGQE=;\n b=hj7LwCm6fQQlEQxsheSYvCM8y0AddOg6ctUaKPnzVP5h7IT7JB17sVcogZ/BdZG7zJacz0\n K6tYdz2XFfrLtntHyIDe0C191fdqB00HzG+My22u/9I4DLW5/mO20stdGzWSIkQsSWsona\n D5WeFHRUEdtc69SP16poIzTxooHbUgc=", "X-MC-Unique": "1PHx1a5LOnKbeJ4Dg3PO0g-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org,\n\tchenbo.xia@intel.com,\n\tmatan@nvidia.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Fri, 11 Sep 2020 18:33:34 +0200", "Message-Id": "<20200911163334.86448-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.22", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0.001", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] vhost: remove experimental tag on vDPA API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "As announced in v20.08, this patch makes the vDPA\nand related Vhost API stable.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/rte_vdpa.h | 36 --------------------------\n lib/librte_vhost/rte_vdpa_dev.h | 16 ------------\n lib/librte_vhost/rte_vhost.h | 6 -----\n lib/librte_vhost/rte_vhost_version.map | 34 ++++++++++++------------\n 4 files changed, 17 insertions(+), 75 deletions(-)", "diff": "diff --git a/lib/librte_vhost/rte_vdpa.h b/lib/librte_vhost/rte_vdpa.h\nindex 5065e2130e..f074ec0c4a 100644\n--- a/lib/librte_vhost/rte_vdpa.h\n+++ b/lib/librte_vhost/rte_vdpa.h\n@@ -42,9 +42,6 @@ struct rte_vdpa_stat_name {\n };\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n- *\n * Find the device id of a vdpa device from its name\n *\n * @param name\n@@ -52,14 +49,10 @@ struct rte_vdpa_stat_name {\n * @return\n * vDPA device pointer on success, NULL on failure\n */\n-__rte_experimental\n struct rte_vdpa_device *\n rte_vdpa_find_device_by_name(const char *name);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n- *\n * Get the generic device from the vdpa device\n *\n * @param vdpa_dev\n@@ -67,14 +60,10 @@ rte_vdpa_find_device_by_name(const char *name);\n * @return\n * generic device pointer on success, NULL on failure\n */\n-__rte_experimental\n struct rte_device *\n rte_vdpa_get_rte_device(struct rte_vdpa_device *vdpa_dev);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n- *\n * Get number of queue pairs supported by the vDPA device\n *\n * @param dev\n@@ -84,14 +73,10 @@ rte_vdpa_get_rte_device(struct rte_vdpa_device *vdpa_dev);\n * @return\n * 0 on success, -1 on failure\n */\n-__rte_experimental\n int\n rte_vdpa_get_queue_num(struct rte_vdpa_device *dev, uint32_t *queue_num);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n- *\n * Get the Virtio features supported by the vDPA device\n *\n * @param dev\n@@ -101,14 +86,10 @@ rte_vdpa_get_queue_num(struct rte_vdpa_device *dev, uint32_t *queue_num);\n * @return\n * 0 on success, -1 on failure\n */\n-__rte_experimental\n int\n rte_vdpa_get_features(struct rte_vdpa_device *dev, uint64_t *features);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n- *\n * Get the Vhost-user protocol features supported by the vDPA device\n *\n * @param dev\n@@ -118,14 +99,10 @@ rte_vdpa_get_features(struct rte_vdpa_device *dev, uint64_t *features);\n * @return\n * 0 on success, -1 on failure\n */\n-__rte_experimental\n int\n rte_vdpa_get_protocol_features(struct rte_vdpa_device *dev, uint64_t *features);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n- *\n * Synchronize the used ring from mediated ring to guest, log dirty\n * page for each writeable buffer, caller should handle the used\n * ring logging before device stop.\n@@ -139,14 +116,10 @@ rte_vdpa_get_protocol_features(struct rte_vdpa_device *dev, uint64_t *features);\n * @return\n * number of synced used entries on success, -1 on failure\n */\n-__rte_experimental\n int\n rte_vdpa_relay_vring_used(int vid, uint16_t qid, void *vring_m);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n- *\n * Retrieve names of statistics of a vDPA device.\n *\n * There is an assumption that 'stat_names' and 'stats' arrays are matched\n@@ -166,16 +139,12 @@ rte_vdpa_relay_vring_used(int vid, uint16_t qid, void *vring_m);\n * A negative value on error, otherwise the number of entries filled in the\n * stats name array.\n */\n-__rte_experimental\n int\n rte_vdpa_get_stats_names(struct rte_vdpa_device *dev,\n \t\tstruct rte_vdpa_stat_name *stats_names,\n \t\tunsigned int size);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n- *\n * Retrieve statistics of a vDPA device.\n *\n * There is an assumption that 'stat_names' and 'stats' arrays are matched\n@@ -197,14 +166,10 @@ rte_vdpa_get_stats_names(struct rte_vdpa_device *dev,\n * A negative value on error, otherwise the number of entries filled in the\n * stats table.\n */\n-__rte_experimental\n int\n rte_vdpa_get_stats(struct rte_vdpa_device *dev, uint16_t qid,\n \t\tstruct rte_vdpa_stat *stats, unsigned int n);\n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n- *\n * Reset statistics of a vDPA device.\n *\n * @param dev\n@@ -214,7 +179,6 @@ rte_vdpa_get_stats(struct rte_vdpa_device *dev, uint16_t qid,\n * @return\n * 0 on success, a negative value on error.\n */\n-__rte_experimental\n int\n rte_vdpa_reset_stats(struct rte_vdpa_device *dev, uint16_t qid);\n #endif /* _RTE_VDPA_H_ */\ndiff --git a/lib/librte_vhost/rte_vdpa_dev.h b/lib/librte_vhost/rte_vdpa_dev.h\nindex 89444c2ea1..a60183f780 100644\n--- a/lib/librte_vhost/rte_vdpa_dev.h\n+++ b/lib/librte_vhost/rte_vdpa_dev.h\n@@ -78,9 +78,6 @@ struct rte_vdpa_device {\n };\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n- *\n * Register a vdpa device\n *\n * @param rte_dev\n@@ -90,15 +87,11 @@ struct rte_vdpa_device {\n * @return\n * vDPA device pointer on success, NULL on failure\n */\n-__rte_experimental\n struct rte_vdpa_device *\n rte_vdpa_register_device(struct rte_device *rte_dev,\n \t\tstruct rte_vdpa_dev_ops *ops);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n- *\n * Unregister a vdpa device\n *\n * @param dev\n@@ -106,14 +99,10 @@ rte_vdpa_register_device(struct rte_device *rte_dev,\n * @return\n * device id on success, -1 on failure\n */\n-__rte_experimental\n int\n rte_vdpa_unregister_device(struct rte_vdpa_device *dev);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n- *\n * Enable/Disable host notifier mapping for a vdpa port.\n *\n * @param vid\n@@ -125,14 +114,10 @@ rte_vdpa_unregister_device(struct rte_vdpa_device *dev);\n * @return\n * 0 on success, -1 on failure\n */\n-__rte_experimental\n int\n rte_vhost_host_notifier_ctrl(int vid, uint16_t qid, bool enable);\n \n /**\n- * @warning\n- * @b EXPERIMENTAL: this API may change without prior notice\n- *\n * Synchronize the used ring from mediated ring to guest, log dirty\n * page for each writeable buffer, caller should handle the used\n * ring logging before device stop.\n@@ -146,7 +131,6 @@ rte_vhost_host_notifier_ctrl(int vid, uint16_t qid, bool enable);\n * @return\n * number of synced used entries on success, -1 on failure\n */\n-__rte_experimental\n int\n rte_vdpa_relay_vring_used(int vid, uint16_t qid, void *vring_m);\n \ndiff --git a/lib/librte_vhost/rte_vhost.h b/lib/librte_vhost/rte_vhost.h\nindex a94c84134d..883a334cb4 100644\n--- a/lib/librte_vhost/rte_vhost.h\n+++ b/lib/librte_vhost/rte_vhost.h\n@@ -430,7 +430,6 @@ int rte_vhost_driver_unregister(const char *path);\n * @return\n * 0 on success, -1 on failure\n */\n-__rte_experimental\n int\n rte_vhost_driver_attach_vdpa_device(const char *path,\n \t\tstruct rte_vdpa_device *dev);\n@@ -443,7 +442,6 @@ rte_vhost_driver_attach_vdpa_device(const char *path,\n * @return\n * 0 on success, -1 on failure\n */\n-__rte_experimental\n int\n rte_vhost_driver_detach_vdpa_device(const char *path);\n \n@@ -455,7 +453,6 @@ rte_vhost_driver_detach_vdpa_device(const char *path);\n * @return\n * vDPA device pointer, NULL on failure\n */\n-__rte_experimental\n struct rte_vdpa_device *\n rte_vhost_driver_get_vdpa_device(const char *path);\n \n@@ -913,7 +910,6 @@ uint32_t rte_vhost_rx_queue_count(int vid, uint16_t qid);\n * @return\n * 0 on success, -1 on failure\n */\n-__rte_experimental\n int\n rte_vhost_get_log_base(int vid, uint64_t *log_base, uint64_t *log_size);\n \n@@ -931,7 +927,6 @@ rte_vhost_get_log_base(int vid, uint64_t *log_base, uint64_t *log_size);\n * @return\n * 0 on success, -1 on failure\n */\n-__rte_experimental\n int\n rte_vhost_get_vring_base(int vid, uint16_t queue_id,\n \t\tuint16_t *last_avail_idx, uint16_t *last_used_idx);\n@@ -973,7 +968,6 @@ rte_vhost_get_vring_base_from_inflight(int vid,\n * @return\n * 0 on success, -1 on failure\n */\n-__rte_experimental\n int\n rte_vhost_set_vring_base(int vid, uint16_t queue_id,\n \t\tuint16_t last_avail_idx, uint16_t last_used_idx);\ndiff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map\nindex 20b4abcb4e..55e98e557b 100644\n--- a/lib/librte_vhost/rte_vhost_version.map\n+++ b/lib/librte_vhost/rte_vhost_version.map\n@@ -26,13 +26,10 @@ DPDK_21 {\n \trte_vhost_log_write;\n \trte_vhost_rx_queue_count;\n \trte_vhost_vring_call;\n-\n-\tlocal: *;\n-};\n-\n-EXPERIMENTAL {\n-\tglobal:\n-\n+\trte_vhost_get_log_base;\n+\trte_vhost_get_vring_base;\n+\trte_vhost_set_vring_base;\n+\trte_vhost_host_notifier_ctrl;\n \trte_vdpa_register_device;\n \trte_vdpa_unregister_device;\n \trte_vdpa_get_stats_names;\n@@ -42,19 +39,27 @@ EXPERIMENTAL {\n \trte_vhost_driver_detach_vdpa_device;\n \trte_vhost_driver_get_vdpa_device;\n \trte_vhost_get_vdpa_device;\n+\trte_vdpa_find_device_by_name;\n+\trte_vdpa_get_rte_device;\n+\trte_vdpa_get_queue_num;\n+\trte_vdpa_get_features;\n+\trte_vdpa_get_protocol_features;\n+\trte_vdpa_relay_vring_used;\n+\n+\tlocal: *;\n+};\n+\n+EXPERIMENTAL {\n+\tglobal:\n+\n \trte_vhost_driver_get_protocol_features;\n \trte_vhost_driver_get_queue_num;\n-\trte_vhost_get_log_base;\n-\trte_vhost_get_vring_base;\n-\trte_vhost_set_vring_base;\n \trte_vhost_crypto_create;\n \trte_vhost_crypto_free;\n \trte_vhost_crypto_fetch_requests;\n \trte_vhost_crypto_finalize_requests;\n \trte_vhost_crypto_set_zero_copy;\n \trte_vhost_va_from_guest_pa;\n-\trte_vhost_host_notifier_ctrl;\n-\trte_vdpa_relay_vring_used;\n \trte_vhost_extern_callback_register;\n \trte_vhost_driver_set_protocol_features;\n \trte_vhost_set_inflight_desc_split;\n@@ -66,11 +71,6 @@ EXPERIMENTAL {\n \trte_vhost_get_vhost_ring_inflight;\n \trte_vhost_get_vring_base_from_inflight;\n \trte_vhost_slave_config_change;\n-\trte_vdpa_find_device_by_name;\n-\trte_vdpa_get_rte_device;\n-\trte_vdpa_get_queue_num;\n-\trte_vdpa_get_features;\n-\trte_vdpa_get_protocol_features;\n \trte_vhost_async_channel_register;\n \trte_vhost_async_channel_unregister;\n \trte_vhost_submit_enqueue_burst;\n", "prefixes": [] }