Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/77433/?format=api
{ "id": 77433, "url": "https://patches.dpdk.org/api/patches/77433/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200911150805.79901-6-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200911150805.79901-6-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200911150805.79901-6-maxime.coquelin@redhat.com", "date": "2020-09-11T15:08:03", "name": "[5/7] net/virtio: check protocol feature in user backend", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "187871298fa884f35bc624e36875b584d4717be9", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200911150805.79901-6-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 12149, "url": "https://patches.dpdk.org/api/series/12149/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12149", "date": "2020-09-11T15:07:58", "name": "virtio-user: introduce vhost-vdpa backend", "version": 1, "mbox": "https://patches.dpdk.org/series/12149/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/77433/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/77433/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E70D6A04BB;\n\tFri, 11 Sep 2020 17:09:15 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 321161C125;\n\tFri, 11 Sep 2020 17:08:31 +0200 (CEST)", "from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com\n [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 47A321C122\n for <dev@dpdk.org>; Fri, 11 Sep 2020 17:08:29 +0200 (CEST)", "from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com\n [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id\n us-mta-145-GzbPNYbFOB6Lorrhk04org-1; Fri, 11 Sep 2020 11:08:26 -0400", "from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com\n [10.5.11.23])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3EFA3107B26B;\n Fri, 11 Sep 2020 15:08:25 +0000 (UTC)", "from localhost.localdomain (unknown [10.36.110.16])\n by smtp.corp.redhat.com (Postfix) with ESMTP id A8CC73C89;\n Fri, 11 Sep 2020 15:08:20 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1599836908;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=31xWnchkxx11sAXf55Wpatvw5tNW0olKb7fXLbLTKdk=;\n b=J8+MuGDWSrKeD1Hgs24JPAS77O1kHH++CqOqJJCmFOrh6MnLyhC8leGMpKRCuYF2IpaDZs\n d2gKYzY9U/t2d5ehU4AE0728qQ4V2gYfaBaUq0Soq93K0Oc1f0p1ReZ38+soYPfDZJfYfM\n 1GDdPfn3HYxeLdohTf5hkcIPG247kWk=", "X-MC-Unique": "GzbPNYbFOB6Lorrhk04org-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org,\n\tpatrick.fu@intel.com,\n\tamorenoz@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Fri, 11 Sep 2020 17:08:03 +0200", "Message-Id": "<20200911150805.79901-6-maxime.coquelin@redhat.com>", "In-Reply-To": "<20200911150805.79901-1-maxime.coquelin@redhat.com>", "References": "<20200911150805.79901-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.23", "Authentication-Results": "relay.mimecast.com;\n auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com", "X-Mimecast-Spam-Score": "0.001", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 5/7] net/virtio: check protocol feature in user\n\tbackend", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When sending set status message, move protocol feature check\nto vhost_user to be compatible with different backend types.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n drivers/net/virtio/virtio_user/vhost_user.c | 6 +++++-\n drivers/net/virtio/virtio_user/virtio_user_dev.c | 7 -------\n 2 files changed, 5 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user/vhost_user.c b/drivers/net/virtio/virtio_user/vhost_user.c\nindex 12b6c7dbcf..ef290c357b 100644\n--- a/drivers/net/virtio/virtio_user/vhost_user.c\n+++ b/drivers/net/virtio/virtio_user/vhost_user.c\n@@ -277,9 +277,13 @@ vhost_user_sock(struct virtio_user_dev *dev,\n \tmsg.size = 0;\n \n \tswitch (req) {\n+\tcase VHOST_USER_GET_STATUS:\n+\t\tif (!(dev->protocol_features &\n+\t\t\t\t(1ULL << VHOST_USER_PROTOCOL_F_STATUS)))\n+\t\t\treturn 0;\n+\t\t/* Fallthrough */\n \tcase VHOST_USER_GET_FEATURES:\n \tcase VHOST_USER_GET_PROTOCOL_FEATURES:\n-\tcase VHOST_USER_GET_STATUS:\n \t\tneed_reply = 1;\n \t\tbreak;\n \ndiff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex 753611ef42..97baa243cd 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -838,9 +838,6 @@ virtio_user_send_status_update(struct virtio_user_dev *dev, uint8_t status)\n \tenum virtio_user_backend_type backend_type =\n \t\t\t\tvirtio_user_backend_type(dev->path);\n \n-\tif (!(dev->protocol_features & (1ULL << VHOST_USER_PROTOCOL_F_STATUS)))\n-\t\treturn 0;\n-\n \tif (backend_type == VIRTIO_USER_BACKEND_VHOST_USER)\n \t\tret = dev->ops->send_request(dev,\n \t\t\t\tVHOST_USER_SET_STATUS, &arg);\n@@ -867,13 +864,9 @@ virtio_user_update_status(struct virtio_user_dev *dev)\n \tenum virtio_user_backend_type backend_type =\n \t\t\t\tvirtio_user_backend_type(dev->path);\n \n-\t/* Vhost-user only for now */\n \tif (backend_type != VIRTIO_USER_BACKEND_VHOST_USER)\n \t\treturn 0;\n \n-\tif (!(dev->protocol_features & (1UL << VHOST_USER_PROTOCOL_F_STATUS)))\n-\t\treturn 0;\n-\n \terr = dev->ops->send_request(dev, VHOST_USER_GET_STATUS, &ret);\n \tif (err) {\n \t\tPMD_INIT_LOG(ERR, \"VHOST_USER_GET_STATUS failed (%d): %s\", err,\n", "prefixes": [ "5/7" ] }