Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7743/?format=api
{ "id": 7743, "url": "https://patches.dpdk.org/api/patches/7743/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1445260803-210576-1-git-send-email-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1445260803-210576-1-git-send-email-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1445260803-210576-1-git-send-email-pablo.de.lara.guarch@intel.com", "date": "2015-10-19T13:20:03", "name": "[dpdk-dev] igb: fix IEEE1588 frame identification in i210", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9adc8a896c72e277d9b37860ef79c7e6815cf952", "submitter": { "id": 9, "url": "https://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1445260803-210576-1-git-send-email-pablo.de.lara.guarch@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/7743/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/7743/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 7027B8E83;\n\tMon, 19 Oct 2015 15:20:10 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id E45138E80\n\tfor <dev@dpdk.org>; Mon, 19 Oct 2015 15:20:08 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga102.fm.intel.com with ESMTP; 19 Oct 2015 06:20:08 -0700", "from sie-lab-214-036.ir.intel.com (HELO\n\tsie-lab-214-174.ir.intel.com) ([10.237.214.36])\n\tby FMSMGA003.fm.intel.com with ESMTP; 19 Oct 2015 06:20:04 -0700" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,702,1437462000\"; d=\"scan'208\";a=\"583765832\"", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "dev@dpdk.org", "Date": "Mon, 19 Oct 2015 14:20:03 +0100", "Message-Id": "<1445260803-210576-1-git-send-email-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 2.4.3", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] igb: fix IEEE1588 frame identification in i210", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fixed issue where the flag PKT_RX_IEEE1588_PTP was not being set\nin Intel I210 NIC, as EtherType in RX descriptor is in bits 8:10 of\nPacket Type and not in the default bits 0:2.\n\nFixes known issue \"IEEE1588 support possibly not working\nwith an Intel Ethernet Controller I210 NIC\"\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n doc/guides/rel_notes/known_issues.rst | 19 -------------------\n doc/guides/rel_notes/release_2_2.rst | 5 +++++\n drivers/net/e1000/igb_rxtx.c | 15 +++++++++++----\n 3 files changed, 16 insertions(+), 23 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/known_issues.rst b/doc/guides/rel_notes/known_issues.rst\nindex b9a52d0..9f1fcdb 100644\n--- a/doc/guides/rel_notes/known_issues.rst\n+++ b/doc/guides/rel_notes/known_issues.rst\n@@ -421,25 +421,6 @@ Intel® QuickAssist Technology sample application does not work on a 32-bit OS o\n All.\n \n \n-IEEE1588 support possibly not working with an Intel® Ethernet Controller I210 NIC\n----------------------------------------------------------------------------------\n-\n-**Description**:\n- IEEE1588 support is not working with an Intel® Ethernet Controller I210 NIC.\n-\n-**Implication**:\n- IEEE1588 packets are not forwarded correctly by the Intel® Ethernet Controller I210 NIC.\n-\n-**Resolution/Workaround**:\n- There is no workaround available.\n-\n-**Affected Environment/Platform**:\n- All.\n-\n-**Driver/Module**:\n- IGB Poll Mode Driver\n-\n-\n Differences in how different Intel NICs handle maximum packet length for jumbo frame\n ------------------------------------------------------------------------------------\n \ndiff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.rst\nindex 5687676..f623fdb 100644\n--- a/doc/guides/rel_notes/release_2_2.rst\n+++ b/doc/guides/rel_notes/release_2_2.rst\n@@ -39,6 +39,11 @@ Drivers\n \n Fixed issue with libvirt ``virsh destroy`` not killing the VM.\n \n+* **igb: Fixed IEEE1588 frame identification in I210.**\n+\n+ Fixed issue where the flag PKT_RX_IEEE1588_PTP was not being set\n+ in Intel I210 NIC, as EtherType in RX descriptor is in bits 8:10 of\n+ Packet Type and not in the default bits 0:2.\n \n Libraries\n ~~~~~~~~~\ndiff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c\nindex 19905fd..ebc57cf 100644\n--- a/drivers/net/e1000/igb_rxtx.c\n+++ b/drivers/net/e1000/igb_rxtx.c\n@@ -668,7 +668,7 @@ igb_rxd_pkt_info_to_pkt_type(uint16_t pkt_info)\n }\n \n static inline uint64_t\n-rx_desc_hlen_type_rss_to_pkt_flags(uint32_t hl_tp_rs)\n+rx_desc_hlen_type_rss_to_pkt_flags(struct igb_rx_queue *rxq, uint32_t hl_tp_rs)\n {\n \tuint64_t pkt_flags = ((hl_tp_rs & 0x0F) == 0) ? 0 : PKT_RX_RSS_HASH;\n \n@@ -678,7 +678,14 @@ rx_desc_hlen_type_rss_to_pkt_flags(uint32_t hl_tp_rs)\n \t\t0, 0, 0, 0,\n \t};\n \n-\tpkt_flags |= ip_pkt_etqf_map[(hl_tp_rs >> 4) & 0x07];\n+\tstruct rte_eth_dev dev = rte_eth_devices[rxq->port_id];\n+\tstruct e1000_hw *hw = E1000_DEV_PRIVATE_TO_HW(dev.data->dev_private);\n+\n+\t/* EtherType is in bits 8:10 in Packet Type, and not in the default 0:2 */\n+\tif (hw->mac.type == e1000_i210)\n+\t\tpkt_flags |= ip_pkt_etqf_map[(hl_tp_rs >> 12) & 0x07];\n+\telse\n+\t\tpkt_flags |= ip_pkt_etqf_map[(hl_tp_rs >> 4) & 0x07];\n #endif\n \n \treturn pkt_flags;\n@@ -852,7 +859,7 @@ eth_igb_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\t/* Only valid if PKT_RX_VLAN_PKT set in pkt_flags */\n \t\trxm->vlan_tci = rte_le_to_cpu_16(rxd.wb.upper.vlan);\n \n-\t\tpkt_flags = rx_desc_hlen_type_rss_to_pkt_flags(hlen_type_rss);\n+\t\tpkt_flags = rx_desc_hlen_type_rss_to_pkt_flags(rxq, hlen_type_rss);\n \t\tpkt_flags = pkt_flags | rx_desc_status_to_pkt_flags(staterr);\n \t\tpkt_flags = pkt_flags | rx_desc_error_to_pkt_flags(staterr);\n \t\trxm->ol_flags = pkt_flags;\n@@ -1088,7 +1095,7 @@ eth_igb_recv_scattered_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\t */\n \t\tfirst_seg->vlan_tci = rte_le_to_cpu_16(rxd.wb.upper.vlan);\n \t\thlen_type_rss = rte_le_to_cpu_32(rxd.wb.lower.lo_dword.data);\n-\t\tpkt_flags = rx_desc_hlen_type_rss_to_pkt_flags(hlen_type_rss);\n+\t\tpkt_flags = rx_desc_hlen_type_rss_to_pkt_flags(rxq, hlen_type_rss);\n \t\tpkt_flags = pkt_flags | rx_desc_status_to_pkt_flags(staterr);\n \t\tpkt_flags = pkt_flags | rx_desc_error_to_pkt_flags(staterr);\n \t\tfirst_seg->ol_flags = pkt_flags;\n", "prefixes": [ "dpdk-dev" ] }