Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 7733,
    "url": "https://patches.dpdk.org/api/patches/7733/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1445231772-17467-6-git-send-email-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1445231772-17467-6-git-send-email-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1445231772-17467-6-git-send-email-stephen@networkplumber.org",
    "date": "2015-10-19T05:16:12",
    "name": "[dpdk-dev,5/5] virtio: optimize transmit enqueue",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "5a88baa23c56b7dc49f3d7bc747067ae619503f7",
    "submitter": {
        "id": 27,
        "url": "https://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1445231772-17467-6-git-send-email-stephen@networkplumber.org/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/7733/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/7733/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id B96748E9C;\n\tMon, 19 Oct 2015 07:16:14 +0200 (CEST)",
            "from mail-pa0-f50.google.com (mail-pa0-f50.google.com\n\t[209.85.220.50]) by dpdk.org (Postfix) with ESMTP id 10BD98E86\n\tfor <dev@dpdk.org>; Mon, 19 Oct 2015 07:16:10 +0200 (CEST)",
            "by padhk11 with SMTP id hk11so18235420pad.1\n\tfor <dev@dpdk.org>; Sun, 18 Oct 2015 22:16:09 -0700 (PDT)",
            "from xeon-e3.home.lan (static-50-53-82-155.bvtn.or.frontiernet.net.\n\t[50.53.82.155]) by smtp.gmail.com with ESMTPSA id\n\tk10sm33681035pbq.78.2015.10.18.22.16.08\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSun, 18 Oct 2015 22:16:08 -0700 (PDT)"
        ],
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=uUxF+H0SoaSUPWiVCEWmnSCRKadZrVNHsoGAnUuMSnA=;\n\tb=I5/49sEGbbAthTYzGCC5ahTpcdyvwJ4aZwGmpa8aMCBj9nv88FiD/S92ti8zUoNIYw\n\tHgZ/1GTP93h4Q+Z+ASiSd0DYE9UVPApEg1gd9EYqT09SFVgiguO5pFFBriw6Efq65rQ0\n\tU1H+9ONDqr8kxwsDQxmnzFW0fZxGwFMsBRYraVsWSPiwnnGhnijZsdQ1F8oV0xej8sbV\n\tJArAorpgsu2a4Itp8eqJLAIKagskPi66JM7y1m/88MUQSnK7PvB9aM/7gy86c5bc8vFC\n\tpxTLB5NHKWH9dXSoiW2/ZtV2faGFUHbQgzzi2S3ZGlr7dr8Zd3t9mJHGSg0svQ06sM2O\n\txlgA==",
        "X-Gm-Message-State": "ALoCoQkWwiUuDB9aioihRpODoPny7sAdEZPT6Vu6BrJSUalF/tN0Js/F0q5no9fUqqqtAy6nu7a0",
        "X-Received": "by 10.66.157.3 with SMTP id wi3mr32314642pab.17.1445231769486;\n\tSun, 18 Oct 2015 22:16:09 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "huawei.xie@intel.com,\n\tchangchun.ouyang@intel.com",
        "Date": "Sun, 18 Oct 2015 22:16:12 -0700",
        "Message-Id": "<1445231772-17467-6-git-send-email-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.1.4",
        "In-Reply-To": "<1445231772-17467-1-git-send-email-stephen@networkplumber.org>",
        "References": "<1445231772-17467-1-git-send-email-stephen@networkplumber.org>",
        "Cc": "dev@dpdk.org",
        "Subject": "[dpdk-dev] [PATCH 5/5] virtio: optimize transmit enqueue",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "All the error checks in virtqueue_enqueue_xmit are already done\nby the caller. Therefore they can be removed to improve performance.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/virtio/virtio_rxtx.c | 23 ++---------------------\n 1 file changed, 2 insertions(+), 21 deletions(-)",
    "diff": "diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c\nindex dbedcc3..8fa0dd7 100644\n--- a/drivers/net/virtio/virtio_rxtx.c\n+++ b/drivers/net/virtio/virtio_rxtx.c\n@@ -198,7 +198,7 @@ virtqueue_enqueue_recv_refill(struct virtqueue *vq, struct rte_mbuf *cookie)\n \treturn 0;\n }\n \n-static int\n+static inline void\n virtqueue_enqueue_xmit(struct virtqueue *txvq, struct rte_mbuf *cookie,\n \t\t       uint16_t needed, int use_indirect, int can_push)\n {\n@@ -209,14 +209,7 @@ virtqueue_enqueue_xmit(struct virtqueue *txvq, struct rte_mbuf *cookie,\n \tuint16_t head_size = txvq->hw->vtnet_hdr_size;\n \tunsigned long offs;\n \n-\tif (unlikely(txvq->vq_free_cnt == 0))\n-\t\treturn -ENOSPC;\n-\tif (unlikely(txvq->vq_free_cnt < needed))\n-\t\treturn -EMSGSIZE;\n \thead_idx = txvq->vq_desc_head_idx;\n-\tif (unlikely(head_idx >= txvq->vq_nentries))\n-\t\treturn -EFAULT;\n-\n \tidx = head_idx;\n \tdxp = &txvq->vq_descx[idx];\n \tdxp->cookie = (void *)cookie;\n@@ -267,8 +260,6 @@ virtqueue_enqueue_xmit(struct virtqueue *txvq, struct rte_mbuf *cookie,\n \t\ttxvq->vq_desc_tail_idx = idx;\n \ttxvq->vq_free_cnt = (uint16_t)(txvq->vq_free_cnt - needed);\n \tvq_update_avail_ring(txvq, head_idx);\n-\n-\treturn 0;\n }\n \n static inline struct rte_mbuf *\n@@ -828,17 +819,7 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\t}\n \n \t\t/* Enqueue Packet buffers */\n-\t\terror = virtqueue_enqueue_xmit(txvq, txm, slots,\n-\t\t\t\t\t       use_indirect, can_push);\n-\t\tif (unlikely(error)) {\n-\t\t\tif (error == ENOSPC)\n-\t\t\t\tPMD_TX_LOG(ERR, \"virtqueue_enqueue Free count = 0\");\n-\t\t\telse if (error == EMSGSIZE)\n-\t\t\t\tPMD_TX_LOG(ERR, \"virtqueue_enqueue Free count < 1\");\n-\t\t\telse\n-\t\t\t\tPMD_TX_LOG(ERR, \"virtqueue_enqueue error: %d\", error);\n-\t\t\tbreak;\n-\t\t}\n+\t\tvirtqueue_enqueue_xmit(txvq, txm, slots, use_indirect, can_push);\n \t\ttxvq->bytes += txm->pkt_len;\n \t\t++txvq->packets;\n \t}\n",
    "prefixes": [
        "dpdk-dev",
        "5/5"
    ]
}