Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7719/?format=api
{ "id": 7719, "url": "https://patches.dpdk.org/api/patches/7719/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1445040882-31006-9-git-send-email-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1445040882-31006-9-git-send-email-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/1445040882-31006-9-git-send-email-stephen@networkplumber.org", "date": "2015-10-17T00:14:41", "name": "[dpdk-dev,8/9] test-pmd: don't check deprecated ethernet statistics", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "a96a7e0ede4620468478fa71e019ae40894b66b1", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1445040882-31006-9-git-send-email-stephen@networkplumber.org/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/7719/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/7719/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id EB40691A0;\n\tSat, 17 Oct 2015 02:14:45 +0200 (CEST)", "from mail-pa0-f52.google.com (mail-pa0-f52.google.com\n\t[209.85.220.52]) by dpdk.org (Postfix) with ESMTP id 8655B8E87\n\tfor <dev@dpdk.org>; Sat, 17 Oct 2015 02:14:37 +0200 (CEST)", "by pabws5 with SMTP id ws5so3643360pab.1\n\tfor <dev@dpdk.org>; Fri, 16 Oct 2015 17:14:37 -0700 (PDT)", "from xeon-e3.home.lan (static-50-53-82-155.bvtn.or.frontiernet.net.\n\t[50.53.82.155]) by smtp.gmail.com with ESMTPSA id\n\tqy7sm23431097pab.37.2015.10.16.17.14.36\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tFri, 16 Oct 2015 17:14:36 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=pD7/yC/ni+k5ZF61RJC1NjoJgpqAQyl/oqGE/8cP63c=;\n\tb=QA62w5cwC6VD5xt2DVInJWQUNpjqq1GI6qZBB2KAiTyZTGIBCAcwgnbd5A6YMFZ5HB\n\tzP5oXRsUKtH69JXh9JJa77VgeGG8vrpFeHt68Rac1bRsAr4Rgj5LkNip+DU4oGFPOewB\n\tH7dK5T6bkc1o9skkF8kqDgdg14YrKelZ4oOsIRoT5XjTOxcu9tEF7JMQrmZZ2udVsYZU\n\t9df7kfUa4Sbk7LxmqpjR568gR/6w3/MsiobiCYyIHUhVncEap3EVsUUizqZhveU7dYd0\n\tdbQdSZHd3CrQRgNAHzvY1F3DldHZdGDa45X1K9sxNj8QcBUDEeKbt4YaZbnIUXNBjIlH\n\t4S9A==", "X-Gm-Message-State": "ALoCoQn7M+8ZdmjyfWOY87CmQI+LzTDJH9cszHJnj28VZmlIanCXonfmYpYc/cUl8s9nzgxiOn1w", "X-Received": "by 10.68.223.34 with SMTP id qr2mr19740891pbc.97.1445040876972; \n\tFri, 16 Oct 2015 17:14:36 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Date": "Fri, 16 Oct 2015 17:14:41 -0700", "Message-Id": "<1445040882-31006-9-git-send-email-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<1445040882-31006-1-git-send-email-stephen@networkplumber.org>", "References": "<1445040882-31006-1-git-send-email-stephen@networkplumber.org>", "Cc": "Stephen Hemminger <shemming@brocade.com>", "Subject": "[dpdk-dev] [PATCH 8/9] test-pmd: don't check deprecated ethernet\n\tstatistics", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Stephen Hemminger <shemming@brocade.com>\n\nSeveral fields in ether stats are marked deprecated, just\nignore them.\n\nSigned-off-by: Stephen Hemminger <shemming@brocade.com>\n---\n app/test-pmd/config.c | 30 +++++------------------------\n app/test-pmd/testpmd.c | 50 +++++++++---------------------------------------\n app/test/test_pmd_perf.c | 12 ++++--------\n 3 files changed, 18 insertions(+), 74 deletions(-)", "diff": "diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex cf2aa6e..b3d974c 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -127,14 +127,10 @@ nic_stats_display(portid_t port_id)\n \t nic_stats_border, port_id, nic_stats_border);\n \n \tif ((!port->rx_queue_stats_mapping_enabled) && (!port->tx_queue_stats_mapping_enabled)) {\n-\t\tprintf(\" RX-packets: %-10\"PRIu64\" RX-missed: %-10\"PRIu64\" RX-bytes: \"\n-\t\t \"%-\"PRIu64\"\\n\",\n-\t\t stats.ipackets, stats.imissed, stats.ibytes);\n-\t\tprintf(\" RX-badcrc: %-10\"PRIu64\" RX-badlen: %-10\"PRIu64\" RX-errors: \"\n-\t\t \"%-\"PRIu64\"\\n\",\n-\t\t stats.ibadcrc, stats.ibadlen, stats.ierrors);\n-\t\tprintf(\" RX-nombuf: %-10\"PRIu64\"\\n\",\n-\t\t stats.rx_nombuf);\n+\t\tprintf(\" RX-packets: %-10\"PRIu64\" RX-bytes: %-\"PRIu64\"\\n\",\n+\t\t stats.ipackets, stats.ibytes);\n+\t\tprintf(\" RX-errors: %-10\"PRIu64\" RX-nombuf: %-10\"PRIu64\"\\n\",\n+\t\t stats.ierrors, stats.rx_nombuf);\n \t\tprintf(\" TX-packets: %-10\"PRIu64\" TX-errors: %-10\"PRIu64\" TX-bytes: \"\n \t\t \"%-\"PRIu64\"\\n\",\n \t\t stats.opackets, stats.oerrors, stats.obytes);\n@@ -143,9 +139,7 @@ nic_stats_display(portid_t port_id)\n \t\tprintf(\" RX-packets: %10\"PRIu64\" RX-errors: %10\"PRIu64\n \t\t \" RX-bytes: %10\"PRIu64\"\\n\",\n \t\t stats.ipackets, stats.ierrors, stats.ibytes);\n-\t\tprintf(\" RX-badcrc: %10\"PRIu64\" RX-badlen: %10\"PRIu64\n-\t\t \" RX-errors: %10\"PRIu64\"\\n\",\n-\t\t stats.ibadcrc, stats.ibadlen, stats.ierrors);\n+\t\tprintf(\" RX-errors: %10\"PRIu64\"\\n\", stats.ierrors);\n \t\tprintf(\" RX-nombuf: %10\"PRIu64\"\\n\",\n \t\t stats.rx_nombuf);\n \t\tprintf(\" TX-packets: %10\"PRIu64\" TX-errors: %10\"PRIu64\n@@ -153,12 +147,6 @@ nic_stats_display(portid_t port_id)\n \t\t stats.opackets, stats.oerrors, stats.obytes);\n \t}\n \n-\t/* stats fdir */\n-\tif (fdir_conf.mode != RTE_FDIR_MODE_NONE)\n-\t\tprintf(\" Fdirmiss: %-10\"PRIu64\" Fdirmatch: %-10\"PRIu64\"\\n\",\n-\t\t stats.fdirmiss,\n-\t\t stats.fdirmatch);\n-\n \tif (port->rx_queue_stats_mapping_enabled) {\n \t\tprintf(\"\\n\");\n \t\tfor (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS; i++) {\n@@ -177,14 +165,6 @@ nic_stats_display(portid_t port_id)\n \t\t}\n \t}\n \n-\t/* Display statistics of XON/XOFF pause frames, if any. */\n-\tif ((stats.tx_pause_xon | stats.rx_pause_xon |\n-\t stats.tx_pause_xoff | stats.rx_pause_xoff) > 0) {\n-\t\tprintf(\" RX-XOFF: %-10\"PRIu64\" RX-XON: %-10\"PRIu64\"\\n\",\n-\t\t stats.rx_pause_xoff, stats.rx_pause_xon);\n-\t\tprintf(\" TX-XOFF: %-10\"PRIu64\" TX-XON: %-10\"PRIu64\"\\n\",\n-\t\t stats.tx_pause_xoff, stats.tx_pause_xon);\n-\t}\n \tprintf(\" %s############################%s\\n\",\n \t nic_stats_border, nic_stats_border);\n }\ndiff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 386bf84..26f9352 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -733,19 +733,14 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats)\n \t fwd_stats_border, port_id, fwd_stats_border);\n \n \tif ((!port->rx_queue_stats_mapping_enabled) && (!port->tx_queue_stats_mapping_enabled)) {\n-\t\tprintf(\" RX-packets: %-14\"PRIu64\" RX-dropped: %-14\"PRIu64\"RX-total: \"\n-\t\t \"%-\"PRIu64\"\\n\",\n-\t\t stats->ipackets, stats->imissed,\n-\t\t (uint64_t) (stats->ipackets + stats->imissed));\n+\t\tprintf(\" RX-packets: %-14\"PRIu64\"\\n\", stats->ipackets);\n \n \t\tif (cur_fwd_eng == &csum_fwd_engine)\n \t\t\tprintf(\" Bad-ipcsum: %-14\"PRIu64\" Bad-l4csum: %-14\"PRIu64\" \\n\",\n \t\t\t port->rx_bad_ip_csum, port->rx_bad_l4_csum);\n-\t\tif (((stats->ierrors - stats->imissed) + stats->rx_nombuf) > 0) {\n-\t\t\tprintf(\" RX-badcrc: %-14\"PRIu64\" RX-badlen: %-14\"PRIu64\n-\t\t\t \"RX-error: %-\"PRIu64\"\\n\",\n-\t\t\t stats->ibadcrc, stats->ibadlen, stats->ierrors);\n-\t\t\tprintf(\" RX-nombufs: %-14\"PRIu64\"\\n\", stats->rx_nombuf);\n+\t\tif (stats->ierrors + stats->rx_nombuf > 0) {\n+\t\t\tprintf(\" RX-error: %-\"PRIu64\" RX-nombufs: %-14\"PRIu64\"\\n\",\n+\t\t\t stats->ierrors, stats->rx_nombuf);\n \t\t}\n \n \t\tprintf(\" TX-packets: %-14\"PRIu64\" TX-dropped: %-14\"PRIu64\"TX-total: \"\n@@ -754,20 +749,15 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats)\n \t\t (uint64_t) (stats->opackets + port->tx_dropped));\n \t}\n \telse {\n-\t\tprintf(\" RX-packets: %14\"PRIu64\" RX-dropped:%14\"PRIu64\" RX-total:\"\n-\t\t \"%14\"PRIu64\"\\n\",\n-\t\t stats->ipackets, stats->imissed,\n-\t\t (uint64_t) (stats->ipackets + stats->imissed));\n+\t\tprintf(\" RX-packets: %14\"PRIu64\"\\n\",\n+\t\t stats->ipackets);\n \n \t\tif (cur_fwd_eng == &csum_fwd_engine)\n \t\t\tprintf(\" Bad-ipcsum:%14\"PRIu64\" Bad-l4csum:%14\"PRIu64\"\\n\",\n \t\t\t port->rx_bad_ip_csum, port->rx_bad_l4_csum);\n-\t\tif (((stats->ierrors - stats->imissed) + stats->rx_nombuf) > 0) {\n-\t\t\tprintf(\" RX-badcrc: %14\"PRIu64\" RX-badlen: %14\"PRIu64\n-\t\t\t \" RX-error:%\"PRIu64\"\\n\",\n-\t\t\t stats->ibadcrc, stats->ibadlen, stats->ierrors);\n-\t\t\tprintf(\" RX-nombufs: %14\"PRIu64\"\\n\",\n-\t\t\t stats->rx_nombuf);\n+\t\tif (stats->ierrors + stats->rx_nombuf > 0) {\n+\t\t\tprintf(\" RX-error:%\"PRIu64\" RX-nombufs: %14\"PRIu64\"\\n\",\n+\t\t\t stats->ierrors, stats->rx_nombuf);\n \t\t}\n \n \t\tprintf(\" TX-packets: %14\"PRIu64\" TX-dropped:%14\"PRIu64\" TX-total:\"\n@@ -776,15 +766,6 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats)\n \t\t (uint64_t) (stats->opackets + port->tx_dropped));\n \t}\n \n-\t/* Display statistics of XON/XOFF pause frames, if any. */\n-\tif ((stats->tx_pause_xon | stats->rx_pause_xon |\n-\t stats->tx_pause_xoff | stats->rx_pause_xoff) > 0) {\n-\t\tprintf(\" RX-XOFF: %-14\"PRIu64\" RX-XON: %-14\"PRIu64\"\\n\",\n-\t\t stats->rx_pause_xoff, stats->rx_pause_xon);\n-\t\tprintf(\" TX-XOFF: %-14\"PRIu64\" TX-XON: %-14\"PRIu64\"\\n\",\n-\t\t stats->tx_pause_xoff, stats->tx_pause_xon);\n-\t}\n-\n #ifdef RTE_TEST_PMD_RECORD_BURST_STATS\n \tif (port->rx_stream)\n \t\tpkt_burst_stats_display(\"RX\",\n@@ -793,12 +774,6 @@ fwd_port_stats_display(portid_t port_id, struct rte_eth_stats *stats)\n \t\tpkt_burst_stats_display(\"TX\",\n \t\t\t&port->tx_stream->tx_burst_stats);\n #endif\n-\t/* stats fdir */\n-\tif (fdir_conf.mode != RTE_FDIR_MODE_NONE)\n-\t\tprintf(\" Fdirmiss:%14\"PRIu64\"\t Fdirmatch:%14\"PRIu64\"\\n\",\n-\t\t stats->fdirmiss,\n-\t\t stats->fdirmatch);\n-\n \tif (port->rx_queue_stats_mapping_enabled) {\n \t\tprintf(\"\\n\");\n \t\tfor (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS; i++) {\n@@ -1135,20 +1110,13 @@ stop_packet_forwarding(void)\n \t\tport->stats.ibytes = 0;\n \t\tstats.obytes -= port->stats.obytes;\n \t\tport->stats.obytes = 0;\n-\t\tstats.imissed -= port->stats.imissed;\n-\t\tport->stats.imissed = 0;\n \t\tstats.oerrors -= port->stats.oerrors;\n \t\tport->stats.oerrors = 0;\n \t\tstats.rx_nombuf -= port->stats.rx_nombuf;\n \t\tport->stats.rx_nombuf = 0;\n-\t\tstats.fdirmatch -= port->stats.fdirmatch;\n-\t\tport->stats.rx_nombuf = 0;\n-\t\tstats.fdirmiss -= port->stats.fdirmiss;\n-\t\tport->stats.rx_nombuf = 0;\n \n \t\ttotal_recv += stats.ipackets;\n \t\ttotal_xmit += stats.opackets;\n-\t\ttotal_rx_dropped += stats.imissed;\n \t\ttotal_tx_dropped += port->tx_dropped;\n \t\ttotal_rx_nombuf += stats.rx_nombuf;\n \ndiff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c\nindex 1fd6843..9a085bd 100644\n--- a/app/test/test_pmd_perf.c\n+++ b/app/test/test_pmd_perf.c\n@@ -340,14 +340,10 @@ stats_display(uint8_t port_id)\n \tstruct rte_eth_stats stats;\n \trte_eth_stats_get(port_id, &stats);\n \n-\tprintf(\" RX-packets: %-10\"PRIu64\" RX-missed: %-10\"PRIu64\" RX-bytes: \"\n-\t \"%-\"PRIu64\"\\n\",\n-\t stats.ipackets, stats.imissed, stats.ibytes);\n-\tprintf(\" RX-badcrc: %-10\"PRIu64\" RX-badlen: %-10\"PRIu64\" RX-errors: \"\n-\t \"%-\"PRIu64\"\\n\",\n-\t stats.ibadcrc, stats.ibadlen, stats.ierrors);\n-\tprintf(\" RX-nombuf: %-10\"PRIu64\"\\n\",\n-\t stats.rx_nombuf);\n+\tprintf(\" RX-packets: %-10\"PRIu64\" RX-bytes: %-\"PRIu64\n+\t \" RX-errors: %-10\"PRIu64\" RX-nombuf: %-10\"PRIu64\"\\n\",\n+\t stats.ipackets, stats.ibytes,\n+\t stats.ierrors, stats.rx_nombuf);\n \tprintf(\" TX-packets: %-10\"PRIu64\" TX-errors: %-10\"PRIu64\" TX-bytes: \"\n \t \"%-\"PRIu64\"\\n\",\n \t stats.opackets, stats.oerrors, stats.obytes);\n", "prefixes": [ "dpdk-dev", "8/9" ] }