Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 7694,
    "url": "https://patches.dpdk.org/api/patches/7694/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1444989651-6236-6-git-send-email-tomaszx.kulasek@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1444989651-6236-6-git-send-email-tomaszx.kulasek@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1444989651-6236-6-git-send-email-tomaszx.kulasek@intel.com",
    "date": "2015-10-16T10:00:47",
    "name": "[dpdk-dev,v6,5/9] null: virtual dynamic rss configuration",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "14f09bc7f74994ec5a0810bedb4bf2020ac2714d",
    "submitter": {
        "id": 155,
        "url": "https://patches.dpdk.org/api/people/155/?format=api",
        "name": "Tomasz Kulasek",
        "email": "tomaszx.kulasek@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1444989651-6236-6-git-send-email-tomaszx.kulasek@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/7694/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/7694/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 89A1F8E92;\n\tFri, 16 Oct 2015 12:09:42 +0200 (CEST)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 86E5937AF\n\tfor <dev@dpdk.org>; Fri, 16 Oct 2015 12:09:40 +0200 (CEST)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga101.fm.intel.com with ESMTP; 16 Oct 2015 03:09:39 -0700",
            "from unknown (HELO Sent) ([10.217.248.129])\n\tby orsmga002.jf.intel.com with SMTP; 16 Oct 2015 03:09:39 -0700",
            "by Sent (sSMTP sendmail emulation); Fri, 16 Oct 2015 12:08:12 +0200"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.17,688,1437462000\"; d=\"scan'208\";a=\"828139353\"",
        "From": "Tomasz Kulasek <tomaszx.kulasek@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Fri, 16 Oct 2015 12:00:47 +0200",
        "Message-Id": "<1444989651-6236-6-git-send-email-tomaszx.kulasek@intel.com>",
        "X-Mailer": "git-send-email 2.1.4",
        "In-Reply-To": "<1444989651-6236-1-git-send-email-tomaszx.kulasek@intel.com>",
        "References": "<1443621905-7872-1-git-send-email-tomaszx.kulasek@intel.com>\n\t<1444989651-6236-1-git-send-email-tomaszx.kulasek@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v6 5/9] null: virtual dynamic rss configuration",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This implementation allows to set and read RSS configuration for null\ndevice, and is used to validate right values propagation over the slaves,\nin test units for dynamic RSS configuration for bonding.\n\nv6 changes:\n - reordered with patch 4/9\n - recreated due to the changes in patch 4/9\n\nv5 changes:\n - replaced memcpy with rte_memcpy\n\nSigned-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>\n---\n drivers/net/null/rte_eth_null.c |  115 +++++++++++++++++++++++++++++++++++++++\n 1 file changed, 115 insertions(+)",
    "diff": "diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c\nindex 236d998..64e9000 100644\n--- a/drivers/net/null/rte_eth_null.c\n+++ b/drivers/net/null/rte_eth_null.c\n@@ -37,6 +37,7 @@\n #include <rte_memcpy.h>\n #include <rte_dev.h>\n #include <rte_kvargs.h>\n+#include <rte_spinlock.h>\n \n #include \"rte_eth_null.h\"\n \n@@ -75,6 +76,17 @@ struct pmd_internals {\n \n \tstruct null_queue rx_null_queues[RTE_MAX_QUEUES_PER_PORT];\n \tstruct null_queue tx_null_queues[RTE_MAX_QUEUES_PER_PORT];\n+\n+\t/** Bit mask of RSS offloads, the bit offset also means flow type */\n+\tuint64_t flow_type_rss_offloads;\n+\n+\trte_spinlock_t rss_lock;\n+\n+\tuint16_t reta_size;\n+\tstruct rte_eth_rss_reta_entry64 reta_conf[ETH_RSS_RETA_SIZE_128 /\n+\t\t\tRTE_RETA_GROUP_SIZE];\n+\n+\tuint8_t rss_key[40];                /**< 40-byte hash key. */\n };\n \n \n@@ -295,6 +307,8 @@ eth_dev_info(struct rte_eth_dev *dev,\n \tdev_info->max_tx_queues = RTE_DIM(internals->tx_null_queues);\n \tdev_info->min_rx_bufsize = 0;\n \tdev_info->pci_dev = NULL;\n+\tdev_info->reta_size = internals->reta_size;\n+\tdev_info->flow_type_rss_offloads = internals->flow_type_rss_offloads;\n }\n \n static void\n@@ -375,6 +389,91 @@ static int\n eth_link_update(struct rte_eth_dev *dev __rte_unused,\n \t\tint wait_to_complete __rte_unused) { return 0; }\n \n+static int\n+eth_rss_reta_update(struct rte_eth_dev *dev,\n+\t\tstruct rte_eth_rss_reta_entry64 *reta_conf, uint16_t reta_size)\n+{\n+\tint i, j;\n+\tstruct pmd_internals *internal = dev->data->dev_private;\n+\n+\tif (reta_size != internal->reta_size)\n+\t\treturn -EINVAL;\n+\n+\trte_spinlock_lock(&internal->rss_lock);\n+\n+\t/* Copy RETA table */\n+\tfor (i = 0; i < (internal->reta_size / RTE_RETA_GROUP_SIZE); i++) {\n+\t\tinternal->reta_conf[i].mask = reta_conf[i].mask;\n+\t\tfor (j = 0; j < RTE_RETA_GROUP_SIZE; j++)\n+\t\t\tif ((reta_conf[i].mask >> j) & 0x01)\n+\t\t\t\tinternal->reta_conf[i].reta[j] = reta_conf[i].reta[j];\n+\t}\n+\n+\trte_spinlock_unlock(&internal->rss_lock);\n+\n+\treturn 0;\n+}\n+\n+static int\n+eth_rss_reta_query(struct rte_eth_dev *dev,\n+\t\tstruct rte_eth_rss_reta_entry64 *reta_conf, uint16_t reta_size)\n+{\n+\tint i, j;\n+\tstruct pmd_internals *internal = dev->data->dev_private;\n+\n+\tif (reta_size != internal->reta_size)\n+\t\treturn -EINVAL;\n+\n+\trte_spinlock_lock(&internal->rss_lock);\n+\n+\t/* Copy RETA table */\n+\tfor (i = 0; i < (internal->reta_size / RTE_RETA_GROUP_SIZE); i++) {\n+\t\tfor (j = 0; j < RTE_RETA_GROUP_SIZE; j++)\n+\t\t\tif ((reta_conf[i].mask >> j) & 0x01)\n+\t\t\t\treta_conf[i].reta[j] = internal->reta_conf[i].reta[j];\n+\t}\n+\n+\trte_spinlock_unlock(&internal->rss_lock);\n+\n+\treturn 0;\n+}\n+\n+static int\n+eth_rss_hash_update(struct rte_eth_dev *dev, struct rte_eth_rss_conf *rss_conf)\n+{\n+\tstruct pmd_internals *internal = dev->data->dev_private;\n+\n+\trte_spinlock_lock(&internal->rss_lock);\n+\n+\tif ((rss_conf->rss_hf & internal->flow_type_rss_offloads) != 0)\n+\t\tdev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf =\n+\t\t\t\trss_conf->rss_hf & internal->flow_type_rss_offloads;\n+\n+\tif (rss_conf->rss_key)\n+\t\trte_memcpy(internal->rss_key, rss_conf->rss_key, 40);\n+\n+\trte_spinlock_unlock(&internal->rss_lock);\n+\n+\treturn 0;\n+}\n+\n+static int\n+eth_rss_hash_conf_get(struct rte_eth_dev *dev,\n+\t\tstruct rte_eth_rss_conf *rss_conf)\n+{\n+\tstruct pmd_internals *internal = dev->data->dev_private;\n+\n+\trte_spinlock_lock(&internal->rss_lock);\n+\n+\trss_conf->rss_hf = dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf;\n+\tif (rss_conf->rss_key)\n+\t\trte_memcpy(rss_conf->rss_key, internal->rss_key, 40);\n+\n+\trte_spinlock_unlock(&internal->rss_lock);\n+\n+\treturn 0;\n+}\n+\n static const struct eth_dev_ops ops = {\n \t.dev_start = eth_dev_start,\n \t.dev_stop = eth_dev_stop,\n@@ -387,6 +486,10 @@ static const struct eth_dev_ops ops = {\n \t.link_update = eth_link_update,\n \t.stats_get = eth_stats_get,\n \t.stats_reset = eth_stats_reset,\n+\t.reta_update = eth_rss_reta_update,\n+\t.reta_query = eth_rss_reta_query,\n+\t.rss_hash_update = eth_rss_hash_update,\n+\t.rss_hash_conf_get = eth_rss_hash_conf_get\n };\n \n int\n@@ -402,6 +505,13 @@ eth_dev_null_create(const char *name,\n \tstruct pmd_internals *internals = NULL;\n \tstruct rte_eth_dev *eth_dev = NULL;\n \n+\tstatic const uint8_t default_rss_key[40] = {\n+\t\t0x6D, 0x5A, 0x56, 0xDA, 0x25, 0x5B, 0x0E, 0xC2, 0x41, 0x67, 0x25, 0x3D,\n+\t\t0x43, 0xA3, 0x8F, 0xB0, 0xD0, 0xCA, 0x2B, 0xCB, 0xAE, 0x7B, 0x30, 0xB4,\n+\t\t0x77, 0xCB, 0x2D, 0xA3, 0x80, 0x30, 0xF2, 0x0C, 0x6A, 0x42, 0xB7, 0x3B,\n+\t\t0xBE, 0xAC, 0x01, 0xFA\n+\t};\n+\n \tif (name == NULL)\n \t\treturn -EINVAL;\n \n@@ -443,6 +553,11 @@ eth_dev_null_create(const char *name,\n \tinternals->packet_copy = packet_copy;\n \tinternals->numa_node = numa_node;\n \n+\tinternals->flow_type_rss_offloads =  ETH_RSS_PROTO_MASK;\n+\tinternals->reta_size = RTE_DIM(internals->reta_conf) * RTE_RETA_GROUP_SIZE;\n+\n+\trte_memcpy(internals->rss_key, default_rss_key, 40);\n+\n \tpci_dev->numa_node = numa_node;\n \tpci_dev->driver = &rte_null_pmd.pci_drv;\n \n",
    "prefixes": [
        "dpdk-dev",
        "v6",
        "5/9"
    ]
}