Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76916/?format=api
{ "id": 76916, "url": "https://patches.dpdk.org/api/patches/76916/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200908100636.4575-1-lizh@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200908100636.4575-1-lizh@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200908100636.4575-1-lizh@nvidia.com", "date": "2020-09-08T10:06:36", "name": "[RFC] app/testpmd: distinguish ICMP identifier fields in packet", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a885d9befe03f3f88e9e60fd65cb214a83552e21", "submitter": { "id": 1967, "url": "https://patches.dpdk.org/api/people/1967/?format=api", "name": "Li Zhang", "email": "lizh@nvidia.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200908100636.4575-1-lizh@nvidia.com/mbox/", "series": [ { "id": 12025, "url": "https://patches.dpdk.org/api/series/12025/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=12025", "date": "2020-09-08T10:06:36", "name": "[RFC] app/testpmd: distinguish ICMP identifier fields in packet", "version": 1, "mbox": "https://patches.dpdk.org/series/12025/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/76916/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/76916/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AF1E0A04AA;\n\tTue, 8 Sep 2020 14:26:52 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CE5391B9B7;\n\tTue, 8 Sep 2020 14:26:51 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n by dpdk.org (Postfix) with ESMTP id 809C22BA8\n for <dev@dpdk.org>; Tue, 8 Sep 2020 12:06:40 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n lizh@nvidia.com)\n with SMTP; 8 Sep 2020 13:06:39 +0300", "from nvidia.com (c-235-15-1-006.mtl.labs.mlnx [10.235.15.6])\n by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 088A6doH015884;\n Tue, 8 Sep 2020 13:06:39 +0300" ], "From": "lizh <lizh@nvidia.com>", "To": "dekelp@nvidia.com, orika@nvidia.com, viacheslavo@nvidia.com,\n matan@nvidia.com", "Cc": "dev@dpdk.org, thomas@monjalon.net, rasland@nvidia.com", "Date": "Tue, 8 Sep 2020 13:06:36 +0300", "Message-Id": "<20200908100636.4575-1-lizh@nvidia.com>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Tue, 08 Sep 2020 14:26:51 +0200", "Subject": "[dpdk-dev] [RFC] app/testpmd: distinguish ICMP identifier fields in\n\tpacket", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Ability to distinguish ICMP identifier fields in packets.\nDstinguish ICMP sequence number field too.\nAlready supports ICMP code and type fields in current version.\nExisting fields in ICMP header contain the required information.\nICMP header already is supported and no code change in RTE FLOW.\nExtend testpmd CLI to include the fields of ident and sequence number.\nOne example:\nflow create 0 ingress pattern eth / ipv4 /\n icmp code is 1 ident is 5 seq is 6 /\n end actions count / queue index 0 / end\nThe ICMP packet with code 1, identifier 5 and\nsequence number 6 will be matched.\nIt will implement action counter and forward to queue 0.\n\nSigned-off-by: lizh <lizh@nvidia.com>\n---\n app/test-pmd/cmdline_flow.c | 18 ++++++++++++++++++\n 1 file changed, 18 insertions(+)", "diff": "diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c\nindex 6263d307ed..6e04d538ea 100644\n--- a/app/test-pmd/cmdline_flow.c\n+++ b/app/test-pmd/cmdline_flow.c\n@@ -143,6 +143,8 @@ enum index {\n \tITEM_ICMP,\n \tITEM_ICMP_TYPE,\n \tITEM_ICMP_CODE,\n+\tITEM_ICMP_IDENT,\n+\tITEM_ICMP_SEQ,\n \tITEM_UDP,\n \tITEM_UDP_SRC,\n \tITEM_UDP_DST,\n@@ -893,6 +895,8 @@ static const enum index item_ipv6[] = {\n static const enum index item_icmp[] = {\n \tITEM_ICMP_TYPE,\n \tITEM_ICMP_CODE,\n+\tITEM_ICMP_IDENT,\n+\tITEM_ICMP_SEQ,\n \tITEM_NEXT,\n \tZERO,\n };\n@@ -2193,6 +2197,20 @@ static const struct token token_list[] = {\n \t\t.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_icmp,\n \t\t\t\t\t hdr.icmp_code)),\n \t},\n+\t[ITEM_ICMP_IDENT] = {\n+\t\t.name = \"ident\",\n+\t\t.help = \"ICMP packet identifier\",\n+\t\t.next = NEXT(item_icmp, NEXT_ENTRY(UNSIGNED), item_param),\n+\t\t.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_icmp,\n+\t\t\t\t\t hdr.icmp_ident)),\n+\t},\n+\t[ITEM_ICMP_SEQ] = {\n+\t\t.name = \"seq\",\n+\t\t.help = \"ICMP packet sequence number\",\n+\t\t.next = NEXT(item_icmp, NEXT_ENTRY(UNSIGNED), item_param),\n+\t\t.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_icmp,\n+\t\t\t\t\t hdr.icmp_seq_nb)),\n+\t},\n \t[ITEM_UDP] = {\n \t\t.name = \"udp\",\n \t\t.help = \"match UDP header\",\n", "prefixes": [ "RFC" ] }