Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 7662,
    "url": "https://patches.dpdk.org/api/patches/7662/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1444963882-30931-13-git-send-email-wenzhuo.lu@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1444963882-30931-13-git-send-email-wenzhuo.lu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1444963882-30931-13-git-send-email-wenzhuo.lu@intel.com",
    "date": "2015-10-16T02:50:58",
    "name": "[dpdk-dev,v3,12/36] e1000/base: add return value handler for ESB2 controller init and reset",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "0daa10f758c57fa12199e15e3297a0866dca484d",
    "submitter": {
        "id": 258,
        "url": "https://patches.dpdk.org/api/people/258/?format=api",
        "name": "Wenzhuo Lu",
        "email": "wenzhuo.lu@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1444963882-30931-13-git-send-email-wenzhuo.lu@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/7662/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/7662/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 165AE93A2;\n\tFri, 16 Oct 2015 04:52:06 +0200 (CEST)",
            "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id B9DB39372\n\tfor <dev@dpdk.org>; Fri, 16 Oct 2015 04:52:00 +0200 (CEST)",
            "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga102.jf.intel.com with ESMTP; 15 Oct 2015 19:52:00 -0700",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga001.fm.intel.com with ESMTP; 15 Oct 2015 19:51:59 -0700",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t9G2prFi028051;\n\tFri, 16 Oct 2015 10:51:53 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t9G2pn0F031050; Fri, 16 Oct 2015 10:51:52 +0800",
            "(from wenzhuol@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t9G2pnHu031046; \n\tFri, 16 Oct 2015 10:51:49 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.17,687,1437462000\"; d=\"scan'208\";a=\"812243632\"",
        "From": "Wenzhuo Lu <wenzhuo.lu@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Fri, 16 Oct 2015 10:50:58 +0800",
        "Message-Id": "<1444963882-30931-13-git-send-email-wenzhuo.lu@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1444963882-30931-1-git-send-email-wenzhuo.lu@intel.com>",
        "References": "<1444804479-14840-1-git-send-email-wenzhuo.lu@intel.com>\n\t<1444963882-30931-1-git-send-email-wenzhuo.lu@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v3 12/36] e1000/base: add return value handler\n\tfor ESB2 controller init and reset",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Adding code where missing to handle case where calls to\ne1000_read_kmrn_reg_80003es2lan and e1000_write_kmrn_reg_80003es2lan return\nan error value.\nAlso, when accessing the E1000_KMRNCTRLSTA_INBAND_PARAM offset to disable\nfar-end loopback on 80003es2lan devices, make the handling of a read or\nwrite failure consistent between hw_init and hw_reset.\n\nSigned-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>\n---\n drivers/net/e1000/base/e1000_80003es2lan.c | 31 ++++++++++++++++++++----------\n 1 file changed, 21 insertions(+), 10 deletions(-)",
    "diff": "diff --git a/drivers/net/e1000/base/e1000_80003es2lan.c b/drivers/net/e1000/base/e1000_80003es2lan.c\nindex b79496b..5ac925e 100644\n--- a/drivers/net/e1000/base/e1000_80003es2lan.c\n+++ b/drivers/net/e1000/base/e1000_80003es2lan.c\n@@ -852,11 +852,15 @@ STATIC s32 e1000_reset_hw_80003es2lan(struct e1000_hw *hw)\n \t/* Disable IBIST slave mode (far-end loopback) */\n \tret_val = e1000_read_kmrn_reg_80003es2lan(hw,\n \t\t\t\tE1000_KMRNCTRLSTA_INBAND_PARAM, &kum_reg_data);\n-\tif (ret_val)\n-\t\treturn ret_val;\n-\tkum_reg_data |= E1000_KMRNCTRLSTA_IBIST_DISABLE;\n-\te1000_write_kmrn_reg_80003es2lan(hw, E1000_KMRNCTRLSTA_INBAND_PARAM,\n-\t\t\t\t\tkum_reg_data);\n+\tif (!ret_val) {\n+\t\tkum_reg_data |= E1000_KMRNCTRLSTA_IBIST_DISABLE;\n+\t\tret_val = e1000_write_kmrn_reg_80003es2lan(hw,\n+\t\t\t\t\t\t E1000_KMRNCTRLSTA_INBAND_PARAM,\n+\t\t\t\t\t\t kum_reg_data);\n+\t\tif (ret_val)\n+\t\t\tDEBUGOUT(\"Error disabling far-end loopback\\n\");\n+\t} else\n+\t\tDEBUGOUT(\"Error disabling far-end loopback\\n\");\n \n \tret_val = e1000_get_auto_rd_done_generic(hw);\n \tif (ret_val)\n@@ -912,11 +916,18 @@ STATIC s32 e1000_init_hw_80003es2lan(struct e1000_hw *hw)\n \t\treturn ret_val;\n \n \t/* Disable IBIST slave mode (far-end loopback) */\n-\te1000_read_kmrn_reg_80003es2lan(hw, E1000_KMRNCTRLSTA_INBAND_PARAM,\n-\t\t\t\t\t&kum_reg_data);\n-\tkum_reg_data |= E1000_KMRNCTRLSTA_IBIST_DISABLE;\n-\te1000_write_kmrn_reg_80003es2lan(hw, E1000_KMRNCTRLSTA_INBAND_PARAM,\n-\t\t\t\t\t kum_reg_data);\n+\tret_val =\n+\t    e1000_read_kmrn_reg_80003es2lan(hw, E1000_KMRNCTRLSTA_INBAND_PARAM,\n+\t\t\t\t\t    &kum_reg_data);\n+\tif (!ret_val) {\n+\t\tkum_reg_data |= E1000_KMRNCTRLSTA_IBIST_DISABLE;\n+\t\tret_val = e1000_write_kmrn_reg_80003es2lan(hw,\n+\t\t\t\t\t\t E1000_KMRNCTRLSTA_INBAND_PARAM,\n+\t\t\t\t\t\t kum_reg_data);\n+\t\tif (ret_val)\n+\t\t\tDEBUGOUT(\"Error disabling far-end loopback\\n\");\n+\t} else\n+\t\tDEBUGOUT(\"Error disabling far-end loopback\\n\");\n \n \t/* Set the transmit descriptor write-back policy */\n \treg_data = E1000_READ_REG(hw, E1000_TXDCTL(0));\n",
    "prefixes": [
        "dpdk-dev",
        "v3",
        "12/36"
    ]
}