Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 7660,
    "url": "https://patches.dpdk.org/api/patches/7660/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1444963882-30931-11-git-send-email-wenzhuo.lu@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1444963882-30931-11-git-send-email-wenzhuo.lu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1444963882-30931-11-git-send-email-wenzhuo.lu@intel.com",
    "date": "2015-10-16T02:50:56",
    "name": "[dpdk-dev,v3,10/36] e1000/base: change invariant return to not use variables",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "88309c66ad5a81fe0391b2a5ac6dc435ade58df8",
    "submitter": {
        "id": 258,
        "url": "https://patches.dpdk.org/api/people/258/?format=api",
        "name": "Wenzhuo Lu",
        "email": "wenzhuo.lu@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1444963882-30931-11-git-send-email-wenzhuo.lu@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/7660/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/7660/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D753A938C;\n\tFri, 16 Oct 2015 04:52:00 +0200 (CEST)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 069B65921\n\tfor <dev@dpdk.org>; Fri, 16 Oct 2015 04:51:51 +0200 (CEST)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP; 15 Oct 2015 19:51:51 -0700",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga002.fm.intel.com with ESMTP; 15 Oct 2015 19:51:51 -0700",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t9G2pmv8027983;\n\tFri, 16 Oct 2015 10:51:48 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t9G2pjhb031036; Fri, 16 Oct 2015 10:51:47 +0800",
            "(from wenzhuol@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t9G2pjwS031032; \n\tFri, 16 Oct 2015 10:51:45 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.17,687,1437462000\"; d=\"scan'208\";a=\"828175959\"",
        "From": "Wenzhuo Lu <wenzhuo.lu@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Fri, 16 Oct 2015 10:50:56 +0800",
        "Message-Id": "<1444963882-30931-11-git-send-email-wenzhuo.lu@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1444963882-30931-1-git-send-email-wenzhuo.lu@intel.com>",
        "References": "<1444804479-14840-1-git-send-email-wenzhuo.lu@intel.com>\n\t<1444963882-30931-1-git-send-email-wenzhuo.lu@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v3 10/36] e1000/base: change invariant return to\n\tnot use variables",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Although this change should be optimized out by the compiler, just\nreturn a constant directly rather than declare a variable.\n\nSigned-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>\n---\n drivers/net/e1000/base/e1000_82575.c | 13 +++++--------\n 1 file changed, 5 insertions(+), 8 deletions(-)",
    "diff": "diff --git a/drivers/net/e1000/base/e1000_82575.c b/drivers/net/e1000/base/e1000_82575.c\nindex ab547ca..3bdcf69 100644\n--- a/drivers/net/e1000/base/e1000_82575.c\n+++ b/drivers/net/e1000/base/e1000_82575.c\n@@ -891,7 +891,6 @@ out:\n STATIC s32 e1000_set_d0_lplu_state_82580(struct e1000_hw *hw, bool active)\n {\n \tstruct e1000_phy_info *phy = &hw->phy;\n-\ts32 ret_val = E1000_SUCCESS;\n \tu32 data;\n \n \tDEBUGFUNC(\"e1000_set_d0_lplu_state_82580\");\n@@ -919,7 +918,7 @@ STATIC s32 e1000_set_d0_lplu_state_82580(struct e1000_hw *hw, bool active)\n \t}\n \n \tE1000_WRITE_REG(hw, E1000_82580_PHY_POWER_MGMT, data);\n-\treturn ret_val;\n+\treturn E1000_SUCCESS;\n }\n \n /**\n@@ -939,7 +938,6 @@ STATIC s32 e1000_set_d0_lplu_state_82580(struct e1000_hw *hw, bool active)\n s32 e1000_set_d3_lplu_state_82580(struct e1000_hw *hw, bool active)\n {\n \tstruct e1000_phy_info *phy = &hw->phy;\n-\ts32 ret_val = E1000_SUCCESS;\n \tu32 data;\n \n \tDEBUGFUNC(\"e1000_set_d3_lplu_state_82580\");\n@@ -967,7 +965,7 @@ s32 e1000_set_d3_lplu_state_82580(struct e1000_hw *hw, bool active)\n \t}\n \n \tE1000_WRITE_REG(hw, E1000_82580_PHY_POWER_MGMT, data);\n-\treturn ret_val;\n+\treturn E1000_SUCCESS;\n }\n \n /**\n@@ -981,7 +979,7 @@ s32 e1000_set_d3_lplu_state_82580(struct e1000_hw *hw, bool active)\n  **/\n STATIC s32 e1000_acquire_nvm_82575(struct e1000_hw *hw)\n {\n-\ts32 ret_val;\n+\ts32 ret_val = E1000_SUCCESS;\n \n \tDEBUGFUNC(\"e1000_acquire_nvm_82575\");\n \n@@ -1003,6 +1001,7 @@ STATIC s32 e1000_acquire_nvm_82575(struct e1000_hw *hw)\n \t\t\tDEBUGOUT(\"Nvm bit banging access error detected and cleared.\\n\");\n \t\t}\n \t}\n+\n \tif (hw->mac.type == e1000_82580) {\n \t\tu32 eecd = E1000_READ_REG(hw, E1000_EECD);\n \t\tif (eecd & E1000_EECD_BLOCKED) {\n@@ -1013,7 +1012,6 @@ STATIC s32 e1000_acquire_nvm_82575(struct e1000_hw *hw)\n \t\t}\n \t}\n \n-\n \tret_val = e1000_acquire_nvm_generic(hw);\n \tif (ret_val)\n \t\te1000_release_swfw_sync_82575(hw, E1000_SWFW_EEP_SM);\n@@ -1127,7 +1125,6 @@ STATIC void e1000_release_swfw_sync_82575(struct e1000_hw *hw, u16 mask)\n STATIC s32 e1000_get_cfg_done_82575(struct e1000_hw *hw)\n {\n \ts32 timeout = PHY_CFG_TIMEOUT;\n-\ts32 ret_val = E1000_SUCCESS;\n \tu32 mask = E1000_NVM_CFG_DONE_PORT_0;\n \n \tDEBUGFUNC(\"e1000_get_cfg_done_82575\");\n@@ -1152,7 +1149,7 @@ STATIC s32 e1000_get_cfg_done_82575(struct e1000_hw *hw)\n \t    (hw->phy.type == e1000_phy_igp_3))\n \t\te1000_phy_init_script_igp3(hw);\n \n-\treturn ret_val;\n+\treturn E1000_SUCCESS;\n }\n \n /**\n",
    "prefixes": [
        "dpdk-dev",
        "v3",
        "10/36"
    ]
}