Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7659/?format=api
{ "id": 7659, "url": "https://patches.dpdk.org/api/patches/7659/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1444963882-30931-10-git-send-email-wenzhuo.lu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1444963882-30931-10-git-send-email-wenzhuo.lu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1444963882-30931-10-git-send-email-wenzhuo.lu@intel.com", "date": "2015-10-16T02:50:55", "name": "[dpdk-dev,v3,09/36] e1000/base: add evaluation of e1000_nvm_read return value", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d1e42d8ff214bf61e8204b8313570f8d3d103341", "submitter": { "id": 258, "url": "https://patches.dpdk.org/api/people/258/?format=api", "name": "Wenzhuo Lu", "email": "wenzhuo.lu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1444963882-30931-10-git-send-email-wenzhuo.lu@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/7659/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/7659/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 6433C9388;\n\tFri, 16 Oct 2015 04:51:59 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id C524D9253\n\tfor <dev@dpdk.org>; Fri, 16 Oct 2015 04:51:49 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga103.fm.intel.com with ESMTP; 15 Oct 2015 19:51:49 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga002.jf.intel.com with ESMTP; 15 Oct 2015 19:51:48 -0700", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t9G2pkMw027980;\n\tFri, 16 Oct 2015 10:51:46 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t9G2ph5v031029; Fri, 16 Oct 2015 10:51:45 +0800", "(from wenzhuol@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t9G2phcP031025; \n\tFri, 16 Oct 2015 10:51:43 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,687,1437462000\"; d=\"scan'208\";a=\"827915334\"", "From": "Wenzhuo Lu <wenzhuo.lu@intel.com>", "To": "dev@dpdk.org", "Date": "Fri, 16 Oct 2015 10:50:55 +0800", "Message-Id": "<1444963882-30931-10-git-send-email-wenzhuo.lu@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1444963882-30931-1-git-send-email-wenzhuo.lu@intel.com>", "References": "<1444804479-14840-1-git-send-email-wenzhuo.lu@intel.com>\n\t<1444963882-30931-1-git-send-email-wenzhuo.lu@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 09/36] e1000/base: add evaluation of\n\te1000_nvm_read return value", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Adding code to a case where e1000_nvn_read is called, but there is no\nconsideration for when the read fails (returns an error code).\nAlso, this patch adds an error message to a base NVM reading function that\nis missing it for consistency.\nThis patch is not covering all cases of these conditions, it only covers\nthe code used by the e1000e driver.\n\nSigned-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>\n---\n drivers/net/e1000/base/e1000_manage.c | 5 ++++-\n drivers/net/e1000/base/e1000_nvm.c | 3 +++\n 2 files changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/e1000/base/e1000_manage.c b/drivers/net/e1000/base/e1000_manage.c\nindex ac4c08a..8564a7f 100644\n--- a/drivers/net/e1000/base/e1000_manage.c\n+++ b/drivers/net/e1000/base/e1000_manage.c\n@@ -363,9 +363,12 @@ bool e1000_enable_mng_pass_thru(struct e1000_hw *hw)\n \t} else if ((hw->mac.type == e1000_82574) ||\n \t\t (hw->mac.type == e1000_82583)) {\n \t\tu16 data;\n+\t\ts32 ret_val;\n \n \t\tfactps = E1000_READ_REG(hw, E1000_FACTPS);\n-\t\te1000_read_nvm(hw, NVM_INIT_CONTROL2_REG, 1, &data);\n+\t\tret_val = e1000_read_nvm(hw, NVM_INIT_CONTROL2_REG, 1, &data);\n+\t\tif (ret_val)\n+\t\t\treturn false;\n \n \t\tif (!(factps & E1000_FACTPS_MNGCG) &&\n \t\t ((data & E1000_NVM_INIT_CTRL2_MNGM) ==\ndiff --git a/drivers/net/e1000/base/e1000_nvm.c b/drivers/net/e1000/base/e1000_nvm.c\nindex 966a34c..01be9e4 100644\n--- a/drivers/net/e1000/base/e1000_nvm.c\n+++ b/drivers/net/e1000/base/e1000_nvm.c\n@@ -585,6 +585,9 @@ s32 e1000_read_nvm_eerd(struct e1000_hw *hw, u16 offset, u16 words, u16 *data)\n \t\t\t E1000_NVM_RW_REG_DATA);\n \t}\n \n+\tif (ret_val)\n+\t\tDEBUGOUT1(\"NVM read error: %d\\n\", ret_val);\n+\n \treturn ret_val;\n }\n \n", "prefixes": [ "dpdk-dev", "v3", "09/36" ] }