Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 76294,
    "url": "https://patches.dpdk.org/api/patches/76294/?format=api",
    "web_url": "https://patches.dpdk.org/project/dts/patch/1599059713-44254-1-git-send-email-yuan.peng@intel.com/",
    "project": {
        "id": 3,
        "url": "https://patches.dpdk.org/api/projects/3/?format=api",
        "name": "DTS",
        "link_name": "dts",
        "list_id": "dts.dpdk.org",
        "list_email": "dts@dpdk.org",
        "web_url": "",
        "scm_url": "git://dpdk.org/tools/dts",
        "webscm_url": "http://git.dpdk.org/tools/dts/",
        "list_archive_url": "https://inbox.dpdk.org/dts",
        "list_archive_url_format": "https://inbox.dpdk.org/dts/{}",
        "commit_url_format": ""
    },
    "msgid": "<1599059713-44254-1-git-send-email-yuan.peng@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dts/1599059713-44254-1-git-send-email-yuan.peng@intel.com",
    "date": "2020-09-02T15:15:13",
    "name": "tests: change packet configuration",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": false,
    "hash": "d28863f66f04a54f7b36ac96e2b0847bc972f3b3",
    "submitter": {
        "id": 429,
        "url": "https://patches.dpdk.org/api/people/429/?format=api",
        "name": "Peng, Yuan",
        "email": "yuan.peng@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dts/patch/1599059713-44254-1-git-send-email-yuan.peng@intel.com/mbox/",
    "series": [
        {
            "id": 11892,
            "url": "https://patches.dpdk.org/api/series/11892/?format=api",
            "web_url": "https://patches.dpdk.org/project/dts/list/?series=11892",
            "date": "2020-09-02T15:15:13",
            "name": "tests: change packet configuration",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/11892/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/76294/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/76294/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dts-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A442BA04B7;\n\tWed,  2 Sep 2020 10:10:33 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6DD8A4C99;\n\tWed,  2 Sep 2020 10:10:33 +0200 (CEST)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by dpdk.org (Postfix) with ESMTP id 009D4E07\n for <dts@dpdk.org>; Wed,  2 Sep 2020 10:10:31 +0200 (CEST)",
            "from orsmga005.jf.intel.com ([10.7.209.41])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Sep 2020 01:10:27 -0700",
            "from npg_dpdk_nic_yuanpeng_tester62.sh.intel.com ([10.67.119.61])\n by orsmga005.jf.intel.com with ESMTP; 02 Sep 2020 01:10:25 -0700"
        ],
        "IronPort-SDR": [
            "\n NQtJlhMFMgvDUUT8la6IpGtlu/59MjZR5KegJDAXHbv5EFMrcnWGyMT9FN8XlMkZfM0XqOSsyp\n k+hm1vxKx/yg==",
            "\n 80QSV3A7gjfXDiCge9Ck7ow0PBOtOnn+zXtKRvre4fqF3Kpnj4UO6pp4NZwS29d5X382391XvX\n Y2Uk8bnwds9Q=="
        ],
        "X-IronPort-AV": [
            "E=McAfee;i=\"6000,8403,9731\"; a=\"175395776\"",
            "E=Sophos;i=\"5.76,381,1592895600\"; d=\"scan'208\";a=\"175395776\"",
            "E=Sophos;i=\"5.76,381,1592895600\"; d=\"scan'208\";a=\"477541148\""
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "From": "Peng Yuan <yuan.peng@intel.com>",
        "To": "dts@dpdk.org",
        "Cc": "Peng Yuan <yuan.peng@intel.com>",
        "Date": "Wed,  2 Sep 2020 15:15:13 +0000",
        "Message-Id": "<1599059713-44254-1-git-send-email-yuan.peng@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "Subject": "[dts] [PATCH]tests: change packet configuration",
        "X-BeenThere": "dts@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "test suite reviews and discussions <dts.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dts/>",
        "List-Post": "<mailto:dts@dpdk.org>",
        "List-Help": "<mailto:dts-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dts-bounces@dpdk.org",
        "Sender": "\"dts\" <dts-bounces@dpdk.org>"
    },
    "content": "change packet configuration to fix traffic error.\nadd eal_param to adapt the tester and dut on the same server senario.\nget driver type from config file.\n\nSigned-off-by: Peng Yuan <yuan.peng@intel.com>",
    "diff": "diff --git a/tests/TestSuite_softnic.py b/tests/TestSuite_softnic.py\nindex c6ba6b9..7752546 100644\n--- a/tests/TestSuite_softnic.py\n+++ b/tests/TestSuite_softnic.py\n@@ -75,7 +75,8 @@ class TestSoftnic(TestCase):\n         self.dut.session.copy_file_to(self.firmware, self.root_path)\n         self.dut.session.copy_file_to(self.tm_firmware, self.root_path)\n         self.dut.session.copy_file_to(self.nat_firmware, self.root_path)\n-        self.cmd = \"./%s/app/testpmd -c 0x7 -s 0x4 -n 4 --vdev 'net_softnic0,firmware=/tmp/%s,cpu_id=1,conn_port=8086' -- -i --forward-mode=softnic --portmask=0x2\"\n+        self.eal_param = \" -w %s\" % self.dut.ports_info[0]['pci']\n+        self.cmd = \"./%s/app/testpmd -c 0x7 -s 0x4 -n 4 %s --vdev 'net_softnic0,firmware=/tmp/%s,cpu_id=1,conn_port=8086' -- -i --forward-mode=softnic --portmask=0x2\"\n         # get dts output path\n         if self.logger.log_path.startswith(os.sep):\n             self.output_path = self.logger.log_path\n@@ -90,7 +91,7 @@ class TestSoftnic(TestCase):\n         self.host_intf = self.dut.ports_info[self.used_dut_port]['intf']\n         out = self.dut.send_expect('ethtool %s' % self.host_intf, '#')\n         self.speed = re.findall('Supported link modes:   (\\d*)', out)[0]\n-        self.dut.bind_interfaces_linux('igb_uio', [ports[0]])\n+        self.dut.bind_interfaces_linux(self.drivername, [ports[0]])\n \n     def set_up(self):\n         \"\"\"\n@@ -106,7 +107,7 @@ class TestSoftnic(TestCase):\n         # 10G nic pps(M)\n         expect_pps = [14, 8, 4, 2, 1, 0.9, 0.8]\n \n-        self.dut.send_expect(self.cmd % (self.target, 'firmware.cli'), \"testpmd>\", timeout=300)\n+        self.dut.send_expect(self.cmd % (self.target, self.eal_param, 'firmware.cli'), \"testpmd>\", timeout=300)\n         self.dut.send_expect(\"set fwd macswap\", \"testpmd>\")\n         self.dut.send_expect(\"start\", \"testpmd>\")\n         rx_port = self.tester.get_local_port(0)\n@@ -116,7 +117,7 @@ class TestSoftnic(TestCase):\n             payload_size = frame - self.headers_size\n             tgen_input = []\n             pcap = os.sep.join([self.output_path, \"test.pcap\"])\n-            pkt = \"Ether(dst='%s')/IP()/UDP()/Raw('x'*%d)\" % (self.dmac, payload_size)\n+            pkt = \"Ether(dst='%s')/IP()/UDP()/Raw(load='x'*%d)\" % (self.dmac, payload_size)\n             self.tester.scapy_append('wrpcap(\"%s\", [%s])' % (pcap, pkt))\n             tgen_input.append((tx_port, rx_port, pcap))\n             self.tester.scapy_execute()\n@@ -132,11 +133,11 @@ class TestSoftnic(TestCase):\n \n     def test_perf_shaping_for_pipe(self):\n         self.change_config_file('tm_firmware.cli')\n-        self.dut.send_expect(self.cmd % (self.target, 'tm_firmware.cli'), \"testpmd> \", timeout=800)\n+        self.dut.send_expect(self.cmd % (self.target, self.eal_param, 'tm_firmware.cli'), \"testpmd> \", timeout=800)\n         self.dut.send_expect(\"set fwd macswap\", \"testpmd>\")\n         self.dut.send_expect(\"start\", \"testpmd>\")\n         rx_port = self.tester.get_local_port(0)\n-        pkts = [\"Ether(dst='%s')/IP(dst='100.0.0.0')/UDP()/Raw('x'*(64 - %s))\", \"Ether(dst='%s')/IP(dst='100.0.15.255')/UDP()/Raw('x'*(64 - %s))\", \"Ether(dst='%s')/IP(dst='100.0.4.0')/UDP()/Raw('x'*(64 - %s))\"]\n+        pkts = [\"Ether(dst='%s')/IP(dst='100.0.0.0')/UDP()/Raw(load='x'*(64 - %s))\", \"Ether(dst='%s')/IP(dst='100.0.15.255')/UDP()/Raw(load='x'*(64 - %s))\", \"Ether(dst='%s')/IP(dst='100.0.4.0')/UDP()/Raw(load='x'*(64 - %s))\"]\n         except_bps_range = [1700000, 2000000]\n \n         for i in range(3):\n@@ -169,7 +170,7 @@ class TestSoftnic(TestCase):\n         for t in pkt_type:\n             for i in range(2):\n                 self.dut.send_expect(\"sed -i -e '12c table action profile AP0 ipv4 offset 270 fwd nat %s proto %s' %s\" % (pkt_location[i], t, self.root_path + 'nat_firmware.cli'), \"#\")\n-                self.dut.send_expect(self.cmd % (self.target, 'nat_firmware.cli'), \"testpmd>\", timeout=60)\n+                self.dut.send_expect(self.cmd % (self.target, self.eal_param, 'nat_firmware.cli'), \"testpmd>\", timeout=60)\n                 self.dut.send_expect(\"start\", \"testpmd>\")\n                 # src ip tcp\n                 for j in range(2):\n@@ -182,9 +183,9 @@ class TestSoftnic(TestCase):\n         self.tester.scapy_foreground()\n         pkt = \"Ether(dst='%s')/IP(dst='%s')/\" % (self.dmac, ip)\n         if pkt_type == 'tcp':\n-            pkt = pkt + \"TCP()/Raw('x'*20)\"\n+            pkt = pkt + \"TCP()/Raw(load='x'*20)\"\n         else:\n-            pkt = pkt + \"UDP()/Raw('x'*20)\"\n+            pkt = pkt + \"UDP()/Raw(load='x'*20)\"\n \n         self.tester.scapy_append('sendp([%s], iface=\"%s\")' % (pkt, self.txItf))\n         self.start_tcpdump(self.txItf)\n",
    "prefixes": []
}