Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 76273,
    "url": "https://patches.dpdk.org/api/patches/76273/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1598980809-19942-1-git-send-email-rahul.lakkireddy@chelsio.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1598980809-19942-1-git-send-email-rahul.lakkireddy@chelsio.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1598980809-19942-1-git-send-email-rahul.lakkireddy@chelsio.com",
    "date": "2020-09-01T17:20:09",
    "name": "net/cxgbe: fix segfault when accessing empty Tx mbuf list",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "f5cfc3a7f58ae906e5466df95bd122183f2cadb6",
    "submitter": {
        "id": 241,
        "url": "https://patches.dpdk.org/api/people/241/?format=api",
        "name": "Rahul Lakkireddy",
        "email": "rahul.lakkireddy@chelsio.com"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1598980809-19942-1-git-send-email-rahul.lakkireddy@chelsio.com/mbox/",
    "series": [
        {
            "id": 11883,
            "url": "https://patches.dpdk.org/api/series/11883/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11883",
            "date": "2020-09-01T17:20:09",
            "name": "net/cxgbe: fix segfault when accessing empty Tx mbuf list",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/11883/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/76273/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/76273/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2D77FA04AC;\n\tTue,  1 Sep 2020 19:34:19 +0200 (CEST)",
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1557D1C0B1;\n\tTue,  1 Sep 2020 19:34:19 +0200 (CEST)",
            "from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8])\n by dpdk.org (Postfix) with ESMTP id 5216E1C0B0;\n Tue,  1 Sep 2020 19:34:17 +0200 (CEST)",
            "from localhost (scalar.blr.asicdesigners.com [10.193.185.94])\n by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id 081HYEmF013799;\n Tue, 1 Sep 2020 10:34:15 -0700"
        ],
        "From": "Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>",
        "To": "dev@dpdk.org",
        "Cc": "brian90013@gmail.com, kaara.satwik@chelsio.com, stable@dpdk.org",
        "Date": "Tue,  1 Sep 2020 22:50:09 +0530",
        "Message-Id": "<1598980809-19942-1-git-send-email-rahul.lakkireddy@chelsio.com>",
        "X-Mailer": "git-send-email 2.5.3",
        "Subject": "[dpdk-dev] [PATCH] net/cxgbe: fix segfault when accessing empty Tx\n\tmbuf list",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Ensure packets are available before accessing the mbuf list in Tx\nburst function. Otherwise, just reclaim completed Tx descriptors and\nexit.\n\nFixes: b1df19e43e1d (\"net/cxgbe: fix prefetch for non-coalesced Tx packets\")\nCc: stable@dpdk.org\n\nReported-by: Brian Poole <brian90013@gmail.com>\nSigned-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>\n---\n drivers/net/cxgbe/cxgbe_ethdev.c | 4 ++++\n 1 file changed, 4 insertions(+)",
    "diff": "diff --git a/drivers/net/cxgbe/cxgbe_ethdev.c b/drivers/net/cxgbe/cxgbe_ethdev.c\nindex 60d325723..38b43772c 100644\n--- a/drivers/net/cxgbe/cxgbe_ethdev.c\n+++ b/drivers/net/cxgbe/cxgbe_ethdev.c\n@@ -71,6 +71,9 @@ uint16_t cxgbe_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \tt4_os_lock(&txq->txq_lock);\n \t/* free up desc from already completed tx */\n \treclaim_completed_tx(&txq->q);\n+\tif (unlikely(!nb_pkts))\n+\t\tgoto out_unlock;\n+\n \trte_prefetch0(rte_pktmbuf_mtod(tx_pkts[0], volatile void *));\n \twhile (total_sent < nb_pkts) {\n \t\tpkts_remain = nb_pkts - total_sent;\n@@ -91,6 +94,7 @@ uint16_t cxgbe_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\treclaim_completed_tx(&txq->q);\n \t}\n \n+out_unlock:\n \tt4_os_unlock(&txq->txq_lock);\n \treturn total_sent;\n }\n",
    "prefixes": []
}