Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7625/?format=api
{ "id": 7625, "url": "https://patches.dpdk.org/api/patches/7625/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1444874628-5453-20-git-send-email-wenzhuo.lu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1444874628-5453-20-git-send-email-wenzhuo.lu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1444874628-5453-20-git-send-email-wenzhuo.lu@intel.com", "date": "2015-10-15T02:03:32", "name": "[dpdk-dev,v2,19/35] e1000/base: add return value for resume workaround", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5132de1e0d17d18ebca47314150518b9c87fc47c", "submitter": { "id": 258, "url": "https://patches.dpdk.org/api/people/258/?format=api", "name": "Wenzhuo Lu", "email": "wenzhuo.lu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1444874628-5453-20-git-send-email-wenzhuo.lu@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/7625/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/7625/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 241F791C0;\n\tThu, 15 Oct 2015 04:04:43 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 7C2159204\n\tfor <dev@dpdk.org>; Thu, 15 Oct 2015 04:04:39 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga102.fm.intel.com with ESMTP; 14 Oct 2015 19:04:38 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga002.fm.intel.com with ESMTP; 14 Oct 2015 19:04:38 -0700", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t9F24aLG004951;\n\tThu, 15 Oct 2015 10:04:36 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t9F24Xog005900; Thu, 15 Oct 2015 10:04:35 +0800", "(from wenzhuol@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t9F24XwI005896; \n\tThu, 15 Oct 2015 10:04:33 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,683,1437462000\"; d=\"scan'208\";a=\"827239042\"", "From": "Wenzhuo Lu <wenzhuo.lu@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 15 Oct 2015 10:03:32 +0800", "Message-Id": "<1444874628-5453-20-git-send-email-wenzhuo.lu@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1444874628-5453-1-git-send-email-wenzhuo.lu@intel.com>", "References": "<1444804479-14840-1-git-send-email-wenzhuo.lu@intel.com>\n\t<1444874628-5453-1-git-send-email-wenzhuo.lu@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 19/35] e1000/base: add return value for resume\n\tworkaround", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add u32 return value to function e1000_resume_workarounds_pchlan,\nso that calling function can detect PHY access failure during resuming\nflow.\n\nSigned-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>\n---\n drivers/net/e1000/base/e1000_ich8lan.c | 11 ++++++-----\n drivers/net/e1000/base/e1000_ich8lan.h | 2 +-\n 2 files changed, 7 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/e1000/base/e1000_ich8lan.c b/drivers/net/e1000/base/e1000_ich8lan.c\nindex 4ffaeef..5635dd5 100644\n--- a/drivers/net/e1000/base/e1000_ich8lan.c\n+++ b/drivers/net/e1000/base/e1000_ich8lan.c\n@@ -4943,19 +4943,18 @@ out:\n * the PHY.\n * On i217, setup Intel Rapid Start Technology.\n **/\n-void e1000_resume_workarounds_pchlan(struct e1000_hw *hw)\n+u32 e1000_resume_workarounds_pchlan(struct e1000_hw *hw)\n {\n \ts32 ret_val;\n \n \tDEBUGFUNC(\"e1000_resume_workarounds_pchlan\");\n-\n \tif (hw->mac.type < e1000_pch2lan)\n-\t\treturn;\n+\t\treturn E1000_SUCCESS;\n \n \tret_val = e1000_init_phy_workarounds_pchlan(hw);\n \tif (ret_val) {\n \t\tDEBUGOUT1(\"Failed to init PHY flow ret_val=%d\\n\", ret_val);\n-\t\treturn;\n+\t\treturn ret_val;\n \t}\n \n \t/* For i217 Intel Rapid Start Technology support when the system\n@@ -4969,7 +4968,7 @@ void e1000_resume_workarounds_pchlan(struct e1000_hw *hw)\n \t\tret_val = hw->phy.ops.acquire(hw);\n \t\tif (ret_val) {\n \t\t\tDEBUGOUT(\"Failed to setup iRST\\n\");\n-\t\t\treturn;\n+\t\t\treturn ret_val;\n \t\t}\n \n \t\t/* Clear Auto Enable LPI after link up */\n@@ -5003,7 +5002,9 @@ release:\n \t\tif (ret_val)\n \t\t\tDEBUGOUT1(\"Error %d in resume workarounds\\n\", ret_val);\n \t\thw->phy.ops.release(hw);\n+\t\treturn ret_val;\n \t}\n+\treturn E1000_SUCCESS;\n }\n \n /**\ndiff --git a/drivers/net/e1000/base/e1000_ich8lan.h b/drivers/net/e1000/base/e1000_ich8lan.h\nindex c690d9e..130627c 100644\n--- a/drivers/net/e1000/base/e1000_ich8lan.h\n+++ b/drivers/net/e1000/base/e1000_ich8lan.h\n@@ -300,7 +300,7 @@ void e1000_set_kmrn_lock_loss_workaround_ich8lan(struct e1000_hw *hw,\n void e1000_igp3_phy_powerdown_workaround_ich8lan(struct e1000_hw *hw);\n void e1000_gig_downshift_workaround_ich8lan(struct e1000_hw *hw);\n void e1000_suspend_workarounds_ich8lan(struct e1000_hw *hw);\n-void e1000_resume_workarounds_pchlan(struct e1000_hw *hw);\n+u32 e1000_resume_workarounds_pchlan(struct e1000_hw *hw);\n s32 e1000_configure_k1_ich8lan(struct e1000_hw *hw, bool k1_enable);\n void e1000_copy_rx_addrs_to_phy_ich8lan(struct e1000_hw *hw);\n s32 e1000_lv_jumbo_workaround_ich8lan(struct e1000_hw *hw, bool enable);\n", "prefixes": [ "dpdk-dev", "v2", "19/35" ] }