Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7611/?format=api
{ "id": 7611, "url": "https://patches.dpdk.org/api/patches/7611/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1444874628-5453-6-git-send-email-wenzhuo.lu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1444874628-5453-6-git-send-email-wenzhuo.lu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1444874628-5453-6-git-send-email-wenzhuo.lu@intel.com", "date": "2015-10-15T02:03:18", "name": "[dpdk-dev,v2,05/35] e1000/base: redundant PHY power down for i210", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b9993f407a729f8f98d09575b4dcf99986717c12", "submitter": { "id": 258, "url": "https://patches.dpdk.org/api/people/258/?format=api", "name": "Wenzhuo Lu", "email": "wenzhuo.lu@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1444874628-5453-6-git-send-email-wenzhuo.lu@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/7611/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/7611/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id AF7038E9C;\n\tThu, 15 Oct 2015 04:04:10 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 37B128E9A\n\tfor <dev@dpdk.org>; Thu, 15 Oct 2015 04:04:07 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga101.fm.intel.com with ESMTP; 14 Oct 2015 19:04:07 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby FMSMGA003.fm.intel.com with ESMTP; 14 Oct 2015 19:04:07 -0700", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t9F244WD004287;\n\tThu, 15 Oct 2015 10:04:04 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t9F241eb005553; Thu, 15 Oct 2015 10:04:03 +0800", "(from wenzhuol@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t9F241KT005549; \n\tThu, 15 Oct 2015 10:04:01 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.17,683,1437462000\"; d=\"scan'208\";a=\"581021744\"", "From": "Wenzhuo Lu <wenzhuo.lu@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 15 Oct 2015 10:03:18 +0800", "Message-Id": "<1444874628-5453-6-git-send-email-wenzhuo.lu@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1444874628-5453-1-git-send-email-wenzhuo.lu@intel.com>", "References": "<1444804479-14840-1-git-send-email-wenzhuo.lu@intel.com>\n\t<1444874628-5453-1-git-send-email-wenzhuo.lu@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 05/35] e1000/base: redundant PHY power down\n\tfor i210", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The wrong bit is being used in PHYREG16 for PHY power down. In addition,\nthe use of PHYREG 16 is unnecessary if bit 11 of PHYREG 0 is used.\n\nSigned-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>\n---\n drivers/net/e1000/base/e1000_phy.c | 15 ---------------\n drivers/net/e1000/base/e1000_phy.h | 1 -\n 2 files changed, 16 deletions(-)", "diff": "diff --git a/drivers/net/e1000/base/e1000_phy.c b/drivers/net/e1000/base/e1000_phy.c\nindex 7620ecf..6bbb379 100644\n--- a/drivers/net/e1000/base/e1000_phy.c\n+++ b/drivers/net/e1000/base/e1000_phy.c\n@@ -3498,16 +3498,10 @@ STATIC s32 e1000_access_phy_wakeup_reg_bm(struct e1000_hw *hw, u32 offset,\n void e1000_power_up_phy_copper(struct e1000_hw *hw)\n {\n \tu16 mii_reg = 0;\n-\tu16 power_reg = 0;\n \n \t/* The PHY will retain its settings across a power down/up cycle */\n \thw->phy.ops.read_reg(hw, PHY_CONTROL, &mii_reg);\n \tmii_reg &= ~MII_CR_POWER_DOWN;\n-\tif (hw->phy.type == e1000_phy_i210) {\n-\t\thw->phy.ops.read_reg(hw, GS40G_COPPER_SPEC, &power_reg);\n-\t\tpower_reg &= ~GS40G_CS_POWER_DOWN;\n-\t\thw->phy.ops.write_reg(hw, GS40G_COPPER_SPEC, power_reg);\n-\t}\n \thw->phy.ops.write_reg(hw, PHY_CONTROL, mii_reg);\n }\n \n@@ -3522,17 +3516,10 @@ void e1000_power_up_phy_copper(struct e1000_hw *hw)\n void e1000_power_down_phy_copper(struct e1000_hw *hw)\n {\n \tu16 mii_reg = 0;\n-\tu16 power_reg = 0;\n \n \t/* The PHY will retain its settings across a power down/up cycle */\n \thw->phy.ops.read_reg(hw, PHY_CONTROL, &mii_reg);\n \tmii_reg |= MII_CR_POWER_DOWN;\n-\t/* i210 Phy requires an additional bit for power up/down */\n-\tif (hw->phy.type == e1000_phy_i210) {\n-\t\thw->phy.ops.read_reg(hw, GS40G_COPPER_SPEC, &power_reg);\n-\t\tpower_reg |= GS40G_CS_POWER_DOWN;\n-\t\thw->phy.ops.write_reg(hw, GS40G_COPPER_SPEC, power_reg);\n-\t}\n \thw->phy.ops.write_reg(hw, PHY_CONTROL, mii_reg);\n \tmsec_delay(1);\n }\n@@ -3563,7 +3550,6 @@ STATIC s32 __e1000_read_phy_reg_hv(struct e1000_hw *hw, u32 offset, u16 *data,\n \t\tif (ret_val)\n \t\t\treturn ret_val;\n \t}\n-\n \t/* Page 800 works differently than the rest so it has its own func */\n \tif (page == BM_WUC_PAGE) {\n \t\tret_val = e1000_access_phy_wakeup_reg_bm(hw, offset, data,\n@@ -3673,7 +3659,6 @@ STATIC s32 __e1000_write_phy_reg_hv(struct e1000_hw *hw, u32 offset, u16 data,\n \t\tif (ret_val)\n \t\t\treturn ret_val;\n \t}\n-\n \t/* Page 800 works differently than the rest so it has its own func */\n \tif (page == BM_WUC_PAGE) {\n \t\tret_val = e1000_access_phy_wakeup_reg_bm(hw, offset, &data,\ndiff --git a/drivers/net/e1000/base/e1000_phy.h b/drivers/net/e1000/base/e1000_phy.h\nindex b30b36e..2b78af0 100644\n--- a/drivers/net/e1000/base/e1000_phy.h\n+++ b/drivers/net/e1000/base/e1000_phy.h\n@@ -143,7 +143,6 @@ bool e1000_is_mphy_ready(struct e1000_hw *hw);\n #define GS40G_MAC_LB\t\t\t0x4140\n #define GS40G_MAC_SPEED_1G\t\t0X0006\n #define GS40G_COPPER_SPEC\t\t0x0010\n-#define GS40G_CS_POWER_DOWN\t\t0x0002\n \n /* BM/HV Specific Registers */\n #define BM_PORT_CTRL_PAGE\t\t769\n", "prefixes": [ "dpdk-dev", "v2", "05/35" ] }