Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/76066/?format=api
{ "id": 76066, "url": "https://patches.dpdk.org/api/patches/76066/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200827073120.48772-2-alvinx.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200827073120.48772-2-alvinx.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200827073120.48772-2-alvinx.zhang@intel.com", "date": "2020-08-27T07:31:20", "name": "[2/2] net/iavf: support outer IP hash for GTPC", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "41e9556fde805bf1ada702a3e527b87d8062fed4", "submitter": { "id": 1398, "url": "https://patches.dpdk.org/api/people/1398/?format=api", "name": "Alvin Zhang", "email": "alvinx.zhang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200827073120.48772-2-alvinx.zhang@intel.com/mbox/", "series": [ { "id": 11818, "url": "https://patches.dpdk.org/api/series/11818/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11818", "date": "2020-08-27T07:31:19", "name": "[1/2] common/iavf: add GTPC support", "version": 1, "mbox": "https://patches.dpdk.org/series/11818/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/76066/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/76066/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BF2E4A04B1;\n\tThu, 27 Aug 2020 09:35:29 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D54D61C0B0;\n\tThu, 27 Aug 2020 09:35:24 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by dpdk.org (Postfix) with ESMTP id 94E0B1B951\n for <dev@dpdk.org>; Thu, 27 Aug 2020 09:35:20 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Aug 2020 00:35:18 -0700", "from shwdenpg235.ccr.corp.intel.com ([10.240.182.60])\n by orsmga002.jf.intel.com with ESMTP; 27 Aug 2020 00:35:16 -0700" ], "IronPort-SDR": [ "\n 0Sf/VsH5zk1oF8/gjXrTznQ1fwnW4i0bqMw3scltlDnt0yA8vKeGlysdqC/548puAUAaNV7l+B\n eWzMNM9TexKQ==", "\n 01Mi77PEOukCeujZRITiwtCafwlgKJmCk8g7TJLBgdhaowMB8TfkzzulkvnDRToSdNdrYv4cy6\n IES5l+Eix7cw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9725\"; a=\"156442301\"", "E=Sophos;i=\"5.76,359,1592895600\"; d=\"scan'208\";a=\"156442301\"", "E=Sophos;i=\"5.76,359,1592895600\"; d=\"scan'208\";a=\"313147069\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "alvinx.zhang@intel.com", "To": "jia.guo@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "dev@dpdk.org,\n\tAlvin Zhang <alvinx.zhang@intel.com>", "Date": "Thu, 27 Aug 2020 15:31:20 +0800", "Message-Id": "<20200827073120.48772-2-alvinx.zhang@intel.com>", "X-Mailer": "git-send-email 2.21.0.windows.1", "In-Reply-To": "<20200827073120.48772-1-alvinx.zhang@intel.com>", "References": "<20200827073120.48772-1-alvinx.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/2] net/iavf: support outer IP hash for GTPC", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Alvin Zhang <alvinx.zhang@intel.com>\n\nAdd patterns for GTPC, now outer IP hash can be configured as input set for\nGTPC packet.\n\nSigned-off-by: Alvin Zhang <alvinx.zhang@intel.com>\n---\n drivers/net/iavf/iavf_generic_flow.c | 36 +++++++++++\n drivers/net/iavf/iavf_generic_flow.h | 8 +++\n drivers/net/iavf/iavf_hash.c | 122 ++++++++++++++++++++++++++++++++++-\n 3 files changed, 164 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/iavf/iavf_generic_flow.c b/drivers/net/iavf/iavf_generic_flow.c\nindex 321a4dc..44fab4d 100644\n--- a/drivers/net/iavf/iavf_generic_flow.c\n+++ b/drivers/net/iavf/iavf_generic_flow.c\n@@ -315,6 +315,24 @@ enum rte_flow_item_type iavf_pattern_eth_qinq_ipv6_icmp6[] = {\n \tRTE_FLOW_ITEM_TYPE_END,\n };\n \n+/* IPV4 GTPC */\n+enum rte_flow_item_type iavf_pattern_eth_ipv4_gtpc[] = {\n+\tRTE_FLOW_ITEM_TYPE_ETH,\n+\tRTE_FLOW_ITEM_TYPE_IPV4,\n+\tRTE_FLOW_ITEM_TYPE_UDP,\n+\tRTE_FLOW_ITEM_TYPE_GTPC,\n+\tRTE_FLOW_ITEM_TYPE_END,\n+};\n+\n+enum rte_flow_item_type iavf_pattern_eth_vlan_ipv4_gtpc[] = {\n+\tRTE_FLOW_ITEM_TYPE_ETH,\n+\tRTE_FLOW_ITEM_TYPE_VLAN,\n+\tRTE_FLOW_ITEM_TYPE_IPV4,\n+\tRTE_FLOW_ITEM_TYPE_UDP,\n+\tRTE_FLOW_ITEM_TYPE_GTPC,\n+\tRTE_FLOW_ITEM_TYPE_END,\n+};\n+\n /* IPV4 GTPU (EH) */\n enum rte_flow_item_type iavf_pattern_eth_ipv4_gtpu[] = {\n \tRTE_FLOW_ITEM_TYPE_ETH,\n@@ -333,6 +351,24 @@ enum rte_flow_item_type iavf_pattern_eth_ipv4_gtpu_eh[] = {\n \tRTE_FLOW_ITEM_TYPE_END,\n };\n \n+/* IPV6 GTPC */\n+enum rte_flow_item_type iavf_pattern_eth_ipv6_gtpc[] = {\n+\tRTE_FLOW_ITEM_TYPE_ETH,\n+\tRTE_FLOW_ITEM_TYPE_IPV6,\n+\tRTE_FLOW_ITEM_TYPE_UDP,\n+\tRTE_FLOW_ITEM_TYPE_GTPC,\n+\tRTE_FLOW_ITEM_TYPE_END,\n+};\n+\n+enum rte_flow_item_type iavf_pattern_eth_vlan_ipv6_gtpc[] = {\n+\tRTE_FLOW_ITEM_TYPE_ETH,\n+\tRTE_FLOW_ITEM_TYPE_VLAN,\n+\tRTE_FLOW_ITEM_TYPE_IPV6,\n+\tRTE_FLOW_ITEM_TYPE_UDP,\n+\tRTE_FLOW_ITEM_TYPE_GTPC,\n+\tRTE_FLOW_ITEM_TYPE_END,\n+};\n+\n /* IPV6 GTPU (EH) */\n enum rte_flow_item_type iavf_pattern_eth_ipv6_gtpu[] = {\n \tRTE_FLOW_ITEM_TYPE_ETH,\ndiff --git a/drivers/net/iavf/iavf_generic_flow.h b/drivers/net/iavf/iavf_generic_flow.h\nindex f365cc3..eb466f9 100644\n--- a/drivers/net/iavf/iavf_generic_flow.h\n+++ b/drivers/net/iavf/iavf_generic_flow.h\n@@ -182,10 +182,18 @@\n extern enum rte_flow_item_type iavf_pattern_eth_vlan_ipv6_icmp6[];\n extern enum rte_flow_item_type iavf_pattern_eth_qinq_ipv6_icmp6[];\n \n+/* IPV4 GTPC */\n+extern enum rte_flow_item_type iavf_pattern_eth_ipv4_gtpc[];\n+extern enum rte_flow_item_type iavf_pattern_eth_vlan_ipv4_gtpc[];\n+\n /* IPv4 GTPU (EH) */\n extern enum rte_flow_item_type iavf_pattern_eth_ipv4_gtpu[];\n extern enum rte_flow_item_type iavf_pattern_eth_ipv4_gtpu_eh[];\n \n+/* IPV4 GTPC */\n+extern enum rte_flow_item_type iavf_pattern_eth_ipv6_gtpc[];\n+extern enum rte_flow_item_type iavf_pattern_eth_vlan_ipv6_gtpc[];\n+\n /* IPv6 GTPU (EH) */\n extern enum rte_flow_item_type iavf_pattern_eth_ipv6_gtpu[];\n extern enum rte_flow_item_type iavf_pattern_eth_ipv6_gtpu_eh[];\ndiff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c\nindex c06b52e..7bc32b0 100644\n--- a/drivers/net/iavf/iavf_hash.c\n+++ b/drivers/net/iavf/iavf_hash.c\n@@ -41,6 +41,8 @@ enum iavf_pattern_hint_type {\n \tIAVF_PHINT_IPV6_GTPU_EH\t\t\t= 0x00002000,\n \tIAVF_PHINT_IPV6_GTPU_EH_DWNLINK\t\t= 0x00004000,\n \tIAVF_PHINT_IPV6_GTPU_EH_UPLINK\t\t= 0x00008000,\n+\tIAVF_PHINT_IPV4_GTPC\t\t\t= 0x00010000,\n+\tIAVF_PHINT_IPV6_GTPC\t\t\t= 0x00020000,\n };\n \n #define IAVF_GTPU_EH_DWNLINK\t0\n@@ -189,6 +191,10 @@ struct iavf_hash_flow_cfg {\n \tIAVF_PHINT_IPV6_TCP};\n static struct iavf_pattern_match_type phint_eth_vlan_ipv6_sctp = {\n \tIAVF_PHINT_IPV6_SCTP};\n+static struct iavf_pattern_match_type phint_eth_ipv4_gtpc = {\n+\tIAVF_PHINT_IPV4_GTPC };\n+static struct iavf_pattern_match_type phint_eth_ipv6_gtpc = {\n+\tIAVF_PHINT_IPV6_GTPC };\n \n /**\n * Supported pattern for hash.\n@@ -281,6 +287,12 @@ struct iavf_hash_flow_cfg {\n \t\t\t\t\t&phint_eth_vlan_ipv6_tcp},\n \t{iavf_pattern_eth_vlan_ipv6_sctp, IAVF_INSET_NONE,\n \t\t\t\t\t&phint_eth_vlan_ipv6_sctp},\n+\t{iavf_pattern_eth_ipv4_gtpc, IAVF_INSET_NONE, &phint_eth_ipv4_gtpc},\n+\t{iavf_pattern_eth_ipv6_gtpc, IAVF_INSET_NONE, &phint_eth_ipv6_gtpc},\n+\t{iavf_pattern_eth_vlan_ipv4_gtpc, IAVF_INSET_NONE,\n+\t\t\t\t\t&phint_eth_ipv4_gtpc},\n+\t{iavf_pattern_eth_vlan_ipv6_gtpc, IAVF_INSET_NONE,\n+\t\t\t\t\t&phint_eth_ipv6_gtpc},\n \t{iavf_pattern_empty, IAVF_INSET_NONE, &phint_empty},\n };\n \n@@ -290,6 +302,7 @@ struct iavf_hash_flow_cfg {\n #define PROTO_COUNT_ONE\t\t\t1\n #define PROTO_COUNT_TWO\t\t\t2\n #define PROTO_COUNT_THREE\t\t3\n+#define PROTO_COUNT_FOUR\t\t4\n \n #define BUFF_NOUSED\t\t\t0\n #define FIELD_FOR_PROTO_ONLY\t\t0\n@@ -445,6 +458,10 @@ struct iavf_hash_flow_cfg {\n \tFIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_DST) | \\\n \tFIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV6_PROT), {BUFF_NOUSED } }\n \n+#define proto_hint_gtpc_only { \\\n+\tVIRTCHNL_PROTO_HDR_GTPC, \\\n+\tFIELD_FOR_PROTO_ONLY, {BUFF_NOUSED } }\n+\n #define proto_hint_gtpu_ip_teid { \\\n \tVIRTCHNL_PROTO_HDR_GTPU_IP, \\\n \tFIELD_SELECTOR(VIRTCHNL_PROTO_HDR_GTPU_IP_TEID), {BUFF_NOUSED } }\n@@ -770,6 +787,37 @@ struct virtchnl_proto_hdrs hdrs_hint_ipv4_udp_esp = {\n \tproto_hint_udp_only, proto_hint_esp }\n };\n \n+/* IPv4 GTPC */\n+struct virtchnl_proto_hdrs hdrs_hint_ipv4_gtpc = {\n+\tTUNNEL_LEVEL_OUTER, PROTO_COUNT_THREE, {proto_hint_ipv4,\n+\tproto_hint_udp_only, proto_hint_gtpc_only}\n+};\n+\n+struct virtchnl_proto_hdrs hdrs_hint_ipv4_dst_gtpc = {\n+\tTUNNEL_LEVEL_OUTER, PROTO_COUNT_THREE, {proto_hint_ipv4_dst,\n+\tproto_hint_udp_only, proto_hint_gtpc_only}\n+};\n+\n+struct virtchnl_proto_hdrs hdrs_hint_ipv4_src_gtpc = {\n+\tTUNNEL_LEVEL_OUTER, PROTO_COUNT_THREE, {proto_hint_ipv4_src,\n+\tproto_hint_udp_only, proto_hint_gtpc_only}\n+};\n+\n+struct virtchnl_proto_hdrs hdrs_hint_cvlan_ipv4_gtpc = {\n+\tTUNNEL_LEVEL_OUTER, PROTO_COUNT_FOUR, {proto_hint_cvlan,\n+\tproto_hint_ipv4, proto_hint_udp_only, proto_hint_gtpc_only}\n+};\n+\n+struct virtchnl_proto_hdrs hdrs_hint_cvlan_ipv4_dst_gtpc = {\n+\tTUNNEL_LEVEL_OUTER, PROTO_COUNT_FOUR, {proto_hint_cvlan,\n+\tproto_hint_ipv4_dst, proto_hint_udp_only, proto_hint_gtpc_only}\n+};\n+\n+struct virtchnl_proto_hdrs hdrs_hint_cvlan_ipv4_src_gtpc = {\n+\tTUNNEL_LEVEL_OUTER, PROTO_COUNT_FOUR, {proto_hint_cvlan,\n+\tproto_hint_ipv4_src, proto_hint_udp_only, proto_hint_gtpc_only}\n+};\n+\n /* IPv4 GTPU IP */\n \n struct virtchnl_proto_hdrs hdrs_hint_ipv4_src_gtpu_ip = {\n@@ -891,6 +939,37 @@ struct virtchnl_proto_hdrs hdrs_hint_teid_gtpu_ip = {\n \tTUNNEL_LEVEL_FIRST_INNER, PROTO_COUNT_TWO, {proto_hint_gtpu_ip_teid}\n };\n \n+/* IPv6 GTPC */\n+struct virtchnl_proto_hdrs hdrs_hint_ipv6_gtpc = {\n+\tTUNNEL_LEVEL_OUTER, PROTO_COUNT_THREE, {proto_hint_ipv6,\n+\tproto_hint_udp_only, proto_hint_gtpc_only}\n+};\n+\n+struct virtchnl_proto_hdrs hdrs_hint_ipv6_dst_gtpc = {\n+\tTUNNEL_LEVEL_OUTER, PROTO_COUNT_THREE, {proto_hint_ipv6_dst,\n+\tproto_hint_udp_only, proto_hint_gtpc_only}\n+};\n+\n+struct virtchnl_proto_hdrs hdrs_hint_ipv6_src_gtpc = {\n+\tTUNNEL_LEVEL_OUTER, PROTO_COUNT_THREE, {proto_hint_ipv6_src,\n+\tproto_hint_udp_only, proto_hint_gtpc_only}\n+};\n+\n+struct virtchnl_proto_hdrs hdrs_hint_cvlan_ipv6_gtpc = {\n+\tTUNNEL_LEVEL_OUTER, PROTO_COUNT_FOUR, {proto_hint_cvlan,\n+\tproto_hint_ipv6, proto_hint_udp_only, proto_hint_gtpc_only}\n+};\n+\n+struct virtchnl_proto_hdrs hdrs_hint_cvlan_ipv6_dst_gtpc = {\n+\tTUNNEL_LEVEL_OUTER, PROTO_COUNT_FOUR, {proto_hint_cvlan,\n+\tproto_hint_ipv6_dst, proto_hint_udp_only, proto_hint_gtpc_only}\n+};\n+\n+struct virtchnl_proto_hdrs hdrs_hint_cvlan_ipv6_src_gtpc = {\n+\tTUNNEL_LEVEL_OUTER, PROTO_COUNT_FOUR, {proto_hint_cvlan,\n+\tproto_hint_ipv6_src, proto_hint_udp_only, proto_hint_gtpc_only}\n+};\n+\n /* IPv6 GTPU IP */\n \n struct virtchnl_proto_hdrs hdrs_hint_ipv6_src_gtpu_ip = {\n@@ -2267,7 +2346,44 @@ struct iavf_hash_match_type iavf_hash_map_list[] = {\n };\n \n struct iavf_hash_match_type iavf_gtpu_hash_map_list[] = {\n-\t/* GTPU */\n+\t/* IPv4 GTPC */\n+\t{ETH_RSS_IPV4,\n+\t\t&hdrs_hint_ipv4_gtpc, IAVF_PHINT_IPV4_GTPC},\n+\t{ETH_RSS_IPV4 |\n+\t\tETH_RSS_L3_DST_ONLY,\n+\t\t&hdrs_hint_ipv4_dst_gtpc, IAVF_PHINT_IPV4_GTPC},\n+\t{ETH_RSS_IPV4 |\n+\t\tETH_RSS_L3_SRC_ONLY,\n+\t\t&hdrs_hint_ipv4_src_gtpc, IAVF_PHINT_IPV4_GTPC},\n+\t{ETH_RSS_C_VLAN |\n+\t\tETH_RSS_IPV4,\n+\t\t&hdrs_hint_cvlan_ipv4_gtpc, IAVF_PHINT_IPV4_GTPC},\n+\t{ETH_RSS_C_VLAN |\n+\t\tETH_RSS_IPV4 | ETH_RSS_L3_DST_ONLY,\n+\t\t&hdrs_hint_cvlan_ipv4_dst_gtpc, IAVF_PHINT_IPV4_GTPC},\n+\t{ETH_RSS_C_VLAN |\n+\t\tETH_RSS_IPV4 | ETH_RSS_L3_SRC_ONLY,\n+\t\t&hdrs_hint_cvlan_ipv4_src_gtpc, IAVF_PHINT_IPV4_GTPC},\n+\n+\t/* IPv6 GTPC */\n+\t{ETH_RSS_IPV6,\n+\t\t&hdrs_hint_ipv6_gtpc, IAVF_PHINT_IPV6_GTPC},\n+\t{ETH_RSS_IPV6 |\n+\t\tETH_RSS_L3_DST_ONLY,\n+\t\t&hdrs_hint_ipv6_dst_gtpc, IAVF_PHINT_IPV6_GTPC},\n+\t{ETH_RSS_IPV6 |\n+\t\tETH_RSS_L3_SRC_ONLY,\n+\t\t&hdrs_hint_ipv6_src_gtpc, IAVF_PHINT_IPV6_GTPC},\n+\t{ETH_RSS_C_VLAN |\n+\t\tETH_RSS_IPV6,\n+\t\t&hdrs_hint_cvlan_ipv6_gtpc, IAVF_PHINT_IPV6_GTPC},\n+\t{ETH_RSS_C_VLAN |\n+\t\tETH_RSS_IPV6 | ETH_RSS_L3_DST_ONLY,\n+\t\t&hdrs_hint_cvlan_ipv6_dst_gtpc, IAVF_PHINT_IPV6_GTPC},\n+\t{ETH_RSS_C_VLAN |\n+\t\tETH_RSS_IPV6 | ETH_RSS_L3_SRC_ONLY,\n+\t\t&hdrs_hint_cvlan_ipv6_src_gtpc, IAVF_PHINT_IPV6_GTPC},\n+\n \t/* GTPU IP */\n \t/* IPv4 GTPU IP IPv4*/\n \t{ETH_RSS_IPV4 |\n@@ -3841,7 +3957,9 @@ struct virtchnl_proto_hdrs *iavf_hash_default_hdrs[] = {\n \t\t\t (pattern_hint & IAVF_PHINT_IPV6_GTPU_IP) ||\n \t\t\t (pattern_hint & IAVF_PHINT_IPV6_GTPU_EH) ||\n \t\t\t (pattern_hint & IAVF_PHINT_IPV6_GTPU_EH_UPLINK) ||\n-\t\t\t (pattern_hint & IAVF_PHINT_IPV6_GTPU_EH_DWNLINK)) {\n+\t\t\t (pattern_hint & IAVF_PHINT_IPV6_GTPU_EH_DWNLINK) ||\n+\t\t\t (pattern_hint & IAVF_PHINT_IPV4_GTPC) ||\n+\t\t\t (pattern_hint & IAVF_PHINT_IPV6_GTPC)) {\n \t\t\t\thash_map_list = iavf_gtpu_hash_map_list;\n \t\t\t\tmlist_len = RTE_DIM(iavf_gtpu_hash_map_list);\n \t\t\t} else {\n", "prefixes": [ "2/2" ] }