Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/7602/?format=api
{ "id": 7602, "url": "https://patches.dpdk.org/api/patches/7602/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/d209690bda34d966299f000d63c0451b969262b0.1444818124.git.pmatilai@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<d209690bda34d966299f000d63c0451b969262b0.1444818124.git.pmatilai@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/d209690bda34d966299f000d63c0451b969262b0.1444818124.git.pmatilai@redhat.com", "date": "2015-10-14T10:22:04", "name": "[dpdk-dev] eal: default to one memory channel if not specified", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "29753fe88447a464eb220230d9c56f6901599a5e", "submitter": { "id": 169, "url": "https://patches.dpdk.org/api/people/169/?format=api", "name": "Panu Matilainen", "email": "pmatilai@redhat.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/d209690bda34d966299f000d63c0451b969262b0.1444818124.git.pmatilai@redhat.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/7602/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/7602/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 003338D99;\n\tWed, 14 Oct 2015 12:23:09 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id DF1265A64\n\tfor <dev@dpdk.org>; Wed, 14 Oct 2015 12:23:07 +0200 (CEST)", "from int-mx14.intmail.prod.int.phx2.redhat.com\n\t(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])\n\tby mx1.redhat.com (Postfix) with ESMTPS id 424C88E70B;\n\tWed, 14 Oct 2015 10:23:07 +0000 (UTC)", "from dhcp195.koti.laiskiainen.org.com (vpn1-7-71.ams2.redhat.com\n\t[10.36.7.71])\n\tby int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tESMTP id t9EAN5oV004753; Wed, 14 Oct 2015 06:23:06 -0400" ], "From": "Panu Matilainen <pmatilai@redhat.com>", "To": "dev@dpdk.org", "Date": "Wed, 14 Oct 2015 13:22:04 +0300", "Message-Id": "<d209690bda34d966299f000d63c0451b969262b0.1444818124.git.pmatilai@redhat.com>", "X-Scanned-By": "MIMEDefang 2.68 on 10.5.11.27", "Subject": "[dpdk-dev] [PATCH] eal: default to one memory channel if not\n\tspecified", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Obtaining the correct value, especially from a running system, can\nbe anything from difficult to plain impossible. Since the value is\nmerely an optimization and does not affect functionality otherwise,\nits pointless to force such a guess on users initially, such things\nbelong to performance tuning phase.\n\nSigned-off-by: Panu Matilainen <pmatilai@redhat.com>\n---\n lib/librte_eal/common/eal_common_options.c | 10 ++--------\n 1 file changed, 2 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c\nindex 1f459ac..28f10a2 100644\n--- a/lib/librte_eal/common/eal_common_options.c\n+++ b/lib/librte_eal/common/eal_common_options.c\n@@ -104,7 +104,7 @@ eal_reset_internal_config(struct internal_config *internal_cfg)\n \n \tinternal_cfg->memory = 0;\n \tinternal_cfg->force_nrank = 0;\n-\tinternal_cfg->force_nchannel = 0;\n+\tinternal_cfg->force_nchannel = 1;\n \tinternal_cfg->hugefile_prefix = HUGEFILE_PREFIX_DEFAULT;\n \tinternal_cfg->hugepage_dir = NULL;\n \tinternal_cfg->force_sockets = 0;\n@@ -834,12 +834,6 @@ eal_check_common_options(struct internal_config *internal_cfg)\n \t\tRTE_LOG(ERR, EAL, \"Invalid process type specified\\n\");\n \t\treturn -1;\n \t}\n-\tif (internal_cfg->process_type == RTE_PROC_PRIMARY &&\n-\t\t\tinternal_cfg->force_nchannel == 0) {\n-\t\tRTE_LOG(ERR, EAL, \"Number of memory channels (-n) not \"\n-\t\t\t\"specified\\n\");\n-\t\treturn -1;\n-\t}\n \tif (index(internal_cfg->hugefile_prefix, '%') != NULL) {\n \t\tRTE_LOG(ERR, EAL, \"Invalid char, '%%', in --\"OPT_FILE_PREFIX\" \"\n \t\t\t\"option\\n\");\n@@ -869,7 +863,7 @@ eal_check_common_options(struct internal_config *internal_cfg)\n void\n eal_common_usage(void)\n {\n-\tprintf(\"-c COREMASK|-l CORELIST -n CHANNELS [options]\\n\\n\"\n+\tprintf(\"-c COREMASK|-l CORELIST [options]\\n\\n\"\n \t \"EAL common options:\\n\"\n \t \" -c COREMASK Hexadecimal bitmask of cores to run on\\n\"\n \t \" -l CORELIST List of cores to run on\\n\"\n", "prefixes": [ "dpdk-dev" ] }