Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75801/?format=api
{ "id": 75801, "url": "https://patches.dpdk.org/api/patches/75801/?format=api", "web_url": "https://patches.dpdk.org/project/dts/patch/1597971298-6514-1-git-send-email-lihongx.ma@intel.com/", "project": { "id": 3, "url": "https://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<1597971298-6514-1-git-send-email-lihongx.ma@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/1597971298-6514-1-git-send-email-lihongx.ma@intel.com", "date": "2020-08-21T00:54:58", "name": "[V1] nic_single_core: add 1C/2T fwd core for test", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "803c45e09c366fcda504679199992d1a64e15e46", "submitter": { "id": 1641, "url": "https://patches.dpdk.org/api/people/1641/?format=api", "name": "Ma, LihongX", "email": "lihongx.ma@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dts/patch/1597971298-6514-1-git-send-email-lihongx.ma@intel.com/mbox/", "series": [ { "id": 11738, "url": "https://patches.dpdk.org/api/series/11738/?format=api", "web_url": "https://patches.dpdk.org/project/dts/list/?series=11738", "date": "2020-08-21T00:54:58", "name": "[V1] nic_single_core: add 1C/2T fwd core for test", "version": 1, "mbox": "https://patches.dpdk.org/series/11738/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/75801/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/75801/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4838BA04AF;\n\tFri, 21 Aug 2020 10:28:18 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E07CC5F69;\n\tFri, 21 Aug 2020 10:28:17 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by dpdk.org (Postfix) with ESMTP id 3454B4CA6\n for <dts@dpdk.org>; Fri, 21 Aug 2020 10:28:15 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Aug 2020 01:28:12 -0700", "from dpdk-lihong-ub1604.sh.intel.com ([10.67.118.174])\n by fmsmga006.fm.intel.com with ESMTP; 21 Aug 2020 01:28:12 -0700" ], "IronPort-SDR": [ "\n pmwztKwRe+cUREfrxSeMay/xjUWAreGiPZqO+LZzu1UAutvw8TN7btV9iYcpH1F++VN7BP+BKw\n Rx4f9QsRMqhw==", "\n WLda5qxkHEASrdb7vkCp7cT+SLNbZ8XPMUfVsIbHdWikoLXj75d4o061HAntSiYpRo5YxcTXlW\n 5RYVbiAW1IEQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9719\"; a=\"152899246\"", "E=Sophos;i=\"5.76,335,1592895600\"; d=\"scan'208\";a=\"152899246\"", "E=Sophos;i=\"5.76,335,1592895600\"; d=\"scan'208\";a=\"497912032\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "LihongX Ma <lihongx.ma@intel.com>", "To": "dts@dpdk.org", "Cc": "YingyaX.Han@intel.com,\n\tlihong <lihongx.ma@intel.com>", "Date": "Fri, 21 Aug 2020 08:54:58 +0800", "Message-Id": "<1597971298-6514-1-git-send-email-lihongx.ma@intel.com>", "X-Mailer": "git-send-email 2.7.4", "Subject": "[dts] [PATCH V1] nic_single_core: add 1C/2T fwd core for test", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org", "Sender": "\"dts\" <dts-bounces@dpdk.org>" }, "content": "From: lihong <lihongx.ma@intel.com>\n\nadd 1C/2T to the suite nic_single_core for test\n\nSigned-off-by: LihongX Ma <lihongx.ma@intel.com>\n---\n conf/nic_single_core_perf.cfg | 38 ++++--\n tests/TestSuite_nic_single_core_perf.py | 221 +++++++++++++++++---------------\n 2 files changed, 148 insertions(+), 111 deletions(-)", "diff": "diff --git a/conf/nic_single_core_perf.cfg b/conf/nic_single_core_perf.cfg\nindex 4c283c9..e7bf3b2 100644\n--- a/conf/nic_single_core_perf.cfg\n+++ b/conf/nic_single_core_perf.cfg\n@@ -30,15 +30,35 @@\n \n [suite]\n update_expected = True\n-test_parameters = {64: [512, 2048]}\n+test_parameters = {'1C/1T': {64: [512, 2048]},\n+ '1C/2T': {64: [512, 2048]}}\n test_duration = 60\n accepted_tolerance = 1\n expected_throughput = {\n- 'fortville_spirit': {64: {512: 0.00, 2048: 0.00}},\n- 'niantic': {64: {128: 0.00, 512: 0.00, 2048: 0.00}},\n- 'fortville_25g': {64: {512: 0.00, 2048: 0.00}},\n- 'columbiaville_100g': {64: {512: 0.00, 2048: 0.00}},\n- 'columbiaville_25g': {64: {512: 0.00, 2048: 0.00}},\n- 'ConnectX4_LX_MT4117': {'40G': {64: {128: 0.00, 256: 0.00, 512: 0.00, 2048: 0.00}},\n- '25G': {64: {128: 0.00, 256: 0.00, 512: 0.00, 2048: 0.00}}},\n- 'ConnectX5_MT4121': {64: {128: 0.00, 256: 0.00, 512: 0.00, 2048: 0.00}}}\n+ 'fortville_spirit': {\n+ '1C/1T': {64: {512: 0.00, 2048: 0.00}},\n+ '1C/2T': {64: {512: 0.00, 2048: 0.00}}},\n+ 'fortville_eagle': {\n+ '1C/1T':{64: {512: 0.00, 2048: 0.00}},\n+ '1C/2T':{64: {512: 0.00, 2048: 0.00}}},\n+ 'niantic': {\n+ '1C/1T': {64: {128: 0.00, 512: 0.00, 2048: 0.00}},\n+ '1C/2T': {64: {128: 0.00, 512: 0.00, 2048: 0.00}}},\n+ 'fortville_25g': {\n+ '1C/1T': {64: {512: 0.00, 2048: 0.00}},\n+ '1C/2T': {64: {512: 0.00, 2048: 0.00}}},\n+ 'columbiaville_100g': {\n+ '1C/1T': {64: {512: 0.00, 2048: 0.00}},\n+ '1C/2T': {64: {512: 0.00, 2048: 0.00}}},\n+ 'columbiaville_25g': {\n+ '1C/1T': {64: {512: 0.00, 2048: 0.00}},\n+ '1C/2T': {64: {512: 0.00, 2048: 0.00}}},\n+ 'ConnectX4_LX_MT4117': {'40G': {\n+ '1C/1T': {64: {128: 0.00, 256: 0.00, 512: 0.00, 2048: 0.00}},\n+ '1C/2T': {64: {128: 0.00, 256: 0.00, 512: 0.00, 2048: 0.00}}},\n+ '25G': {\n+ '1C/1T': {64: {128: 0.00, 256: 0.00, 512: 0.00, 2048: 0.00}},\n+ '1C/2T': {64: {128: 0.00, 256: 0.00, 512: 0.00, 2048: 0.00}}}},\n+ 'ConnectX5_MT4121': {\n+ '1C/1T': {64: {128: 0.00, 256: 0.00, 512: 0.00, 2048: 0.00}},\n+ '1C/2T': {64: {128: 0.00, 256: 0.00, 512: 0.00, 2048: 0.00}}}}\ndiff --git a/tests/TestSuite_nic_single_core_perf.py b/tests/TestSuite_nic_single_core_perf.py\nindex b4d82c1..3460252 100644\n--- a/tests/TestSuite_nic_single_core_perf.py\n+++ b/tests/TestSuite_nic_single_core_perf.py\n@@ -55,7 +55,6 @@ class TestNicSingleCorePerf(TestCase):\n self.verify(self.nic in ['niantic', 'fortville_25g', 'fortville_spirit', 'ConnectX5_MT4121',\n 'ConnectX4_LX_MT4117', 'columbiaville_100g', 'columbiaville_25g'],\n \"Not required NIC \")\n-\n self.headers_size = HEADER_SIZE['eth'] + HEADER_SIZE['ip']\n \n # Update DPDK config file and rebuild to get best perf on fortville\n@@ -120,7 +119,7 @@ class TestNicSingleCorePerf(TestCase):\n self.gap = self.get_suite_cfg()['accepted_tolerance']\n \n # header to print test result table\n- self.table_header = ['Frame Size', 'TXD/RXD', 'Throughput', 'Rate',\n+ self.table_header = ['Fwd_core', 'Frame Size', 'TXD/RXD', 'Throughput', 'Rate',\n 'Expected Throughput', 'Throughput Difference']\n self.test_result = {}\n \n@@ -204,10 +203,11 @@ class TestNicSingleCorePerf(TestCase):\n Update expected numbers to configurate file: conf/$suite_name.cfg\n \"\"\"\n if load_global_setting(UPDATE_EXPECTED) == \"yes\":\n- for frame_size in list(self.test_parameters.keys()):\n- for nb_desc in self.test_parameters[frame_size]:\n- self.expected_throughput[frame_size][nb_desc] = \\\n- round(self.throughput[frame_size][nb_desc], 3)\n+ for fwd_config in list(self.test_parameters.keys()):\n+ for frame_size in list(self.test_parameters[fwd_config].keys()):\n+ for nb_desc in self.test_parameters[fwd_config][frame_size]:\n+ self.expected_throughput[fwd_config][frame_size][nb_desc] = \\\n+ round(self.throughput[fwd_config][frame_size][nb_desc], 3)\n \n def perf_test(self, port_num):\n \"\"\"\n@@ -218,57 +218,69 @@ class TestNicSingleCorePerf(TestCase):\n for i in range(port_num):\n eal_para += \" -w \" + self.dut.ports_info[i]['pci']\n \n- # run testpmd with 2 cores, one for interaction ,and one for forwarding\n- core_config = \"1S/2C/1T\"\n- core_list = self.dut.get_core_list(core_config, socket=self.socket)\n- self.logger.info(\"Executing Test Using cores: %s\" % core_list)\n port_mask = utils.create_mask(self.dut_ports)\n \n- # parameters for application/testpmd\n- param = \" --portmask=%s\" % (port_mask)\n- # fortville has to use 2 queues at least to get the best performance\n- if self.nic in [\"fortville_25g\", \"fortville_spirit\"]:\n- param += \" --rxq=2 --txq=2\"\n- # columbiaville use one queue per port for best performance.\n- elif self.nic in [\"columbiaville_100g\", \"columbiaville_25g\"]:\n- param += \" --rxq=1 --txq=1\"\n- # workaround for that testpmd can't forward packets in io forward mode\n- param += \" --port-topology=loop\"\n-\n- for frame_size in list(self.test_parameters.keys()):\n- self.throughput[frame_size] = dict()\n- pcaps = self.create_pacap_file(frame_size, port_num)\n- tgenInput = self.prepare_stream(pcaps, port_num)\n- for nb_desc in self.test_parameters[frame_size]:\n- self.logger.info(\"Test running at parameters: \" +\n- \"framesize: {}, rxd/txd: {}\".format(frame_size, nb_desc))\n- parameter = param + \" --txd=%d --rxd=%d\" % (nb_desc, nb_desc)\n- self.pmdout.start_testpmd(\n- core_config, parameter, eal_para, socket=self.socket)\n- self.dut.send_expect(\"start\", \"testpmd> \", 15)\n-\n- vm_config = self.set_fields()\n- # clear streams before add new streams\n- self.tester.pktgen.clear_streams()\n-\n- # run packet generator\n- streams = self.pktgen_helper.prepare_stream_from_tginput(tgenInput, 100, vm_config, self.tester.pktgen)\n- # set traffic option\n- traffic_opt = {'duration': self.test_duration}\n- # _, pps = self.tester.traffic_generator_throughput(tgenInput, rate_percent=100, delay=30)\n- _, packets_received = self.tester.pktgen.measure_throughput(stream_ids=streams, options=traffic_opt)\n- self.verify(packets_received > 0, \"No traffic detected\")\n- throughput = packets_received / 1000000.0\n- self.throughput[frame_size][nb_desc] = throughput\n-\n- self.dut.send_expect(\"stop\", \"testpmd> \")\n- self.dut.send_expect(\"quit\", \"# \", 30)\n-\n- self.verify(throughput,\n- \"No traffic detected, please check your configuration\")\n- self.logger.info(\"Trouthput of \" +\n- \"framesize: {}, rxd/txd: {} is :{} Mpps\".format(\n- frame_size, nb_desc, throughput))\n+ for fwd_config in list(self.test_parameters.keys()):\n+ # parameters for application/testpmd\n+ param = \" --portmask=%s\" % (port_mask)\n+ # the fwd_config just the config for fwd core\n+ # to start testpmd should add 1C to it\n+ core_config = '1S/%s' % fwd_config\n+ thread_num = int(fwd_config[fwd_config.find('/')+1: fwd_config.find('T')])\n+ core_list = self.dut.get_core_list(core_config, socket=self.socket)\n+ self.verify(len(core_list) >= thread_num, \"the Hyper-threading not open, please open it to test\")\n+\n+ # need add one more core for start testpmd\n+ core_list = [core_list[0]] + [str(int(i) + 1) for i in core_list]\n+\n+ self.logger.info(\"Executing Test Using cores: %s of config %s\" % (core_list, fwd_config))\n+\n+ nb_cores = thread_num\n+\n+ # fortville has to use 2 queues at least to get the best performance\n+ if self.nic in [\"fortville_25g\", \"fortville_spirit\"] or thread_num == 2:\n+ param += \" --rxq=2 --txq=2\"\n+ # columbiaville use one queue per port for best performance.\n+ elif self.nic in [\"columbiaville_100g\", \"columbiaville_25g\"]:\n+ param += \" --rxq=1 --txq=1\"\n+ # workaround for that testpmd can't forward packets in io forward mode\n+ param += \" --port-topology=loop\"\n+\n+ self.throughput[fwd_config] = dict()\n+ for frame_size in list(self.test_parameters[fwd_config].keys()):\n+ self.throughput[fwd_config][frame_size] = dict()\n+ pcaps = self.create_pacap_file(frame_size, port_num)\n+ tgenInput = self.prepare_stream(pcaps, port_num)\n+ for nb_desc in self.test_parameters[fwd_config][frame_size]:\n+ self.logger.info(\"Test running at parameters: \" +\n+ \"framesize: {}, rxd/txd: {}\".format(frame_size, nb_desc))\n+ parameter = param + \" --txd=%d --rxd=%d --nb-cores=%d\" % (nb_desc, nb_desc, nb_cores)\n+ self.pmdout.start_testpmd(\n+ core_list, parameter, eal_para, socket=self.socket)\n+ self.dut.send_expect(\"start\", \"testpmd> \", 15)\n+\n+ vm_config = self.set_fields()\n+ # clear streams before add new streams\n+ self.tester.pktgen.clear_streams()\n+\n+ # run packet generator\n+ streams = self.pktgen_helper.prepare_stream_from_tginput(tgenInput, 100, vm_config, self.tester.pktgen)\n+ # set traffic option\n+ traffic_opt = {'duration': self.test_duration}\n+ # _, pps = self.tester.traffic_generator_throughput(tgenInput, rate_percent=100, delay=30)\n+ _, packets_received = self.tester.pktgen.measure_throughput(stream_ids=streams, options=traffic_opt)\n+ self.verify(packets_received > 0, \"No traffic detected\")\n+ throughput = packets_received / 1000000.0\n+ self.throughput[fwd_config][frame_size][nb_desc] = throughput\n+\n+ self.dut.send_expect(\"stop\", \"testpmd> \")\n+ self.dut.send_expect(\"quit\", \"# \", 30)\n+\n+ self.verify(throughput,\n+ \"No traffic detected, please check your configuration\")\n+ self.logger.info(\"Trouthput of \" +\n+ \"framesize: {}, rxd/txd: {} is :{} Mpps\".format(\n+ frame_size, nb_desc, throughput))\n \n return self.throughput\n \n@@ -282,35 +294,39 @@ class TestNicSingleCorePerf(TestCase):\n \n # save test results to self.test_result\n header = self.table_header\n- for frame_size in list(self.test_parameters.keys()):\n- wirespeed = self.wirespeed(self.nic, frame_size, self.nb_ports)\n+ for fwd_config in list(self.test_parameters.keys()):\n ret_datas = {}\n- for nb_desc in self.test_parameters[frame_size]:\n- ret_data = {}\n- ret_data[header[0]] = frame_size\n- ret_data[header[1]] = nb_desc\n- ret_data[header[2]] = \"{:.3f} Mpps\".format(\n- self.throughput[frame_size][nb_desc])\n- ret_data[header[3]] = \"{:.3f}%\".format(\n- self.throughput[frame_size][nb_desc] * 100 / wirespeed)\n- ret_data[header[4]] = \"{:.3f} Mpps\".format(\n- self.expected_throughput[frame_size][nb_desc])\n- ret_data[header[5]] = \"{:.3f} Mpps\".format(\n- self.throughput[frame_size][nb_desc] -\n- self.expected_throughput[frame_size][nb_desc])\n-\n- ret_datas[nb_desc] = deepcopy(ret_data)\n- self.test_result[frame_size] = deepcopy(ret_datas)\n+ for frame_size in list(self.test_parameters[fwd_config].keys()):\n+ wirespeed = self.wirespeed(self.nic, frame_size, self.nb_ports)\n+ ret_datas[frame_size] = {}\n+ for nb_desc in self.test_parameters[fwd_config][frame_size]:\n+ ret_data = {}\n+ ret_data[header[0]] = fwd_config\n+ ret_data[header[1]] = frame_size\n+ ret_data[header[2]] = nb_desc\n+ ret_data[header[3]] = \"{:.3f} Mpps\".format(\n+ self.throughput[fwd_config][frame_size][nb_desc])\n+ ret_data[header[4]] = \"{:.3f}%\".format(\n+ self.throughput[fwd_config][frame_size][nb_desc] * 100 / wirespeed)\n+ ret_data[header[5]] = \"{:.3f} Mpps\".format(\n+ self.expected_throughput[fwd_config][frame_size][nb_desc])\n+ ret_data[header[6]] = \"{:.3f} Mpps\".format(\n+ self.throughput[fwd_config][frame_size][nb_desc] -\n+ self.expected_throughput[fwd_config][frame_size][nb_desc])\n+\n+ ret_datas[frame_size][nb_desc] = deepcopy(ret_data)\n+ self.test_result[fwd_config] = deepcopy(ret_datas)\n \n # Create test results table\n self.result_table_create(header)\n- for frame_size in list(self.test_parameters.keys()):\n- for nb_desc in self.test_parameters[frame_size]:\n- table_row = list()\n- for i in range(len(header)):\n- table_row.append(\n- self.test_result[frame_size][nb_desc][header[i]])\n- self.result_table_add(table_row)\n+ for fwd_config in list(self.test_parameters.keys()):\n+ for frame_size in list(self.test_parameters[fwd_config].keys()):\n+ for nb_desc in self.test_parameters[fwd_config][frame_size]:\n+ table_row = list()\n+ for i in range(len(header)):\n+ table_row.append(\n+ self.test_result[fwd_config][frame_size][nb_desc][header[i]])\n+ self.result_table_add(table_row)\n # present test results to screen\n self.result_table_print()\n \n@@ -328,28 +344,29 @@ class TestNicSingleCorePerf(TestCase):\n case_name = self.running_case\n json_obj[case_name] = list()\n status_result = []\n- for frame_size in list(self.test_parameters.keys()):\n- for nb_desc in self.test_parameters[frame_size]:\n- row_in = self.test_result[frame_size][nb_desc]\n- row_dict0 = dict()\n- row_dict0['performance'] = list()\n- row_dict0['parameters'] = list()\n- result_throughput = float(row_in['Throughput'].split()[0])\n- expected_throughput = float(row_in['Expected Throughput'].split()[0])\n- # delta value and accepted tolerance in percentage\n- delta = result_throughput - expected_throughput\n- if delta > -self.gap:\n- row_dict0['status'] = 'PASS'\n- else:\n- row_dict0['status'] = 'FAIL'\n- row_dict1 = dict(name=\"Throughput\", value=result_throughput, unit=\"Mpps\", delta=delta)\n- row_dict2 = dict(name=\"Txd/Rxd\", value=row_in[\"TXD/RXD\"], unit=\"descriptor\")\n- row_dict3 = dict(name=\"frame_size\", value=row_in[\"Frame Size\"], unit=\"bytes\")\n- row_dict0['performance'].append(row_dict1)\n- row_dict0['parameters'].append(row_dict2)\n- row_dict0['parameters'].append(row_dict3)\n- json_obj[case_name].append(row_dict0)\n- status_result.append(row_dict0['status'])\n+ for fwd_config in list(self.test_parameters.keys()):\n+ for frame_size in list(self.test_parameters[fwd_config].keys()):\n+ for nb_desc in self.test_parameters[fwd_config][frame_size]:\n+ row_in = self.test_result[fwd_config][frame_size][nb_desc]\n+ row_dict0 = dict()\n+ row_dict0['performance'] = list()\n+ row_dict0['parameters'] = list()\n+ result_throughput = float(row_in['Throughput'].split()[0])\n+ expected_throughput = float(row_in['Expected Throughput'].split()[0])\n+ # delta value and accepted tolerance in percentage\n+ delta = result_throughput - expected_throughput\n+ if delta > -self.gap:\n+ row_dict0['status'] = 'PASS'\n+ else:\n+ row_dict0['status'] = 'FAIL'\n+ row_dict1 = dict(name=\"Throughput\", value=result_throughput, unit=\"Mpps\", delta=delta)\n+ row_dict2 = dict(name=\"Txd/Rxd\", value=row_in[\"TXD/RXD\"], unit=\"descriptor\")\n+ row_dict3 = dict(name=\"frame_size\", value=row_in[\"Frame Size\"], unit=\"bytes\")\n+ row_dict0['performance'].append(row_dict1)\n+ row_dict0['parameters'].append(row_dict2)\n+ row_dict0['parameters'].append(row_dict3)\n+ json_obj[case_name].append(row_dict0)\n+ status_result.append(row_dict0['status'])\n with open(os.path.join(rst.path2Result,\n '{0:s}_single_core_perf.json'.format(\n self.nic)), 'w') as fp:\n", "prefixes": [ "V1" ] }