Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75527/?format=api
{ "id": 75527, "url": "https://patches.dpdk.org/api/patches/75527/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1597360905-74106-8-git-send-email-navasile@linux.microsoft.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1597360905-74106-8-git-send-email-navasile@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1597360905-74106-8-git-send-email-navasile@linux.microsoft.com", "date": "2020-08-13T23:21:30", "name": "[07/22] doc: change the Windows UIO driver's default security descriptor to admin only", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ac6ca53a4838f4b5b5f9dee04c7012c276ae0282", "submitter": { "id": 1668, "url": "https://patches.dpdk.org/api/people/1668/?format=api", "name": "Narcisa Ana Maria Vasile", "email": "navasile@linux.microsoft.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1597360905-74106-8-git-send-email-navasile@linux.microsoft.com/mbox/", "series": [ { "id": 11644, "url": "https://patches.dpdk.org/api/series/11644/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11644", "date": "2020-08-13T23:21:23", "name": "windows/netuio: add netuio driver for Windows", "version": 1, "mbox": "https://patches.dpdk.org/series/11644/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/75527/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/75527/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 69F94A04B1;\n\tFri, 14 Aug 2020 01:24:02 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E605F1C136;\n\tFri, 14 Aug 2020 01:22:56 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by dpdk.org (Postfix) with ESMTP id EB4CC1C0D2\n for <dev@dpdk.org>; Fri, 14 Aug 2020 01:22:44 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1059)\n id C090020B4918; Thu, 13 Aug 2020 16:22:43 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com C090020B4918", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1597360963;\n bh=o9F3SfmbvtdoEhQhrzNxos1Y9SEqNdD4/z/Caj2hVVw=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=PCA/d480YIkj4/cfh3e5N6di4amo+0D9obgPBUuW9D+LwJSjsGu+MA2rgsgz8HNli\n oNB4QNQqdlym7X+4/8I9vx3N5z4iCKH+xZBaszRtXgzfvf1+sLff/+OcuX27ATHOfx\n VOFhn4A0wB742Lp7JRKIAJiHg21cwF4lvZaIo9h0=", "From": "Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>", "To": "dev@dpdk.org, thomas@monjalon.net, haramakr@linux.microsoft.com,\n ocardona@microsoft.com, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com", "Cc": "ranjit.menon@intel.com, dmitrym@microsoft.com,\n Harini Ramakrishnan <haramakr@microsoft.com>", "Date": "Thu, 13 Aug 2020 16:21:30 -0700", "Message-Id": "<1597360905-74106-8-git-send-email-navasile@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1597360905-74106-1-git-send-email-navasile@linux.microsoft.com>", "References": "<1597360905-74106-1-git-send-email-navasile@linux.microsoft.com>", "Subject": "[dpdk-dev] [PATCH 07/22] doc: change the Windows UIO driver's\n\tdefault security descriptor to admin only", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Harini Ramakrishnan <haramakr@microsoft.com>\n\n---\n kernel/windows/netuio/netuio_dev.c | 54 +++++++++++++++++-------------\n 1 file changed, 30 insertions(+), 24 deletions(-)", "diff": "diff --git a/kernel/windows/netuio/netuio_dev.c b/kernel/windows/netuio/netuio_dev.c\nindex 10ff5f903..4d8b9430d 100644\n--- a/kernel/windows/netuio/netuio_dev.c\n+++ b/kernel/windows/netuio/netuio_dev.c\n@@ -32,37 +32,43 @@ netuio_create_device(_Inout_ PWDFDEVICE_INIT DeviceInit)\n NTSTATUS status;\n \n PAGED_CODE();\n- WDF_OBJECT_ATTRIBUTES_INIT_CONTEXT_TYPE(&deviceAttributes, NETUIO_CONTEXT_DATA);\n \n- // Set the device context cleanup callback.\n- // This function will be called when the WDF Device Object associated to the current device is destroyed\n- deviceAttributes.EvtCleanupCallback = netuio_evt_device_context_cleanup;\n+\t// Ensure that only administrators can access our device object.\n+\tstatus = WdfDeviceInitAssignSDDLString(DeviceInit, &SDDL_DEVOBJ_SYS_ALL_ADM_ALL);\n \n- status = WdfDeviceCreate(&DeviceInit, &deviceAttributes, &device);\n+\tif (NT_SUCCESS(status)) {\n+\t\tWDF_OBJECT_ATTRIBUTES_INIT_CONTEXT_TYPE(&deviceAttributes, NETUIO_CONTEXT_DATA);\n \n- if (NT_SUCCESS(status)) {\n- // Create a device interface so that applications can find and talk to us.\n- status = WdfDeviceCreateDeviceInterface(device, &GUID_DEVINTERFACE_netUIO, NULL);\n+\t\t// Set the device context cleanup callback.\n+\t\t// This function will be called when the WDF Device Object associated to the current device is destroyed\n+\t\tdeviceAttributes.EvtCleanupCallback = netuio_evt_device_context_cleanup;\n \n- if (NT_SUCCESS(status)) {\n- // Retrieve and store PCI information\n- status = get_pci_device_info(device);\n- }\n+\t\tstatus = WdfDeviceCreate(&DeviceInit, &deviceAttributes, &device);\n+\t}\n \n- if (NT_SUCCESS(status)) {\n- // Create a symbolic link name for user-space access\n- status = create_device_specific_symbolic_link(device);\n- }\n+\tif (NT_SUCCESS(status)) {\n+\t\t// Create a device interface so that applications can find and talk to us.\n+\t\tstatus = WdfDeviceCreateDeviceInterface(device, &GUID_DEVINTERFACE_netUIO, NULL);\n+\t}\n \n- if (NT_SUCCESS(status)) {\n- // Initialize the I/O Package and any Queues\n- status = netuio_queue_initialize(device);\n- }\n+ if (NT_SUCCESS(status)) {\n+ // Retrieve and store PCI information\n+ status = get_pci_device_info(device);\n+ }\n \n- if (NT_SUCCESS(status)) {\n- // Allocate physically contiguous memory for user process use. We'll map it later\n- status = allocate_usermemory_segment(device);\n- }\n+ if (NT_SUCCESS(status)) {\n+ // Create a symbolic link name for user-space access\n+ status = create_device_specific_symbolic_link(device);\n+ }\n+\n+ if (NT_SUCCESS(status)) {\n+ // Initialize the I/O Package and any Queues\n+ status = netuio_queue_initialize(device);\n+ }\n+\n+ if (NT_SUCCESS(status)) {\n+ // Allocate physically contiguous memory for user process use. We'll map it later\n+ status = allocate_usermemory_segment(device);\n }\n \n return status;\n", "prefixes": [ "07/22" ] }