Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75373/?format=api
{ "id": 75373, "url": "https://patches.dpdk.org/api/patches/75373/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200811072752.20813-1-stevex.yang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200811072752.20813-1-stevex.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200811072752.20813-1-stevex.yang@intel.com", "date": "2020-08-11T07:27:52", "name": "net/iavf: release port upon close", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0c8139d48101637d85b71e29985d1800ceb831f7", "submitter": { "id": 1883, "url": "https://patches.dpdk.org/api/people/1883/?format=api", "name": "Steve Yang", "email": "stevex.yang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200811072752.20813-1-stevex.yang@intel.com/mbox/", "series": [ { "id": 11585, "url": "https://patches.dpdk.org/api/series/11585/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11585", "date": "2020-08-11T07:27:52", "name": "net/iavf: release port upon close", "version": 1, "mbox": "https://patches.dpdk.org/series/11585/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/75373/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/75373/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4BE11A04C5;\n\tTue, 11 Aug 2020 09:32:15 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DB0F11B203;\n\tTue, 11 Aug 2020 09:32:14 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by dpdk.org (Postfix) with ESMTP id CDE0AE07\n for <dev@dpdk.org>; Tue, 11 Aug 2020 09:32:12 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 11 Aug 2020 00:32:11 -0700", "from intel-npg-odc-srv01.cd.intel.com ([10.240.178.134])\n by fmsmga001.fm.intel.com with ESMTP; 11 Aug 2020 00:32:09 -0700" ], "IronPort-SDR": [ "\n 1QITmRtcDDyUsRUT7qTl3HcIIvr1inraMccLhZP89zxNqg9JVmV0G78a70ra+qPjpZAGYuARRB\n /ApFGYBz6wUQ==", "\n F5WcENnvbh/KWvgsRyWJsVUCyXLWlzoxqMeGjFl/3JDe1T+UDkZfzYe77N5GbKnEb0Ajn8sGiB\n N71V0MflHsaw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9709\"; a=\"238515555\"", "E=Sophos;i=\"5.75,460,1589266800\"; d=\"scan'208\";a=\"238515555\"", "E=Sophos;i=\"5.75,460,1589266800\"; d=\"scan'208\";a=\"398453072\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "SteveX Yang <stevex.yang@intel.com>", "To": "qiming.yang@intel.com, beilei.xing@intel.com, jingjing.wu@intel.com,\n dev@dpdk.org", "Cc": "SteveX Yang <stevex.yang@intel.com>", "Date": "Tue, 11 Aug 2020 07:27:52 +0000", "Message-Id": "<20200811072752.20813-1-stevex.yang@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH] net/iavf: release port upon close", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources\nfor the port can be freed by rte_eth_dev_close().\n\nSigned-off-by: SteveX Yang <stevex.yang@intel.com>\n---\n drivers/net/iavf/iavf_ethdev.c | 43 ++++++++++++++++++++--------------\n 1 file changed, 25 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c\nindex c3aa4cd72..ebff4d40b 100644\n--- a/drivers/net/iavf/iavf_ethdev.c\n+++ b/drivers/net/iavf/iavf_ethdev.c\n@@ -1362,6 +1362,11 @@ iavf_dev_init(struct rte_eth_dev *eth_dev)\n \tadapter->eth_dev = eth_dev;\n \tadapter->stopped = 1;\n \n+\t/* Pass the information to the rte_eth_dev_close() that it should also\n+\t * release the private port resources.\n+\t */\n+\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n+\n \tif (iavf_init_vf(eth_dev) != 0) {\n \t\tPMD_INIT_LOG(ERR, \"Init vf failed\");\n \t\treturn -1;\n@@ -1416,6 +1421,7 @@ iavf_dev_close(struct rte_eth_dev *dev)\n \tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n \tstruct iavf_adapter *adapter =\n \t\tIAVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);\n+\tstruct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);\n \n \tiavf_dev_stop(dev);\n \tiavf_flow_flush(dev, NULL);\n@@ -1428,20 +1434,21 @@ iavf_dev_close(struct rte_eth_dev *dev)\n \trte_intr_callback_unregister(intr_handle,\n \t\t\t\t iavf_dev_interrupt_handler, dev);\n \tiavf_disable_irq0(hw);\n-}\n-\n-static int\n-iavf_dev_uninit(struct rte_eth_dev *dev)\n-{\n-\tstruct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);\n-\n-\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n-\t\treturn -EPERM;\n \n \tdev->dev_ops = NULL;\n \tdev->rx_pkt_burst = NULL;\n \tdev->tx_pkt_burst = NULL;\n-\tiavf_dev_close(dev);\n+\n+\tif (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_RSS_PF) {\n+\t\tif (vf->rss_lut) {\n+\t\t\trte_free(vf->rss_lut);\n+\t\t\tvf->rss_lut = NULL;\n+\t\t}\n+\t\tif (vf->rss_key) {\n+\t\t\trte_free(vf->rss_key);\n+\t\t\tvf->rss_key = NULL;\n+\t\t}\n+\t}\n \n \trte_free(vf->vf_res);\n \tvf->vsi_res = NULL;\n@@ -1449,15 +1456,15 @@ iavf_dev_uninit(struct rte_eth_dev *dev)\n \n \trte_free(vf->aq_resp);\n \tvf->aq_resp = NULL;\n+}\n \n-\tif (vf->rss_lut) {\n-\t\trte_free(vf->rss_lut);\n-\t\tvf->rss_lut = NULL;\n-\t}\n-\tif (vf->rss_key) {\n-\t\trte_free(vf->rss_key);\n-\t\tvf->rss_key = NULL;\n-\t}\n+static int\n+iavf_dev_uninit(struct rte_eth_dev *dev)\n+{\n+\tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n+\t\treturn -EPERM;\n+\n+\tiavf_dev_close(dev);\n \n \treturn 0;\n }\n", "prefixes": [] }