Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75329/?format=api
{ "id": 75329, "url": "https://patches.dpdk.org/api/patches/75329/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200809132813.622-1-vipul.ashri@oracle.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200809132813.622-1-vipul.ashri@oracle.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200809132813.622-1-vipul.ashri@oracle.com", "date": "2020-08-09T13:28:13", "name": "Virtio TX: reverting a small change causing Virtio standard TX broken", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "45641512b3c60ad8ca1d37a108def7779102dc6f", "submitter": { "id": 1867, "url": "https://patches.dpdk.org/api/people/1867/?format=api", "name": "Vipul Ashri", "email": "vipul.ashri@oracle.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200809132813.622-1-vipul.ashri@oracle.com/mbox/", "series": [ { "id": 11562, "url": "https://patches.dpdk.org/api/series/11562/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11562", "date": "2020-08-09T13:28:13", "name": "Virtio TX: reverting a small change causing Virtio standard TX broken", "version": 1, "mbox": "https://patches.dpdk.org/series/11562/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/75329/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/75329/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2F940A04C1;\n\tMon, 10 Aug 2020 10:42:06 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 69708288C;\n\tMon, 10 Aug 2020 10:42:05 +0200 (CEST)", "from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86])\n by dpdk.org (Postfix) with ESMTP id 2CA012B87\n for <dev@dpdk.org>; Sun, 9 Aug 2020 15:30:26 +0200 (CEST)", "from pps.filterd (userp2130.oracle.com [127.0.0.1])\n by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 079DUHKw155095\n for <dev@dpdk.org>; Sun, 9 Aug 2020 13:30:26 GMT", "from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79])\n by userp2130.oracle.com with ESMTP id 32t2yd9dpd-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL)\n for <dev@dpdk.org>; Sun, 09 Aug 2020 13:30:26 +0000", "from pps.filterd (userp3020.oracle.com [127.0.0.1])\n by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 079DJLFN117250\n for <dev@dpdk.org>; Sun, 9 Aug 2020 13:28:25 GMT", "from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236])\n by userp3020.oracle.com with ESMTP id 32t5tpk48u-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK)\n for <dev@dpdk.org>; Sun, 09 Aug 2020 13:28:25 +0000", "from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17])\n by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 079DSOLP001856\n for <dev@dpdk.org>; Sun, 9 Aug 2020 13:28:24 GMT", "from VASHRI-IN.in.oracle.com (/10.166.163.221)\n by default (Oracle Beehive Gateway v4.0)\n with ESMTP ; Sun, 09 Aug 2020 13:28:23 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding; s=corp-2020-01-29;\n bh=NOJBsFa7MeRWOcpCrzmhrqyz38cMHAwFTYVD6Xa5oTI=;\n b=QOqsRkSStHAfOsIZKF2UQpufIvxgJwgKJcOBDFS0HjhSsTEELvUSqFnZqDjBIaUGNeNl\n jWbr2R0IzJZ0VA66tcMpKEzWg0gb/uEhNeTNV9Vx2/jUQBrP3/D7Z4mkXv5vwC6vd+OJ\n 1US7qM+qM7vn2ZKWMlPt8CGtRdvnROV+7xSpE7pKPQt24qgkxf0+ysvoxFUYr2lVik+M\n 0I+s0kxw0Nr0aihI5WueGcc3z5Nd4BzU/k3uokR5ujmrAPD8vC3RnycXXdRWS/wuTEts\n eWBrg2ImiepfM9XUt5vKo/1Eg7VyRHfgOt5UPOqR6Jp6AYLkTtv2VFdmGljXucBcRKQb aA==", "From": "Vipul Ashri <vipul.ashri@oracle.com>", "To": "dev@dpdk.org", "Cc": "vipul.ashri@oracle.com", "Date": "Sun, 9 Aug 2020 18:58:13 +0530", "Message-Id": "<20200809132813.622-1-vipul.ashri@oracle.com>", "X-Mailer": "git-send-email 2.28.0.windows.1", "In-Reply-To": "<20200807125731.1287-1-vipul.ashri@oracle.com>", "References": "<20200807125731.1287-1-vipul.ashri@oracle.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-Virus-Version": [ "vendor=nai engine=6000 definitions=9707\n signatures=668679", "vendor=nai engine=6000 definitions=9707\n signatures=668679" ], "X-Proofpoint-Spam-Details": [ "rule=notspam policy=default score=0 spamscore=0\n bulkscore=0 phishscore=0\n malwarescore=0 mlxscore=0 adultscore=0 mlxlogscore=999 suspectscore=1\n classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000\n definitions=main-2008090099", "rule=notspam policy=default score=0 mlxlogscore=999\n priorityscore=1501\n malwarescore=0 impostorscore=0 lowpriorityscore=0 mlxscore=0 bulkscore=0\n suspectscore=1 phishscore=0 adultscore=0 spamscore=0 clxscore=1015\n classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000\n definitions=main-2008090100" ], "X-Mailman-Approved-At": "Mon, 10 Aug 2020 10:42:04 +0200", "Subject": "[dpdk-dev] [PATCH] Virtio TX: reverting a small change causing\n\tVirtio standard TX broken", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Virtio Standard TX broken : Reverting a small change added few months back which has caused breakage in Virtio Standard TX path.\n\nDuring basic ping Tx/Rx testing of net_virtio pmd driver using standard Tx path, We saw TX is broken since anomaly code added by below patch once submitted\nhttp://git.dpdk.org/dpdk/patch/?id=57f90f89458807bccc63425e4b72796870177977\n\nSigned-off-by: Vipul Ashri <vipul.ashri@oracle.com>\n---\n drivers/net/virtio/virtqueue.h | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h\nindex 105a9c00c..81118d9fb 100644\n--- a/drivers/net/virtio/virtqueue.h\n+++ b/drivers/net/virtio/virtqueue.h\n@@ -607,10 +607,8 @@ virtqueue_notify(struct virtqueue *vq)\n \n /* avoid write operation when necessary, to lessen cache issues */\n #define ASSIGN_UNLESS_EQUAL(var, val) do {\t\\\n-\ttypeof(var) var_ = (var);\t\t\\\n-\ttypeof(val) val_ = (val);\t\t\\\n-\tif ((var_) != (val_))\t\t\t\\\n-\t\t(var_) = (val_);\t\t\\\n+\tif ((var) != (val))\t\t\t\\\n+\t\t(var) = (val);\t\t\\\n } while (0)\n \n #define virtqueue_clear_net_hdr(hdr) do {\t\t\\\n", "prefixes": [] }