Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/75295/?format=api
{ "id": 75295, "url": "https://patches.dpdk.org/api/patches/75295/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20200807123009.21266-19-ciara.power@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200807123009.21266-19-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200807123009.21266-19-ciara.power@intel.com", "date": "2020-08-07T12:30:08", "name": "[20.11,18/19] doc: remove references to make in sample app guides", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7f2d74a436deafd9eec68d0c90f651c6ac6fcd18", "submitter": { "id": 978, "url": "https://patches.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20200807123009.21266-19-ciara.power@intel.com/mbox/", "series": [ { "id": 11549, "url": "https://patches.dpdk.org/api/series/11549/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=11549", "date": "2020-08-07T12:29:50", "name": "remove make support in DPDK", "version": 1, "mbox": "https://patches.dpdk.org/series/11549/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/75295/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/75295/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6132EA04B0;\n\tFri, 7 Aug 2020 14:42:29 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 773261C1C2;\n\tFri, 7 Aug 2020 14:38:08 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by dpdk.org (Postfix) with ESMTP id 85C501C1AA\n for <dev@dpdk.org>; Fri, 7 Aug 2020 14:38:05 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Aug 2020 05:38:05 -0700", "from silpixa00399953.ir.intel.com (HELO\n silpixa00399953.ger.corp.intel.com) ([10.237.222.53])\n by orsmga001.jf.intel.com with ESMTP; 07 Aug 2020 05:38:03 -0700" ], "IronPort-SDR": [ "\n zKWHOOvEVTbY42kiaCGn0/vfzu84V0euH7tLgw81CBzZGiMmuaTAmk5ur3YGFFdCOoMjGOiydK\n 0zW2UYGEYxMQ==", "\n TV9IWVJkRNa/x8fj8mELCFTo20JNIQ0Ezui1eBzuuiBg7h3AnSAWmOIT7X/kWc+N5D8RJn1pVY\n UuJzUAmJNKkQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9705\"; a=\"152298301\"", "E=Sophos;i=\"5.75,445,1589266800\"; d=\"scan'208\";a=\"152298301\"", "E=Sophos;i=\"5.75,445,1589266800\"; d=\"scan'208\";a=\"367914609\"" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, thomas@monjalon.net,\n Ciara Power <ciara.power@intel.com>", "Date": "Fri, 7 Aug 2020 13:30:08 +0100", "Message-Id": "<20200807123009.21266-19-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200807123009.21266-1-ciara.power@intel.com>", "References": "<20200807123009.21266-1-ciara.power@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 20.11 18/19] doc: remove references to make in\n\tsample app guides", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Signed-off-by: Ciara Power <ciara.power@intel.com>\n---\n doc/guides/sample_app_ug/bbdev_app.rst | 11 +------\n doc/guides/sample_app_ug/compiling.rst | 29 ++++---------------\n .../sample_app_ug/l3_forward_access_ctrl.rst | 2 +-\n .../sample_app_ug/performance_thread.rst | 3 +-\n doc/guides/sample_app_ug/qos_scheduler.rst | 2 +-\n doc/guides/sample_app_ug/rxtx_callbacks.rst | 7 -----\n doc/guides/sample_app_ug/service_cores.rst | 11 +------\n doc/guides/sample_app_ug/tep_termination.rst | 15 +---------\n doc/guides/sample_app_ug/test_pipeline.rst | 2 +-\n doc/guides/sample_app_ug/vhost.rst | 2 +-\n .../sample_app_ug/vm_power_management.rst | 22 +++++---------\n .../sample_app_ug/vmdq_dcb_forwarding.rst | 4 +--\n doc/guides/sample_app_ug/vmdq_forwarding.rst | 4 +--\n 13 files changed, 26 insertions(+), 88 deletions(-)", "diff": "diff --git a/doc/guides/sample_app_ug/bbdev_app.rst b/doc/guides/sample_app_ug/bbdev_app.rst\nindex 405e706a46..ef12dca8e6 100644\n--- a/doc/guides/sample_app_ug/bbdev_app.rst\n+++ b/doc/guides/sample_app_ug/bbdev_app.rst\n@@ -39,16 +39,7 @@ Compiling the Application\n \n .. code-block:: console\n \n- export RTE_SDK=/path/to/rte_sdk\n- cd ${RTE_SDK}/examples/bbdev_app\n-\n-#. Set the target (a default target is used if not specified). For example:\n-\n- .. code-block:: console\n-\n- export RTE_TARGET=x86_64-native-linux-gcc\n-\n- See the *DPDK Getting Started Guide* for possible RTE_TARGET values.\n+ cd dpdk/examples/bbdev_app\n \n #. Build the application:\n \ndiff --git a/doc/guides/sample_app_ug/compiling.rst b/doc/guides/sample_app_ug/compiling.rst\nindex 6f04743c82..c08cb63571 100644\n--- a/doc/guides/sample_app_ug/compiling.rst\n+++ b/doc/guides/sample_app_ug/compiling.rst\n@@ -9,17 +9,11 @@ This section explains how to compile the DPDK sample applications.\n To compile all the sample applications\n --------------------------------------\n \n-Set the path to DPDK source code if its not set:\n-\n- .. code-block:: console\n-\n- export RTE_SDK=/path/to/rte_sdk\n-\n Go to DPDK source:\n \n .. code-block:: console\n \n- cd $RTE_SDK\n+ cd dpdk\n \n Build DPDK:\n \n@@ -32,15 +26,13 @@ Build the sample applications:\n \n .. code-block:: console\n \n- export RTE_TARGET=build\n make -C examples\n \n-For other possible ``RTE_TARGET`` values and additional information on\n-compiling see\n+For additional information on compiling see\n :ref:`Compiling DPDK on Linux <linux_gsg_compiling_dpdk>` or\n :ref:`Compiling DPDK on FreeBSD <building_from_source>`.\n-Applications are output to: ``$RTE_SDK/examples/app-dir/build`` or\n-``$RTE_SDK/examples/app-dir/$RTE_TARGET``.\n+Applications are output to: ``dpdk/examples/app-dir/build`` or\n+``dpdk/examples/app-dir/{build_dir}``.\n \n \n In the example above the compiled application is written to the ``build`` subdirectory.\n@@ -63,17 +55,11 @@ sets verbose output.\n To compile a single application\n -------------------------------\n \n-Set the path to DPDK source code:\n-\n- .. code-block:: console\n-\n- export RTE_SDK=/path/to/rte_sdk\n-\n Go to DPDK source:\n \n .. code-block:: console\n \n- cd $RTE_SDK\n+ cd dpdk\n \n Build DPDK:\n \n@@ -83,14 +69,13 @@ Build DPDK:\n make\n \n Go to the sample application directory. Unless otherwise specified the sample\n-applications are located in ``$RTE_SDK/examples/``.\n+applications are located in ``dpdk/examples/``.\n \n \n Build the application:\n \n .. code-block:: console\n \n- export RTE_TARGET=build\n make\n \n To cross compile the sample application(s)\n@@ -101,8 +86,6 @@ In example of AARCH64 cross compiling:\n \n .. code-block:: console\n \n- export RTE_TARGET=build\n- export RTE_SDK=/path/to/rte_sdk\n make -C examples CROSS=aarch64-linux-gnu-\n or\n make CROSS=aarch64-linux-gnu-\ndiff --git a/doc/guides/sample_app_ug/l3_forward_access_ctrl.rst b/doc/guides/sample_app_ug/l3_forward_access_ctrl.rst\nindex a44fbcd52c..ac23c3aa9c 100644\n--- a/doc/guides/sample_app_ug/l3_forward_access_ctrl.rst\n+++ b/doc/guides/sample_app_ug/l3_forward_access_ctrl.rst\n@@ -184,7 +184,7 @@ Packet 2 matches Rule 2 and is forwarded to port 1.\n Packet 3 matches Rule 3 and is forwarded to port 0.\n \n For more details on the rule file format,\n-please refer to rule_ipv4.db and rule_ipv6.db files (inside <RTE_SDK>/examples/l3fwd-acl/).\n+please refer to rule_ipv4.db and rule_ipv6.db files (inside dpdk/examples/l3fwd-acl/).\n \n Application Phases\n ~~~~~~~~~~~~~~~~~~\ndiff --git a/doc/guides/sample_app_ug/performance_thread.rst b/doc/guides/sample_app_ug/performance_thread.rst\nindex b04d0ba444..7303ff19c4 100644\n--- a/doc/guides/sample_app_ug/performance_thread.rst\n+++ b/doc/guides/sample_app_ug/performance_thread.rst\n@@ -1150,8 +1150,7 @@ To build and run the pthread shim example\n \n .. code-block:: console\n \n- export RTE_SDK=/path/to/rte_sdk\n- cd ${RTE_SDK}/examples/performance-thread/pthread_shim\n+ cd dpdk/examples/performance-thread/pthread_shim\n \n \n #. Set the target (a default target is used if not specified). For example:\ndiff --git a/doc/guides/sample_app_ug/qos_scheduler.rst b/doc/guides/sample_app_ug/qos_scheduler.rst\nindex b5010657a7..5cd64b5fd4 100644\n--- a/doc/guides/sample_app_ug/qos_scheduler.rst\n+++ b/doc/guides/sample_app_ug/qos_scheduler.rst\n@@ -42,7 +42,7 @@ The application is located in the ``qos_sched`` sub-directory.\n .. note::\n \n To get statistics on the sample app using the command line interface as described in the next section,\n- DPDK must be compiled defining *CONFIG_RTE_SCHED_COLLECT_STATS*,\n+ DPDK must be compiled defining *RTE_SCHED_COLLECT_STATS*,\n which can be done by changing the configuration file for the specific target to be compiled.\n \n Running the Application\ndiff --git a/doc/guides/sample_app_ug/rxtx_callbacks.rst b/doc/guides/sample_app_ug/rxtx_callbacks.rst\nindex 0a69ec71ab..087744bd0b 100644\n--- a/doc/guides/sample_app_ug/rxtx_callbacks.rst\n+++ b/doc/guides/sample_app_ug/rxtx_callbacks.rst\n@@ -25,13 +25,6 @@ To compile the sample application see :doc:`compiling`.\n \n The application is located in the ``rxtx_callbacks`` sub-directory.\n \n-The callbacks feature requires that the ``CONFIG_RTE_ETHDEV_RXTX_CALLBACKS``\n-setting is on in the ``config/common_`` config file that applies to the\n-target. This is generally on by default:\n-\n-.. code-block:: console\n-\n- CONFIG_RTE_ETHDEV_RXTX_CALLBACKS=y\n \n Running the Application\n -----------------------\ndiff --git a/doc/guides/sample_app_ug/service_cores.rst b/doc/guides/sample_app_ug/service_cores.rst\nindex cd0f4717aa..d2a2a6cac3 100644\n--- a/doc/guides/sample_app_ug/service_cores.rst\n+++ b/doc/guides/sample_app_ug/service_cores.rst\n@@ -24,16 +24,7 @@ Compiling the Application\n \n .. code-block:: console\n \n- export RTE_SDK=/path/to/rte_sdk\n- cd ${RTE_SDK}/examples/service_cores\n-\n-#. Set the target (a default target is used if not specified). For example:\n-\n- .. code-block:: console\n-\n- export RTE_TARGET=x86_64-native-linux-gcc\n-\n- See the *DPDK Getting Started* Guide for possible RTE_TARGET values.\n+ cd dpdk/examples/service_cores\n \n #. Build the application:\n \ndiff --git a/doc/guides/sample_app_ug/tep_termination.rst b/doc/guides/sample_app_ug/tep_termination.rst\nindex df159355d6..a26fa888e7 100644\n--- a/doc/guides/sample_app_ug/tep_termination.rst\n+++ b/doc/guides/sample_app_ug/tep_termination.rst\n@@ -90,18 +90,6 @@ The example in this section have been validated with the following distributions\n \n * Fedora* 20\n \n-Compiling the Sample Code\n--------------------------\n-\n-To enable vhost, turn on vhost library in the configure file\n-``config/common_linux``.\n-\n- .. code-block:: console\n-\n- CONFIG_RTE_LIBRTE_VHOST=y\n-\n-Then following the to compile the sample application shown in\n-:doc:`compiling`.\n \n Running the Sample Code\n -----------------------\n@@ -110,8 +98,7 @@ Running the Sample Code\n \n .. code-block:: console\n \n- export RTE_SDK=/path/to/rte_sdk\n- cd ${RTE_SDK}/examples/tep_termination\n+ cd dpdk/examples/tep_termination\n \n #. Run the tep_termination sample code:\n \ndiff --git a/doc/guides/sample_app_ug/test_pipeline.rst b/doc/guides/sample_app_ug/test_pipeline.rst\nindex 5aefd8d89f..a540faa3ed 100644\n--- a/doc/guides/sample_app_ug/test_pipeline.rst\n+++ b/doc/guides/sample_app_ug/test_pipeline.rst\n@@ -32,7 +32,7 @@ Compiling the Application\n -------------------------\n To compile the sample application see :doc:`compiling`\n \n-The application is located in the ``$RTE_SDK/app/test-pipeline`` directory.\n+The application is located in the ``dpdk/app/test-pipeline`` directory.\n \n \n Running the Application\ndiff --git a/doc/guides/sample_app_ug/vhost.rst b/doc/guides/sample_app_ug/vhost.rst\nindex b7ed4f8bdf..ad682c68b2 100644\n--- a/doc/guides/sample_app_ug/vhost.rst\n+++ b/doc/guides/sample_app_ug/vhost.rst\n@@ -78,7 +78,7 @@ could be done by:\n .. code-block:: console\n \n modprobe uio_pci_generic\n- $RTE_SDK/usertools/dpdk-devbind.py -b uio_pci_generic 0000:00:04.0\n+ dpdk/usertools/dpdk-devbind.py -b uio_pci_generic 0000:00:04.0\n \n Then start testpmd for packet forwarding testing.\n \ndiff --git a/doc/guides/sample_app_ug/vm_power_management.rst b/doc/guides/sample_app_ug/vm_power_management.rst\nindex 1b6de8e936..d8d35d6d88 100644\n--- a/doc/guides/sample_app_ug/vm_power_management.rst\n+++ b/doc/guides/sample_app_ug/vm_power_management.rst\n@@ -245,26 +245,23 @@ To build just the ``vm_power_manager`` application using ``make``:\n \n .. code-block:: console\n \n- export RTE_SDK=/path/to/rte_sdk\n- export RTE_TARGET=build\n- cd ${RTE_SDK}/examples/vm_power_manager/\n+ cd dpdk/examples/vm_power_manager/\n make\n \n-The resulting binary is ``${RTE_SDK}/build/examples/vm_power_manager``.\n+The resulting binary is ``dpdk/build/examples/vm_power_manager``.\n \n To build just the ``vm_power_manager`` application using ``meson``/``ninja``:\n \n .. code-block:: console\n \n- export RTE_SDK=/path/to/rte_sdk\n- cd ${RTE_SDK}\n+ cd dpdk\n meson build\n cd build\n ninja\n meson configure -Dexamples=vm_power_manager\n ninja\n \n-The resulting binary is ``${RTE_SDK}/build/examples/dpdk-vm_power_manager``.\n+The resulting binary is ``dpdk/build/examples/dpdk-vm_power_manager``.\n \n Running the Host Application\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n@@ -462,12 +459,10 @@ the following commands:\n \n .. code-block:: console\n \n- export RTE_SDK=/path/to/rte_sdk\n- export RTE_TARGET=build\n- cd ${RTE_SDK}/examples/vm_power_manager/guest_cli/\n+ cd dpdk/examples/vm_power_manager/guest_cli/\n make\n \n-The resulting binary is ``${RTE_SDK}/build/examples/guest_cli``.\n+The resulting binary is ``dpdk/build/examples/guest_cli``.\n \n **Note**: This sample application conditionally links in the Jansson JSON\n library. Consequently, if you are using a multilib or cross-compile\n@@ -498,15 +493,14 @@ To build just the ``vm_power_manager`` application using ``meson``/``ninja``:\n \n .. code-block:: console\n \n- export RTE_SDK=/path/to/rte_sdk\n- cd ${RTE_SDK}\n+ cd dpdk\n meson build\n cd build\n ninja\n meson configure -Dexamples=vm_power_manager/guest_cli\n ninja\n \n-The resulting binary is ``${RTE_SDK}/build/examples/guest_cli``.\n+The resulting binary is ``dpdk/build/examples/guest_cli``.\n \n Running the Guest Application\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\ndiff --git a/doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst b/doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst\nindex 8e1774d9e2..c66877c538 100644\n--- a/doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst\n+++ b/doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst\n@@ -26,8 +26,8 @@ multiple queues. When run with 8 threads, that is, with the -c FF option, each t\n As supplied, the sample application configures the VMDQ feature to have 32 pools with 4 queues each as indicated in :numref:`figure_vmdq_dcb_example`.\n The Intel® 82599 10 Gigabit Ethernet Controller NIC also supports the splitting of traffic into 16 pools of 8 queues. While the\n Intel® X710 or XL710 Ethernet Controller NICs support many configurations of VMDQ pools of 4 or 8 queues each. For simplicity, only 16\n-or 32 pools is supported in this sample. And queues numbers for each VMDQ pool can be changed by setting CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM\n-in config/common_* file.\n+or 32 pools is supported in this sample. And queues numbers for each VMDQ pool can be changed by setting RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM\n+in config/rte_config.h file.\n The nb-pools, nb-tcs and enable-rss parameters can be passed on the command line, after the EAL parameters:\n \n .. code-block:: console\ndiff --git a/doc/guides/sample_app_ug/vmdq_forwarding.rst b/doc/guides/sample_app_ug/vmdq_forwarding.rst\nindex c3a3439e51..5df6bbeef3 100644\n--- a/doc/guides/sample_app_ug/vmdq_forwarding.rst\n+++ b/doc/guides/sample_app_ug/vmdq_forwarding.rst\n@@ -24,8 +24,8 @@ multiple queues. When run with 8 threads, that is, with the -c FF option, each t\n As supplied, the sample application configures the VMDq feature to have 32 pools with 4 queues each.\n The Intel® 82599 10 Gigabit Ethernet Controller NIC also supports the splitting of traffic into 16 pools of 2 queues.\n While the Intel® X710 or XL710 Ethernet Controller NICs support many configurations of VMDq pools of 4 or 8 queues each.\n-And queues numbers for each VMDq pool can be changed by setting CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM\n-in config/common_* file.\n+And queues numbers for each VMDq pool can be changed by setting RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM\n+in config/rte_config.h file.\n The nb-pools and enable-rss parameters can be passed on the command line, after the EAL parameters:\n \n .. code-block:: console\n", "prefixes": [ "20.11", "18/19" ] }