Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 7484,
    "url": "https://patches.dpdk.org/api/patches/7484/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1A27633A6DA49C4A92FCD5D4312DBF536A5B392B@IRSMSX109.ger.corp.intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1A27633A6DA49C4A92FCD5D4312DBF536A5B392B@IRSMSX109.ger.corp.intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1A27633A6DA49C4A92FCD5D4312DBF536A5B392B@IRSMSX109.ger.corp.intel.com",
    "date": "2015-10-08T14:37:36",
    "name": "[dpdk-dev] ethdev: distinguish between drop and error stats",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "bffc3b8a80571ea476be9ee50d53b0d26235c122",
    "submitter": {
        "id": 259,
        "url": "https://patches.dpdk.org/api/people/259/?format=api",
        "name": "Tahhan, Maryam",
        "email": "maryam.tahhan@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1A27633A6DA49C4A92FCD5D4312DBF536A5B392B@IRSMSX109.ger.corp.intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/7484/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/7484/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E69C48DAB;\n\tThu,  8 Oct 2015 16:37:42 +0200 (CEST)",
            "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 9A42C8DA7\n\tfor <dev@dpdk.org>; Thu,  8 Oct 2015 16:37:40 +0200 (CEST)",
            "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga103.jf.intel.com with ESMTP; 08 Oct 2015 07:37:39 -0700",
            "from irsmsx152.ger.corp.intel.com ([163.33.192.66])\n\tby fmsmga001.fm.intel.com with ESMTP; 08 Oct 2015 07:37:37 -0700",
            "from irsmsx109.ger.corp.intel.com ([169.254.13.139]) by\n\tIRSMSX152.ger.corp.intel.com ([169.254.6.64]) with mapi id\n\t14.03.0248.002; Thu, 8 Oct 2015 15:37:36 +0100"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.17,655,1437462000\"; \n\td=\"scan'208,217\";a=\"806492978\"",
        "From": "\"Tahhan, Maryam\" <maryam.tahhan@intel.com>",
        "To": "Jay Rolette <rolette@infiniteio.com>",
        "Thread-Topic": "[dpdk-dev] [PATCH] ethdev: distinguish between drop and error\n\tstats",
        "Thread-Index": "AQHQ/RCgwmPlqiFfVUCcKt4PKnicmp5YILWAgAmSGOA=",
        "Date": "Thu, 8 Oct 2015 14:37:36 +0000",
        "Message-ID": "<1A27633A6DA49C4A92FCD5D4312DBF536A5B392B@IRSMSX109.ger.corp.intel.com>",
        "References": "<1443790078-15834-1-git-send-email-maryam.tahhan@intel.com>\n\t<CADNuJVqx7VhX3EuEWM3y+1N7G9dypi9owgLOZMAcNsebLwCtvA@mail.gmail.com>",
        "In-Reply-To": "<CADNuJVqx7VhX3EuEWM3y+1N7G9dypi9owgLOZMAcNsebLwCtvA@mail.gmail.com>",
        "Accept-Language": "en-IE, en-US",
        "Content-Language": "en-US",
        "X-MS-Has-Attach": "",
        "X-MS-TNEF-Correlator": "",
        "x-originating-ip": "[163.33.239.182]",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=\"utf-8\"",
        "Content-Transfer-Encoding": "base64",
        "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15",
        "Cc": "DPDK <dev@dpdk.org>",
        "Subject": "Re: [dpdk-dev] [PATCH] ethdev: distinguish between drop and error\n\tstats",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Hi Jay\r\nYeah, I will do this to make the distinction clear for the counters I’m modifying in my patch. But please note that these aren’t counters that are defined in the NIC datasheets, these are the high level DPDK general counters for ethdevs. Their descriptions exist in the code and the generated DPDK docs.\r\n\r\nBest Regards,\r\nMaryam\r\n\r\nFrom: Jay Rolette [mailto:rolette@infiniteio.com]\r\nSent: Friday, October 2, 2015 2:25 PM\r\nTo: Tahhan, Maryam\r\nCc: DPDK\r\nSubject: Re: [dpdk-dev] [PATCH] ethdev: distinguish between drop and error stats\r\n\r\nCan you improve the comments on these counters? If you didn't happen to follow this thread, there's no way to reasonably figure out what the difference is from looking at the code without chasing it all the way down and cross-referencing the NIC datasheet.\r\n\r\nThanks,\r\nJay\r\n\r\nOn Fri, Oct 2, 2015 at 7:47 AM, Maryam Tahhan <maryam.tahhan@intel.com<mailto:maryam.tahhan@intel.com>> wrote:\r\nMake a distniction between dropped packets and error statistics to allow\r\na higher level fault management entity to interact with DPDK and take\r\nappropriate measures when errors are detected. It will also provide\r\nvaluable information for any applications that collects/extracts DPDK\r\nstats, such applications include Open vSwitch.\r\nAfter this patch the distinction is:\r\nierrors = Total number of packets dropped by hardware (malformed\r\npackets, ...) Where the # of drops can ONLY be <=  the packets received\r\n(without overlap between registers).\r\nRx_pkt_errors = Total number of erroneous received packets. Where the #\r\nof errors can be >= the packets received (without overlap between\r\nregisters), this is because there may be multiple errors associated with\r\na packet.\r\n\r\nSigned-off-by: Maryam Tahhan <maryam.tahhan@intel.com<mailto:maryam.tahhan@intel.com>>\r\n---\r\n lib/librte_ether/rte_ethdev.h | 3 ++-\r\n 1 file changed, 2 insertions(+), 1 deletion(-)\r\n\r\n--\r\n2.4.3",
    "diff": "diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h\r\nindex 8a8c82b..53dd55d 100644\r\n--- a/lib/librte_ether/rte_ethdev.h\r\n+++ b/lib/librte_ether/rte_ethdev.h\r\n@@ -200,8 +200,9 @@ struct rte_eth_stats {\r\n        /**< Deprecated; Total of RX packets with CRC error. */\r\n        uint64_t ibadlen;\r\n        /**< Deprecated; Total of RX packets with bad length. */\r\n-       uint64_t ierrors;   /**< Total number of erroneous received packets. */\r\n+       uint64_t ierrors;   /**< Total number of dropped received packets. */\r\n        uint64_t oerrors;   /**< Total number of failed transmitted packets. */\r\n+       uint64_t ipkterrors;   /**< Total number of erroneous received packets. */\r\n        uint64_t imcasts;\r\n        /**< Deprecated; Total number of multicast received packets. */\r\n        uint64_t rx_nombuf; /**< Total number of RX mbuf allocation failures. */\r\n",
    "prefixes": [
        "dpdk-dev"
    ]
}